From 11ae3cff7b3cf20f6f868d420b051013634a1dc8 Mon Sep 17 00:00:00 2001 From: Derick Alangi Date: Mon, 25 Mar 2019 00:45:00 +0100 Subject: [PATCH] rdbms: Drop unused constructor property and default method arg Change-Id: Id83efd8f68b241ca0d7c5340cc2fd93379578fac --- includes/libs/rdbms/lbfactory/LBFactory.php | 2 +- includes/libs/rdbms/lbfactory/LBFactoryMulti.php | 4 ---- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/includes/libs/rdbms/lbfactory/LBFactory.php b/includes/libs/rdbms/lbfactory/LBFactory.php index 007ac20662..3a8f2e1fcd 100644 --- a/includes/libs/rdbms/lbfactory/LBFactory.php +++ b/includes/libs/rdbms/lbfactory/LBFactory.php @@ -654,7 +654,7 @@ abstract class LBFactory implements ILBFactory { } public function closeAll() { - $this->forEachLBCallMethod( 'closeAll', [] ); + $this->forEachLBCallMethod( 'closeAll' ); } public function setAgentName( $agent ) { diff --git a/includes/libs/rdbms/lbfactory/LBFactoryMulti.php b/includes/libs/rdbms/lbfactory/LBFactoryMulti.php index 189ceee56d..aec99f4ec7 100644 --- a/includes/libs/rdbms/lbfactory/LBFactoryMulti.php +++ b/includes/libs/rdbms/lbfactory/LBFactoryMulti.php @@ -89,9 +89,6 @@ class LBFactoryMulti extends LBFactory { */ private $readOnlyBySection = []; - /** @var array Load balancer factory configuration */ - private $conf; - /** @var LoadBalancer[] */ private $mainLBs = []; @@ -166,7 +163,6 @@ class LBFactoryMulti extends LBFactory { public function __construct( array $conf ) { parent::__construct( $conf ); - $this->conf = $conf; $required = [ 'sectionsByDB', 'sectionLoads', 'serverTemplate' ]; $optional = [ 'groupLoadsBySection', 'groupLoadsByDB', 'hostsByName', 'externalLoads', 'externalTemplateOverrides', 'templateOverridesByServer', -- 2.20.1