Mark A. Hershberger [Wed, 14 Jul 2010 21:46:52 +0000 (21:46 +0000)]
follow up r69339:
* Add a missing setVaryCookie for consistency
* don't cache result when token is given in ApiFeedWatchlist
Mark A. Hershberger [Wed, 14 Jul 2010 21:00:09 +0000 (21:00 +0000)]
follow up r69339: Add a missing setVaryCookie for consistency and to avoid user X with skin Y getting the response marked up for skin B.
Raimond Spekking [Wed, 14 Jul 2010 20:12:19 +0000 (20:12 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-07-14 19:53:00 UTC)
Platonides [Wed, 14 Jul 2010 19:19:16 +0000 (19:19 +0000)]
Remove extra space.
Roan Kattouw [Wed, 14 Jul 2010 19:00:54 +0000 (19:00 +0000)]
API: Make output containing private or user-specific data uncacheable for logged-in users by setting Vary: Cookie or Cache-Control: private, whichever is appropriate. Fixes instances in core and WMF-deployed extensions only. Without this change, the output of requests like ?action=query&list=recentchanges&rcprop=patrolled&smaxage=3600 would be cached in Squid and viewable for anyone using the same URL, even if they don't have patrol rights. Other, more serious exploits are also possible. Also avoid using $wgUser in one place, kill some unused global $wgUser; instances and tweak a comment.
Aryeh Gregor [Wed, 14 Jul 2010 18:50:32 +0000 (18:50 +0000)]
Remove 'minordefault' preference completely
See bug 24313. The preference encourages people to mark changes minor
by mistake, but it's better to have minor changes not marked minor than
non-minor changes marked minor. enwiki users at [[Help talk:Minor
edit]] seemed to think it was a good idea. Plus, I'm always in favor of
removing user preferences where possible.
The only likely fallout of note is some bot operators who didn't notice
this suddenly find their bot not marking anything minor. I doubt it
will cause major problems, though.
Trevor Parscal [Wed, 14 Jul 2010 18:31:29 +0000 (18:31 +0000)]
By flipping '"Courier New", monospace' to 'monospace, "Courier New"', we can get the beneifts of allowing the user's monospace font override to still be used. Improves on r69335 which is itself an improvement on r65391.
Trevor Parscal [Wed, 14 Jul 2010 17:50:51 +0000 (17:50 +0000)]
Improves on the technique used in r65391 to fix the font-size issues in Firefox, Chrome and Safari caused by using "monospace" as a font-family. The old approach was to use "monospace, sans-serif", which worked but was reported to actually fall-back on the sans-serif variant. Some research has shown that using '"Courier New", monospace' resolves the issue on all browsers without risking falling back to proportionally spaced fonts.
Chad Horohoe [Wed, 14 Jul 2010 17:42:52 +0000 (17:42 +0000)]
Fix nitpick complaint on r61809
Mark A. Hershberger [Wed, 14 Jul 2010 17:34:18 +0000 (17:34 +0000)]
* revert r61258
* check if iconv extension is loaded and, if so, use it in UtfNormal::cleanUp()
Chad Horohoe [Wed, 14 Jul 2010 17:28:08 +0000 (17:28 +0000)]
Revert r64217 (WikiSysop is back, and now (s)he's localisable) per comments on review
Adam Miller [Wed, 14 Jul 2010 15:06:52 +0000 (15:06 +0000)]
style version bump for r69317
Chad Horohoe [Wed, 14 Jul 2010 01:18:14 +0000 (01:18 +0000)]
Installer no longer writes LocalSettings.php to /config. Now offer it as a download to the user and instruct them to upload/move it to the wiki base directory. Also only set _InstallDone if we hit no fatals during installation
Adam Miller [Tue, 13 Jul 2010 22:31:46 +0000 (22:31 +0000)]
Epic bug fix. Changing the markup structure of Vectors tabs and related watch/unwatch code to address bug 23490
Raimond Spekking [Tue, 13 Jul 2010 19:10:15 +0000 (19:10 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-07-13 18:48:00 UTC)
Max Semenik [Tue, 13 Jul 2010 18:29:33 +0000 (18:29 +0000)]
Revert r69291, other references-related problems reported
Platonides [Mon, 12 Jul 2010 20:11:41 +0000 (20:11 +0000)]
7, it's 7! (follow up to r68824)
Robert Leverington [Mon, 12 Jul 2010 16:54:25 +0000 (16:54 +0000)]
cleanupSpam.php:
- Replace calls to Article::updateArticle with equivilant calls to Article::doEdit. Resolves bug 18892.
Max Semenik [Mon, 12 Jul 2010 11:14:00 +0000 (11:14 +0000)]
Fixed weird unit test failures I experienced after r68544
Alexandre Emsenhuber [Sun, 11 Jul 2010 19:25:46 +0000 (19:25 +0000)]
* (bug 24045) MediaWiki:Ipb-needreblock is now wrapped in a div with class "mw-ipd-needreblock"
Alexandre Emsenhuber [Sun, 11 Jul 2010 18:24:53 +0000 (18:24 +0000)]
Fixed some doxygen warnings
Alexandre Emsenhuber [Sun, 11 Jul 2010 18:13:23 +0000 (18:13 +0000)]
removed PHP4-ism
Max Semenik [Sun, 11 Jul 2010 17:34:06 +0000 (17:34 +0000)]
ereg is deprecated
Raimond Spekking [Sun, 11 Jul 2010 15:10:37 +0000 (15:10 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-07-11 14:47:00 UTC)
Alexandre Emsenhuber [Sun, 11 Jul 2010 14:17:17 +0000 (14:17 +0000)]
Modified Special:Userlogout to subclass UnlistedSpecialPage
Chad Horohoe [Sun, 11 Jul 2010 12:34:54 +0000 (12:34 +0000)]
Followup r69251, copy+paste fail
Chad Horohoe [Sun, 11 Jul 2010 12:31:44 +0000 (12:31 +0000)]
Cleanup to r69187: forgot to safeguard against ul_value or updatelog itself not existing.
Chad Horohoe [Sun, 11 Jul 2010 11:27:58 +0000 (11:27 +0000)]
Doc fixes and message cleanups to r69238
Alexandre Emsenhuber [Sat, 10 Jul 2010 21:20:50 +0000 (21:20 +0000)]
Fixed some doxygen warnings
Alexandre Emsenhuber [Sat, 10 Jul 2010 20:13:06 +0000 (20:13 +0000)]
* Modified Special:Specialpages to subclass UnlistedSpecialPage instead of using wfSpecialSpecialpages()
* Use Html:: methods
Raimond Spekking [Sat, 10 Jul 2010 15:33:41 +0000 (15:33 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-07-10 15:00:00 UTC)
Chad Horohoe [Sat, 10 Jul 2010 12:29:15 +0000 (12:29 +0000)]
Add $wgUseInstantCommons support to installer, tweak help based on presumed access to it
Bryan Tong Minh [Sat, 10 Jul 2010 11:53:22 +0000 (11:53 +0000)]
(bug 24296) Added converttitles parameter to convert titles to their canonical language variant.
Sam Reed [Sat, 10 Jul 2010 11:46:47 +0000 (11:46 +0000)]
Followup r69235
Replace setPropert with setProperty
Bryan Tong Minh [Sat, 10 Jul 2010 11:30:11 +0000 (11:30 +0000)]
(bug 14685) Double underscore magic word usage is now tracked in the page_props table, as well as the behavioral magic words {{DEFAULTSORT}} and {{DISPLAYTITLE}}.
Bryan Tong Minh [Sat, 10 Jul 2010 10:47:52 +0000 (10:47 +0000)]
Follow-up r69231: servedby is a boolean so will always be non-null.
Bryan Tong Minh [Sat, 10 Jul 2010 10:46:20 +0000 (10:46 +0000)]
(bug 24185) Titles in the Media and Special namespace are now supported for title normalization in action=query. Special pages have their name resolved to the local alias.
Chad Horohoe [Sat, 10 Jul 2010 10:39:30 +0000 (10:39 +0000)]
Partial revert r69231, unrelated and unfinished installer changes
Chad Horohoe [Sat, 10 Jul 2010 10:37:39 +0000 (10:37 +0000)]
(bug 24303) Expose hostname in API results. Show via servedby parameter, added unconditionally on errors
Max Semenik [Sat, 10 Jul 2010 10:26:59 +0000 (10:26 +0000)]
Update tests for r69229
Max Semenik [Sat, 10 Jul 2010 10:15:59 +0000 (10:15 +0000)]
Fixed mysqlisms in Database.php comments, abstracted getSearchEngine()
Chad Horohoe [Sat, 10 Jul 2010 09:26:42 +0000 (09:26 +0000)]
Cleanup r69128, getStatArray() -> getStatusArray(). It's two characters, c'mon
Niklas Laxström [Sat, 10 Jul 2010 08:14:39 +0000 (08:14 +0000)]
Clean up query code
Niklas Laxström [Sat, 10 Jul 2010 07:36:09 +0000 (07:36 +0000)]
Tweak comparison in r69171
Max Semenik [Fri, 9 Jul 2010 21:27:36 +0000 (21:27 +0000)]
Removed User::setLoaded(), deprecated since times forgotten
Chad Horohoe [Fri, 9 Jul 2010 21:19:58 +0000 (21:19 +0000)]
This can be protected now since we redid installSteps hooks
Max Semenik [Fri, 9 Jul 2010 21:11:54 +0000 (21:11 +0000)]
Follow-up to r67044: moved string function tests to a separate file protected by conditional, tweaked test runner to skip instead of exploding when required function hook is not found.
Chad Horohoe [Fri, 9 Jul 2010 20:53:52 +0000 (20:53 +0000)]
Reduce some duplication
Chad Horohoe [Fri, 9 Jul 2010 19:05:48 +0000 (19:05 +0000)]
Put sanity checks on some of the installer steps. Also make WebInstaller_Install bail if you try a 2nd time
Chad Horohoe [Fri, 9 Jul 2010 18:36:10 +0000 (18:36 +0000)]
Move status box below output from pass/fail
Raimond Spekking [Fri, 9 Jul 2010 15:54:33 +0000 (15:54 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-07-09 15:17:00 UTC)
Siebrand Mazeland [Fri, 9 Jul 2010 14:51:31 +0000 (14:51 +0000)]
Use 'summary' instead of 'comment'
Chad Horohoe [Fri, 9 Jul 2010 14:15:48 +0000 (14:15 +0000)]
Kill deprecated function. Marked as such for ~30k revs and no callers
Max Semenik [Fri, 9 Jul 2010 13:45:09 +0000 (13:45 +0000)]
Removed commented-out deprecated function
Chad Horohoe [Fri, 9 Jul 2010 12:43:27 +0000 (12:43 +0000)]
Cleanup to r69191: use addParserOutput() instead of addHtml(), specify current rev on Article, use doViewParse() so we can cache the ParserOutput
Bryan Tong Minh [Fri, 9 Jul 2010 11:08:18 +0000 (11:08 +0000)]
(bug 22339) Added srwhat=nearmatch to list=search to get a "go" result
Refactored SearchResult constructor to accept Titles. New static function newFromRow and newFromTitle can be used.
Added SearchNearMatchResultSet to wrap the output of SearchEngine::getNearMatch.
Bryan Tong Minh [Fri, 9 Jul 2010 09:46:05 +0000 (09:46 +0000)]
Revert r64436, r64437, r64508 per CR r64436
Tim Starling [Fri, 9 Jul 2010 06:54:14 +0000 (06:54 +0000)]
Revert r63213, r63214 per CR comment on r63214, doesn't match documented cmd.exe behaviour
Max Semenik [Thu, 8 Jul 2010 19:30:21 +0000 (19:30 +0000)]
requestWriteMode() is deprecated and unused
Chad Horohoe [Thu, 8 Jul 2010 18:46:10 +0000 (18:46 +0000)]
Tweaks to UPGRADE and INSTALL instructions. Include new info about new-installer, remove some redundant sections
Chad Horohoe [Thu, 8 Jul 2010 18:35:26 +0000 (18:35 +0000)]
Followup r69186, need to specify column name here
Chad Horohoe [Thu, 8 Jul 2010 17:01:28 +0000 (17:01 +0000)]
(bug 24124) Diffs are taking 10 to 20 seconds to load. Use parser cache for page preview when diffing to current version (which is the most often). Cuts execution time down on my sample page from 1141.44ms down to 13.78ms on a pcache hit
Greg Sabino Mullane [Thu, 8 Jul 2010 15:11:57 +0000 (15:11 +0000)]
Add ul_value to Postgres schema.
Chad Horohoe [Thu, 8 Jul 2010 15:00:00 +0000 (15:00 +0000)]
Change Updaters to Updater
Chad Horohoe [Thu, 8 Jul 2010 14:57:19 +0000 (14:57 +0000)]
Refactor a lot of updaters.inc into some classes in the installer code. Still need all these blasted global functions. And OpenID still uses $wgUpdates, so support for it remains...for now!
Chad Horohoe [Thu, 8 Jul 2010 13:58:42 +0000 (13:58 +0000)]
Add optional ul_value blob to updatelog so it can store more useful things
Niklas Laxström [Thu, 8 Jul 2010 13:34:03 +0000 (13:34 +0000)]
Introduce $wgBetterDirectionality that lets us work on support for rtl ui in ltr wiki and vice versa.
Niklas Laxström [Thu, 8 Jul 2010 12:49:19 +0000 (12:49 +0000)]
Unused template parameter
Roan Kattouw [Thu, 8 Jul 2010 10:49:36 +0000 (10:49 +0000)]
Followup to r51583: actually use the rd_interwiki and rd_fragment fields, in the spirit of r33133: we now use the redirect table as a cache for redirect targets, no longer pulling the page text from ES for every logged-in redirect view. Old-style redirect table entries with NULL for fragment and interwiki are automatically updated when the redirect is visited or edited.
Chad Horohoe [Thu, 8 Jul 2010 10:34:59 +0000 (10:34 +0000)]
Followup r68831, r69170. Set none as the default cache always, never APC
Niklas Laxström [Thu, 8 Jul 2010 09:28:31 +0000 (09:28 +0000)]
Whitespace fix
Niklas Laxström [Thu, 8 Jul 2010 09:15:53 +0000 (09:15 +0000)]
Added $wgAllUnicodeFixes to replace live-hack at twn
Niklas Laxström [Thu, 8 Jul 2010 09:08:03 +0000 (09:08 +0000)]
Simplify wfMsgGetKey
Niklas Laxström [Thu, 8 Jul 2010 09:03:47 +0000 (09:03 +0000)]
Update syntax examples a bit
Niklas Laxström [Thu, 8 Jul 2010 08:23:35 +0000 (08:23 +0000)]
Avoid unstubbing in wfGetLangObj, code style
Niklas Laxström [Thu, 8 Jul 2010 08:12:19 +0000 (08:12 +0000)]
Document mDebugtext
Niklas Laxström [Thu, 8 Jul 2010 08:11:14 +0000 (08:11 +0000)]
Little debugging help for LinkBatch
Mark A. Hershberger [Thu, 8 Jul 2010 08:08:14 +0000 (08:08 +0000)]
r68831 make sure $selected is set.
Max Semenik [Thu, 8 Jul 2010 06:53:42 +0000 (06:53 +0000)]
Update comment: makeLikeArray() is deprecated
Ævar Arnfjörð Bjarmason [Wed, 7 Jul 2010 15:05:05 +0000 (15:05 +0000)]
new-installer: Revert DB driver check breakage in r69128
We should use isCompiled() to check if we can actually use a DB
driver. Just constructing the object isn't enough. r69128 regressed so
that the installed displayed Oracle as an option for me, even though I
have no driver for it.
Philip Tzou [Wed, 7 Jul 2010 14:46:27 +0000 (14:46 +0000)]
Continue to clean up the LanguageConverter.php.
Chad Horohoe [Wed, 7 Jul 2010 13:56:44 +0000 (13:56 +0000)]
doesn't need to be passed by ref
Chad Horohoe [Wed, 7 Jul 2010 13:53:27 +0000 (13:53 +0000)]
Give the installerdbtype object to custom callbacks too :)
Chad Horohoe [Wed, 7 Jul 2010 13:52:05 +0000 (13:52 +0000)]
Partial revert r69128: go back to making isCompiled() an instance method rather than static. Moved $installSteps tweaking to new preInstall() method rather than piling more hacks into the constructor. Also pass InstallerDBType to install steps, reduce some code duplication
Mark A. Hershberger [Wed, 7 Jul 2010 13:39:57 +0000 (13:39 +0000)]
* use call_user_func instead of $class::isCompiled() for php 5.2 (re r69128)
* in performInstallation, $step is always a string, check $stepObj instead
* remove installUser() method that only called setupUser, which only MySQL needs and is added by modifying the steps
Chad Horohoe [Wed, 7 Jul 2010 12:48:20 +0000 (12:48 +0000)]
performInstallation() should halt when a fatal status is encountered
ThomasV [Wed, 7 Jul 2010 11:05:00 +0000 (11:05 +0000)]
fix text layer extraction (bug 21526); patch by Simon Lipp
Ævar Arnfjörð Bjarmason [Wed, 7 Jul 2010 10:55:53 +0000 (10:55 +0000)]
new-installer: WebInstaller's ->finish method needs to be public, not private
It's called from new-index.php if we can't start a session:
$installer = new WebInstaller( $wgRequest );
if ( !$installer->startSession() ) {
$installer->finish();
Resulting in:
[07-Jul-2010 10:37:00] PHP Fatal error: Call to private method WebInstaller::finish() from context '' in /home/avar/g/phase3/config/new-index.php on line 12
Ævar Arnfjörð Bjarmason [Wed, 7 Jul 2010 10:42:12 +0000 (10:42 +0000)]
new-installer: Remove duplicate code added in r69128
Ævar Arnfjörð Bjarmason [Wed, 7 Jul 2010 10:42:10 +0000 (10:42 +0000)]
new-installer: Remove debug_print_backtrace() call added in r69128
Philip Tzou [Wed, 7 Jul 2010 08:59:03 +0000 (08:59 +0000)]
* Deprecated convertLinkToAllVariants() since the "{" and "}" are not allowed in titles, the text will get all converted always like autoConvertToAllVariants().
* Removed some redundant code.
Philip Tzou [Wed, 7 Jul 2010 08:35:25 +0000 (08:35 +0000)]
Clean up LanguageConverter.php.
Mark A. Hershberger [Wed, 7 Jul 2010 02:53:57 +0000 (02:53 +0000)]
finish revert of r69108
Mark A. Hershberger [Wed, 7 Jul 2010 02:53:19 +0000 (02:53 +0000)]
* Add Status::getWarningsArray() to complement Status::getErrorsArray()
* Add Status::getWikiTextArray() to allow different ways of formating a bunch of status messages (e.g. CLI output)
* Clean up messages in CliInstaller, use more i18n
* Use warning messages from Status return object in CLI installer
* Make Installer::isCompiled static so we don't have to create an object just to see that we can't use it.
* Add Installer::addInstallStepFollowing so we don't have MySQLInstaller mucking in its parent's data
Ævar Arnfjörð Bjarmason [Tue, 6 Jul 2010 21:34:20 +0000 (21:34 +0000)]
new-installer: Make findExtensions() return a key-value array
Now we return e.g.:
array( 'Cite', 'LiquidThreads' );
Instead return:
array(
'Cite' => null,
'LiquidThreads' => $some_config
);
Where $some_config is a yet-to-be determined configuration. It's
intended for e.g. sourcing SQL tables that the extension needs.
Chad Horohoe [Tue, 6 Jul 2010 20:56:37 +0000 (20:56 +0000)]
Remove a few functions that have been labelled deprecated forever and have no callers anywhere
Chad Horohoe [Tue, 6 Jul 2010 20:44:48 +0000 (20:44 +0000)]
Revert r69005 (adding valid_tag to parsertest tables). Not sure what freaky magic was going on, can't seem to replicate
Ævar Arnfjörð Bjarmason [Tue, 6 Jul 2010 20:40:05 +0000 (20:40 +0000)]
new-installer: Delay database object construction until ->execute time
My method of putting code that alters $this->parent->installSteps in
the MySQL constructor didn't work because the installer will construct
objects for all the databases, even those it doesn't use.
This ostensibly happens because it needs to be able to provide
defaults for all of them on the DBConnect page.
But when I was going to fix that by exiting the MySQL constructior by
checking $wgDBtype I found that it didn't work, because WebInstaller
calls Installer's __construct *before* any sessions are read or set
up, so $wgDBtype will always be mysql, since that's the default.
Fix that by delaying the construction of the database objects. The
WebInstaller (or equivalent) now has to call ->setupDatabaseObjects()
in its ->execute method. This way the defaults on the DBConnect will
still be provided, but we'll have access to session data in the
database constructors.
Ughed-by: Chad <innocentkiller@gmail.com>
Chad Horohoe [Tue, 6 Jul 2010 19:06:44 +0000 (19:06 +0000)]
Followup r69007, use $wgDeletedDirectory since it exists now
Chad Horohoe [Tue, 6 Jul 2010 18:57:06 +0000 (18:57 +0000)]
Disable installer when LocalSettings.php is detected