Happy-melon [Thu, 14 Apr 2011 10:38:29 +0000 (10:38 +0000)]
r86001, now with less scariness :P I took out the delete action and did purge instead, which is a much more self-contained action-with-a-form. Also implement a few changes suggested by Brion on IRC last night.
Leo Koppelkamm [Thu, 14 Apr 2011 10:02:51 +0000 (10:02 +0000)]
Fixing line-break issues with r85922
Tim Starling [Thu, 14 Apr 2011 07:10:59 +0000 (07:10 +0000)]
(bug 28507) Fix for r85844: that revision was not actually sufficient to fix bug 28235, since URLs can have more than one question mark in them.
Platonides [Wed, 13 Apr 2011 23:50:33 +0000 (23:50 +0000)]
Move </td> and </th> to its own line (unless it's an empty cell)
Fixes the other r86004 test case and r86010 one.
Nimish Gautam [Wed, 13 Apr 2011 23:47:01 +0000 (23:47 +0000)]
Created BeforeWelcomeCreation hook to be run before any welcome message gets displayed
Platonides [Wed, 13 Apr 2011 23:36:49 +0000 (23:36 +0000)]
Another evil test to join r86004 (didn't produce malformed output in the pre-r85922 parser)
Happy-melon [Wed, 13 Apr 2011 23:36:27 +0000 (23:36 +0000)]
Revert r86001: Brion says it's too scary :D will recommit in pieces
Platonides [Wed, 13 Apr 2011 23:19:27 +0000 (23:19 +0000)]
Follow up r85922 moving the </caption> to another line, fixing one of the tests added in r86004.
Platonides [Wed, 13 Apr 2011 23:16:22 +0000 (23:16 +0000)]
Add a couple of broken tests showing why having the table closing tags in the same line is not a good idea.
Platonides [Wed, 13 Apr 2011 23:12:25 +0000 (23:12 +0000)]
Follow up r85991. For some reason I committed the test for r85921 parser, not for r85922
Happy-melon [Wed, 13 Apr 2011 23:04:07 +0000 (23:04 +0000)]
New infrastructure for actions, as discussed on wikitech-l. Fairly huge commit.
* Actions come in two flavours: the show-a-form-then-do-something-with-the-result (delete, protect, edit, etc) and the just-do-something (watch, rollback, patrol, etc). Create abstract base classes Action and FormlessAction to support these two cases. HTMLForm is an integral part of the form-based structure.
* Look mum, no globals! :D Fully context-based.
* Implement watch/unwatch, credits and delete actions in the new system as proof-of-concept. This also gives the delete frontend a much-needed overhaul.
* Stub out the newly-deprecated functions from Article.php. This already reduces its linecount by about 15%, and there are plenty more actions still to do.
* Centralising actions like this is going to render a lot of hooks type-incompatible. There's simply nowhere you can put the ArticleConfirmDelete hook, for instance, where it can be passed an OutputPage as the second parameter. On the other hand, we can implement new hooks like ActionModifyFormFields and ActionBeforeFormDisplay, which can do much prettier stuff to the forms, like adding extra fields the 'right' way. Update LiquidThreads to use these new hooks where appropriate.
Happy-melon [Wed, 13 Apr 2011 22:30:13 +0000 (22:30 +0000)]
Unbundle OutputPage::showErrorPage() in Exception.php to allow ErrorPageError objects to be passed a Message object for a more complicated display.
Platonides [Wed, 13 Apr 2011 22:20:14 +0000 (22:20 +0000)]
Readd support for headings inside tables, broken in r85922 and reported on its CodeReview.
Added testcase for it.
It changes again Parser24.
Raimond Spekking [Wed, 13 Apr 2011 20:02:04 +0000 (20:02 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-04-13 19:20:00 UTC)
Leo Koppelkamm [Wed, 13 Apr 2011 20:01:23 +0000 (20:01 +0000)]
Tables: Fix Bug 20078, add test for it
Leo Koppelkamm [Wed, 13 Apr 2011 19:46:09 +0000 (19:46 +0000)]
Followup to r85922: Adapt to MW-coding style
Happy-melon [Wed, 13 Apr 2011 16:51:22 +0000 (16:51 +0000)]
Look mum, no globals! Implement a RequestContext for HTMLForm, passed in the constructor. Currently this is optional with B/C; at a later date it should be made compulsory. Doing this removes the need to call $form->setTitle() on every single use; only when you want to set the title to something other than the page context title. Implemented the new syntax in a sample of forms. Also fix a few minor errors in HTMLForm.php that my IDE complained about.
Happy-melon [Wed, 13 Apr 2011 14:30:55 +0000 (14:30 +0000)]
Implement user-is-blocked and wiki-is-read-only as exceptions.
Happy-melon [Wed, 13 Apr 2011 14:27:59 +0000 (14:27 +0000)]
Follow-up r85929: update MediaWiki::articleFromTitle() call in SearchEngine.php
Sam Reed [Wed, 13 Apr 2011 13:09:17 +0000 (13:09 +0000)]
Related to bug 28470 (Doxygen not updating)
Move require_once( MWInit::compiledPath( 'includes/normal/UtfNormalDefines.php' ) ); to Setup.php
Might want relocating in Setup.php though
Leo Koppelkamm [Wed, 13 Apr 2011 12:44:33 +0000 (12:44 +0000)]
Followup to r85922: Output th instead of td for tfoot
Leo Koppelkamm [Wed, 13 Apr 2011 11:24:38 +0000 (11:24 +0000)]
Followup to r85922: Fix STRICT error, rmv redundant whitespace
Neil Kandalgaonkar [Wed, 13 Apr 2011 05:40:51 +0000 (05:40 +0000)]
reverting some changes unintentionally committed in r85939
Neil Kandalgaonkar [Wed, 13 Apr 2011 05:31:22 +0000 (05:31 +0000)]
followup to r85929 -- missing the break;s for non-default cases.
Aaron Schulz [Wed, 13 Apr 2011 00:50:44 +0000 (00:50 +0000)]
* Removed getSelectOptions, which did nothing other than send FOR UPDATE on some slave queries to barely used features
* Removed only Core use of forUpdate(); same issue
Happy-melon [Tue, 12 Apr 2011 23:28:23 +0000 (23:28 +0000)]
Follow-up r85928: back out unrelated changes.
Happy-melon [Tue, 12 Apr 2011 23:02:02 +0000 (23:02 +0000)]
Follow-up r85928: AutoLoader entry.
Happy-melon [Tue, 12 Apr 2011 23:00:49 +0000 (23:00 +0000)]
Implement a $context and getContext/setContext methods for Article (and its subclasses).
Happy-melon [Tue, 12 Apr 2011 22:59:17 +0000 (22:59 +0000)]
allow methods to generate a "user does not have required permissions" error by throwing an exception rather than calling $wgOut->permissionRequired(). Currently somewhat circular as the exception goes back to OutputPage::showErrorPage(), but hopefully that global dependency can be reduced in future.
Leo Koppelkamm [Tue, 12 Apr 2011 21:27:24 +0000 (21:27 +0000)]
Platonides [Tue, 12 Apr 2011 20:56:35 +0000 (20:56 +0000)]
$wgDBprefix shall be converted to uppercase per r85786
Platonides [Tue, 12 Apr 2011 20:48:19 +0000 (20:48 +0000)]
I forgot to commit this in r85906
Happy-melon [Tue, 12 Apr 2011 20:38:16 +0000 (20:38 +0000)]
Improvements to handling of 'catastrophic' errors, like unsupported PHP versions, no MySQL functions, no LocalSettings, etc.
* Fix parsing of the three major entry points (index.php, api.php, load.php) back to PHP 4.4.9. We don't care what happens if you actually try to run these files on old versions, but the entry files need to parse correctly.
* consign /includes/templates/PHP4.php and /includes/templates/NoLocalSettings.php to the fiery pit of hell where they belong.
* Prevent loading of any other files for PHP < 5. WebStart.php was rendered unparseable in PHP 4 by the introduction of try/catch blocks in r85327.
* Die outright with a pretty error message on PHP < 5.2.3 as well as PHP 4. All versions of PHP below that throw parse errors of various sorts.
* Reimplement wfDie() to provide an entry-point-dependent die-with-readable-error-message function (for instance, we want a pretty human-readable page in index.php, something wrapped in CSS/JS /*...*/ comment block in load.php, etc).
* Standardise the appearance of the catastrophic errors thrown at the top of the stack with the ones lower down (exception-within-exception, etc). There isn't really a way to do this without duplication, AFAICT.
Sam Reed [Tue, 12 Apr 2011 20:30:25 +0000 (20:30 +0000)]
Reverting r85784 for good measure too
(Pending better solution)
Sam Reed [Tue, 12 Apr 2011 20:27:26 +0000 (20:27 +0000)]
Revert r85776, r85782 pending better solution
Aaron Schulz [Tue, 12 Apr 2011 20:26:56 +0000 (20:26 +0000)]
Added pageDataFromId return type to docs
Aaron Schulz [Tue, 12 Apr 2011 20:21:16 +0000 (20:21 +0000)]
* Made pageDataFromTitle protected (unused elsewhere)
* Split out selectFields() for easier use of loadPageData()
* Marked Revision::selectFields as public (was used as such)
Bryan Tong Minh [Tue, 12 Apr 2011 19:25:56 +0000 (19:25 +0000)]
Add support for importing/exporting files. This can be done by embedding the image as base64 in the XML stream or by copying the images directory manually and pointing the importer to the base images directory.
Currently only backend code available and a few member variables need to be modified to enable the functionality.
Export.php:
* Add <rel> and <sha1base36> elememnts to the XML output
* Add optional <archivename> and <contents> elements to the XML output. <contents> contains an encoding attribute, which is currently only set to base64.
Import.php:
* Add Import::$mImageBasePath which should point to the images/ directory to import from
* Add methods to WikiRevision (terrible name btw) to set the rel, hash, archivename and filesrc.
* Cleanup and made WikiRevision::importUpload working. It's still quite a mess though
OldLocalFiel.php:
* Fix a few timestamp related things from r85635
Raimond Spekking [Tue, 12 Apr 2011 19:17:37 +0000 (19:17 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-04-12 19:00:00 UTC)
Platonides [Tue, 12 Apr 2011 18:59:19 +0000 (18:59 +0000)]
Follow up r85888: Add the parameter to DatabasePostgres.php and DatabaseOracle.php
Follow up r85884: The parent tableName() should work now for DatabaseMssql.php
Platonides [Tue, 12 Apr 2011 18:54:51 +0000 (18:54 +0000)]
Change the duplicateTableStructure() to use the original names.
It is now duplicateTableStructure() duty to addIdentifierQuotes() them.
Fixed bug for mysql < 4.1 where the new name would be quoted twice.
Always quote identifier in Oracle, doing otherwise seems a bug (can someone confirm?)
Platonides [Tue, 12 Apr 2011 18:52:16 +0000 (18:52 +0000)]
Follow up r85888
Ryan Kaldari [Tue, 12 Apr 2011 17:32:59 +0000 (17:32 +0000)]
less redundant wording, follow up to r85894
Leons Petrazickis [Tue, 12 Apr 2011 17:18:35 +0000 (17:18 +0000)]
Addressing comments by Krinkle on r85885. Removing commented-out code. Verified that there is no more of it.
Ryan Kaldari [Tue, 12 Apr 2011 17:11:43 +0000 (17:11 +0000)]
updating release notes, follow up to r85847 and r83212
Siebrand Mazeland [Tue, 12 Apr 2011 17:08:59 +0000 (17:08 +0000)]
Fix typo in r85885.
Brion Vibber [Tue, 12 Apr 2011 17:08:31 +0000 (17:08 +0000)]
Revert r84856: restore version that works before destruction of the UsersPager class
Ryan Kaldari [Tue, 12 Apr 2011 17:07:58 +0000 (17:07 +0000)]
Livonian
Leons Petrazickis [Tue, 12 Apr 2011 17:07:01 +0000 (17:07 +0000)]
Addressing comment by IAlex. Setting svn:eol-style to native and removing ?> from end of file.
Brion Vibber [Tue, 12 Apr 2011 17:04:56 +0000 (17:04 +0000)]
Revert r84805: broke CentralAuth by removing base UsersPager class used in other special pages
Platonides [Tue, 12 Apr 2011 17:00:08 +0000 (17:00 +0000)]
Add parameter to tableName() to get the bare table name.
Siebrand Mazeland [Tue, 12 Apr 2011 16:58:50 +0000 (16:58 +0000)]
Update wording for messages added in r85976.
Platonides [Tue, 12 Apr 2011 16:57:44 +0000 (16:57 +0000)]
No need to quote just to avoid the prefixes.
Leons Petrazickis [Tue, 12 Apr 2011 16:35:41 +0000 (16:35 +0000)]
Fixes to DB2 support. DB2 support integration with 1.17 Installer and Updater. Developed by Andre, Tiago, Diego, and Cesar as described in wikitech-l message. Reviewed by me.
Platonides [Tue, 12 Apr 2011 16:34:12 +0000 (16:34 +0000)]
Abstract tableName() by adding new function isQuotedIdentifier() to databases.
This fixes bug in DatabaseOracle.php tableName() on line 671 and allows it to call
the parent implementation instead of copying it with different quotes.
Adapt Mssql addIdentifierQuotes(). Replace its addIdentifierQuotes calls with addQuotes
as it's what it really is. The serialize() is probably unneeded, since I don't think it will
ever be called with objects but I kept it anyway.
Jack Phoenix [Tue, 12 Apr 2011 15:46:00 +0000 (15:46 +0000)]
follow-up to r85876: fix some coding style issues (some of which were not introduced in r85876) + tweak docs (we don't usually mark author(s)/copyright holder(s) on individual functions, only on whole files)
Max Semenik [Tue, 12 Apr 2011 15:37:51 +0000 (15:37 +0000)]
Made install.php fail gracefully on PHP4
Purodha B Blissenbach [Tue, 12 Apr 2011 13:01:14 +0000 (13:01 +0000)]
Add new message of r85876 to messge maintenance list.
Purodha B Blissenbach [Tue, 12 Apr 2011 12:49:56 +0000 (12:49 +0000)]
(bug 13879) Special:Emailuser now asks for suitable target user if called without.
Happy-melon [Tue, 12 Apr 2011 12:09:11 +0000 (12:09 +0000)]
Clean up some direct $db->query($sql) calls. Remove limit/offset parameters from Article::getContributors() as they weren't being used anywhere and probably didn't work properly anyway.
Raimond Spekking [Tue, 12 Apr 2011 12:05:21 +0000 (12:05 +0000)]
Add new message key from r85844 to maintenance file
Tim Starling [Tue, 12 Apr 2011 03:59:47 +0000 (03:59 +0000)]
In SQLBagOStuff: make it possible to change the purge period, or disable purging altogether. At Domas's suggestion, for deployment to Wikimedia very soon.
Tim Starling [Tue, 12 Apr 2011 02:10:16 +0000 (02:10 +0000)]
Fix for bug 28450: escaped CSS comments
Ryan Kaldari [Tue, 12 Apr 2011 01:33:57 +0000 (01:33 +0000)]
follow up to r85847 - tokipona projects are long dead and gone
Ryan Kaldari [Tue, 12 Apr 2011 01:27:10 +0000 (01:27 +0000)]
follow up to r85847 - tokipona projects long dead and gone
Tim Starling [Tue, 12 Apr 2011 01:26:17 +0000 (01:26 +0000)]
Check all MSIE requests since we also want to protect IE 3-5 etc.
Ryan Kaldari [Tue, 12 Apr 2011 01:22:25 +0000 (01:22 +0000)]
tokipona projects are long dead and gone, no need for abbreviated (incorrect) language code any more
Tim Starling [Tue, 12 Apr 2011 00:55:10 +0000 (00:55 +0000)]
Fix for bug 28235: IE6 looks for the file extension in the query string
Sam Reed [Tue, 12 Apr 2011 00:16:04 +0000 (00:16 +0000)]
Whitespace, braces, documentation
Sam Reed [Mon, 11 Apr 2011 20:43:04 +0000 (20:43 +0000)]
Spaces, braces and trailing whitespace
Raimond Spekking [Mon, 11 Apr 2011 19:18:59 +0000 (19:18 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-04-11 18:35:00 UTC)
Sam Reed [Mon, 11 Apr 2011 18:46:35 +0000 (18:46 +0000)]
Revert r85785
Sam Reed [Mon, 11 Apr 2011 18:37:29 +0000 (18:37 +0000)]
Revert r85799
Sam Reed [Mon, 11 Apr 2011 18:29:18 +0000 (18:29 +0000)]
Revert r85783, it seems to brake random stuff in random places #fail
Sam Reed [Mon, 11 Apr 2011 17:37:09 +0000 (17:37 +0000)]
Add MWInit to AutoLoader, see if we unbreak doxygen
Max Semenik [Mon, 11 Apr 2011 17:16:41 +0000 (17:16 +0000)]
Bug 28478: database error in DatabaseSqlite::getFulltextSearchModule().
It was caused by a weird bug in SQLite: virtual table using a non-existent module still gets created somehow, and it is completely undeletable.
Alexandre Emsenhuber [Mon, 11 Apr 2011 16:52:51 +0000 (16:52 +0000)]
No need to call wfSuppressWarnings() and wfRestoreWarnings(); wfDl() already does this
Paul Copperman [Mon, 11 Apr 2011 16:49:36 +0000 (16:49 +0000)]
Fix some Notices:
* LanguageKaa.php: Fix ucfirst and lcfirst for empty strings.
* SkinTemplate.php: Fix undefined array access.
* ProxyTools.php: When running hiphop in cli mode, apache_request_headers() returns null. Fix wfGetForwardedFor() to account for that.
Sam Reed [Mon, 11 Apr 2011 16:42:23 +0000 (16:42 +0000)]
commons.wikimedia: (SQL Query hidden) from within function "LinksUpdate::incrTableUpdate". Database returned error "1205: Lock wait timeout exceeded; try restarting transaction (10.0.6.41)".
Per Krinkle on IRC
Paul Copperman [Mon, 11 Apr 2011 16:41:23 +0000 (16:41 +0000)]
Follow-Up r85618:
* UploadFromUrlTest.php: Remove another instance of stray ini_set statements.
* Makefile: Also exclude group Stub from tests when running 'make noparser' etc.
Sam Reed [Mon, 11 Apr 2011 13:53:57 +0000 (13:53 +0000)]
Remove unused globals
Jure Kajzer [Mon, 11 Apr 2011 13:50:21 +0000 (13:50 +0000)]
* fix as per brion's comment on r85669
Sam Reed [Mon, 11 Apr 2011 13:07:55 +0000 (13:07 +0000)]
* (bug 13921) deadlocks mass-deleting media files in categories
Sam Reed [Mon, 11 Apr 2011 13:02:55 +0000 (13:02 +0000)]
* (bug 27639) Transaction timeout when trying to OldLocalFile::upgradeRow()
Sam Reed [Mon, 11 Apr 2011 12:56:23 +0000 (12:56 +0000)]
* (bug 20468) User::invalidateCache throws 1205: Lock wait timeout exceeded
Sam Reed [Mon, 11 Apr 2011 12:48:59 +0000 (12:48 +0000)]
Followup r85776, per Aaron, add documentation showing reason why explicit creation of a new LB was added
Sam Reed [Mon, 11 Apr 2011 12:47:55 +0000 (12:47 +0000)]
Code comments, few braces
Sam Reed [Mon, 11 Apr 2011 00:29:42 +0000 (00:29 +0000)]
* (bug 28485) Block::purgeExpired Database returned error "1205: Lock wait timeout exceeded;"
Commit changes per Tims suggestion on the ubg
Neil Kandalgaonkar [Sun, 10 Apr 2011 22:27:52 +0000 (22:27 +0000)]
followup to r85654, move global declarations
Sam Reed [Sun, 10 Apr 2011 21:52:34 +0000 (21:52 +0000)]
* (bug 26873) API: Add 'toponly' filter in usercontribs module
Sam Reed [Sun, 10 Apr 2011 21:42:20 +0000 (21:42 +0000)]
* (bug 28455) Add 'toponly' to recentchanges API module
Sam Reed [Sun, 10 Apr 2011 21:11:39 +0000 (21:11 +0000)]
* (bug 27712) add parent_id to list=deletedrevs
Platonides [Sun, 10 Apr 2011 16:42:29 +0000 (16:42 +0000)]
Follow up r85566. Add the helper classes to test autoloader.
Platonides [Sun, 10 Apr 2011 15:54:11 +0000 (15:54 +0000)]
Remove double ; from r84971
Make explicit that the previous values of $wgAutoloadClasses are not preserved and make happy the 'unused global' detector.
Alexandre Emsenhuber [Sun, 10 Apr 2011 14:21:37 +0000 (14:21 +0000)]
dl() -> wfDl()
Sam Reed [Sun, 10 Apr 2011 13:01:47 +0000 (13:01 +0000)]
* (bug 28254) action=paraminfo: Extract type from PARAM_DFLT if PARAM_TYPE is not set
Patch by Umherirrender
Sam Reed [Sun, 10 Apr 2011 12:27:32 +0000 (12:27 +0000)]
* (bug 28364) add registration date to meta=userinfo
Sam Reed [Sun, 10 Apr 2011 12:15:03 +0000 (12:15 +0000)]
* (bug 28368) add hint for multipart/form-data to api information of action=import&xml=
Add RELEASE-NOTES for r85585 too
Max Semenik [Sun, 10 Apr 2011 08:44:06 +0000 (08:44 +0000)]
SQLite is picky about the position of AUTOINCREMENT in field definition, handle it when converting from MySQL syntax
Aaron Schulz [Sun, 10 Apr 2011 06:46:02 +0000 (06:46 +0000)]
Quick fix to categoriesHtml() given new skin changes