Sam Reed [Mon, 5 Mar 2012 23:05:52 +0000 (23:05 +0000)]
Normalise method returns, and returned value usage
Documentation fixes
Thomas Gries [Mon, 5 Mar 2012 23:04:24 +0000 (23:04 +0000)]
updating the outdated Amazon book link, which is invalid since many years or so
Sam Reed [Mon, 5 Mar 2012 22:43:10 +0000 (22:43 +0000)]
Special pages aren't a contextsource. Ping r100114, pass $this->getContext()
Trevor Parscal [Mon, 5 Mar 2012 22:40:29 +0000 (22:40 +0000)]
Lightened the background color of diff context lines as per Erwin Dokter's suggestion. Now using the standard Vector gray background color (#f3f3f3) which is as light as you can go without most monitors rendering it as white.
Alexandre Emsenhuber [Mon, 5 Mar 2012 21:33:48 +0000 (21:33 +0000)]
* Use local context to get messages
* Use Language::userTime() and Language::userDate() instead of Language::time() and Language::date() to display dates with user's preferences
Alexandre Emsenhuber [Mon, 5 Mar 2012 21:21:34 +0000 (21:21 +0000)]
Make RecentChangeTest work by using the same context for expected and actual results. They were failing on my installation because $wgLang->getCode() != $wgContLang->getCode() when the test was called.
Raimond Spekking [Mon, 5 Mar 2012 21:20:53 +0000 (21:20 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Sam Reed [Mon, 5 Mar 2012 21:14:10 +0000 (21:14 +0000)]
Appending a newline at the end of the message results in a much nicer console display
Alexandre Emsenhuber [Mon, 5 Mar 2012 21:06:56 +0000 (21:06 +0000)]
Removed incorrect svn:executable properties
Trevor Parscal [Mon, 5 Mar 2012 19:46:21 +0000 (19:46 +0000)]
Further refinements for r112836 and r112853.
* Used thiner borders on the top, right and bottom of diff lines (looks nicer with many short lines of diff)
* Dropped outlines on changed words altogether and use a slightly darker blue background for added words (couldn't make this look nice in all scenarios)
* Added borders to context lines similar to those used on added/removed lines to make them look more consistent (improves their function as context if they look more similar)
Sam Reed [Mon, 5 Mar 2012 19:17:55 +0000 (19:17 +0000)]
Add to documentation
Add a couple of braces
Update code calling Language related deprecated code
Sam Reed [Mon, 5 Mar 2012 16:38:55 +0000 (16:38 +0000)]
Fix minor issue from r112988
Sam Reed [Mon, 5 Mar 2012 15:23:04 +0000 (15:23 +0000)]
Documentation updates
Normalise method returns
Sam Reed [Mon, 5 Mar 2012 15:21:15 +0000 (15:21 +0000)]
Synchronise RELEASE-NOTES-1.19
Niklas Laxström [Mon, 5 Mar 2012 15:13:26 +0000 (15:13 +0000)]
Why is tis empty? Bug 34938
Tim Starling [Mon, 5 Mar 2012 12:14:53 +0000 (12:14 +0000)]
Transitional patch for bug 34832: introduce a CI-style option to allow deployment of 1.19 to converter wikis without disruption. The bug fix can be rolled out later by setting $wgBug34832TransitionalRollback = false. This is meant as a temporary measure, while we figure out a way to properly support Chinese wikis for inclusion in the 1.19 tarball.
Introduce a global variable which causes language conversion to not be disabled in interface messages (as before r94279). Use $wgContLang for conversion (as before r97849) since $wgContLang is set to the base language (e.g. zh) on converter wikis, whereas a typical user language (e.g. zh-tw) only has a FakeConverter.
Antoine Musso [Mon, 5 Mar 2012 12:05:13 +0000 (12:05 +0000)]
TODO about 'class' throwing a fatal error
Antoine Musso [Mon, 5 Mar 2012 11:50:30 +0000 (11:50 +0000)]
amend r113016 , that was for bug 34302
Antoine Musso [Mon, 5 Mar 2012 11:48:35 +0000 (11:48 +0000)]
place holder to test bug 34919 when it is fixed
Tim Starling [Mon, 5 Mar 2012 05:53:12 +0000 (05:53 +0000)]
* Fix for r41340, r96405, r97849: introduce a function which gets the current content language, called Parser::getTargetLanguage() following the ParserOptions terminology, and added doc comments, to improve the chances of a human being able to work out what is going on. Just because a function happens to do the thing you want doesn't mean you should call it.
* The language object used for lc() in Parser::braceSubstitution() must match the one used in setFunctionHook() during firstCallInit(). It can't change depending on what message you are parsing. Use $wgContLang like before r97849.
Krinkle [Mon, 5 Mar 2012 01:47:30 +0000 (01:47 +0000)]
[mediawiki.test] follow-up r112368: Append to fixture instead of body. Otherwise it stays in the dom even after the test is done
Brian Wolff [Mon, 5 Mar 2012 00:51:47 +0000 (00:51 +0000)]
(bug 34922) If rev_parent_id is null, then the character delta displayed on Special:Contributions is wrong. In that case instead just display "x bytes". Kind of sticks out, but better than a wrong number (possible alternative is just display no number at all)
No release notes since issue introduced in 1.19 and I'm going to tag this commit for merging.
Sam Reed [Mon, 5 Mar 2012 00:05:31 +0000 (00:05 +0000)]
Fix missing * from start of comment block
Also minor documentation update
Antoine Musso [Sun, 4 Mar 2012 23:05:44 +0000 (23:05 +0000)]
make file an argument, --title is script specific
--file did not make that many sense, it is easier to just pass the filename
as an argument
Call to parent constructor was misplaced, that made the script specific
options pretends they were generic maintenance parameters.
Krinkle [Sun, 4 Mar 2012 22:56:43 +0000 (22:56 +0000)]
[ResourceLoader] Minor clean up
* Re-order special modules and add a few comments
* Single quote in QUnitTestResources.php
* Space in ResourceLoader.php
(Separated from another commit while skimming code)
Krinkle [Sun, 4 Mar 2012 22:54:09 +0000 (22:54 +0000)]
[JSTesting] message fix
Krinkle [Sun, 4 Mar 2012 22:53:05 +0000 (22:53 +0000)]
[ObjectCache.php] Add comment describing that CACHE_ANYTHING will use whatever is configured on the wiki for $wgMainCacheType etc., and that if those are set to CACHE_NONE (which it is by default) then CACHE_ANYTHING is CACHE_DB.
Aaron Schulz [Sun, 4 Mar 2012 21:08:55 +0000 (21:08 +0000)]
Added some super calls to constructors to be safe
Raimond Spekking [Sun, 4 Mar 2012 20:23:13 +0000 (20:23 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Ryan Kaldari [Sun, 4 Mar 2012 19:14:20 +0000 (19:14 +0000)]
grammar fix
Brian Wolff [Sun, 4 Mar 2012 05:15:50 +0000 (05:15 +0000)]
(bug 28019) Make Special:MyPage and Special:MyTalk carry preloadtitle
url parameter to target page. Useful for inputbox extension.
Patch by Bagariavivek.
Perhaps should go through [[Manual:Parameters_to_index.php]] and add anything that's sane to the allowed list, at some point.
Raimond Spekking [Sat, 3 Mar 2012 21:32:20 +0000 (21:32 +0000)]
Localisation update for core and extension messages from translatewiki.net
Alexandre Emsenhuber [Sat, 3 Mar 2012 20:22:18 +0000 (20:22 +0000)]
DatabaseBase::selectRow() return a simple object, not a ResultWrapper instance
Aaron Schulz [Sat, 3 Mar 2012 19:14:50 +0000 (19:14 +0000)]
[FileBackend]
* Various documentation improvements.
* Moved a few protected FileBackendStoreShardListIterator functions down. Same with normalizeContainerPath().
Raimond Spekking [Sat, 3 Mar 2012 18:39:55 +0000 (18:39 +0000)]
r112918: Add new message key to maintenance file
Aaron Schulz [Sat, 3 Mar 2012 18:29:38 +0000 (18:29 +0000)]
Moved FileBackendStore and helper classes to their own file (no code changes). Updated AutoLoader.
Alexandre Emsenhuber [Sat, 3 Mar 2012 18:02:21 +0000 (18:02 +0000)]
* Removed check for invalid object in formatResult(), Title::makeTitle() always returns an object
* Don't call Title::exists() when result is not cached since the page must exist, and this was issuing a database query per row
* Reorder some variables for better clarity
* Don't execute the LinkBatch if there are now rows
* Call methods directly on ResultWrapper instead of DatabaseBase in preprocessResults()
* Use local context to get message
Alexandre Emsenhuber [Sat, 3 Mar 2012 17:33:26 +0000 (17:33 +0000)]
Change some DatabaseBase::query() calls to use more specific methods
Alexandre Emsenhuber [Sat, 3 Mar 2012 16:36:37 +0000 (16:36 +0000)]
* (bug 34937) Fix for r107636: call WikiPage::onArticleCreate() when moving a page an not overriding the redirect
Aaron Schulz [Sat, 3 Mar 2012 12:46:58 +0000 (12:46 +0000)]
[Title] In moveToInternal(), just use getParentId() on the null revision object as the base ID rather than $latest. They should conceptually be the same but the former was already fetched with master data.
Aaron Schulz [Sat, 3 Mar 2012 11:49:02 +0000 (11:49 +0000)]
[DatabaseBase] Made encodeExpiry() recognize 'infinity' and added a decodeExpiry() function
Aaron Schulz [Sat, 3 Mar 2012 11:16:30 +0000 (11:16 +0000)]
Added FIXME to formatExpiry()
Benny Situ [Fri, 2 Mar 2012 20:58:10 +0000 (20:58 +0000)]
fix for bug34781 - display old title text if the namespace has been changed
Alexandre Emsenhuber [Fri, 2 Mar 2012 20:35:01 +0000 (20:35 +0000)]
* Don't execute the LinkBatch if there are now rows
* Call methods directly on ResultWrapper instead of DatabaseBase
Alexandre Emsenhuber [Fri, 2 Mar 2012 19:39:07 +0000 (19:39 +0000)]
Use local context to get messages
Alexandre Emsenhuber [Fri, 2 Mar 2012 19:35:06 +0000 (19:35 +0000)]
Per happy-melon, fix for r107653: don't add the error class on success message
Krinkle [Fri, 2 Mar 2012 19:26:22 +0000 (19:26 +0000)]
release-notes
Krinkle [Fri, 2 Mar 2012 19:23:58 +0000 (19:23 +0000)]
[Resources.php] Fix missing dependency on jquery.textSelection (follows-up r81648, r81651)
Sam Reed [Fri, 2 Mar 2012 19:11:55 +0000 (19:11 +0000)]
Bug 34896 - Update jQuery.json
Has whitespace changes (bit of a null diff in many cases)
Tim Starling [Fri, 2 Mar 2012 04:52:16 +0000 (04:52 +0000)]
(bug 34832) Parse recentchangestext with the interface option off, since it comes from wfMsgForContent()
Tim Starling [Fri, 2 Mar 2012 04:00:58 +0000 (04:00 +0000)]
Fix for r86304: if MessageCache::parse() is called twice, once with $interface=true and then with $interface=false, actually use $interface=false the second time instead of using the cached value from the previous call. Same for $language. This is the reason why edittools was affected by bug 34832.
Aaron Schulz [Fri, 2 Mar 2012 01:34:06 +0000 (01:34 +0000)]
Added some lock call profiling
Brian Wolff [Fri, 2 Mar 2012 01:02:41 +0000 (01:02 +0000)]
(bug 34863) Make it so an image that was previously deleted and currently does not exist (locally or foreignly), shows a snippet from the deletion (and move) log.
Currently things outside of file namespace display the snippet, so file ns should display snippet for completeness. As far as I can tell, the only reason files don't is because ImagePage class overrides the Article class, and it was unintentional that the snippet was not included in ImagePage class.
Aaron Schulz [Fri, 2 Mar 2012 00:47:30 +0000 (00:47 +0000)]
Added missing space :)
Sam Reed [Fri, 2 Mar 2012 00:15:20 +0000 (00:15 +0000)]
Add some {}
Ping r111605
Trevor Parscal [Fri, 2 Mar 2012 00:07:33 +0000 (00:07 +0000)]
Improves on r112836 by only using borders on the left and right of the changed text, which makes multi-line changes render much nicer.
Raimond Spekking [Thu, 1 Mar 2012 22:21:50 +0000 (22:21 +0000)]
Localisation update for core and extension messages from translatewiki.net
Aaron Schulz [Thu, 1 Mar 2012 22:10:12 +0000 (22:10 +0000)]
(bug 34873) List contributions of existing users that have invalid names
Aaron Schulz [Thu, 1 Mar 2012 22:01:57 +0000 (22:01 +0000)]
r112839: missing file change
Aaron Schulz [Thu, 1 Mar 2012 21:59:56 +0000 (21:59 +0000)]
Error log readability is nice
Aaron Schulz [Thu, 1 Mar 2012 21:55:22 +0000 (21:55 +0000)]
Actually enforce the FileBackend name requirements instead of just having a comment
Alexandre Emsenhuber [Thu, 1 Mar 2012 21:29:11 +0000 (21:29 +0000)]
* Pass number with numParams() to Message object and let that object format the number
* Added missing escaped() call from my last commit
Trevor Parscal [Thu, 1 Mar 2012 21:27:52 +0000 (21:27 +0000)]
Resolves bug #11374 and improves on r94429, r94461, r101147, r105280, r106884, r107127, r108975 and r109932 which were reverted by r112750.
Sam Reed [Thu, 1 Mar 2012 20:04:42 +0000 (20:04 +0000)]
Squishing resources/ images
Sam Reed [Thu, 1 Mar 2012 19:12:07 +0000 (19:12 +0000)]
Tidy up return values of envChecks
False is used to to signify a failure mode we need to do stuff for, so returning true is ok in other cases, and makes it explicit
Robin Pepermans [Thu, 1 Mar 2012 17:57:15 +0000 (17:57 +0000)]
fix typo in r112479
Alexandre Emsenhuber [Thu, 1 Mar 2012 17:29:12 +0000 (17:29 +0000)]
* (bug 34849) Diff when editing an old version show the comparison with the current text again
Niklas Laxström [Thu, 1 Mar 2012 13:38:49 +0000 (13:38 +0000)]
Hrrrmp *grumbles*
Antoine Musso [Thu, 1 Mar 2012 13:14:48 +0000 (13:14 +0000)]
Credit for Christian Aistleitner
Antoine Musso [Thu, 1 Mar 2012 13:11:25 +0000 (13:11 +0000)]
Bug 34818 improves regex to capture DB error message
Patch by christian at quelltextlich dot at
Antoine Musso [Thu, 1 Mar 2012 11:33:38 +0000 (11:33 +0000)]
Bug 34734 - compressOld.php ignoring -s option
This is fixing a regression caused by r90549.
Patch by christian at quelltextlich dot at
Niklas Laxström [Thu, 1 Mar 2012 10:54:18 +0000 (10:54 +0000)]
Whitespace cleanup
Niklas Laxström [Thu, 1 Mar 2012 10:42:02 +0000 (10:42 +0000)]
Restore many missing spaces from r112589
Also fixed indentation by spaces
And please don't ever use != ''. It's misleading.
Krinkle [Thu, 1 Mar 2012 01:07:18 +0000 (01:07 +0000)]
[mediawiki.action.history.diff.css] Revert 1.19 style changes back to how it was in REL1_18
* After the 1.19wmf1 deployment several people have complained about various aspects of the new diff styling
-- The contrast being too low in the highlighted part (darker background behind bolded text)
-- The colors not being obvious perhaps (orange/blue)
-- Color blind users not seeing the difference very well between the light tones of the orange and blue
-- Trevor mentioned something about W3C Accessibility guidelines
To play it safe for now I think we should revert these changes to the status quo, and take the next few days (or weeks) to carefully check the concerns, perhaps look at other diff tools out there for inspiration (GitHub, Gerrit, LocalWiki, ..).
* Goes back to r91762 (last rev before REL1_18)
-- reverting: r94429, r94461, r101147, r105280, r106884, r107127, r108975, r109932
* Re-opens bug 33335
Aaron Schulz [Wed, 29 Feb 2012 22:45:17 +0000 (22:45 +0000)]
In populateImageSha1.php:
* Added 'force' parameter to run the script on rows with sha1 existing values (and where the file exists)
* Do the all the old versions of files after doing their current versions
* Broke long line and made a few minor cleanups
Tim Starling [Wed, 29 Feb 2012 22:30:23 +0000 (22:30 +0000)]
Fix comment from r54410, add rationale for using MySQL command line pipe
Arthur Richards [Wed, 29 Feb 2012 21:56:05 +0000 (21:56 +0000)]
Added unsetVal() method as antithesis to setVal()
Sam Reed [Wed, 29 Feb 2012 21:21:17 +0000 (21:21 +0000)]
More image shrinkage!
Sam Reed [Wed, 29 Feb 2012 20:23:05 +0000 (20:23 +0000)]
Fix double indenting
Brion Vibber [Wed, 29 Feb 2012 20:02:42 +0000 (20:02 +0000)]
* (bug 34768) Set width and height for search-ltr.png (and search-rtl.png) in Vector skin
<img> in <button> didn't have width or height set.
Sam Reed [Wed, 29 Feb 2012 17:50:02 +0000 (17:50 +0000)]
Followup r112374/bug 34653
We still get legacy log entries, so grab the data from parameters as applicable
Should probably be encapsulated into DatabaseLogEntry itself, with a getParamValue esk wrapper
This fixes issues noticed on live site for the moment
TODO: Check if rights/block are still ok (probably not?)
TODO: If (especially if above needs doing) encapsulate grabbing of old/new parameters to logging code
Raimond Spekking [Wed, 29 Feb 2012 12:34:33 +0000 (12:34 +0000)]
Localisation update for core and extension messages from translatewiki.net
Krinkle [Wed, 29 Feb 2012 01:52:47 +0000 (01:52 +0000)]
[mediawiki.js] minor improvements based on recently added features to JSLint
* Fix with help of JSLint:
-- else statement after a return at the end of a connected if statement
* Using arguments.length incorrectly
* Added JSLint settings to the file
Aaron Schulz [Wed, 29 Feb 2012 00:36:40 +0000 (00:36 +0000)]
r111588: refactored proxy/noProxy code slightly for simplicity
Ryan Kaldari [Tue, 28 Feb 2012 23:48:36 +0000 (23:48 +0000)]
making sure colored buttons get white icons, implementing a smarter css selector scheme for large colored buttons (less redundancy)
Alexandre Emsenhuber [Tue, 28 Feb 2012 21:12:38 +0000 (21:12 +0000)]
* Don't execute the LinkBatch if there are now rows
* Call methods directly on ResultWrapper instead of DatabaseBase
Robin Pepermans [Tue, 28 Feb 2012 20:14:39 +0000 (20:14 +0000)]
fix r112591: re-add whitespace between message name and (talk)
Alexandre Emsenhuber [Tue, 28 Feb 2012 18:46:36 +0000 (18:46 +0000)]
Use local context to get messages
Alexandre Emsenhuber [Tue, 28 Feb 2012 18:41:36 +0000 (18:41 +0000)]
Pass __METHOD__ to DatabaseBase::commit() and DatabaseBase::rollback()
Max Semenik [Tue, 28 Feb 2012 14:42:08 +0000 (14:42 +0000)]
Follow-up r112565: fix code duplication
Siebrand Mazeland [Tue, 28 Feb 2012 12:41:26 +0000 (12:41 +0000)]
(bug 34702) More localised parentheses.
Siebrand Mazeland [Tue, 28 Feb 2012 11:56:59 +0000 (11:56 +0000)]
(bug 34702) More localised parentheses. Patch contributed by Yusuke Matsubara.
Krinkle [Tue, 28 Feb 2012 03:17:05 +0000 (03:17 +0000)]
[mediawiki.action.edit] Clean up and bug fixes
* Bugfix: Locally alias the toolbar object and replace usage of 'this' with 'toolbar'. Calls to window.addButton were failing due to it referring to the dynamic 'this' context which changes when the function is a member of a different object.
* Bugfux: Move currentFocused = $( '#wpTextbox1' ) into the dom-ready hook. When executed before dom-ready the element doesn't exist yet. r111983 did this for $toolbar, but not for currentFocused (bug 34538)
* Move onReady and isReady to the local scope (introduced recently in r111983, not used or meant to be used publicly)
* Merge onReady with the $(document).ready hook function, same purpose
* JS conventions (closure arguments, var hoisting, whitespace)
* Touch r111983, r112451, r112567
Tim Starling [Tue, 28 Feb 2012 02:55:36 +0000 (02:55 +0000)]
Fix r110209: Move the invalid title check above the first use of the title object, to avoid a fatal error, for example when navigating to [[Special:MovePage]] with no target.
Roan Kattouw [Tue, 28 Feb 2012 02:36:29 +0000 (02:36 +0000)]
Fix scoping in r112451: isReady was accidentally used as a global variable
Aaron Schulz [Tue, 28 Feb 2012 02:32:59 +0000 (02:32 +0000)]
r112563: Removed random bogus user IDs passed into to Block constructor in tests
Chad Horohoe [Tue, 28 Feb 2012 02:18:18 +0000 (02:18 +0000)]
(bug 34762) Calling close() on a DatabaseBase object now clears the connection. Based on patch by Christian.
By the way, the duplication here is stupid.
Aaron Schulz [Tue, 28 Feb 2012 02:04:30 +0000 (02:04 +0000)]
Force the target user ID to be the correct foreign ID on the relevant local wikis for crosswiki suppress blocks.
Krinkle [Tue, 28 Feb 2012 01:56:15 +0000 (01:56 +0000)]
[IRC Log Message] Fix for protect/protect and protect/modify
* protect/protect and protect/modify were still failing because the output on IRC is not matching the i18n messages. The bots look for comment.match(<i18n-message> + (optionally) followed by ": user comment").
* The problem with protect/protect and protect/modify is that the protection settings are also inserted in somewhere in the message. Before MediaWiki 1.19 these were included in the IRC message as part of $1 (title). That may be ugly, but that's how it has always been. Since the point is to reproduce the old output we need to fix this one as well. This will make the output like:
Krinkle * protected "[[Sandbox [edit=autoconfirmed)]]"
which is exactly how it has been before and that's the the bots rely on (which was presumably done originally like that since it was the only way to make the output match the i18n message)
* Fixes more bug 34508
Krinkle [Tue, 28 Feb 2012 00:39:01 +0000 (00:39 +0000)]
[RecentChangeTest] Refactor unit test to test better test the issue
* assert used message-keys/variables instead of hardcoded values
* Pass $comment to the assertion helper instead of using it by default so that actions that don't use a comment (such as patrol) don't get forced a comment, to better replicate the IRC behavior
* Adding placeholder for Auto-Edit-Summary things that should also be checked in here, not sure how to do those yet
* Adding tests for block/* and protect/*