Mark A. Hershberger [Fri, 25 Mar 2011 03:36:18 +0000 (03:36 +0000)]
Fixes Bug #28214 - When page not found, sends malformed HTTP/1.x instead of HTTP/1.1 in header of respons
Note that there are a few places in the source where headers are sent
with HTTP/1.0 instead of HTTP/1.1 but this patch doesa not address those
Happy-melon [Thu, 24 Mar 2011 23:28:39 +0000 (23:28 +0000)]
Move WatchlistEditor.php to /specials since inside it is essentially a complete special page. Make it subclass SpecialPage and do all the usual stuff. Rewrite it to use HTMLForm and other exciting things, and give it a good general clean up.
Happy-melon [Thu, 24 Mar 2011 22:46:07 +0000 (22:46 +0000)]
Refactor the get-legend-for-section-fieldset logic out into its own function so it can be overridden.
Platonides [Thu, 24 Mar 2011 21:35:14 +0000 (21:35 +0000)]
Use class name Html in canonical form.
Removed unused globals $wgHooks, $wgBlockAllowsUTEdit, $wgUser, $wgOut
$wgUser was already set global at function beginning.
Moved global out of switch
Ryan Lane [Thu, 24 Mar 2011 21:32:08 +0000 (21:32 +0000)]
Follow up to r84638. Moving the $wgUser global, and fixing formatting.
Sam Reed [Thu, 24 Mar 2011 21:21:15 +0000 (21:21 +0000)]
Commiting simplest hack fix for strict errors
Instantiating new instance of UtfNormal
Will probably nee tidying up later, if we have some other instance we can normally use
Raimond Spekking [Thu, 24 Mar 2011 21:05:31 +0000 (21:05 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-03-24 20:39:00 UTC)
Happy-melon [Thu, 24 Mar 2011 20:51:38 +0000 (20:51 +0000)]
(bug 5303) Merge UtfNormal rewrite. Patch by Ludovic Arnaud (YuviPanda). This is well beyond my ability to review... :D
Sam Reed [Thu, 24 Mar 2011 20:27:30 +0000 (20:27 +0000)]
Followup r79549, only try and filter by group (or right) if there are some groups to do a WHERE on
Sam Reed [Thu, 24 Mar 2011 20:05:45 +0000 (20:05 +0000)]
* (bug 28226) prop=extlinks&eloffset should be an integer
Sam Reed [Thu, 24 Mar 2011 20:02:41 +0000 (20:02 +0000)]
Remove 2 erroneous $db parameters from External links modules
Aaron Schulz [Thu, 24 Mar 2011 18:39:30 +0000 (18:39 +0000)]
* Follow-up for r84660:
** Don't regress in terms of making sure truncating and adding an ellipses won't make the string longer (or equally long)
** Fixed ellipsis adjustment check in truncateHtml()
* Other:
** Made removeBadCharLast/removeBadCharFirst not give warnings on empty string input
** Removed tidy call in truncateHtml, slower and adds some garbage
** Code comment tweaks
Sam Reed [Thu, 24 Mar 2011 11:11:15 +0000 (11:11 +0000)]
Don't pass $this by reference
Aaron Schulz [Thu, 24 Mar 2011 08:44:42 +0000 (08:44 +0000)]
Follow-up r84659: no need to pass parser by reference to event handlers
Tim Starling [Thu, 24 Mar 2011 04:24:30 +0000 (04:24 +0000)]
Revert r84615, complaints received from ml.wikipedia.org. Just because a language has its own set of numerals doesn't mean writers of that language prefer to use them. You can make these changes on a case-by-case basis, after community consultation.
Brian Wolff [Thu, 24 Mar 2011 03:39:21 +0000 (03:39 +0000)]
(follow-up r84660) Per comments, make truncate return original string instead of ellipsis if string is smaller then length and ellipsis is not.
Daniel Friesen [Thu, 24 Mar 2011 03:00:31 +0000 (03:00 +0000)]
Better RELEASE-NOTES for r79520, also taking it's follow ups into account.
Brian Wolff [Thu, 24 Mar 2011 02:54:11 +0000 (02:54 +0000)]
(follow-up 79778) Make $wgLang->truncate function consider the length of the ... (ellipsis message) in the truncation length.
The length of this message varries by localization, so the previous solution of telling truncate to truncate 5 bytes
less than needed is not good since this will be too little or too much.
Updated places where its used. Some places I left as is, as it looked like the new behaviour would work fine for them to.
(for example, the autosummary feature - it was cutting off at 200 bytes, which is no where near 250 limit, so I presume that
was for asethic reasons rather then to fit as much in before the db limit).
Will do another commit for extension callers in a moment.
Aaron Schulz [Thu, 24 Mar 2011 01:44:48 +0000 (01:44 +0000)]
* Replaced crufty BeforeParserMakeImageLinkObj/BeforeGalleryFindFile hooks with BeforeParserFetchFileAndTile hook
* Updated the only calling extension (these was basically single-purpose hooks)
Sam Reed [Thu, 24 Mar 2011 00:48:22 +0000 (00:48 +0000)]
Adding some type documentation to some well used globals
Sam Reed [Thu, 24 Mar 2011 00:43:27 +0000 (00:43 +0000)]
Remove some trailing whitespace
Add some documentation
Happy-melon [Wed, 23 Mar 2011 22:29:56 +0000 (22:29 +0000)]
Follow-up r79723: even nicer whitespace :D
Ryan Lane [Wed, 23 Mar 2011 22:13:09 +0000 (22:13 +0000)]
Removing pass by reference, and making the $error argument for doDeleteArticle a reference. Follow up for r84638.
Neil Kandalgaonkar [Wed, 23 Mar 2011 22:01:15 +0000 (22:01 +0000)]
remove terminally annoying logging message that clutters up IE. Guys, there is a distinction between debug mode for the loading system and when ordinary developers want to debug their own scripts
Raimond Spekking [Wed, 23 Mar 2011 21:58:41 +0000 (21:58 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-03-23 21:48:00 UTC)
Ryan Lane [Wed, 23 Mar 2011 21:54:59 +0000 (21:54 +0000)]
Moving deletion hooks into doArticleDelete so that other code can sanely delete articles. Fixed other core code that was wrapping the calls with hook calls.
Aaron Schulz [Wed, 23 Mar 2011 21:45:32 +0000 (21:45 +0000)]
Follow-up r84610: made makeImage() b/c for callers
Aaron Schulz [Wed, 23 Mar 2011 21:21:31 +0000 (21:21 +0000)]
* Follow-up r84610: don't assume a Parser object is attached
* Removed unused $i var
Happy-melon [Wed, 23 Mar 2011 18:53:50 +0000 (18:53 +0000)]
$wgUser->blockedBy() already returns a name, doesn't need to be passed through User::whoIs(). Probably something I broke at some point :D
Aaron Schulz [Wed, 23 Mar 2011 18:23:55 +0000 (18:23 +0000)]
Straighten out dependency handling from r84610 (files) and before (templates)
Sam Reed [Wed, 23 Mar 2011 17:45:53 +0000 (17:45 +0000)]
Added 11 more sets of numbered list localisations
Based on http://help.dottoro.com/lccatosn.php
Probably some more that can be done, but I don't know the language codes well enough
Roan Kattouw [Wed, 23 Mar 2011 17:45:00 +0000 (17:45 +0000)]
Bump RL filter version to 4 to keep it in sync with the cluster. WMF-centrism, I know, sue me ;)
Aaron Schulz [Wed, 23 Mar 2011 17:35:40 +0000 (17:35 +0000)]
* Put parser output file version tracking to core
* Added some ParserOutput accessors
* A few cleanups to fetchFile()
Sam Reed [Wed, 23 Mar 2011 17:19:23 +0000 (17:19 +0000)]
Add localised number listing for Oriya
Aaron Schulz [Wed, 23 Mar 2011 03:13:37 +0000 (03:13 +0000)]
* Made BeforeParserMakeImageLinkObj/BeforeGalleryFindFile let hooks set sha1 parameter
* Made FlaggedRevs specify files by sha1,timestamp to handle renames with no redirects. This makes them handled as well as templates in this regard. (bug 27836)
* Moved BeforeGalleryFindFile hook to proper place (don't trigger for non-NS_FILE titles)
* Removed unused mRevisionId field from ImageGallery
* Removed old hotfix from makeMediaLinkObj(); all the current callers would crash beforehand if the title was null anyway
* Updated hook docs (some prior params were missing)
* Broke some long lines and cleaned up some whitespace
* TODO: track file info in core rather than fr_fileSHA1Keys and ugly, duplicated, queries. This should be easy to do now.
Happy-melon [Wed, 23 Mar 2011 00:10:46 +0000 (00:10 +0000)]
Try to untangle the autoblock time logic, which made very little sense and led to very old indefinite blocks triggering autoblocks with ipb_expiry < ipb_timestamp.
Sam Reed [Tue, 22 Mar 2011 22:49:39 +0000 (22:49 +0000)]
Partial revert to r83979
Reverting code in SpecialUpload, as it broke errors, leaving the other changes in place, as they are fine
Sam Reed [Tue, 22 Mar 2011 22:36:56 +0000 (22:36 +0000)]
* (bug 28166) UploadBase assumes that 'edit' and 'upload' rights are not per page restrictions
* (bug 27470) Upload blacklist for target names not being applied
Add core bug to RELEASE-NOTES
Both fixed with r84573 and r84575
However, seems I broke some error handling in r83979, will investigate
Antoine Musso [Tue, 22 Mar 2011 22:26:58 +0000 (22:26 +0000)]
Remove sneaky space in class-> method() call
follow up r82406
Sam Reed [Tue, 22 Mar 2011 22:22:39 +0000 (22:22 +0000)]
Followup r65898, fix inverse logic for title existence
Related to bug 27470 and bug 28166
Krinkle [Tue, 22 Mar 2011 21:44:18 +0000 (21:44 +0000)]
Follow-up r84565: Whitespace
Krinkle [Tue, 22 Mar 2011 21:42:16 +0000 (21:42 +0000)]
Fixing bug 27764. Adding an extra if-check to make sure ['text'] is defined. In To avoid wrapping multiple 'if shorthands', converted it to an actual if-statement at the same time
Jack Phoenix [Tue, 22 Mar 2011 20:44:26 +0000 (20:44 +0000)]
findhooks.php: also check for Hooks::run, not just wfRunHooks. Hooks class has existed since r80435 but IIRC nothing in core calls it (yet). Also added some braces and tweaked docs.
Aaron Schulz [Tue, 22 Mar 2011 20:34:50 +0000 (20:34 +0000)]
Made FileRepo::newFileFromKey actually work
Raimond Spekking [Tue, 22 Mar 2011 20:33:52 +0000 (20:33 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-03-22 19:57:00 UTC)
Jack Phoenix [Tue, 22 Mar 2011 20:23:52 +0000 (20:23 +0000)]
coding style tweaks, doc updates, marked some public functions as such
Raimond Spekking [Tue, 22 Mar 2011 19:02:48 +0000 (19:02 +0000)]
Bug 28184 - Namespaces for the Latgalian Wikipedia
Pls sync with 1.17wmf1. Thanks.
Happy-melon [Tue, 22 Mar 2011 17:26:32 +0000 (17:26 +0000)]
Fix "$1 is already blocked" parameter-not-passed-to-message error
Happy-melon [Tue, 22 Mar 2011 17:18:15 +0000 (17:18 +0000)]
(hopefully) last bit of heavy lifting in Block.php: now that we've internalised most of the variables, untangle their twisted connections to the database layer and remove various now-unused protected methods and variables.
Chad Horohoe [Tue, 22 Mar 2011 15:59:50 +0000 (15:59 +0000)]
Cleanup r80892, r84485: Check user also in sqlite for consistency.
Chad Horohoe [Tue, 22 Mar 2011 13:59:00 +0000 (13:59 +0000)]
Followup r84527, forgot to press save on R-N changes
Chad Horohoe [Tue, 22 Mar 2011 13:57:11 +0000 (13:57 +0000)]
(bug 26866) remove trackback user right from DefaultSettings.php
Aaron Schulz [Tue, 22 Mar 2011 13:11:28 +0000 (13:11 +0000)]
* Avoid adding DISTINCT if possible
* Added comments
Aaron Schulz [Tue, 22 Mar 2011 11:51:09 +0000 (11:51 +0000)]
Fixed daft error in r84523 so "angry" autoblocks work again
Happy-melon [Tue, 22 Mar 2011 11:45:18 +0000 (11:45 +0000)]
Don't try and load a block with no target; we're not going to find it :D
Aaron Schulz [Tue, 22 Mar 2011 11:22:15 +0000 (11:22 +0000)]
Relate block log entries to block table rows (useful for bug 25763)
Happy-melon [Tue, 22 Mar 2011 11:14:11 +0000 (11:14 +0000)]
Follow-up r84475: fix notices.
Sam Reed [Tue, 22 Mar 2011 00:24:17 +0000 (00:24 +0000)]
Followup r84470, fill "MW 1.15 compat"
Sam Reed [Tue, 22 Mar 2011 00:08:45 +0000 (00:08 +0000)]
* (bug 27586) Remove duplication of props in ApiQueryStashImageInfo by using ApiQueryImageInfo
Programatically do properties and descriptions. Reduces text duplication, and hence normalises descriptions! :)
Follows up r84502, r84433
Sam Reed [Mon, 21 Mar 2011 23:51:26 +0000 (23:51 +0000)]
* (bug 27589) list=allimages&aiprop=archivename is useless
Followup r84433
Add way to filter returned properties/descriptions
Happy-melon [Mon, 21 Mar 2011 23:27:08 +0000 (23:27 +0000)]
Follow-up r84475: what ever posessed me to get rid of this?
Happy-melon [Mon, 21 Mar 2011 23:03:11 +0000 (23:03 +0000)]
Follow-up r84475: fixing the warning is easy enough... :D Also some random tweaks to Database.php documentation.
Greg Sabino Mullane [Mon, 21 Mar 2011 22:09:49 +0000 (22:09 +0000)]
When switching from admin to non-admin account, make sure to set $this->db to null, otherwise MW will happily return the old handle, which means we end up in the old admin database, and thus create our 'mediawiki' schema in the postgres or template1 database (whoops!). There may be other similar cases in the code in which we are not clearing this->db before toggling the useAdmin attribute. Fixes bug 28171.
Greg Sabino Mullane [Mon, 21 Mar 2011 21:59:04 +0000 (21:59 +0000)]
template1 is a poor choice: use the standard 'postgres' database instead.
Especially as the installer currently is modifying this database! (a separate bug...)
Greg Sabino Mullane [Mon, 21 Mar 2011 21:36:21 +0000 (21:36 +0000)]
$safedb needs to be set *outside* the if/else block, not just inside the if
Fixes bug 28170
Sam Reed [Mon, 21 Mar 2011 21:26:16 +0000 (21:26 +0000)]
Fix variable typo introduced in r83282
Greg Sabino Mullane [Mon, 21 Mar 2011 21:20:11 +0000 (21:20 +0000)]
Do not depend on the lack of a server for connecting: Postgres has a valid and common use case where the server name (aka host) is empty, as the connection is via a Unix socket. Instead, check if a $user has been sent to the function, as all databases can agree that we need at least that much before doing an open. Fixes bug 28167.
Raimond Spekking [Mon, 21 Mar 2011 20:38:19 +0000 (20:38 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-03-21 19:57:00 UTC)
Happy-melon [Mon, 21 Mar 2011 19:12:41 +0000 (19:12 +0000)]
Blame hashar for this giant commit; he teased me for making so many smaller ones earlier... :D
* Internalise $mAddress/$mUser, $mBy/$mByName, $mEnableAutoblock, $mId as getTarget(), getBlockers(), isAutoblocking(), getId().
* This required editing AbuseFilter and CheckUser backwards-incompatibly, so push the rest of the changes out to those extensions.
* Attack the evil 14-parameter constructor and gratuitously-confusing newFromDB( $notVeryImportantParameter, $moreImportantParameter)
* Reimplement the hack for bug 13611 in a slightly less fragile fashion; could still do with further cleanup, but then again the login frontend is its own can of worms... :S
* Remove transitionary getTargetAndType() and newFromTargetAndType() methods
* Some optimisation in parseTarget()
* Fix the broken phpunit test mentioned in r84251
Max Semenik [Mon, 21 Mar 2011 18:41:46 +0000 (18:41 +0000)]
Removed Article::insertNewArticle() and Article::updateArticle() - deprecated in 1.7(!), unused
Russ Nelson [Mon, 21 Mar 2011 18:38:45 +0000 (18:38 +0000)]
Some docs, a spelin eror and fixing a mw1.15 compatibility bug.
Raimond Spekking [Mon, 21 Mar 2011 17:23:14 +0000 (17:23 +0000)]
Bug 28159 - Change interwiki name of language kbd to Къэбэрдеибзэ / Qabardjajəbza
Platonides [Mon, 21 Mar 2011 16:46:17 +0000 (16:46 +0000)]
(Bug 26223) Concurrently moving an article to different titles leaks a redirect revision with no page.
Just the GAID_FOR_UPDATE fixes the issue in my tests, but without the transaction there's still potential for inconsistencies.
Aaron Schulz [Mon, 21 Mar 2011 16:15:56 +0000 (16:15 +0000)]
Broke some of the more annoying lines
Sam Reed [Mon, 21 Mar 2011 15:18:11 +0000 (15:18 +0000)]
Reinstate some lines added during r84357
I guess they're used on some code paths... As it's not an unconditional return...
Greg Sabino Mullane [Mon, 21 Mar 2011 14:59:14 +0000 (14:59 +0000)]
Change the default user from 'root' to 'postgres' if using a PostgreSQL backend.
There may be a better way to do this, so comments welcome.
Roan Kattouw [Mon, 21 Mar 2011 14:56:30 +0000 (14:56 +0000)]
Add warnings about how the math options must all be different; two of these being translated the same in Gujarati caused bug 28152
Greg Sabino Mullane [Mon, 21 Mar 2011 03:01:36 +0000 (03:01 +0000)]
Don't need an Oracle flag here...
Sam Reed [Sun, 20 Mar 2011 23:50:59 +0000 (23:50 +0000)]
Start of bug 27586/bug 27589
Turn properties into a filterable key/value pair, but leave exisiting wrapper methods in place for the moment
Will finish it off later
Sam Reed [Sun, 20 Mar 2011 22:46:09 +0000 (22:46 +0000)]
As I've removed most of Roans reason to use php magic variables, completely remove them this time.
Followup r84430
Sam Reed [Sun, 20 Mar 2011 22:35:41 +0000 (22:35 +0000)]
Followup r84392
Be a bit more explicit about the code, add a bit of readability into foreach too
Aaron Schulz [Sun, 20 Mar 2011 21:55:54 +0000 (21:55 +0000)]
Ugly bug 24375 hack
Aaron Schulz [Sun, 20 Mar 2011 21:30:24 +0000 (21:30 +0000)]
Reverted r84386; breakage too severe
Aaron Schulz [Sun, 20 Mar 2011 20:50:05 +0000 (20:50 +0000)]
More comments on hash inputs
Aaron Schulz [Sun, 20 Mar 2011 20:34:03 +0000 (20:34 +0000)]
* Added findFileFromKey() function
* Added doc comments to findBySha1()
Roan Kattouw [Sun, 20 Mar 2011 19:53:46 +0000 (19:53 +0000)]
Per CR, remove round() call I accidentally reintroduced in r84401
Krinkle [Sun, 20 Mar 2011 19:09:41 +0000 (19:09 +0000)]
Typo from r54350: Overide > Override
Max Semenik [Sun, 20 Mar 2011 18:47:16 +0000 (18:47 +0000)]
Installer: require_once extensions, simple require can cause problems with extensions implicitly depending on other extensions (e.g. Maps already requires Validator, if user checks Validator, xe gets a fatal).
Max Semenik [Sun, 20 Mar 2011 17:54:43 +0000 (17:54 +0000)]
Fixed <doclink> broken by r83023
Happy-melon [Sun, 20 Mar 2011 17:43:17 +0000 (17:43 +0000)]
Follow-up r84358 CR: rename 'editusertalk' to 'editownusertalk', private --> protected, and run stylize.php over Block.php
Max Semenik [Sun, 20 Mar 2011 17:36:18 +0000 (17:36 +0000)]
(bug 26939) Installer does not set $wgMetaNamespace
Roan Kattouw [Sun, 20 Mar 2011 17:18:39 +0000 (17:18 +0000)]
Add Michael Dale to the list of patch contributors
Roan Kattouw [Sun, 20 Mar 2011 17:15:51 +0000 (17:15 +0000)]
(bug 26805) Introduce ResourceLoaderGetStartupModules hook to allow extensions to add modules to the startup set (normally this is jQuery and mediawiki). Applied patch by Michael Dale, with minor style tweaks
Roan Kattouw [Sun, 20 Mar 2011 17:10:48 +0000 (17:10 +0000)]
Followup r84399: remove another round() call
Roan Kattouw [Sun, 20 Mar 2011 17:08:38 +0000 (17:08 +0000)]
Remove stray round() call, rounding of timestamps was removed some time ago. Thanks to Michael for pointing this one out
Roan Kattouw [Sun, 20 Mar 2011 16:52:57 +0000 (16:52 +0000)]
(bug 27336) Add $wgJobTypesExcludedFromDefaultQueue for job types that aren't supposed to be run by 'normal' job runners. Modified patch by Michael Dale
Roan Kattouw [Sun, 20 Mar 2011 16:38:08 +0000 (16:38 +0000)]
(bug 27641) purgeThumbnails should support exclusion of expensive files. Add $wgExcludeFromThumbnailPurge and don't purge thumbnails whose extension is in that array when the files they belong to are purged with action=purge. Committing patch by Michael Dale with small coding style tweaks
Roan Kattouw [Sun, 20 Mar 2011 16:30:59 +0000 (16:30 +0000)]
Revert r83812 (schema change for cl_type enum), no longer needed after r84392. Also reverts r83821 (followup to r83812, add /*_*/ )
Platonides [Sun, 20 Mar 2011 16:29:31 +0000 (16:29 +0000)]
Follow up r84175
Roan Kattouw [Sun, 20 Mar 2011 16:25:01 +0000 (16:25 +0000)]
Per r83812 CR, solve the categorymembers paging problem by doing separate queries for each value of cl_type, with some trickery to make paging work. This makes the enum->varchar schema change for cl_type unnecessary, so I'll revert that.
Code was largely copied from Tim's CR comment on r83812 but adapted to deal with the fact that we have to apply the cmcontinue-induced WHERE on cl_sortkey and cl_from only for the first query. Because ApiQueryBase doesn't let us unset or overwrite conditions like these in a nice way, I added an $extraQuery parameter to ApiQueryBase::select() that excepts additional query parameters that are only applied to that query but not stored in the object.