Trevor Parscal [Wed, 29 Sep 2010 19:04:04 +0000 (19:04 +0000)]
Made ResourceLoader an instantiable object, rather than a static one, making it more modular and testable.
Chad Horohoe [Wed, 29 Sep 2010 18:48:05 +0000 (18:48 +0000)]
Move 'no license' further down the list. We want people to freely license their work! Pointed out by vimpulse on IRC
Chad Horohoe [Wed, 29 Sep 2010 18:19:03 +0000 (18:19 +0000)]
Move doApiRequest() up a level so ApiTest can use it as well. Fix first two tests to do internal FauxRequests rather than relying on an external HTTP connection
Chad Horohoe [Wed, 29 Sep 2010 18:18:07 +0000 (18:18 +0000)]
Document return values I needed
Trevor Parscal [Wed, 29 Sep 2010 18:02:56 +0000 (18:02 +0000)]
Added support for PHPUnit 3.5, where PHPUnit_Util_Timer is replaced with PHP_Timer.
Chad Horohoe [Wed, 29 Sep 2010 17:39:06 +0000 (17:39 +0000)]
Mark test incomplete if Main Page only has one author like on my install
Ryan Kaldari [Wed, 29 Sep 2010 17:25:17 +0000 (17:25 +0000)]
fixing per comments at r70517
Chad Horohoe [Wed, 29 Sep 2010 16:26:24 +0000 (16:26 +0000)]
Remove bogus addGroup() call. All users are in *
Platonides [Wed, 29 Sep 2010 16:20:41 +0000 (16:20 +0000)]
Fixed dummy test that only checks that the License object can be created.
Platonides [Wed, 29 Sep 2010 16:05:46 +0000 (16:05 +0000)]
Move some globals into the class.
Platonides [Wed, 29 Sep 2010 15:54:43 +0000 (15:54 +0000)]
Tiny changes, fix comment, remove unused globals and throw and exception instead of a fatal if given a wrong langcode.
Platonides [Wed, 29 Sep 2010 15:47:56 +0000 (15:47 +0000)]
Remove $wgServerName. Its only usage was for {{servername}}, and needed to be kept in sync with $wgServer in LocalSettings.
None of the 3 globals based on it changed if you set it in LocalSettings.
Note that all those !isset( $wgServerName ) in ApiTests were useless, since if not in LocalSettings it would be 'localhost', not null (as still are those !isset( $wgServer )).
Platonides [Wed, 29 Sep 2010 15:22:47 +0000 (15:22 +0000)]
Fight PHP Fatal error: Call to a member function attributes() on a non-object
Max Semenik [Wed, 29 Sep 2010 12:09:55 +0000 (12:09 +0000)]
Revert r73887. I blame Nikerabbit!
Max Semenik [Wed, 29 Sep 2010 09:05:47 +0000 (09:05 +0000)]
Fixed a few parser tests that were failing for me when run by PHPUnit
Raimond Spekking [Tue, 28 Sep 2010 19:02:58 +0000 (19:02 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-09-28 18:52:00 UTC)
Antoine Musso [Tue, 28 Sep 2010 18:44:25 +0000 (18:44 +0000)]
Rewrite messenging for old message deletion. The old one is boring.
Chad Horohoe [Tue, 28 Sep 2010 18:13:42 +0000 (18:13 +0000)]
Unify setUp/tearDown in ApiSetup, rather than duplicating in ApiWatchTest. Also fix some errors with not passing an array reference that were being suppressed (but silently work, yay PHP)
Chad Horohoe [Tue, 28 Sep 2010 17:10:51 +0000 (17:10 +0000)]
Followup r64181, rm comment that doesn't fit anymore
Chad Horohoe [Tue, 28 Sep 2010 17:08:57 +0000 (17:08 +0000)]
Use suite user/password rather than assuming WikiSysop
Niklas Laxström [Tue, 28 Sep 2010 15:58:53 +0000 (15:58 +0000)]
Revert r73879 for now, not ready yet.
Chad Horohoe [Tue, 28 Sep 2010 15:53:24 +0000 (15:53 +0000)]
Followup r73884, remove unused file (obsoleted in r68544)
Chad Horohoe [Tue, 28 Sep 2010 15:41:55 +0000 (15:41 +0000)]
Followup r73880, forgot to give kbd and samp their attribute whitelists
Max Semenik [Tue, 28 Sep 2010 13:46:23 +0000 (13:46 +0000)]
DatabaseSqlite: better check for error. Noticed by Nikerabbit
Chad Horohoe [Tue, 28 Sep 2010 12:24:56 +0000 (12:24 +0000)]
Move parser test related stuff to tests directory
* Moved test record stuff to testHelpers.inc, could be useful for non-parser test stuff?
* Everything else in tests/parser
* parserTestsParserTime from r12533 doesn't seem used?
Chad Horohoe [Tue, 28 Sep 2010 11:39:10 +0000 (11:39 +0000)]
Sanity check on result from SHOW PROCESSLIST, foreach -> while (sorta followup to r68878)
Chad Horohoe [Tue, 28 Sep 2010 11:12:56 +0000 (11:12 +0000)]
More bug 671: whitelist <kbd> and <samp> for user input. Followup per r70164's comment.
Niklas Laxström [Tue, 28 Sep 2010 10:04:22 +0000 (10:04 +0000)]
Replace imho ugly viewsourcefor subtitle with viewsourcetitle and viewsourceheader (for <title> and <h1> respectively).
Max Semenik [Tue, 28 Sep 2010 08:32:09 +0000 (08:32 +0000)]
Follow-up r68878: ensure that returned value is int
Niklas Laxström [Tue, 28 Sep 2010 08:16:42 +0000 (08:16 +0000)]
Don't show empty source code for non-existing pages if editing was prevented by a permission error
Chad Horohoe [Tue, 28 Sep 2010 03:18:49 +0000 (03:18 +0000)]
Fix icky info/error/warning box styling
Brion Vibber [Tue, 28 Sep 2010 02:33:43 +0000 (02:33 +0000)]
Clean tabs/spaces for r73853
Brion Vibber [Tue, 28 Sep 2010 02:24:59 +0000 (02:24 +0000)]
Fix tab/space, use null as default value rather than string to match expected return (cleanup from r73859)
Brion Vibber [Tue, 28 Sep 2010 02:18:35 +0000 (02:18 +0000)]
Tweak tab vs spaces from r73860
Sam Reed [Tue, 28 Sep 2010 01:33:11 +0000 (01:33 +0000)]
Tweak/add some documentation as hints for some code analysis
Sam Reed [Tue, 28 Sep 2010 01:21:38 +0000 (01:21 +0000)]
Define variable before usage in hook call
Sam Reed [Tue, 28 Sep 2010 01:21:15 +0000 (01:21 +0000)]
Swap a couple of while loops for foreach
Sam Reed [Tue, 28 Sep 2010 00:56:04 +0000 (00:56 +0000)]
Minor followup to r66061, make the examples more explicit/verbose (different types of query module)
Trevor Parscal [Mon, 27 Sep 2010 23:50:20 +0000 (23:50 +0000)]
Improves on fix in r73808 which was aimed at correcting a mistake made when making IEFixes.js ResourceLoader compatible. This uses the undefined keyword as an initial value, to emulate the value that would be assigned when using "var myVariable;".
Antoine Musso [Mon, 27 Sep 2010 20:19:22 +0000 (20:19 +0000)]
Adds a make target to build phpunit code coverage which will be generated to
/docs/code-coverage . You will need the Xdebug PHP extension to run code
coverage.
Raimond Spekking [Mon, 27 Sep 2010 19:39:45 +0000 (19:39 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-09-27 19:19:00 UTC)
Antoine Musso [Mon, 27 Sep 2010 18:46:16 +0000 (18:46 +0000)]
update my personal email address (following r73779)
Trevor Parscal [Mon, 27 Sep 2010 18:43:21 +0000 (18:43 +0000)]
Fixed typo in a comment
Trevor Parscal [Mon, 27 Sep 2010 15:59:58 +0000 (15:59 +0000)]
* Improved on r73567, this makes WebRequest::getFuzzyBool case insensitive, making 'false', 'FALSE', 'FaLsE', etc to be boolean false
* Fixed syntax error in Skin.php
Roan Kattouw [Mon, 27 Sep 2010 15:51:47 +0000 (15:51 +0000)]
Revert r72816 and do it properly: the SELECT should be executed on the master
Chad Horohoe [Mon, 27 Sep 2010 14:24:13 +0000 (14:24 +0000)]
Fix a bunch of '? true : false' instances
Roan Kattouw [Mon, 27 Sep 2010 13:06:58 +0000 (13:06 +0000)]
Fix an instance of window.someVar; that slipped through the cracks
Roan Kattouw [Mon, 27 Sep 2010 13:06:35 +0000 (13:06 +0000)]
Fix indentation
Roan Kattouw [Mon, 27 Sep 2010 12:30:04 +0000 (12:30 +0000)]
Fix indentation
Raimond Spekking [Sun, 26 Sep 2010 19:56:28 +0000 (19:56 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-09-26 19:39:00 UTC)
Alexandre Emsenhuber [Sun, 26 Sep 2010 16:37:00 +0000 (16:37 +0000)]
* (bug 25292) SkinSubPageSubtitle hook now passes the Skin object as second parameter
Antoine Musso [Sun, 26 Sep 2010 15:52:51 +0000 (15:52 +0000)]
update my personal email address altern.org -> free.fr
Raimond Spekking [Sat, 25 Sep 2010 19:37:18 +0000 (19:37 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-09-25 19:25:00 UTC)
Max Semenik [Sat, 25 Sep 2010 17:45:00 +0000 (17:45 +0000)]
A few index-related fixes in SQLite DB patches, ping r66920.
The need to drop index patch-rename-iwl_prefix.sql arose from development versions that had discrepancies between tables.sql and updater. Let's just DROP IF EXISTS it.
Sam Reed [Sat, 25 Sep 2010 17:17:27 +0000 (17:17 +0000)]
Add missing @'s to r73753, document return type
Sam Reed [Sat, 25 Sep 2010 17:08:23 +0000 (17:08 +0000)]
$name used in continue is undefined, use $message
Though, this module seems to have no limits, so not sure why we have a continue/"from"
Sam Reed [Sat, 25 Sep 2010 17:01:17 +0000 (17:01 +0000)]
extract is weird
Do what extract is doing explicitally
Platonides [Sat, 25 Sep 2010 16:58:32 +0000 (16:58 +0000)]
Revert r73587 and fix r62087 regression by providing the default value in $comment definition.
This not only fixes the issue of line 189, but also the one at line 156.
Sam Reed [Sat, 25 Sep 2010 16:56:03 +0000 (16:56 +0000)]
Remove some unused keys from foreach
Documentation tweaks
Sam Reed [Sat, 25 Sep 2010 16:45:41 +0000 (16:45 +0000)]
Fill in missing params from a dieUsage
Braces
Fixup parameter documentation
Sam Reed [Sat, 25 Sep 2010 16:38:44 +0000 (16:38 +0000)]
What's a boolif?
Sam Reed [Sat, 25 Sep 2010 16:37:39 +0000 (16:37 +0000)]
Remove some unused variables
Tweak php doc, "One" is not a type, so insert string in there
Antoine Musso [Sat, 25 Sep 2010 16:09:16 +0000 (16:09 +0000)]
adds testing for IP and Xml classes
Antoine Musso [Sat, 25 Sep 2010 16:08:24 +0000 (16:08 +0000)]
comment typo
Trevor Parscal [Fri, 24 Sep 2010 22:10:25 +0000 (22:10 +0000)]
* Fixed bug #25281 by adding special treatment for modules in the "private" group
* Added $wgResourceLoaderInlinePrivateModules to allow private modules to be either embedded in the HTML output or accessed through ResourceLoader (which will bypass squid cache and check the user paramter against $wgUser)
* Moved more generated javascript functionality to ResourceLoader
* Fixed comment typo made in r73673
* Added documentation for ResoruceLoaderRegisterModules hook
Trevor Parscal [Fri, 24 Sep 2010 21:03:29 +0000 (21:03 +0000)]
Moved more generated javascript to ResourceLoader functions. Cleaned some things up in the startup module.
Roan Kattouw [Fri, 24 Sep 2010 20:01:52 +0000 (20:01 +0000)]
Support ESI in the resource loader. Only used for the startup module for now, we'll have to think our ESI strategy through before expanding on that
Raimond Spekking [Fri, 24 Sep 2010 19:22:35 +0000 (19:22 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-09-24 19:02:00 UTC)
Trevor Parscal [Fri, 24 Sep 2010 18:49:19 +0000 (18:49 +0000)]
* Moved registration generation to startup module.
* Moved some javascript code generation to reusable functions (more to do).
* Reduced the code output by using mutliple calling method for mediaWiki.loader.state.
* Moved CSS minification to the end (should be a bit faster than running it for each module).
Roan Kattouw [Fri, 24 Sep 2010 18:16:59 +0000 (18:16 +0000)]
Fix r73645: also do negative caching
Trevor Parscal [Fri, 24 Sep 2010 17:31:40 +0000 (17:31 +0000)]
Added early exits when files are used before webstart
Trevor Parscal [Fri, 24 Sep 2010 17:19:27 +0000 (17:19 +0000)]
Fixed issue in r73645 where an unset value was being returned in some cases.
Matthew Britton [Fri, 24 Sep 2010 14:40:18 +0000 (14:40 +0000)]
reimplement r73652 having actually read coding conventions this time
Matthew Britton [Fri, 24 Sep 2010 13:00:46 +0000 (13:00 +0000)]
API: sinumberingroup now gives correct size of 'user' group, and omits size of implicit groups rather than showing 0.
Trevor Parscal [Thu, 23 Sep 2010 21:23:51 +0000 (21:23 +0000)]
Improved the performance of ResourceLoader by pre-loading module information in a batch query. This was mostly code written by catrope and patched in / gotten working by me.
Raimond Spekking [Thu, 23 Sep 2010 19:45:46 +0000 (19:45 +0000)]
Follow-up r73632: Fix typo
Alexandre Emsenhuber [Thu, 23 Sep 2010 19:41:29 +0000 (19:41 +0000)]
Fixed some doxygen warnings
Max Semenik [Thu, 23 Sep 2010 19:39:32 +0000 (19:39 +0000)]
Fixed a glitch from r73632
Max Semenik [Thu, 23 Sep 2010 19:36:06 +0000 (19:36 +0000)]
Special:Version now displays whether a SQLite database supports full-text search
Raimond Spekking [Thu, 23 Sep 2010 19:30:38 +0000 (19:30 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-09-23 19:15:00 UTC)
Niklas Laxström [Thu, 23 Sep 2010 19:15:58 +0000 (19:15 +0000)]
(bug 25273) Message::params() triggers a fatal error.
Patch by hashar.
Trevor Parscal [Thu, 23 Sep 2010 18:08:20 +0000 (18:08 +0000)]
Fixed typo pointed out by Icefox - thanks! See comments for r73499.
Matthew Britton [Thu, 23 Sep 2010 10:46:08 +0000 (10:46 +0000)]
follow up r72387: using ApiQuery here breaks ApiParamInfo (bug 25248)
Andrew Garrett [Thu, 23 Sep 2010 06:18:46 +0000 (06:18 +0000)]
Replace $ with $j in ajaxwatch.js, was causing fatal JS errors on pages for me. (resourceloader-related issue?)
OverlordQ [Thu, 23 Sep 2010 02:59:07 +0000 (02:59 +0000)]
Fix regression caused by r62087 which failed to insert rows into the image table due to null comment.
Also correct indefinite/infinite/infinity protection.
Trevor Parscal [Wed, 22 Sep 2010 21:49:31 +0000 (21:49 +0000)]
* Optimized watch star sprite (only linking to the the image once rather than 4 times, makes data-URLs more efficient)
* Removed version numbers from links
Priyanka Dhanda [Wed, 22 Sep 2010 21:23:21 +0000 (21:23 +0000)]
Followup to r73500. SeleniumTestConfig renamed to SeleniumConfig. Make sure SELENIUMTEST is defined to use it.
Fixed some indents and pass by reference warnings
Raimond Spekking [Wed, 22 Sep 2010 21:05:23 +0000 (21:05 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-09-22 20:51:00 UTC)
Trevor Parscal [Wed, 22 Sep 2010 20:44:12 +0000 (20:44 +0000)]
* Added $wgResourceLoaderDebug, a default fallback for debug mode which can be overridden by the debug URL parameter a la $wgLanguageCode
* Merged $wgResourceLoader(Unv|V)ersioned(Client|Server)Maxage vars into $wgResourceLoaderMaxage, which contains an array of the same values.
Trevor Parscal [Wed, 22 Sep 2010 20:15:31 +0000 (20:15 +0000)]
* Added WebRequest::getFuzzyBool, which is a more JavaScript friendly version of getBool. Essentailly the same thing, except the string 'false' is also considered boolean false.
* Made use of getFuzzyBool where otherwise awkward and sometimes varied versions of 'flase' === false detection were being used.
Trevor Parscal [Wed, 22 Sep 2010 20:11:30 +0000 (20:11 +0000)]
Actually improves on fix for bug #25246 by reducing the power of the foreground color rule - it was overriding the placeholder class. This corrects a mistake made in r73562.
Chad Horohoe [Wed, 22 Sep 2010 19:19:47 +0000 (19:19 +0000)]
Skip new object construction if it's going to be the same
Trevor Parscal [Wed, 22 Sep 2010 19:15:53 +0000 (19:15 +0000)]
Improves on fix for bug #25246 by reducing the power of the foreground color rule - it was overriding the placeholder class.
Chad Horohoe [Wed, 22 Sep 2010 19:09:14 +0000 (19:09 +0000)]
Fix dupe title construction, reported by ymas on IRC
Trevor Parscal [Wed, 22 Sep 2010 18:36:57 +0000 (18:36 +0000)]
Resolves bug #25246 by adding an explicit foreground color to the search box.
Trevor Parscal [Wed, 22 Sep 2010 18:30:32 +0000 (18:30 +0000)]
Removed extra "Msg" string being appended to message names, which was a remanant of the old code. This fixes bug #25251
Trevor Parscal [Wed, 22 Sep 2010 18:03:29 +0000 (18:03 +0000)]
Fixed check for mediaWiki existance and removed additional unneeded wrapping in mediaWiki.loader.using calls as per comments on r73499.
Platonides [Wed, 22 Sep 2010 16:50:09 +0000 (16:50 +0000)]
Fix bug from r68337. The variable is called $res, not $result
Platonides [Wed, 22 Sep 2010 16:06:27 +0000 (16:06 +0000)]
No need of $wgMemc after r73386.
Change the comment added in r73260 so that it doesn't look that relying on how previous tests set the globals is ever acceptable.
Chad Horohoe [Wed, 22 Sep 2010 13:54:53 +0000 (13:54 +0000)]
Followup r71961, more php4 constructors