From: Aaron Schulz <aschulz@wikimedia.org>
Date: Mon, 21 Sep 2015 23:22:37 +0000 (-0700)
Subject: Removed DeferredUpdates::addHTMLCacheUpdate()
X-Git-Tag: 1.31.0-rc.0~9927^2
X-Git-Url: http://git.cyclocoop.org/%7B%24www_url%7Dadmin/membres/fiche.php?a=commitdiff_plain;h=d3f5c943eaa9681f4dcb2a1eb3a1fd2b4894fcd6;p=lhc%2Fweb%2Fwiklou.git

Removed DeferredUpdates::addHTMLCacheUpdate()

* That method does not belong in DeferredUpdates
  as this class should agnostic to the work done

Change-Id: I8098ffb82bf9c33ccb48a31aa9dbad514e8724a8
---

diff --git a/RELEASE-NOTES-1.26 b/RELEASE-NOTES-1.26
index bf07b2056d..19309a80d6 100644
--- a/RELEASE-NOTES-1.26
+++ b/RELEASE-NOTES-1.26
@@ -189,6 +189,7 @@ changes to languages because of Phabricator reports.
   extension instead. New tokens types should not be added.
 * DatabaseBase::errorCount() was removed (unused).
 * $wgDeferredUpdateList was removed.
+* DeferredUpdates::addHTMLCacheUpdate() was removed.
 
 == Compatibility ==
 
diff --git a/includes/deferred/DeferredUpdates.php b/includes/deferred/DeferredUpdates.php
index 713ce70b3f..cd0266f6b8 100644
--- a/includes/deferred/DeferredUpdates.php
+++ b/includes/deferred/DeferredUpdates.php
@@ -78,17 +78,6 @@ class DeferredUpdates {
 		}
 	}
 
-	/**
-	 * HTMLCacheUpdates are the most common deferred update people use. This
-	 * is a shortcut method for that.
-	 * @see HTMLCacheUpdate::__construct()
-	 * @param Title $title
-	 * @param string $table
-	 */
-	public static function addHTMLCacheUpdate( $title, $table ) {
-		self::addUpdate( new HTMLCacheUpdate( $title, $table ) );
-	}
-
 	/**
 	 * Add a callable update.  In a lot of cases, we just need a callback/closure,
 	 * defining a new DeferrableUpdate object is not necessary
diff --git a/includes/page/WikiPage.php b/includes/page/WikiPage.php
index 30590cfada..ddda1305d5 100644
--- a/includes/page/WikiPage.php
+++ b/includes/page/WikiPage.php
@@ -3219,10 +3219,10 @@ class WikiPage implements Page, IDBAccessObject {
 	 */
 	public static function onArticleEdit( Title $title, Revision $revision = null ) {
 		// Invalidate caches of articles which include this page
-		DeferredUpdates::addHTMLCacheUpdate( $title, 'templatelinks' );
+		DeferredUpdates::addUpdate( new HTMLCacheUpdate( $title, 'templatelinks' ) );
 
 		// Invalidate the caches of all pages which redirect here
-		DeferredUpdates::addHTMLCacheUpdate( $title, 'redirect' );
+		DeferredUpdates::addUpdate( new HTMLCacheUpdate( $title, 'redirect' ) );
 
 		// Purge squid for this page only
 		$title->purgeSquid();