From: Timo Tijhof <krinklemail@gmail.com>
Date: Thu, 21 Sep 2017 23:10:45 +0000 (+0100)
Subject: mw.loader: Simplify getVersion and getState
X-Git-Tag: 1.31.0-rc.0~1997^2
X-Git-Url: http://git.cyclocoop.org/%7B%24www_url%7Dadmin/membres/fiche.php?a=commitdiff_plain;h=6c2621fefc744f36c84275a46f55c3ed70bb9baf;p=lhc%2Fweb%2Fwiklou.git

mw.loader: Simplify getVersion and getState

This undefined check no longer makes sense since there are now
defaults for these in register(). There is no supported scenario
in which a module would have a key in the registry but not
have these properties defined, or have them defined with
the undefined value.

Change-Id: I945871861ccf3659c2d7dd021aa87dfd747f22b9
---

diff --git a/resources/src/mediawiki/mediawiki.js b/resources/src/mediawiki/mediawiki.js
index b5224867d2..7e02df4f8d 100644
--- a/resources/src/mediawiki/mediawiki.js
+++ b/resources/src/mediawiki/mediawiki.js
@@ -2123,10 +2123,7 @@
 				 *  in the registry.
 				 */
 				getVersion: function ( module ) {
-					if ( !hasOwn.call( registry, module ) || registry[ module ].version === undefined ) {
-						return null;
-					}
-					return registry[ module ].version;
+					return hasOwn.call( registry, module ) ? registry[ module ].version : null;
 				},
 
 				/**
@@ -2137,10 +2134,7 @@
 				 *  in the registry.
 				 */
 				getState: function ( module ) {
-					if ( !hasOwn.call( registry, module ) || registry[ module ].state === undefined ) {
-						return null;
-					}
-					return registry[ module ].state;
+					return hasOwn.call( registry, module ) ? registry[ module ].state : null;
 				},
 
 				/**