From: Reedy <reedy@wikimedia.org>
Date: Sat, 4 Aug 2012 13:35:23 +0000 (+0100)
Subject: * Bug 39032 - ApiQuery generates help in constructor.
X-Git-Tag: 1.31.0-rc.0~22850^2
X-Git-Url: http://git.cyclocoop.org/%7B%24www_url%7Dadmin/membres/fiche.php?a=commitdiff_plain;h=52861ea3a106d30b10495f385ec9183214cd7778;p=lhc%2Fweb%2Fwiklou.git

* Bug 39032 - ApiQuery generates help in constructor.

Functions called unnecesserily, as their return values aren't used
or even cached.

Removing them to reduce the pointless overhead of calling them

Change-Id: I0d8ddab9492ea79d5de4118944e77ac774275506
---

diff --git a/RELEASE-NOTES-1.20 b/RELEASE-NOTES-1.20
index 3a14f55c54..75146be54c 100644
--- a/RELEASE-NOTES-1.20
+++ b/RELEASE-NOTES-1.20
@@ -223,6 +223,7 @@ upgrade PHP if you have not done so prior to upgrading MediaWiki.
 * (bug 38231) Add xml parse tree to action=parse.
 * Watchlist notification timestamp may be queried by page and may be updated via the API.
 * (bug 38904) prop=revisions&rvstart=... no longer blows up when continuing.
+* (bug 39032) ApiQuery generates help in constructor.
 
 === Languages updated in 1.20 ===
 
diff --git a/includes/api/ApiQuery.php b/includes/api/ApiQuery.php
index d7c341d528..e22ef27d84 100644
--- a/includes/api/ApiQuery.php
+++ b/includes/api/ApiQuery.php
@@ -119,9 +119,6 @@ class ApiQuery extends ApiBase {
 		$this->mPropModuleNames = array_keys( $this->mQueryPropModules );
 		$this->mListModuleNames = array_keys( $this->mQueryListModules );
 		$this->mMetaModuleNames = array_keys( $this->mQueryMetaModules );
-
-		$this->makeHelpMsgHelper( $this->mQueryPropModules, 'prop' );
-		$this->makeHelpMsgHelper( $this->mQueryListModules, 'list' );
 	}
 
 	/**