From: Brian Wolff <bawolff+wn@gmail.com>
Date: Sun, 17 Feb 2019 11:14:18 +0000 (+0000)
Subject: Do not use raw html for Special:ProtectedPages drop-down messages
X-Git-Tag: 1.34.0-rc.0~2800^2
X-Git-Url: http://git.cyclocoop.org/%7B%24www_url%7Dadmin/membres/fiche.php?a=commitdiff_plain;h=1d680bbe923d2942dd7d08ed58d2a93f3ada0957;p=lhc%2Fweb%2Fwiklou.git

Do not use raw html for Special:ProtectedPages drop-down messages

The following messages are affected: protectedpages-indef,
protectedpages-cascade, protectedpages-noredirect.

This appear to be accidental. AFAIK nobody is using these messages
in a raw html fashion.

This change is to make phan-taint-check happier.

Bug: T216348
Change-Id: I0e038c2e01e2252be288b86950208510741efc67
---

diff --git a/includes/specials/SpecialProtectedpages.php b/includes/specials/SpecialProtectedpages.php
index 4b1b344cbf..d99de1e2fa 100644
--- a/includes/specials/SpecialProtectedpages.php
+++ b/includes/specials/SpecialProtectedpages.php
@@ -110,10 +110,10 @@ class SpecialProtectedpages extends SpecialPage {
 				'class' => 'HTMLMultiSelectField',
 				'label' => $this->msg( 'protectedpages-filters' )->text(),
 				'flatlist' => true,
-				'options' => [
-					$this->msg( 'protectedpages-indef' )->text() => 'indefonly',
-					$this->msg( 'protectedpages-cascade' )->text() => 'cascadeonly',
-					$this->msg( 'protectedpages-noredirect' )->text() => 'noredirect',
+				'options-messages' => [
+					'protectedpages-indef' => 'indefonly',
+					'protectedpages-cascade' => 'cascadeonly',
+					'protectedpages-noredirect' => 'noredirect',
 				],
 				'default' => $filters,
 			],