From: Antoine Musso <hashar@free.fr>
Date: Fri, 24 Mar 2017 14:19:36 +0000 (+0100)
Subject: Check for string initialization in lcfirst() for HHVM 3.18
X-Git-Tag: 1.31.0-rc.0~3704^2
X-Git-Url: http://git.cyclocoop.org/%7B%24www_url%7Dadmin/membres/fiche.php?a=commitdiff_plain;h=1819a85bed4738ddd8e716b03acb3b2dff12e570;p=lhc%2Fweb%2Fwiklou.git

Check for string initialization in lcfirst() for HHVM 3.18

HHVM 3.18 emits a notice when attempting to access the first offset of
an empty string.  We had that fixed for ucfirst() in 3605066c96. This is
the same for lcfirst().

Bug: T161095
Change-Id: I1456611222c24290f259298e883ca89dd830c74b
---

diff --git a/languages/classes/LanguageKk.php b/languages/classes/LanguageKk.php
index 0460a6c6bb..3a50987733 100644
--- a/languages/classes/LanguageKk.php
+++ b/languages/classes/LanguageKk.php
@@ -408,7 +408,7 @@ class LanguageKk extends LanguageKk_cyrl {
 	 * @return string
 	 */
 	function lcfirst( $string ) {
-		if ( $string[0] == 'I' ) {
+		if ( substr( $string, 0, 1 ) === 'I' ) {
 			$variant = $this->getPreferredVariant();
 			if ( $variant == 'kk-latn' || $variant == 'kk-tr' ) {
 				return 'ı' . substr( $string, 1 );