From: James D. Forrester <jforrester@wikimedia.org>
Date: Sat, 9 Feb 2019 01:37:23 +0000 (-0800)
Subject: Drop MWExceptionHandler::getLogId(), deprecated in 1.27 and unused
X-Git-Tag: 1.34.0-rc.0~2882
X-Git-Url: http://git.cyclocoop.org/%7B%24www_url%7Dadmin/membres/fiche.php?a=commitdiff_plain;h=0a3217462c38624d76bd90e3566ce5c399644767;p=lhc%2Fweb%2Fwiklou.git

Drop MWExceptionHandler::getLogId(), deprecated in 1.27 and unused

Change-Id: Id03aaf4f2ea5c910e13274826e44033e12adcd2e
---

diff --git a/RELEASE-NOTES-1.33 b/RELEASE-NOTES-1.33
index 12f915b4c2..1f84421b69 100644
--- a/RELEASE-NOTES-1.33
+++ b/RELEASE-NOTES-1.33
@@ -219,6 +219,8 @@ because of Phabricator reports.
   be unused, and is distinct from OutputPage->addLink(), which remains.
 * JsonContent->getJsonData(), deprecated in 1.25, has been removed. Instead, use
   JsonContent->getData().
+* MWExceptionHandler::getLogId(), deprecated in 1.27, has been removed, as the
+  exception ID is the same as the request ID, from WebRequest::getRequestId()..
 
 === Deprecations in 1.33 ===
 * The configuration option $wgUseESI has been deprecated, and is expected
diff --git a/includes/exception/MWExceptionHandler.php b/includes/exception/MWExceptionHandler.php
index 951498e537..6e3fa794ce 100644
--- a/includes/exception/MWExceptionHandler.php
+++ b/includes/exception/MWExceptionHandler.php
@@ -462,22 +462,6 @@ TXT;
 		}, $trace );
 	}
 
-	/**
-	 * Get the ID for this exception.
-	 *
-	 * The ID is saved so that one can match the one output to the user (when
-	 * $wgShowExceptionDetails is set to false), to the entry in the debug log.
-	 *
-	 * @since 1.22
-	 * @deprecated since 1.27: Exception IDs are synonymous with request IDs.
-	 * @param Exception|Throwable $e
-	 * @return string
-	 */
-	public static function getLogId( $e ) {
-		wfDeprecated( __METHOD__, '1.27' );
-		return WebRequest::getRequestId();
-	}
-
 	/**
 	 * If the exception occurred in the course of responding to a request,
 	 * returns the requested URL. Otherwise, returns false.