From: Bartosz Dziewoński <matma.rex@gmail.com>
Date: Thu, 27 Apr 2017 18:19:32 +0000 (+0200)
Subject: SpecialJavaScriptTest: Do not accidentally pass parameters to QUnit.start()
X-Git-Tag: 1.31.0-rc.0~3396^2~1
X-Git-Url: http://git.cyclocoop.org/%7B%24www_url%7Dadmin/membres/fiche.php?a=commitdiff_plain;h=01d04fa014d73f5468ba80ef908b0331deaba662;p=lhc%2Fweb%2Fwiklou.git

SpecialJavaScriptTest: Do not accidentally pass parameters to QUnit.start()

If the mw.loader.using() call's promise is rejected, we end up
passing an Error object as the 'count' parameter to QUnit.start().
This seems to be harmless, but is very confusing when debugging.

Change-Id: I44caca5285dbced5a5876d9d7ff6236dbd3efc35
---

diff --git a/includes/specials/SpecialJavaScriptTest.php b/includes/specials/SpecialJavaScriptTest.php
index 6fbac8a448..52064b79f5 100644
--- a/includes/specials/SpecialJavaScriptTest.php
+++ b/includes/specials/SpecialJavaScriptTest.php
@@ -140,7 +140,9 @@ class SpecialJavaScriptTest extends SpecialPage {
 	var start = window.__karma__ ? window.__karma__.start : QUnit.start;
 	try {
 		mw.loader.using( $modules )
-			.always( start )
+			.always( function () {
+				start();
+			} )
 			.fail( function ( e ) { throw e; } );
 	} catch ( e ) {
 		start();