Merge "mediawiki.searchSuggest: Show full article title as a tooltip for each suggestion"

diff --combined resources/src/mediawiki/mediawiki.searchSuggest.js
index c2c70b0,639d51d..282cf6f
--- 1/resources/src/mediawiki/mediawiki.searchSuggest.js
--- 2/resources/src/mediawiki/mediawiki.searchSuggest.js
+++ b/resources/src/mediawiki/mediawiki.searchSuggest.js
@@@ -3,7 -3,7 +3,7 @@@
   */
  ( function ( mw, $ ) {
        $( function () {
 -              var map, resultRenderCache, searchboxesSelectors,
 +              var api, map, resultRenderCache, searchboxesSelectors,
                        // Region where the suggestions box will appear directly below
                        // (using the same width). Can be a container element or the input
                        // itself, depending on what suits best in the environment.
@@@ -66,6 -66,7 +66,7 @@@
                                .wrap(
                                        $( '<a>' )
                                                .attr( 'href', resultRenderCache.baseHref + $.param( resultRenderCache.linkParams ) )
+                                               .attr( 'title', text )
                                                .addClass( 'mw-searchSuggest-link' )
                                );
                }
@@@ -107,7 -108,7 +108,7 @@@
                        }
                }
  
 -              // General suggestions functionality for all search boxes
 +              // Generic suggestions functionality for all search boxes
                searchboxesSelectors = [
                        // Primary searchbox on every page in standard skins
                        '#searchInput',
@@@ -115,40 -116,38 +116,40 @@@
                        '#powerSearchText',
                        '#searchText',
                        // Generic selector for skins with multiple searchboxes (used by CologneBlue)
 +                      // and for MediaWiki itself (special pages with page title inputs)
                        '.mw-searchInput'
                ];
                $( searchboxesSelectors.join( ', ' ) )
                        .suggestions( {
                                fetch: function ( query ) {
 -                                      var $el;
 -
 -                                      if ( query.length !== 0 ) {
 -                                              $el = $( this );
 -                                              $el.data( 'request', ( new mw.Api() ).get( {
 -                                                      action: 'opensearch',
 -                                                      search: query,
 -                                                      namespace: 0,
 -                                                      suggest: ''
 -                                              } ).done( function ( data ) {
 -                                                      $el.suggestions( 'suggestions', data[1] );
 -                                              } ) );
 -                                      }
 +                                      var $textbox = this,
 +                                              node = this[0];
 +
 +                                      api = api || new mw.Api();
 +
 +                                      $.data( node, 'request', api.get( {
 +                                              action: 'opensearch',
 +                                              search: query,
 +                                              namespace: 0,
 +                                              suggest: ''
 +                                      } ).done( function ( data ) {
 +                                              $textbox.suggestions( 'suggestions', data[1] );
 +                                      } ) );
                                },
                                cancel: function () {
 -                                      var apiPromise = $( this ).data( 'request' );
 -                                      // If the delay setting has caused the fetch to have not even happened
 -                                      // yet, the apiPromise object will have never been set.
 -                                      if ( apiPromise && $.isFunction( apiPromise.abort ) ) {
 -                                              apiPromise.abort();
 -                                              $( this ).removeData( 'request' );
 +                                      var node = this[0],
 +                                              request = $.data( node, 'request' );
 +
 +                                      if ( request ) {
 +                                              request.abort();
 +                                              $.removeData( node, 'request' );
                                        }
                                },
                                result: {
                                        render: renderFunction,
                                        select: function () {
 -                                              return true; // allow the form to be submitted
 +                                              // allow the form to be submitted
 +                                              return true;
                                        }
                                },
                                delay: 120,
@@@ -158,16 -157,6 +159,16 @@@
                                // make sure paste and cut events from the mouse and drag&drop events
                                // trigger the keypress handler and cause the suggestions to update
                                $( this ).trigger( 'keypress' );
 +                      } )
 +                      // In most skins (at least Monobook and Vector), the font-size is messed up in <body>.
 +                      // (they use 2 elements to get a sane font-height). So, instead of making exceptions for
 +                      // each skin or adding more stylesheets, just copy it from the active element so auto-fit.
 +                      .each( function () {
 +                              var $this = $( this );
 +                              $this
 +                                      .data( 'suggestions-context' )
 +                                      .data.$container
 +                                              .css( 'fontSize', $this.css( 'fontSize' ) );
                        } );
  
                // Ensure that the thing is actually present!
@@@ -180,6 -169,12 +181,6 @@@
  
                // Special suggestions functionality for skin-provided search box
                $searchInput.suggestions( {
 -                      result: {
 -                              render: renderFunction,
 -                              select: function () {
 -                                      return true; // allow the form to be submitted
 -                              }
 -                      },
                        special: {
                                render: specialRenderFunction,
                                select: function ( $input ) {
@@@ -193,6 -188,15 +194,6 @@@
  
                // If the form includes any fallback fulltext search buttons, remove them
                $searchInput.closest( 'form' ).find( '.mw-fallbackSearchButton' ).remove();
 -
 -              // In most skins (at least Monobook and Vector), the font-size is messed up in <body>.
 -              // (they use 2 elements to get a sane font-height). So, instead of making exceptions for
 -              // each skin or adding more stylesheets, just copy it from the active element so auto-fit.
 -              $searchInput
 -                      .data( 'suggestions-context' )
 -                      .data.$container
 -                              .css( 'fontSize', $searchInput.css( 'fontSize' ) );
 -
        } );
  
  }( mediaWiki, jQuery ) );