resourceloader: Fix fatal when using $wgResourceModuleSkinStyles with "+"
authorBartosz Dziewoński <matma.rex@gmail.com>
Thu, 7 May 2015 13:51:09 +0000 (15:51 +0200)
committerKrinkle <krinklemail@gmail.com>
Thu, 7 May 2015 14:21:52 +0000 (14:21 +0000)
Fatal error: [] operator not supported for strings in
includes/resourceloader/ResourceLoader.php on line 354

This would occur when a skin customized ResourceModuleSkinStyles using
the '+' syntax, which preserves default skinStyles, and the default
skinStyles was defined as a string rather than array.

Change-Id: I6cd12a638d562c75bc4704e098de84f3882248b6

includes/resourceloader/ResourceLoader.php

index 7da3aec..ce18c32 100644 (file)
@@ -339,7 +339,7 @@ class ResourceLoader {
                                        } elseif ( isset( $skinStyles['+' . $name] ) ) {
                                                $paths = (array)$skinStyles['+' . $name];
                                                $styleFiles = isset( $this->moduleInfos[$name]['skinStyles']['default'] ) ?
-                                                       $this->moduleInfos[$name]['skinStyles']['default'] :
+                                                       (array)$this->moduleInfos[$name]['skinStyles']['default'] :
                                                        array();
                                        } else {
                                                continue;