* (bug 1477) hide details of SQL error messages by default

  Set $wgShowSQLErrors = true for debugging.

  Removed unused settings $wgBufferSQLResults and $wgShowSQLErrors.

diff --git a/includes/DefaultSettings.php b/includes/DefaultSettings.php
index bb6bba8..26a282c 100644 (file)
--- a/includes/DefaultSettings.php
+++ b/includes/DefaultSettings.php
@@ -286,9 +286,6 @@ $wgDBtransactions   = false;
 $wgDBmysql4                    = false;
 $wgSqlTimeout          = 30;
 
-/** use buffered queries by default */
-$wgBufferSQLResults     = true;
-
 /**
  * Other wikis on this site, can be administered from a single developer
  * account.
@@ -414,9 +411,12 @@ $wgReadOnly             = false;
 $wgLogQueries           = false;
 $wgDebugDumpSql         = false;
 
-/** Whether to disable automatic generation of "we're sorry, but there has been
- * a database error" pages. */
-$wgIgnoreSQLErrors      = false;
+/**
+ * Whether to show "we're sorry, but there has been a database error" pages.
+ * Displaying errors aids in debugging, but may display information useful
+ * to an attacker.
+ */
+$wgShowSQLErrors        = false;
 
 # Should [[Category:Dog]] on a page associate it with the
 # category "Dog"? (a link to that category page will be

diff --git a/includes/SpecialSitesettings.php b/includes/SpecialSitesettings.php
index 51eeaee..7438e14 100644 (file)
--- a/includes/SpecialSitesettings.php
+++ b/includes/SpecialSitesettings.php
@@ -170,7 +170,6 @@ class SiteSettingsForm extends HTMLForm {
                        $this->checkbox( 'wgDebugComments' ) .
                        $this->checkbox( 'wgLogQueries' ) .
                        $this->checkbox( 'wgDebugDumpSql' ) .
-                       $this->checkbox( 'wgIgnoreSQLErrors' ) .
                        $this->fieldset( 'sitesettings-debugging-profiling',
                                $this->checkbox( 'wgProfiling' ) .
                                $this->textbox( 'wgProfileLimit' ) .