private $genericReadIndex = -1;
/** @var int[] The group replica DB indexes keyed by group */
private $readIndexByGroup = [];
- /** @var bool|DBMasterPos False if not set */
+ /** @var bool|DBMasterPos Replication sync position or false if not set */
private $waitForPos;
/** @var bool Whether the generic reader fell back to a lagged replica DB */
private $laggedReplicaMode = false;
}
/**
+ * @param int $flags
+ * @return bool
+ */
+ private function sanitizeConnectionFlags( $flags ) {
+ if ( ( $flags & self::CONN_TRX_AUTOCOMMIT ) === self::CONN_TRX_AUTOCOMMIT ) {
+ // Assuming all servers are of the same type (or similar), which is overwhelmingly
+ // the case, use the master server information to get the attributes. The information
+ // for $i cannot be used since it might be DB_REPLICA, which might require connection
+ // attempts in order to be resolved into a real server index.
+ $attributes = $this->getServerAttributes( $this->getWriterIndex() );
+ if ( $attributes[Database::ATTR_DB_LEVEL_LOCKING] ) {
+ // Callers sometimes want to (a) escape REPEATABLE-READ stateness without locking
+ // rows (e.g. FOR UPDATE) or (b) make small commits during a larger transactions
+ // to reduce lock contention. None of these apply for sqlite and using separate
+ // connections just causes self-deadlocks.
+ $flags &= ~self::CONN_TRX_AUTOCOMMIT;
+ $this->connLogger->info( __METHOD__ .
+ ': ignoring CONN_TRX_AUTOCOMMIT to avoid deadlocks.' );
+ }
+ }
+
+ return $flags;
+ }
+
+ /**
+ * @param IDatabase $conn
+ * @param int $flags
+ * @throws DBUnexpectedError
+ */
+ private function enforceConnectionFlags( IDatabase $conn, $flags ) {
+ if ( ( $flags & self::CONN_TRX_AUTOCOMMIT ) == self::CONN_TRX_AUTOCOMMIT ) {
+ if ( $conn->trxLevel() ) { // sanity
+ throw new DBUnexpectedError(
+ $conn,
+ 'Handle requested with CONN_TRX_AUTOCOMMIT yet it has a transaction'
+ );
+ }
+
+ $conn->clearFlag( $conn::DBO_TRX ); // auto-commit mode
+ }
+ }
+
+ /**
* Get a LoadMonitor instance
*
* @return ILoadMonitor
* @param int $i
* @param array $groups
* @param string|bool $domain
- * @return int
+ * @return int The index of a specific server (replica DBs are checked for connectivity)
*/
private function getConnectionIndex( $i, $groups, $domain ) {
// Check one "group" per default: the generic pool
? $defaultGroups
: (array)$groups;
- if ( $i == self::DB_MASTER ) {
+ if ( $i === self::DB_MASTER ) {
$i = $this->getWriterIndex();
- } elseif ( $i == self::DB_REPLICA ) {
+ } elseif ( $i === self::DB_REPLICA ) {
# Try to find an available server in any the query groups (in order)
foreach ( $groups as $group ) {
$groupIndex = $this->getReaderIndex( $group, $domain );
}
# Operation-based index
- if ( $i == self::DB_REPLICA ) {
+ if ( $i === self::DB_REPLICA ) {
$this->lastError = 'Unknown error'; // reset error string
# Try the general server pool if $groups are unavailable.
$i = ( $groups === [ false ] )
$this->lastError = 'No working replica DB server: ' . $this->lastError;
// Throw an exception
$this->reportConnectionError();
- return null; // not reached
+ return null; // unreachable due to exception
}
}
$this->getLoadMonitor()->scaleLoads( $loads, $domain );
// Pick a server to use, accounting for weights, load, lag, and "waitForPos"
+ $this->lazyLoadReplicationPositions(); // optimizes server candidate selection
list( $i, $laggedReplicaMode ) = $this->pickReaderIndex( $loads, $domain );
if ( $i === false ) {
// DB connection unsuccessful
} else {
$i = false;
if ( $this->waitForPos && $this->waitForPos->asOfTime() ) {
+ $this->replLogger->debug( __METHOD__ . ": replication positions detected" );
// "chronologyCallback" sets "waitForPos" for session consistency.
// This triggers doWait() after connect, so it's especially good to
// avoid lagged servers so as to avoid excessive delay in that method.
$serverName = $this->getServerName( $i );
$this->connLogger->debug( __METHOD__ . ": Using reader #$i: $serverName..." );
- $conn = $this->openConnection( $i, $domain );
+ $conn = $this->getConnection( $i, [], $domain, self::CONN_SILENCE_ERRORS );
if ( !$conn ) {
$this->connLogger->warning( __METHOD__ . ": Failed connecting to $i/$domain" );
unset( $currentLoads[$i] ); // avoid this server next iteration
);
return false;
- } else {
- $conn = $this->openConnection( $index, self::DOMAIN_ANY );
- if ( !$conn ) {
- $this->replLogger->warning(
- __METHOD__ . ': failed to connect to {dbserver}',
- [ 'dbserver' => $server ]
- );
+ }
+ // Open a temporary new connection in order to wait for replication
+ $conn = $this->getConnection( $index, [], self::DOMAIN_ANY, self::CONN_SILENCE_ERRORS );
+ if ( !$conn ) {
+ $this->replLogger->warning(
+ __METHOD__ . ': failed to connect to {dbserver}',
+ [ 'dbserver' => $server ]
+ );
- return false;
- }
- // Avoid connection spam in waitForAll() when connections
- // are made just for the sake of doing this lag check.
- $close = true;
+ return false;
}
+ // Avoid connection spam in waitForAll() when connections
+ // are made just for the sake of doing this lag check.
+ $close = true;
}
$this->replLogger->info(
}
public function getConnection( $i, $groups = [], $domain = false, $flags = 0 ) {
- if ( $i === null || $i === false ) {
+ if ( !is_int( $i ) ) {
throw new InvalidArgumentException( "Cannot connect without a server index" );
+ } elseif ( $groups && $i > 0 ) {
+ throw new InvalidArgumentException( "Got query groups with server index #$i" );
}
$domain = $this->resolveDomainID( $domain );
+ $flags = $this->sanitizeConnectionFlags( $flags );
$masterOnly = ( $i == self::DB_MASTER || $i == $this->getWriterIndex() );
- if ( ( $flags & self::CONN_TRX_AUTOCOMMIT ) === self::CONN_TRX_AUTOCOMMIT ) {
- // Assuming all servers are of the same type (or similar), which is overwhelmingly
- // the case, use the master server information to get the attributes. The information
- // for $i cannot be used since it might be DB_REPLICA, which might require connection
- // attempts in order to be resolved into a real server index.
- $attributes = $this->getServerAttributes( $this->getWriterIndex() );
- if ( $attributes[Database::ATTR_DB_LEVEL_LOCKING] ) {
- // Callers sometimes want to (a) escape REPEATABLE-READ stateness without locking
- // rows (e.g. FOR UPDATE) or (b) make small commits during a larger transactions
- // to reduce lock contention. None of these apply for sqlite and using separate
- // connections just causes self-deadlocks.
- $flags &= ~self::CONN_TRX_AUTOCOMMIT;
- $this->connLogger->info( __METHOD__ .
- ': ignoring CONN_TRX_AUTOCOMMIT to avoid deadlocks.' );
- }
- }
-
// Number of connections made before getting the server index and handle
$priorConnectionsMade = $this->connsOpened;
- // Decide which server to use (might trigger new connections)
+
+ // Choose a server if $i is DB_MASTER/DB_REPLICA (might trigger new connections)
$serverIndex = $this->getConnectionIndex( $i, $groups, $domain );
// Get an open connection to that server (might trigger a new connection)
- $conn = $this->openConnection( $serverIndex, $domain, $flags );
- if ( !$conn ) {
- $this->reportConnectionError();
- return null; // unreachable due to exception
+ $conn = $this->localDomain->equals( $domain )
+ ? $this->getLocalConnection( $serverIndex, $flags )
+ : $this->getForeignConnection( $serverIndex, $domain, $flags );
+ // Throw an error or bail out if the connection attempt failed
+ if ( !( $conn instanceof IDatabase ) ) {
+ if ( ( $flags & self::CONN_SILENCE_ERRORS ) != self::CONN_SILENCE_ERRORS ) {
+ $this->reportConnectionError();
+ }
+
+ return false;
}
// Profile any new connections caused by this method
$this->trxProfiler->recordConnection( $host, $dbname, $masterOnly );
}
+ if ( !$conn->isOpen() ) {
+ // Connection was made but later unrecoverably lost for some reason.
+ // Do not return a handle that will just throw exceptions on use,
+ // but let the calling code (e.g. getReaderIndex) try another server.
+ $this->errorConnection = $conn;
+ return false;
+ }
+
+ $this->enforceConnectionFlags( $conn, $flags );
if ( $serverIndex == $this->getWriterIndex() ) {
// If the load balancer is read-only, perhaps due to replication lag, then master
// DB handles will reflect that. Note that Database::assertIsWritableMaster() takes
: self::DB_REPLICA;
}
+ /**
+ * @param int $i
+ * @param bool $domain
+ * @param int $flags
+ * @return Database|bool Live database handle or false on failure
+ * @deprecated Since 1.34 Use getConnection() instead
+ */
public function openConnection( $i, $domain = false, $flags = 0 ) {
- $domain = $this->resolveDomainID( $domain );
-
- if ( !$this->connectionAttempted && $this->chronologyCallback ) {
- // Load any "waitFor" positions before connecting so that doWait() is triggered
- $this->connLogger->debug( __METHOD__ . ': calling initLB() before first connection.' );
- $this->connectionAttempted = true;
- ( $this->chronologyCallback )( $this );
- }
-
- $conn = $this->localDomain->equals( $domain )
- ? $this->openLocalConnection( $i, $flags )
- : $this->openForeignConnection( $i, $domain, $flags );
-
- if ( $conn instanceof IDatabase && !$conn->isOpen() ) {
- // Connection was made but later unrecoverably lost for some reason.
- // Do not return a handle that will just throw exceptions on use,
- // but let the calling code (e.g. getReaderIndex) try another server.
- $this->errorConnection = $conn;
- $conn = false;
- }
-
- if (
- $conn instanceof IDatabase &&
- ( ( $flags & self::CONN_TRX_AUTOCOMMIT ) == self::CONN_TRX_AUTOCOMMIT )
- ) {
- if ( $conn->trxLevel() ) { // sanity
- throw new DBUnexpectedError(
- $conn,
- 'Handle requested with CONN_TRX_AUTOCOMMIT yet it has a transaction'
- );
- }
-
- $conn->clearFlag( $conn::DBO_TRX ); // auto-commit mode
- }
-
- return $conn;
+ return $this->getConnection( $i, [], $domain, $flags | self::CONN_SILENCE_ERRORS );
}
/**
* @param int $flags Class CONN_* constant bitfield
* @return Database
*/
- private function openLocalConnection( $i, $flags = 0 ) {
+ private function getLocalConnection( $i, $flags = 0 ) {
// Connection handles required to be in auto-commit mode use a separate connection
// pool since the main pool is effected by implicit and explicit transaction rounds
$autoCommit = ( ( $flags & self::CONN_TRX_AUTOCOMMIT ) == self::CONN_TRX_AUTOCOMMIT );
* @return Database|bool Returns false on connection error
* @throws DBError When database selection fails
*/
- private function openForeignConnection( $i, $domain, $flags = 0 ) {
+ private function getForeignConnection( $i, $domain, $flags = 0 ) {
$domainInstance = DatabaseDomain::newFromId( $domain );
// Connection handles required to be in auto-commit mode use a separate connection
// pool since the main pool is effected by implicit and explicit transaction rounds
}
}
+ $this->lazyLoadReplicationPositions(); // session consistency
+
return $db;
}
+ /**
+ * Make sure that any "waitForPos" positions are loaded and available to doWait()
+ */
+ private function lazyLoadReplicationPositions() {
+ if ( !$this->connectionAttempted && $this->chronologyCallback ) {
+ $this->connectionAttempted = true;
+ ( $this->chronologyCallback )( $this ); // generally calls waitFor()
+ $this->connLogger->debug( __METHOD__ . ': executed chronology callback.' );
+ }
+ }
+
/**
* @throws DBConnectionError
*/
if ( !$pos ) {
// Get the current master position, opening a connection if needed
- $masterConn = $this->getAnyOpenConnection( $this->getWriterIndex() );
+ $index = $this->getWriterIndex();
+ $masterConn = $this->getAnyOpenConnection( $index );
if ( $masterConn ) {
$pos = $masterConn->getMasterPos();
} else {
- $masterConn = $this->openConnection( $this->getWriterIndex(), self::DOMAIN_ANY );
+ $masterConn = $this->getConnection( $index, [], self::DOMAIN_ANY, self::CONN_SILENCE_ERRORS );
if ( !$masterConn ) {
throw new DBReplicationWaitError(
null,
}
if ( $pos instanceof DBMasterPos ) {
+ $start = microtime( true );
$result = $conn->masterPosWait( $pos, $timeout );
+ $seconds = max( microtime( true ) - $start, 0 );
if ( $result == -1 || is_null( $result ) ) {
- $msg = __METHOD__ . ': timed out waiting on {host} pos {pos}';
+ $msg = __METHOD__ . ': timed out waiting on {host} pos {pos} [{seconds}s]';
$this->replLogger->warning( $msg, [
'host' => $conn->getServer(),
'pos' => $pos,
+ 'seconds' => round( $seconds, 6 ),
'trace' => ( new RuntimeException() )->getTraceAsString()
] );
$ok = false;
dépôts / lhc / web / wiklou.git / commitdiff