Updated unit tests as well for AuthManagerTest::testContinueAccountCreation()
and AuthManagerTest::testContinueAccountLink().
Change-Id: I96363e34688517796c2812cb3f483e1bfa26be6b
$user->load( User::READ_LOCKING );
if ( $state['userid'] === 0 ) {
$user->load( User::READ_LOCKING );
if ( $state['userid'] === 0 ) {
- if ( $user->getId() != 0 ) {
+ if ( $user->getId() !== 0 ) {
$this->logger->debug( __METHOD__ . ': User exists locally', [
'user' => $user->getName(),
'creator' => $creator->getName(),
$this->logger->debug( __METHOD__ . ': User exists locally', [
'user' => $user->getName(),
'creator' => $creator->getName(),
"User \"{$state['username']}\" should exist now, but doesn't!"
);
}
"User \"{$state['username']}\" should exist now, but doesn't!"
);
}
- if ( $user->getId() != $state['userid'] ) {
+ if ( $user->getId() !== $state['userid'] ) {
$this->logger->debug( __METHOD__ . ': User ID/name mismatch', [
'user' => $user->getName(),
'creator' => $creator->getName(),
$this->logger->debug( __METHOD__ . ': User ID/name mismatch', [
'user' => $user->getName(),
'creator' => $creator->getName(),
] );
throw new \UnexpectedValueException(
"User \"{$state['username']}\" exists, but " .
] );
throw new \UnexpectedValueException(
"User \"{$state['username']}\" exists, but " .
- "ID {$user->getId()} != {$state['userid']}!"
+ "ID {$user->getId()} !== {$state['userid']}!"
// @codeCoverageIgnoreStart
if (
!$localId &&
// @codeCoverageIgnoreStart
if (
!$localId &&
- MediaWikiServices::getInstance()->getDBLoadBalancer()->getReaderIndex() != 0
+ MediaWikiServices::getInstance()->getDBLoadBalancer()->getReaderIndex() !== 0
) {
$localId = User::idFromName( $username, User::READ_LATEST );
$flags = User::READ_LATEST;
) {
$localId = User::idFromName( $username, User::READ_LATEST );
$flags = User::READ_LATEST;
$session->remove( 'AuthManager::accountLinkState' );
return AuthenticationResponse::newFail( wfMessage( 'noname' ) );
}
$session->remove( 'AuthManager::accountLinkState' );
return AuthenticationResponse::newFail( wfMessage( 'noname' ) );
}
- if ( $user->getId() != $state['userid'] ) {
+ if ( $user->getId() !== $state['userid'] ) {
throw new \UnexpectedValueException(
"User \"{$state['username']}\" is valid, but " .
throw new \UnexpectedValueException(
"User \"{$state['username']}\" is valid, but " .
- "ID {$user->getId()} != {$state['userid']}!"
+ "ID {$user->getId()} !== {$state['userid']}!"
* @param string $name Username
*/
public function __construct( $id, $name ) {
* @param string $name Username
*/
public function __construct( $id, $name ) {
$this->username = $name;
}
}
$this->username = $name;
}
}
/**
* @group AuthManager
* @group Database
/**
* @group AuthManager
* @group Database
- * @covers MediaWiki\Auth\AuthManager
+ * @covers \MediaWiki\Auth\AuthManager
*/
class AuthManagerTest extends \MediaWikiTestCase {
/** @var WebRequest */
*/
class AuthManagerTest extends \MediaWikiTestCase {
/** @var WebRequest */
$this->fail( 'Expected exception not thrown' );
} catch ( \UnexpectedValueException $ex ) {
$this->assertEquals(
$this->fail( 'Expected exception not thrown' );
} catch ( \UnexpectedValueException $ex ) {
$this->assertEquals(
- "User \"{$name}\" exists, but ID $id != " . ( $id + 1 ) . '!', $ex->getMessage()
+ "User \"{$name}\" exists, but ID $id !== " . ( $id + 1 ) . '!', $ex->getMessage()
);
}
$this->unhook( 'LocalUserCreated' );
);
}
$this->unhook( 'LocalUserCreated' );
$this->fail( 'Expected exception not thrown' );
} catch ( \UnexpectedValueException $ex ) {
$this->assertEquals(
$this->fail( 'Expected exception not thrown' );
} catch ( \UnexpectedValueException $ex ) {
$this->assertEquals(
- "User \"{$user->getName()}\" is valid, but ID $id != " . ( $id + 1 ) . '!',
+ "User \"{$user->getName()}\" is valid, but ID $id !== " . ( $id + 1 ) . '!',