From b70bcab4868950b55cbc32728717853d3d603ebd Mon Sep 17 00:00:00 2001 From: Timo Tijhof Date: Sat, 30 Sep 2017 18:35:13 +0100 Subject: [PATCH] mw.loader: Return consistent object shape from splitModuleKey() This is used in mw.loader.implement() in a truthy check before assigning as value of `registry[module].version`. Both implicit undefined and empty string are falsey so the behaviour is unchanged. This reduces shape variability for JS engines, and also avoid potential mistakes if the function is used elsewhere since internally the registry, as maintained by mw.loader.register(), uses empty string as default for version, not undefined. Change-Id: I067137557a55d521fefa40986373e55b6bbb59ff --- resources/src/mediawiki/mediawiki.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/resources/src/mediawiki/mediawiki.js b/resources/src/mediawiki/mediawiki.js index aae292d902..66e09dc629 100644 --- a/resources/src/mediawiki/mediawiki.js +++ b/resources/src/mediawiki/mediawiki.js @@ -1718,7 +1718,10 @@ function splitModuleKey( key ) { var index = key.indexOf( '@' ); if ( index === -1 ) { - return { name: key }; + return { + name: key, + version: '' + }; } return { name: key.slice( 0, index ), -- 2.20.1