From 91d472a490a9253939d9fb2d6147e3aaeca448fa Mon Sep 17 00:00:00 2001 From: =?utf8?q?Niklas=20Laxstr=C3=B6m?= Date: Thu, 20 Jan 2011 07:38:30 +0000 Subject: [PATCH] Kill some duplicated queries by also caching negative results in wasDeletedSinceLastEdit --- includes/EditPage.php | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/includes/EditPage.php b/includes/EditPage.php index 3f7ef96571..8c04326064 100644 --- a/includes/EditPage.php +++ b/includes/EditPage.php @@ -49,7 +49,7 @@ class EditPage { var $isCssJsSubpage = false; var $isCssSubpage = false; var $isJsSubpage = false; - var $deletedSinceEdit = false; + var $deletedSinceEdit; var $formtype; var $firsttime; var $lastDelete; @@ -260,8 +260,12 @@ class EditPage { * deletes. */ protected function wasDeletedSinceLastEdit() { - if ( $this->deletedSinceEdit ) - return true; + if ( $this->deletedSinceEdit !== null ) { + return $this->deletedSinceEdit; + } + + $this->deletedSinceEdit = false; + if ( $this->mTitle->isDeletedQuick() ) { $this->lastDelete = $this->getLastDelete(); if ( $this->lastDelete ) { @@ -271,6 +275,7 @@ class EditPage { } } } + return $this->deletedSinceEdit; } -- 2.20.1