From 694fef93eaab44609c35598c1740a098c18c2320 Mon Sep 17 00:00:00 2001 From: Fomafix Date: Fri, 7 Dec 2018 10:55:03 +0100 Subject: [PATCH] resources: Document why mw.user has two seemingly unused deps The code in the module 'mediawiki.user' does not depend on the modules 'user.options' and 'user.tokens' so the ResourceLoader dependency is not necessary. Change-Id: I22b9175f7623dbdf1c08826904b76dee5d56ea40 --- resources/Resources.php | 3 +++ 1 file changed, 3 insertions(+) diff --git a/resources/Resources.php b/resources/Resources.php index 8f3e8c4960..741b64f669 100644 --- a/resources/Resources.php +++ b/resources/Resources.php @@ -1317,6 +1317,9 @@ return [ 'dependencies' => [ 'mediawiki.api', 'mediawiki.storage', + // The two user.* modules are not used by mediawiki.user itself, + // but kept as expliciit dependencies because they provide part + // of the mw.user API that consumers of this module expect. 'user.options', 'user.tokens', ], -- 2.20.1