From 661c43f3ebea4256e32fb0523cbc9a7f198b635f Mon Sep 17 00:00:00 2001 From: "C. Scott Ananian" Date: Thu, 25 Oct 2018 22:02:47 -0400 Subject: [PATCH] Hard deprecate $wgTidyConfig['driver'] = 'disabled' This was already deprecated in the release notes, and is not used in production, but I'd overlooked adding an appropriate hard deprecation notice in MWTidy::factory() to notify downstream users. Change-Id: I8f4d8154a1d8a233017f54f0fb4bcfdf4a0373e1 --- RELEASE-NOTES-1.32 | 1 + includes/parser/MWTidy.php | 1 + 2 files changed, 2 insertions(+) diff --git a/RELEASE-NOTES-1.32 b/RELEASE-NOTES-1.32 index 8ccc9c2fa7..2cd1222f40 100644 --- a/RELEASE-NOTES-1.32 +++ b/RELEASE-NOTES-1.32 @@ -598,6 +598,7 @@ because of Phabricator reports. $wgTidyConfig instead. * All Tidy configurations other than Remex have been hard deprecated; future parsers will not emit compatible output for these configurations. + In particular, running MediaWiki with tidy disabled has been deprecated. * (T198214) OutputPage::addWikiText(), OutputPage::addWikiTextWithTitle(), and OutputPage::addWikiTextTitle() have been deprecated, since they can result in untidy output. In addition OutputPage::addWikiTextTidy() diff --git a/includes/parser/MWTidy.php b/includes/parser/MWTidy.php index a73c28cdba..8881786067 100644 --- a/includes/parser/MWTidy.php +++ b/includes/parser/MWTidy.php @@ -117,6 +117,7 @@ class MWTidy { $instance = new MediaWiki\Tidy\RemexDriver( $config ); break; case 'disabled': + wfDeprecated( '"disabled" tidy driver', '1.32' ); return false; default: throw new MWException( "Invalid tidy driver: \"{$config['driver']}\"" ); -- 2.20.1