From 570dda04554d0abd066b25b4d8dc430edd0e2d2b Mon Sep 17 00:00:00 2001 From: umherirrender Date: Sun, 3 Feb 2013 20:42:08 +0100 Subject: [PATCH] fix some spacing Change-Id: I88e73d47a552918880514d88a876296a6cb80d88 --- includes/filebackend/FSFile.php | 6 +- includes/filebackend/FileOp.php | 2 +- includes/filerepo/FileRepo.php | 4 +- includes/filerepo/ForeignAPIRepo.php | 6 +- includes/filerepo/LocalRepo.php | 4 +- includes/filerepo/RepoGroup.php | 8 +-- includes/filerepo/file/ArchivedFile.php | 10 +-- includes/filerepo/file/File.php | 30 ++++----- includes/filerepo/file/ForeignAPIFile.php | 6 +- includes/filerepo/file/LocalFile.php | 8 +-- includes/filerepo/file/OldLocalFile.php | 10 +-- .../filerepo/file/UnregisteredLocalFile.php | 2 +- includes/media/BMP.php | 2 +- includes/media/DjVu.php | 6 +- includes/media/DjVuImage.php | 8 +-- includes/media/Exif.php | 46 ++++++------- includes/media/ExifBitmap.php | 12 ++-- includes/media/FormatMetadata.php | 40 +++++------ includes/media/GIF.php | 14 ++-- includes/media/GIFMetadataExtractor.php | 28 ++++---- includes/media/IPTC.php | 60 ++++++++--------- includes/media/ImageHandler.php | 4 +- includes/media/Jpeg.php | 2 +- includes/media/MediaHandler.php | 6 +- includes/media/MediaTransformOutput.php | 8 +-- includes/media/PNG.php | 12 ++-- includes/media/SVG.php | 12 ++-- includes/media/SVGMetadataExtractor.php | 20 +++--- includes/media/Tiff.php | 2 +- includes/media/XCF.php | 2 +- includes/media/XMP.php | 26 ++++---- includes/media/XMPInfo.php | 10 +-- includes/media/XMPValidate.php | 8 +-- includes/parser/CoreLinkFunctions.php | 12 ++-- includes/parser/CoreParserFunctions.php | 4 +- includes/parser/DateFormatter.php | 32 ++++----- includes/parser/LinkHolderArray.php | 20 +++--- includes/parser/Parser.php | 28 ++++---- includes/parser/ParserCache.php | 2 +- includes/parser/ParserOutput.php | 12 ++-- includes/parser/Parser_LinkHooks.php | 66 +++++++++---------- includes/parser/Preprocessor_DOM.php | 44 ++++++------- includes/parser/Preprocessor_Hash.php | 44 ++++++------- includes/parser/Preprocessor_HipHop.hphp | 26 ++++---- includes/parser/Tidy.php | 6 +- 45 files changed, 360 insertions(+), 360 deletions(-) diff --git a/includes/filebackend/FSFile.php b/includes/filebackend/FSFile.php index 5141ec5801..acbc4a996d 100644 --- a/includes/filebackend/FSFile.php +++ b/includes/filebackend/FSFile.php @@ -104,7 +104,7 @@ class FSFile { */ public function getProps( $ext = true ) { wfProfileIn( __METHOD__ ); - wfDebug( __METHOD__.": Getting file info for $this->path\n" ); + wfDebug( __METHOD__ . ": Getting file info for $this->path\n" ); $info = self::placeholderProps(); $info['fileExists'] = $this->exists(); @@ -140,9 +140,9 @@ class FSFile { } $info['sha1'] = $this->getSha1Base36(); - wfDebug(__METHOD__.": $this->path loaded, {$info['size']} bytes, {$info['mime']}.\n"); + wfDebug( __METHOD__ . ": $this->path loaded, {$info['size']} bytes, {$info['mime']}.\n" ); } else { - wfDebug(__METHOD__.": $this->path NOT FOUND!\n"); + wfDebug( __METHOD__ . ": $this->path NOT FOUND!\n" ); } wfProfileOut( __METHOD__ ); diff --git a/includes/filebackend/FileOp.php b/includes/filebackend/FileOp.php index 7952bcb32e..28f5b733f3 100644 --- a/includes/filebackend/FileOp.php +++ b/includes/filebackend/FileOp.php @@ -167,7 +167,7 @@ abstract class FileOp { * @return Array */ final public function applyDependencies( array $deps ) { - $deps['read'] += array_fill_keys( $this->storagePathsRead(), 1 ); + $deps['read'] += array_fill_keys( $this->storagePathsRead(), 1 ); $deps['write'] += array_fill_keys( $this->storagePathsChanged(), 1 ); return $deps; } diff --git a/includes/filerepo/FileRepo.php b/includes/filerepo/FileRepo.php index 4cc4fdec5c..5f7972a2d5 100644 --- a/includes/filerepo/FileRepo.php +++ b/includes/filerepo/FileRepo.php @@ -955,7 +955,7 @@ class FileRepo { $hashPath = $this->getHashPath( $originalName ); $dstRel = "{$hashPath}{$date}!{$originalName}"; $dstUrlRel = $hashPath . $date . '!' . rawurlencode( $originalName ); - $virtualUrl = $this->getVirtualUrl( 'temp' ) . '/' . $dstUrlRel; + $virtualUrl = $this->getVirtualUrl( 'temp' ) . '/' . $dstUrlRel; $result = $this->quickImport( $srcPath, $virtualUrl ); $result->value = $virtualUrl; @@ -1105,7 +1105,7 @@ class FileRepo { if ( !$this->initDirectory( $dstDir )->isOK() ) { return $this->newFatal( 'directorycreateerror', $dstDir ); } - if ( !$this->initDirectory($archiveDir )->isOK() ) { + if ( !$this->initDirectory( $archiveDir )->isOK() ) { return $this->newFatal( 'directorycreateerror', $archiveDir ); } diff --git a/includes/filerepo/ForeignAPIRepo.php b/includes/filerepo/ForeignAPIRepo.php index 7697e4ea41..e1ecb96046 100644 --- a/includes/filerepo/ForeignAPIRepo.php +++ b/includes/filerepo/ForeignAPIRepo.php @@ -267,7 +267,7 @@ class ForeignAPIRepo extends FileRepo { $sizekey = "$width:$height:$params"; /* Get the array of urls that we already know */ - $knownThumbUrls = $wgMemc->get($key); + $knownThumbUrls = $wgMemc->get( $key ); if( !$knownThumbUrls ) { /* No knownThumbUrls for this file */ $knownThumbUrls = array(); @@ -294,9 +294,9 @@ class ForeignAPIRepo extends FileRepo { wfDebug( __METHOD__ . " The deduced filename $fileName is not safe\n" ); return false; } - $localPath = $this->getZonePath( 'thumb' ) . "/" . $this->getHashPath( $name ) . $name; + $localPath = $this->getZonePath( 'thumb' ) . "/" . $this->getHashPath( $name ) . $name; $localFilename = $localPath . "/" . $fileName; - $localUrl = $this->getZoneUrl( 'thumb' ) . "/" . $this->getHashPath( $name ) . rawurlencode( $name ) . "/" . rawurlencode( $fileName ); + $localUrl = $this->getZoneUrl( 'thumb' ) . "/" . $this->getHashPath( $name ) . rawurlencode( $name ) . "/" . rawurlencode( $fileName ); if( $backend->fileExists( array( 'src' => $localFilename ) ) && isset( $metadata['timestamp'] ) ) diff --git a/includes/filerepo/LocalRepo.php b/includes/filerepo/LocalRepo.php index 89a458b708..0fbaeef8a0 100644 --- a/includes/filerepo/LocalRepo.php +++ b/includes/filerepo/LocalRepo.php @@ -212,8 +212,8 @@ class LocalRepo extends FileRepo { $dbr = $this->getSlaveDB(); $id = $dbr->selectField( 'page', // Table - 'page_id', //Field - array( //Conditions + 'page_id', //Field + array( //Conditions 'page_namespace' => $title->getNamespace(), 'page_title' => $title->getDBkey(), ), diff --git a/includes/filerepo/RepoGroup.php b/includes/filerepo/RepoGroup.php index f9e5759920..1f5ae914d2 100644 --- a/includes/filerepo/RepoGroup.php +++ b/includes/filerepo/RepoGroup.php @@ -131,7 +131,7 @@ class RepoGroup { $time = isset( $options['time'] ) ? $options['time'] : ''; $dbkey = $title->getDBkey(); if ( isset( $this->cache[$dbkey][$time] ) ) { - wfDebug( __METHOD__.": got File:$dbkey from process cache\n" ); + wfDebug( __METHOD__ . ": got File:$dbkey from process cache\n" ); # Move it to the end of the list so that we can delete the LRU entry later $this->pingCache( $dbkey ); # Return the entry @@ -388,12 +388,12 @@ class RepoGroup { */ function splitVirtualUrl( $url ) { if ( substr( $url, 0, 9 ) != 'mwrepo://' ) { - throw new MWException( __METHOD__.': unknown protocol' ); + throw new MWException( __METHOD__ . ': unknown protocol' ); } $bits = explode( '/', substr( $url, 9 ), 3 ); if ( count( $bits ) != 3 ) { - throw new MWException( __METHOD__.": invalid mwrepo URL: $url" ); + throw new MWException( __METHOD__ . ": invalid mwrepo URL: $url" ); } return $bits; } @@ -433,7 +433,7 @@ class RepoGroup { while ( count( $this->cache ) >= self::MAX_CACHE_SIZE ) { reset( $this->cache ); $key = key( $this->cache ); - wfDebug( __METHOD__.": evicting $key\n" ); + wfDebug( __METHOD__ . ": evicting $key\n" ); unset( $this->cache[$key] ); } } diff --git a/includes/filerepo/file/ArchivedFile.php b/includes/filerepo/file/ArchivedFile.php index e1a8547895..b02d92b9b3 100644 --- a/includes/filerepo/file/ArchivedFile.php +++ b/includes/filerepo/file/ArchivedFile.php @@ -68,7 +68,7 @@ class ArchivedFile { * @param int $id * @param string $key */ - function __construct( $title, $id=0, $key='' ) { + function __construct( $title, $id = 0, $key = '' ) { $this->id = -1; $this->title = false; $this->name = false; @@ -95,11 +95,11 @@ class ArchivedFile { $this->name = $title->getDBkey(); } - if ($id) { + if ( $id ) { $this->id = $id; } - if ($key) { + if ( $key ) { $this->key = $key; } @@ -130,7 +130,7 @@ class ArchivedFile { $conds['fa_name'] = $this->title->getDBkey(); } - if( !count($conds)) { + if( !count( $conds ) ) { throw new MWException( "No specific information for retrieving archived file" ); } @@ -197,7 +197,7 @@ class ArchivedFile { * @since 1.21 */ public function loadFromRow( $row ) { - $this->id = intval($row->fa_id); + $this->id = intval( $row->fa_id ); $this->name = $row->fa_name; $this->archive_name = $row->fa_archive_name; $this->group = $row->fa_storage_group; diff --git a/includes/filerepo/file/File.php b/includes/filerepo/file/File.php index e4e49f5659..bccbe648d8 100644 --- a/includes/filerepo/file/File.php +++ b/includes/filerepo/file/File.php @@ -40,7 +40,7 @@ * never name a file class explictly outside of the repo class. Instead use the * repo's factory functions to generate file objects, for example: * - * RepoGroup::singleton()->getLocalRepo()->newFile($title); + * RepoGroup::singleton()->getLocalRepo()->newFile( $title ); * * The convenience functions wfLocalFile() and wfFindFile() should be sufficient * in most cases. @@ -54,7 +54,7 @@ abstract class File { const DELETED_RESTRICTED = 8; /** Force rendering in the current process */ - const RENDER_NOW = 1; + const RENDER_NOW = 1; /** * Force rendering even if thumbnail already exist and using RENDER_NOW * I.e. you have to pass both flags: File::RENDER_NOW | File::RENDER_FORCE @@ -348,7 +348,7 @@ abstract class File { if ( $this->canRender() ) { return $this->createThumb( $this->getWidth() ); } else { - wfDebug( __METHOD__.': supposed to render ' . $this->getName() . + wfDebug( __METHOD__ . ': supposed to render ' . $this->getName() . ' (' . $this->getMimeType() . "), but can't!\n" ); return $this->getURL(); #hm... return NULL? } @@ -663,13 +663,13 @@ abstract class File { if ( $this->allowInlineDisplay() ) { return true; } - if ($this->isTrustedFile()) { + if ( $this->isTrustedFile() ) { return true; } $type = $this->getMediaType(); $mime = $this->getMimeType(); - #wfDebug("LocalFile::isSafeFile: type= $type, mime= $mime\n"); + #wfDebug( "LocalFile::isSafeFile: type= $type, mime= $mime\n" ); if ( !$type || $type === MEDIATYPE_UNKNOWN ) { return false; #unknown type, not trusted @@ -903,7 +903,7 @@ abstract class File { // Clean up broken thumbnails as needed $this->migrateThumbFile( $thumbName ); // Check if an up-to-date thumbnail already exists... - wfDebug( __METHOD__.": Doing stat for $thumbPath\n" ); + wfDebug( __METHOD__ . ": Doing stat for $thumbPath\n" ); if ( !( $flags & self::RENDER_FORCE ) && $this->repo->fileExists( $thumbPath ) ) { $timestamp = $this->repo->getFileTimestamp( $thumbPath ); if ( $timestamp !== false && $timestamp >= $wgThumbnailEpoch ) { @@ -1366,7 +1366,7 @@ abstract class File { * @throws MWException */ function readOnlyError() { - throw new MWException( get_class($this) . ': write operations are not supported' ); + throw new MWException( get_class( $this ) . ': write operations are not supported' ); } /** @@ -1500,9 +1500,9 @@ abstract class File { * @param $target Title New file name * @return FileRepoStatus object. */ - function move( $target ) { + function move( $target ) { $this->readOnlyError(); - } + } /** * Delete all versions of the file. @@ -1627,15 +1627,15 @@ abstract class File { $renderUrl = $this->repo->getDescriptionRenderUrl( $this->getName(), $wgLang->getCode() ); if ( $renderUrl ) { if ( $this->repo->descriptionCacheExpiry > 0 ) { - wfDebug("Attempting to get the description from cache..."); + wfDebug( "Attempting to get the description from cache..." ); $key = $this->repo->getLocalCacheKey( 'RemoteFileDescription', 'url', $wgLang->getCode(), $this->getName() ); - $obj = $wgMemc->get($key); - if ($obj) { - wfDebug("success!\n"); + $obj = $wgMemc->get( $key ); + if ( $obj ) { + wfDebug( "success!\n" ); return $obj; } - wfDebug("miss\n"); + wfDebug( "miss\n" ); } wfDebug( "Fetching shared description from $renderUrl\n" ); $res = Http::get( $renderUrl ); @@ -1721,7 +1721,7 @@ abstract class File { * @return array */ static function getPropsFromPath( $path, $ext = true ) { - wfDebug( __METHOD__.": Getting file info for $path\n" ); + wfDebug( __METHOD__ . ": Getting file info for $path\n" ); wfDeprecated( __METHOD__, '1.19' ); $fsFile = new FSFile( $path ); diff --git a/includes/filerepo/file/ForeignAPIFile.php b/includes/filerepo/file/ForeignAPIFile.php index 56482611f8..84e0df6748 100644 --- a/includes/filerepo/file/ForeignAPIFile.php +++ b/includes/filerepo/file/ForeignAPIFile.php @@ -189,7 +189,7 @@ class ForeignAPIFile extends File { * @param string $method * @return int|null|string */ - public function getUser( $method='text' ) { + public function getUser( $method = 'text' ) { return isset( $this->mInfo['user'] ) ? strval( $this->mInfo['user'] ) : null; } @@ -256,7 +256,7 @@ class ForeignAPIFile extends File { */ function getThumbPath( $suffix = '' ) { if ( $this->repo->canCacheThumbs() ) { - $path = $this->repo->getZonePath('thumb') . '/' . $this->getHashPath( $this->getName() ); + $path = $this->repo->getZonePath( 'thumb' ) . '/' . $this->getHashPath( $this->getName() ); if ( $suffix ) { $path = $path . $suffix . '/'; } @@ -293,7 +293,7 @@ class ForeignAPIFile extends File { global $wgMemc, $wgContLang; $url = $this->repo->getDescriptionRenderUrl( $this->getName(), $wgContLang->getCode() ); - $key = $this->repo->getLocalCacheKey( 'RemoteFileDescription', 'url', md5($url) ); + $key = $this->repo->getLocalCacheKey( 'RemoteFileDescription', 'url', md5( $url ) ); $wgMemc->delete( $key ); } diff --git a/includes/filerepo/file/LocalFile.php b/includes/filerepo/file/LocalFile.php index c08d192590..0ddebc9a3e 100644 --- a/includes/filerepo/file/LocalFile.php +++ b/includes/filerepo/file/LocalFile.php @@ -36,7 +36,7 @@ define( 'MW_FILE_VERSION', 9 ); * never name a file class explictly outside of the repo class. Instead use the * repo's factory functions to generate file objects, for example: * - * RepoGroup::singleton()->getLocalRepo()->newFile($title); + * RepoGroup::singleton()->getLocalRepo()->newFile( $title ); * * The convenience functions wfLocalFile() and wfFindFile() should be sufficient * in most cases. @@ -398,7 +398,7 @@ class LocalFile extends File { // Sanity check prefix once if ( substr( key( $array ), 0, $prefixLength ) !== $prefix ) { - throw new MWException( __METHOD__ . ': incorrect $prefix parameter' ); + throw new MWException( __METHOD__ . ': incorrect $prefix parameter' ); } $decoded = array(); @@ -901,7 +901,7 @@ class LocalFile extends File { protected function purgeThumbList( $dir, $files ) { $fileListDebug = strtr( var_export( $files, true ), - array("\n"=>'') + array( "\n" => '' ) ); wfDebug( __METHOD__ . ": $fileListDebug\n" ); @@ -1285,7 +1285,7 @@ class LocalFile extends File { $log->getRcComment(), false ); - if (!is_null($nullRevision)) { + if ( !is_null( $nullRevision ) ) { $nullRevision->insertOn( $dbw ); wfRunHooks( 'NewRevisionFromEditComplete', array( $wikiPage, $nullRevision, $latest, $user ) ); diff --git a/includes/filerepo/file/OldLocalFile.php b/includes/filerepo/file/OldLocalFile.php index 3180835e46..4f27c8df82 100644 --- a/includes/filerepo/file/OldLocalFile.php +++ b/includes/filerepo/file/OldLocalFile.php @@ -42,7 +42,7 @@ class OldLocalFile extends LocalFile { static function newFromTitle( $title, $repo, $time = null ) { # The null default value is only here to avoid an E_STRICT if ( $time === null ) { - throw new MWException( __METHOD__.' got null for $time parameter' ); + throw new MWException( __METHOD__ . ' got null for $time parameter' ); } return new self( $title, $repo, $time, null ); } @@ -132,7 +132,7 @@ class OldLocalFile extends LocalFile { $this->requestedTime = $time; $this->archive_name = $archiveName; if ( is_null( $time ) && is_null( $archiveName ) ) { - throw new MWException( __METHOD__.': must specify at least one of $time or $archiveName' ); + throw new MWException( __METHOD__ . ': must specify at least one of $time or $archiveName' ); } } @@ -164,7 +164,7 @@ class OldLocalFile extends LocalFile { * @return bool */ function isVisible() { - return $this->exists() && !$this->isDeleted(File::DELETED_FILE); + return $this->exists() && !$this->isDeleted( File::DELETED_FILE ); } function loadFromDB() { @@ -255,7 +255,7 @@ class OldLocalFile extends LocalFile { # Don't destroy file info of missing files if ( !$this->fileExists ) { - wfDebug( __METHOD__.": file does not exist, aborting\n" ); + wfDebug( __METHOD__ . ": file does not exist, aborting\n" ); wfProfileOut( __METHOD__ ); return; } @@ -263,7 +263,7 @@ class OldLocalFile extends LocalFile { $dbw = $this->repo->getMasterDB(); list( $major, $minor ) = self::splitMime( $this->mime ); - wfDebug(__METHOD__.': upgrading '.$this->archive_name." to the current schema\n"); + wfDebug( __METHOD__ . ': upgrading ' . $this->archive_name . " to the current schema\n" ); $dbw->update( 'oldimage', array( 'oi_size' => $this->size, // sanity diff --git a/includes/filerepo/file/UnregisteredLocalFile.php b/includes/filerepo/file/UnregisteredLocalFile.php index 698d1ebe78..9a7f653383 100644 --- a/includes/filerepo/file/UnregisteredLocalFile.php +++ b/includes/filerepo/file/UnregisteredLocalFile.php @@ -71,7 +71,7 @@ class UnregisteredLocalFile extends File { */ function __construct( $title = false, $repo = false, $path = false, $mime = false ) { if ( !( $title && $repo ) && !$path ) { - throw new MWException( __METHOD__.': not enough parameters, must specify title and repo, or a full path' ); + throw new MWException( __METHOD__ . ': not enough parameters, must specify title and repo, or a full path' ); } if ( $title instanceof Title ) { $this->title = File::normalizeTitle( $title, 'exception' ); diff --git a/includes/media/BMP.php b/includes/media/BMP.php index a515c635f9..46d1b95bf5 100644 --- a/includes/media/BMP.php +++ b/includes/media/BMP.php @@ -62,7 +62,7 @@ class BmpHandler extends BitmapHandler { return false; } $header = fread( $f, 54 ); - fclose($f); + fclose( $f ); // Extract binary form of width and height from the header $w = substr( $header, 18, 4); diff --git a/includes/media/DjVu.php b/includes/media/DjVu.php index cd8a044c6c..0a39a2cf3e 100644 --- a/includes/media/DjVu.php +++ b/includes/media/DjVu.php @@ -183,7 +183,7 @@ class DjVuHandler extends ImageHandler { if ( $wgDjvuPostProcessor ) { $cmd .= " | {$wgDjvuPostProcessor}"; } - $cmd .= ' > ' . wfEscapeShellArg($dstPath) . ') 2>&1'; + $cmd .= ' > ' . wfEscapeShellArg( $dstPath ) . ') 2>&1'; wfProfileIn( 'ddjvu' ); wfDebug( __METHOD__.": $cmd\n" ); $retval = ''; @@ -194,7 +194,7 @@ class DjVuHandler extends ImageHandler { if ( $retval != 0 || $removed ) { wfDebugLog( 'thumbnail', sprintf( 'thumbnail failed on %s: error %d "%s" from "%s"', - wfHostname(), $retval, trim($err), $cmd ) ); + wfHostname(), $retval, trim( $err ), $cmd ) ); return new MediaTransformError( 'thumbnail_error', $width, $height, $err ); } else { $params = array( @@ -228,7 +228,7 @@ class DjVuHandler extends ImageHandler { * @param $gettext Boolean: DOCUMENT (Default: false) * @return bool */ - function getMetaTree( $image , $gettext = false ) { + function getMetaTree( $image, $gettext = false ) { if ( isset( $image->dejaMetaTree ) ) { return $image->dejaMetaTree; } diff --git a/includes/media/DjVuImage.php b/includes/media/DjVuImage.php index cad9c1b72a..5300947c08 100644 --- a/includes/media/DjVuImage.php +++ b/includes/media/DjVuImage.php @@ -43,9 +43,9 @@ class DjVuImage { $this->mFilename = $filename; } - /** - * @const DJVUTXT_MEMORY_LIMIT Memory limit for the DjVu description software - */ + /** + * @const DJVUTXT_MEMORY_LIMIT Memory limit for the DjVu description software + */ const DJVUTXT_MEMORY_LIMIT = 300000; /** @@ -260,7 +260,7 @@ class DjVuImage { if ( isset( $wgDjvuTxt ) ) { wfProfileIn( 'djvutxt' ); $cmd = wfEscapeShellArg( $wgDjvuTxt ) . ' --detail=page ' . wfEscapeShellArg( $this->mFilename ) ; - wfDebug( __METHOD__.": $cmd\n" ); + wfDebug( __METHOD__ . ": $cmd\n" ); $retval = ''; $txt = wfShellExec( $cmd, $retval, array(), array( 'memory' => self::DJVUTXT_MEMORY_LIMIT ) ); wfProfileOut( 'djvutxt' ); diff --git a/includes/media/Exif.php b/includes/media/Exif.php index f0b4536c37..63b21224f5 100644 --- a/includes/media/Exif.php +++ b/includes/media/Exif.php @@ -290,8 +290,8 @@ class Exif { // Only give a warning for b/c, since originally we didn't // require this. The number of things affected by this is // rather small. - wfWarn( 'Exif class did not have byte order specified. ' - . 'Some properties may be decoded incorrectly.' ); + wfWarn( 'Exif class did not have byte order specified. ' . + 'Some properties may be decoded incorrectly.' ); $this->byteOrder = 'BE'; // BE seems about twice as popular as LE in jpg's. } @@ -322,7 +322,7 @@ class Exif { foreach ( array_keys( $this->mRawExifData ) as $section ) { if ( !in_array( $section, array_keys( $this->mExifTags ) ) ) { - $this->debug( $section , __FUNCTION__, "'$section' is not a valid Exif section" ); + $this->debug( $section, __FUNCTION__, "'$section' is not a valid Exif section" ); continue; } @@ -396,8 +396,8 @@ class Exif { if ( isset ( $this->mFilteredExifData['ComponentsConfiguration'] ) ) { $val = $this->mFilteredExifData['ComponentsConfiguration']; $ccVals = array(); - for ($i = 0; $i < strlen($val); $i++) { - $ccVals[$i] = ord( substr($val, $i, 1) ); + for ( $i = 0; $i < strlen( $val ); $i++ ) { + $ccVals[$i] = ord( substr( $val, $i, 1 ) ); } $ccVals['_type'] = 'ol'; //this is for formatting later. $this->mFilteredExifData['ComponentsConfiguration'] = $ccVals; @@ -413,11 +413,11 @@ class Exif { if ( isset ( $this->mFilteredExifData['GPSVersion'] ) ) { $val = $this->mFilteredExifData['GPSVersion']; $newVal = ''; - for ($i = 0; $i < strlen($val); $i++) { + for ( $i = 0; $i < strlen( $val ); $i++ ) { if ( $i !== 0 ) { $newVal .= '.'; } - $newVal .= ord( substr($val, $i, 1) ); + $newVal .= ord( substr( $val, $i, 1 ) ); } if ( $this->byteOrder === 'LE' ) { // Need to reverse the string @@ -442,17 +442,17 @@ class Exif { private function charCodeString ( $prop ) { if ( isset( $this->mFilteredExifData[$prop] ) ) { - if ( strlen($this->mFilteredExifData[$prop]) <= 8 ) { + if ( strlen( $this->mFilteredExifData[$prop] ) <= 8 ) { //invalid. Must be at least 9 bytes long. - $this->debug( $this->mFilteredExifData[$prop] , __FUNCTION__, false ); - unset($this->mFilteredExifData[$prop]); + $this->debug( $this->mFilteredExifData[$prop], __FUNCTION__, false ); + unset( $this->mFilteredExifData[$prop] ); return; } - $charCode = substr( $this->mFilteredExifData[$prop], 0, 8); - $val = substr( $this->mFilteredExifData[$prop], 8); + $charCode = substr( $this->mFilteredExifData[$prop], 0, 8 ); + $val = substr( $this->mFilteredExifData[$prop], 8 ); - switch ($charCode) { + switch ( $charCode ) { case "\x4A\x49\x53\x00\x00\x00\x00\x00": //JIS $charset = "Shift-JIS"; @@ -466,9 +466,9 @@ class Exif { } // This could possibly check to see if iconv is really installed // or if we're using the compatibility wrapper in globalFunctions.php - if ($charset) { + if ( $charset ) { wfSuppressWarnings(); - $val = iconv($charset, 'UTF-8//IGNORE', $val); + $val = iconv( $charset, 'UTF-8//IGNORE', $val ); wfRestoreWarnings(); } else { // if valid utf-8, assume that, otherwise assume windows-1252 @@ -476,17 +476,17 @@ class Exif { UtfNormal::quickIsNFCVerify( $valCopy ); //validates $valCopy. if ( $valCopy !== $val ) { wfSuppressWarnings(); - $val = iconv('Windows-1252', 'UTF-8//IGNORE', $val); + $val = iconv( 'Windows-1252', 'UTF-8//IGNORE', $val ); wfRestoreWarnings(); } } //trim and check to make sure not only whitespace. - $val = trim($val); + $val = trim( $val ); if ( strlen( $val ) === 0 ) { //only whitespace. - $this->debug( $this->mFilteredExifData[$prop] , __FUNCTION__, "$prop: Is only whitespace" ); - unset($this->mFilteredExifData[$prop]); + $this->debug( $this->mFilteredExifData[$prop], __FUNCTION__, "$prop: Is only whitespace" ); + unset( $this->mFilteredExifData[$prop] ); return; } @@ -580,7 +580,7 @@ class Exif { */ function getFormattedData() { wfDeprecated( __METHOD__, '1.18' ); - if (!$this->mFormattedExifData) { + if ( !$this->mFormattedExifData ) { $this->makeFormattedData(); } return $this->mFormattedExifData; @@ -612,7 +612,7 @@ class Exif { * @return bool */ private function isByte( $in ) { - if ( !is_array( $in ) && sprintf('%d', $in) == $in && $in >= 0 && $in <= 255 ) { + if ( !is_array( $in ) && sprintf( '%d', $in ) == $in && $in >= 0 && $in <= 255 ) { $this->debug( $in, __FUNCTION__, true ); return true; } else { @@ -648,7 +648,7 @@ class Exif { * @return bool */ private function isShort( $in ) { - if ( !is_array( $in ) && sprintf('%d', $in) == $in && $in >= 0 && $in <= 65536 ) { + if ( !is_array( $in ) && sprintf( '%d', $in ) == $in && $in >= 0 && $in <= 65536 ) { $this->debug( $in, __FUNCTION__, true ); return true; } else { @@ -662,7 +662,7 @@ class Exif { * @return bool */ private function isLong( $in ) { - if ( !is_array( $in ) && sprintf('%d', $in) == $in && $in >= 0 && $in <= 4294967296 ) { + if ( !is_array( $in ) && sprintf( '%d', $in ) == $in && $in >= 0 && $in <= 4294967296 ) { $this->debug( $in, __FUNCTION__, true ); return true; } else { diff --git a/includes/media/ExifBitmap.php b/includes/media/ExifBitmap.php index cd7ec198dd..c34e67b81b 100644 --- a/includes/media/ExifBitmap.php +++ b/includes/media/ExifBitmap.php @@ -34,8 +34,8 @@ class ExifBitmapHandler extends BitmapHandler { function convertMetadataVersion( $metadata, $version = 1 ) { // basically flattens arrays. - $version = explode(';', $version, 2); - $version = intval($version[0]); + $version = explode( ';', $version, 2 ); + $version = intval( $version[0] ); if ( $version < 1 || $version >= 2 ) { return $metadata; } @@ -56,7 +56,7 @@ class ExifBitmapHandler extends BitmapHandler { && is_array( $metadata['Software'][0]) && isset( $metadata['Software'][0][0] ) && isset( $metadata['Software'][0][1]) - ) { + ) { $metadata['Software'] = $metadata['Software'][0][0] . ' (Version ' . $metadata['Software'][0][1] . ')'; } @@ -102,11 +102,11 @@ class ExifBitmapHandler extends BitmapHandler { $exif['MEDIAWIKI_EXIF_VERSION'] == 1 ) { //back-compatible but old - wfDebug( __METHOD__.": back-compat version\n" ); + wfDebug( __METHOD__ . ": back-compat version\n" ); return self::METADATA_COMPATIBLE; } # Wrong (non-compatible) version - wfDebug( __METHOD__.": wrong version\n" ); + wfDebug( __METHOD__ . ": wrong version\n" ); return self::METADATA_BAD; } return self::METADATA_GOOD; @@ -163,7 +163,7 @@ class ExifBitmapHandler extends BitmapHandler { $rotation = 0; } - if ($rotation == 90 || $rotation == 270) { + if ( $rotation == 90 || $rotation == 270 ) { $width = $gis[0]; $gis[0] = $gis[1]; $gis[1] = $width; diff --git a/includes/media/FormatMetadata.php b/includes/media/FormatMetadata.php index d44dfd1a33..7109f426f1 100644 --- a/includes/media/FormatMetadata.php +++ b/includes/media/FormatMetadata.php @@ -80,20 +80,20 @@ class FormatMetadata { } //This is done differently as the tag is an array. - if ($tag == 'GPSTimeStamp' && count($vals) === 3) { + if ( $tag == 'GPSTimeStamp' && count( $vals ) === 3) { //hour min sec array - $h = explode('/', $vals[0]); - $m = explode('/', $vals[1]); - $s = explode('/', $vals[2]); + $h = explode( '/', $vals[0] ); + $m = explode( '/', $vals[1] ); + $s = explode( '/', $vals[2] ); // this should already be validated // when loaded from file, but it could // come from a foreign repo, so be // paranoid. - if ( !isset($h[1]) - || !isset($m[1]) - || !isset($s[1]) + if ( !isset( $h[1] ) + || !isset( $m[1] ) + || !isset( $s[1] ) || $h[1] == 0 || $m[1] == 0 || $s[1] == 0 @@ -631,7 +631,7 @@ class FormatMetadata { case 'MaxApertureValue': if ( strpos( $val, '/' ) !== false ) { // need to expand this earlier to calculate fNumber - list($n, $d) = explode('/', $val); + list( $n, $d ) = explode( '/', $val ); if ( is_numeric( $n ) && is_numeric( $d ) ) { $val = $n / $d; } @@ -809,7 +809,7 @@ class FormatMetadata { case 'LanguageCode': $lang = Language::fetchLanguageName( strtolower( $val ), $wgLang->getCode() ); - if ($lang) { + if ( $lang ) { $val = htmlspecialchars( $lang ); } else { $val = htmlspecialchars( $val ); @@ -850,7 +850,7 @@ class FormatMetadata { } if ( !is_array( $vals ) ) { - return $vals; // do nothing if not an array; + return $vals; // do nothing if not an array; } elseif ( count( $vals ) === 1 && $type !== 'lang' ) { return $vals[0]; @@ -899,7 +899,7 @@ class FormatMetadata { } $content .= self::langItem( $vals[$cLang], $cLang, - $isDefault, $noHtml ); + $isDefault, $noHtml ); unset( $vals[$cLang] ); } @@ -915,8 +915,8 @@ class FormatMetadata { } if ( $defaultItem !== false ) { $content = self::langItem( $defaultItem, - $defaultLang, true, $noHtml ) - . $content; + $defaultLang, true, $noHtml ) . + $content; } if ( $noHtml ) { return $content; @@ -951,8 +951,8 @@ class FormatMetadata { */ private static function langItem( $value, $lang, $default = false, $noHtml = false ) { if ( $lang === false && $default === false) { - throw new MWException('$lang and $default cannot both ' - . 'be false.'); + throw new MWException( '$lang and $default cannot both ' + . 'be false.' ); } if ( $noHtml ) { @@ -1017,7 +1017,7 @@ class FormatMetadata { static function msg( $tag, $val, $arg = null, $arg2 = null ) { global $wgContLang; - if ($val === '') + if ( $val === '' ) $val = 'value'; return wfMessage( $wgContLang->lc( "exif-$tag-$val" ), $arg, $arg2 )->text(); } @@ -1033,10 +1033,10 @@ class FormatMetadata { static function formatNum( $num, $round = false ) { global $wgLang; $m = array(); - if( is_array($num) ) { + if( is_array( $num ) ) { $out = array(); foreach( $num as $number ) { - $out[] = self::formatNum($number); + $out[] = self::formatNum( $number ); } return $wgLang->commaList( $out ); } @@ -1126,7 +1126,7 @@ class FormatMetadata { return $val; } $cat = ''; - switch( substr( $val , 0, 2 ) ) { + switch( substr( $val, 0, 2 ) ) { case '01': $cat = 'ace'; break; @@ -1238,7 +1238,7 @@ class FormatMetadata { * @return String of html-ish looking wikitext */ public static function collapseContactInfo( $vals ) { - if( ! ( isset( $vals['CiAdrExtadr'] ) + if( !( isset( $vals['CiAdrExtadr'] ) || isset( $vals['CiAdrCity'] ) || isset( $vals['CiAdrCtry'] ) || isset( $vals['CiEmailWork'] ) diff --git a/includes/media/GIF.php b/includes/media/GIF.php index da8fc6f87b..2e532feb9a 100644 --- a/includes/media/GIF.php +++ b/includes/media/GIF.php @@ -39,7 +39,7 @@ class GIFHandler extends BitmapHandler { return self::BROKEN_FILE; } - return serialize($parsedGIFMetadata); + return serialize( $parsedGIFMetadata ); } /** @@ -53,7 +53,7 @@ class GIFHandler extends BitmapHandler { return false; } $meta = unserialize( $meta ); - if ( !isset( $meta['metadata'] ) || count( $meta['metadata'] ) <= 1 ) { + if ( !isset( $meta['metadata'] ) || count( $meta['metadata'] ) <= 1 ) { return false; } @@ -85,7 +85,7 @@ class GIFHandler extends BitmapHandler { function isAnimatedImage( $image ) { $ser = $image->getMetadata(); if ( $ser ) { - $metadata = unserialize($ser); + $metadata = unserialize( $ser ); if( $metadata['frameCount'] > 1 ) { return true; } @@ -119,13 +119,13 @@ class GIFHandler extends BitmapHandler { wfRestoreWarnings(); if ( !$data || !is_array( $data ) ) { - wfDebug(__METHOD__ . ' invalid GIF metadata' ); + wfDebug( __METHOD__ . ' invalid GIF metadata' ); return self::METADATA_BAD; } if ( !isset( $data['metadata']['_MW_GIF_VERSION'] ) || $data['metadata']['_MW_GIF_VERSION'] != GIFMetadataExtractor::VERSION ) { - wfDebug(__METHOD__ . ' old but compatible GIF metadata' ); + wfDebug( __METHOD__ . ' old but compatible GIF metadata' ); return self::METADATA_COMPATIBLE; } return self::METADATA_GOOD; @@ -141,10 +141,10 @@ class GIFHandler extends BitmapHandler { $original = parent::getLongDesc( $image ); wfSuppressWarnings(); - $metadata = unserialize($image->getMetadata()); + $metadata = unserialize( $image->getMetadata() ); wfRestoreWarnings(); - if (!$metadata || $metadata['frameCount'] <= 1) { + if ( !$metadata || $metadata['frameCount'] <= 1 ) { return $original; } diff --git a/includes/media/GIFMetadataExtractor.php b/includes/media/GIFMetadataExtractor.php index 7a162c3fcb..8b44585b5a 100644 --- a/includes/media/GIFMetadataExtractor.php +++ b/includes/media/GIFMetadataExtractor.php @@ -49,9 +49,9 @@ class GIFMetadataExtractor { * @return array */ static function getMetadata( $filename ) { - self::$gif_frame_sep = pack( "C", ord("," ) ); - self::$gif_extension_sep = pack( "C", ord("!" ) ); - self::$gif_term = pack( "C", ord(";" ) ); + self::$gif_frame_sep = pack( "C", ord( "," ) ); + self::$gif_extension_sep = pack( "C", ord( "!" ) ); + self::$gif_term = pack( "C", ord( ";" ) ); $frameCount = 0; $duration = 0.0; @@ -73,7 +73,7 @@ class GIFMetadataExtractor { // Check for the GIF header $buf = fread( $fh, 6 ); - if ( !($buf == 'GIF87a' || $buf == 'GIF89a') ) { + if ( !( $buf == 'GIF87a' || $buf == 'GIF89a' ) ) { throw new Exception( "Not a valid GIF file; header: $buf" ); } @@ -93,7 +93,7 @@ class GIFMetadataExtractor { while( !feof( $fh ) ) { $buf = fread( $fh, 1 ); - if ($buf == self::$gif_frame_sep) { + if ( $buf == self::$gif_frame_sep ) { // Found a frame $frameCount++; @@ -114,7 +114,7 @@ class GIFMetadataExtractor { $extension_code = unpack( 'C', $buf ); $extension_code = $extension_code[1]; - if ($extension_code == 0xF9) { + if ( $extension_code == 0xF9 ) { // Graphics Control Extension. fread( $fh, 1 ); // Block size @@ -132,10 +132,10 @@ class GIFMetadataExtractor { if ( strlen( $term ) < 1 ) throw new Exception( "Ran out of input" ); $term = unpack( 'C', $term ); $term = $term[1]; - if ($term != 0 ) { + if ( $term != 0 ) { throw new Exception( "Malformed Graphics Control Extension block" ); } - } elseif ($extension_code == 0xFE) { + } elseif ( $extension_code == 0xFE ) { // Comment block(s). $data = self::readBlock( $fh ); if ( $data === "" ) { @@ -164,7 +164,7 @@ class GIFMetadataExtractor { // is identical to the last, only extract once. $comment[] = $data; } - } elseif ($extension_code == 0xFF) { + } elseif ( $extension_code == 0xFF ) { // Application extension (Netscape info about the animated gif) // or XMP (or theoretically any other type of extension block) $blockLength = fread( $fh, 1 ); @@ -173,7 +173,7 @@ class GIFMetadataExtractor { $blockLength = $blockLength[1]; $data = fread( $fh, $blockLength ); - if ($blockLength != 11 ) { + if ( $blockLength != 11 ) { wfDebug( __METHOD__ . ' GIF application block with wrong length' ); fseek( $fh, -($blockLength + 1), SEEK_CUR ); self::skipBlock( $fh ); @@ -184,7 +184,7 @@ class GIFMetadataExtractor { if ( $data == 'NETSCAPE2.0' ) { $data = fread( $fh, 2 ); // Block length and introduction, should be 03 01 - if ($data != "\x03\x01") { + if ( $data != "\x03\x01" ) { throw new Exception( "Expected \x03\x01, got $data" ); } @@ -194,7 +194,7 @@ class GIFMetadataExtractor { $loopData = unpack( 'v', $loopData ); $loopCount = $loopData[1]; - if ($loopCount != 1) { + if ( $loopCount != 1 ) { $isLooped = true; } @@ -231,7 +231,7 @@ class GIFMetadataExtractor { if ( strlen( $buf ) < 1 ) throw new Exception( "Ran out of input" ); $byte = unpack( 'C', $buf ); $byte = $byte[1]; - throw new Exception( "At position: ".ftell($fh). ", Unknown byte ".$byte ); + throw new Exception( "At position: " . ftell( $fh ) . ", Unknown byte " . $byte ); } } @@ -284,7 +284,7 @@ class GIFMetadataExtractor { if ( strlen( $buf ) < 1 ) throw new Exception( "Ran out of input" ); $block_len = unpack( 'C', $buf ); $block_len = $block_len[1]; - if ($block_len == 0) { + if ( $block_len == 0 ) { return; } fread( $fh, $block_len ); diff --git a/includes/media/IPTC.php b/includes/media/IPTC.php index 8fd3552fa4..3ae59ade6b 100644 --- a/includes/media/IPTC.php +++ b/includes/media/IPTC.php @@ -41,15 +41,15 @@ class IPTC { static function parse( $rawData ) { $parsed = iptcparse( $rawData ); $data = Array(); - if (!is_array($parsed)) { + if ( !is_array( $parsed ) ) { return $data; } $c = ''; //charset info contained in tag 1:90. - if (isset($parsed['1#090']) && isset($parsed['1#090'][0])) { - $c = self::getCharset($parsed['1#090'][0]); - if ($c === false) { + if ( isset( $parsed['1#090'] ) && isset( $parsed['1#090'][0] ) ) { + $c = self::getCharset( $parsed['1#090'][0] ); + if ( $c === false ) { //Unknown charset. refuse to parse. //note: There is a different between //unknown and no charset specified. @@ -59,8 +59,8 @@ class IPTC { } foreach ( $parsed as $tag => $val ) { - if ( isset( $val[0] ) && trim($val[0]) == '' ) { - wfDebugLog('iptc', "IPTC tag $tag had only whitespace as its value."); + if ( isset( $val[0] ) && trim( $val[0] ) == '' ) { + wfDebugLog( 'iptc', "IPTC tag $tag had only whitespace as its value." ); continue; } switch( $tag ) { @@ -175,7 +175,7 @@ class IPTC { if ( isset( $parsed['2#070'] ) ) { //if a version is set for the software. $softwareVersion = self::convIPTC( $parsed['2#070'], $c ); - unset($parsed['2#070']); + unset( $parsed['2#070'] ); $data['Software'] = array( array( $software[0], $softwareVersion[0] ) ); } else { $data['Software'] = $software; @@ -227,8 +227,8 @@ class IPTC { } else { $time = Array(); } - $timestamp = self::timeHelper( $val, $time, $c ); - if ($timestamp) { + $timestamp = self::timeHelper( $val, $time, $c ); + if ( $timestamp ) { $data['DateTimeOriginal'] = $timestamp; } break; @@ -241,8 +241,8 @@ class IPTC { } else { $time = Array(); } - $timestamp = self::timeHelper( $val, $time, $c ); - if ($timestamp) { + $timestamp = self::timeHelper( $val, $time, $c ); + if ( $timestamp ) { $data['DateTimeDigitized'] = $timestamp; } break; @@ -254,8 +254,8 @@ class IPTC { } else { $time = Array(); } - $timestamp = self::timeHelper( $val, $time, $c ); - if ($timestamp) { + $timestamp = self::timeHelper( $val, $time, $c ); + if ( $timestamp ) { $data['DateTimeReleased'] = $timestamp; } break; @@ -267,8 +267,8 @@ class IPTC { } else { $time = Array(); } - $timestamp = self::timeHelper( $val, $time, $c ); - if ($timestamp) { + $timestamp = self::timeHelper( $val, $time, $c ); + if ( $timestamp ) { $data['DateTimeExpires'] = $timestamp; } break; @@ -313,7 +313,7 @@ class IPTC { // describing the subject matter of the content. $codes = self::convIPTC( $val, $c ); foreach ( $codes as $ic ) { - $fields = explode(':', $ic, 3 ); + $fields = explode( ':', $ic, 3 ); if ( count( $fields ) < 2 || $fields[0] !== 'IPTC' ) @@ -362,25 +362,25 @@ class IPTC { if ( count( $date ) === 1 ) { //the standard says this should always be 1 //just double checking. - list($date) = self::convIPTC( $date, $c ); + list( $date ) = self::convIPTC( $date, $c ); } else { return null; } if ( count( $time ) === 1 ) { - list($time) = self::convIPTC( $time, $c ); + list( $time ) = self::convIPTC( $time, $c ); $dateOnly = false; } else { $time = '000000+0000'; //placeholder $dateOnly = true; } - if ( ! ( preg_match('/\d\d\d\d\d\d[-+]\d\d\d\d/', $time) + if ( !( preg_match('/\d\d\d\d\d\d[-+]\d\d\d\d/', $time) && preg_match('/\d\d\d\d\d\d\d\d/', $date) - && substr($date, 0, 4) !== '0000' - && substr($date, 4, 2) !== '00' - && substr($date, 6, 2) !== '00' - ) ) { + && substr( $date, 0, 4 ) !== '0000' + && substr( $date, 4, 2 ) !== '00' + && substr( $date, 6, 2 ) !== '00' + ) ) { //something wrong. // Note, this rejects some valid dates according to iptc spec // for example: the date 00000400 means the photo was taken in @@ -425,7 +425,7 @@ class IPTC { */ private static function convIPTC ( $data, $charset ) { if ( is_array( $data ) ) { - foreach ($data as &$val) { + foreach ( $data as &$val ) { $val = self::convIPTCHelper( $val, $charset ); } } else { @@ -444,18 +444,18 @@ class IPTC { private static function convIPTCHelper ( $data, $charset ) { if ( $charset ) { wfSuppressWarnings(); - $data = iconv($charset, "UTF-8//IGNORE", $data); + $data = iconv( $charset, "UTF-8//IGNORE", $data ); wfRestoreWarnings(); - if ($data === false) { + if ( $data === false ) { $data = ""; - wfDebugLog('iptc', __METHOD__ . " Error converting iptc data charset $charset to utf-8"); + wfDebugLog( 'iptc', __METHOD__ . " Error converting iptc data charset $charset to utf-8" ); } } else { //treat as utf-8 if is valid utf-8. otherwise pretend its windows-1252 // most of the time if there is no 1:90 tag, it is either ascii, latin1, or utf-8 $oldData = $data; UtfNormal::quickIsNFCVerify( $data ); //make $data valid utf-8 - if ($data === $oldData) { + if ( $data === $oldData ) { return $data; //if validation didn't change $data } else { return self::convIPTCHelper( $oldData, 'Windows-1252' ); @@ -472,7 +472,7 @@ class IPTC { * all iso 2022 escape codes. In practise, the code for utf-8 is the * only code that seems to have wide use. It does detect that code. */ - static function getCharset($tag) { + static function getCharset( $tag ) { //According to iim standard, charset is defined by the tag 1:90. //in which there are iso 2022 escape sequences to specify the character set. @@ -590,7 +590,7 @@ class IPTC { $c = 'CSN_369103'; break; default: - wfDebugLog('iptc', __METHOD__ . 'Unknown charset in iptc 1:90: ' . bin2hex( $tag ) ); + wfDebugLog( 'iptc', __METHOD__ . 'Unknown charset in iptc 1:90: ' . bin2hex( $tag ) ); //at this point just give up and refuse to parse iptc? $c = false; } diff --git a/includes/media/ImageHandler.php b/includes/media/ImageHandler.php index d1de0ae847..472372c37c 100644 --- a/includes/media/ImageHandler.php +++ b/includes/media/ImageHandler.php @@ -162,11 +162,11 @@ abstract class ImageHandler extends MediaHandler { # Sanity check $width if( $width <= 0) { - wfDebug( __METHOD__.": Invalid destination width: $width\n" ); + wfDebug( __METHOD__ . ": Invalid destination width: $width\n" ); return false; } if ( $srcWidth <= 0 ) { - wfDebug( __METHOD__.": Invalid source width: $srcWidth\n" ); + wfDebug( __METHOD__ . ": Invalid source width: $srcWidth\n" ); return false; } diff --git a/includes/media/Jpeg.php b/includes/media/Jpeg.php index 86f5030d02..5ea30f204d 100644 --- a/includes/media/Jpeg.php +++ b/includes/media/Jpeg.php @@ -37,7 +37,7 @@ class JpegHandler extends ExifBitmapHandler { $meta = BitmapMetadataHandler::Jpeg( $filename ); if ( !is_array( $meta ) ) { // This should never happen, but doesn't hurt to be paranoid. - throw new MWException('Metadata array is not an array'); + throw new MWException( 'Metadata array is not an array' ); } $meta['MEDIAWIKI_EXIF_VERSION'] = Exif::version(); return serialize( $meta ); diff --git a/includes/media/MediaHandler.php b/includes/media/MediaHandler.php index dd764e9ad1..fb305db4cf 100644 --- a/includes/media/MediaHandler.php +++ b/includes/media/MediaHandler.php @@ -135,9 +135,9 @@ abstract class MediaHandler { */ static function getMetadataVersion () { $version = Array( '2' ); // core metadata version - wfRunHooks('GetMetadataVersion', Array(&$version)); + wfRunHooks( 'GetMetadataVersion', Array( &$version ) ); return implode( ';', $version); - } + } /** * Convert metadata version. @@ -365,7 +365,7 @@ abstract class MediaHandler { * @return array for use displaying metadata. */ function formatMetadataHelper( $metadataArray ) { - $result = array( + $result = array( 'visible' => array(), 'collapsed' => array() ); diff --git a/includes/media/MediaTransformOutput.php b/includes/media/MediaTransformOutput.php index 110c65989b..1fbe029e43 100644 --- a/includes/media/MediaTransformOutput.php +++ b/includes/media/MediaTransformOutput.php @@ -198,10 +198,10 @@ abstract class MediaTransformOutput { public function getDescLinkAttribs( $title = null, $params = '' ) { $query = ''; if ( $this->page && $this->page !== 1 ) { - $query = 'page=' . urlencode( $this->page ); + $query = 'page=' . urlencode( $this->page ); } if( $params ) { - $query .= $query ? '&'.$params : $params; + $query .= $query ? '&' . $params : $params; } $attribs = array( 'href' => $this->file->getTitle()->getLocalURL( $query ), @@ -301,7 +301,7 @@ class ThumbnailImage extends MediaTransformOutput { $alt = empty( $options['alt'] ) ? '' : $options['alt']; - $query = empty( $options['desc-query'] ) ? '' : $options['desc-query']; + $query = empty( $options['desc-query'] ) ? '' : $options['desc-query']; if ( !empty( $options['custom-url-link'] ) ) { $linkAttribs = array( 'href' => $options['custom-url-link'] ); @@ -404,7 +404,7 @@ class MediaTransformError extends MediaTransformOutput { class TransformParameterError extends MediaTransformError { function __construct( $params ) { parent::__construct( 'thumbnail_error', - max( isset( $params['width'] ) ? $params['width'] : 0, 120 ), + max( isset( $params['width'] ) ? $params['width'] : 0, 120 ), max( isset( $params['height'] ) ? $params['height'] : 0, 120 ), wfMessage( 'thumbnail_invalid_params' )->text() ); } diff --git a/includes/media/PNG.php b/includes/media/PNG.php index a23821f4fb..b8a5b40b2d 100644 --- a/includes/media/PNG.php +++ b/includes/media/PNG.php @@ -44,7 +44,7 @@ class PNGHandler extends BitmapHandler { return self::BROKEN_FILE; } - return serialize($metadata); + return serialize( $metadata ); } /** @@ -74,8 +74,8 @@ class PNGHandler extends BitmapHandler { */ function isAnimatedImage( $image ) { $ser = $image->getMetadata(); - if ($ser) { - $metadata = unserialize($ser); + if ( $ser ) { + $metadata = unserialize( $ser ); if( $metadata['frameCount'] > 1 ) return true; } return false; @@ -105,13 +105,13 @@ class PNGHandler extends BitmapHandler { wfRestoreWarnings(); if ( !$data || !is_array( $data ) ) { - wfDebug(__METHOD__ . ' invalid png metadata' ); + wfDebug( __METHOD__ . ' invalid png metadata' ); return self::METADATA_BAD; } if ( !isset( $data['metadata']['_MW_PNG_VERSION'] ) || $data['metadata']['_MW_PNG_VERSION'] != PNGMetadataExtractor::VERSION ) { - wfDebug(__METHOD__ . ' old but compatible png metadata' ); + wfDebug( __METHOD__ . ' old but compatible png metadata' ); return self::METADATA_COMPATIBLE; } return self::METADATA_GOOD; @@ -126,7 +126,7 @@ class PNGHandler extends BitmapHandler { $original = parent::getLongDesc( $image ); wfSuppressWarnings(); - $metadata = unserialize($image->getMetadata()); + $metadata = unserialize( $image->getMetadata() ); wfRestoreWarnings(); if( !$metadata || $metadata['frameCount'] <= 0 ) diff --git a/includes/media/SVG.php b/includes/media/SVG.php index f7e988f0e7..cddab51d91 100644 --- a/includes/media/SVG.php +++ b/includes/media/SVG.php @@ -170,14 +170,14 @@ class SvgHandler extends ImageHandler { $cmd = str_replace( array( '$path/', '$width', '$height', '$input', '$output' ), array( $wgSVGConverterPath ? wfEscapeShellArg( "$wgSVGConverterPath/" ) : "", - intval( $width ), - intval( $height ), - wfEscapeShellArg( $srcPath ), - wfEscapeShellArg( $dstPath ) ), + intval( $width ), + intval( $height ), + wfEscapeShellArg( $srcPath ), + wfEscapeShellArg( $dstPath ) ), $wgSVGConverters[$wgSVGConverter] ) . " 2>&1"; wfProfileIn( 'rsvg' ); - wfDebug( __METHOD__.": $cmd\n" ); + wfDebug( __METHOD__ . ": $cmd\n" ); $err = wfShellExec( $cmd, $retval ); wfProfileOut( 'rsvg' ); } @@ -185,7 +185,7 @@ class SvgHandler extends ImageHandler { $removed = $this->removeBadFile( $dstPath, $retval ); if ( $retval != 0 || $removed ) { wfDebugLog( 'thumbnail', sprintf( 'thumbnail failed on %s: error %d "%s" from "%s"', - wfHostname(), $retval, trim($err), $cmd ) ); + wfHostname(), $retval, trim( $err ), $cmd ) ); return new MediaTransformError( 'thumbnail_error', $width, $height, $err ); } return true; diff --git a/includes/media/SVGMetadataExtractor.php b/includes/media/SVGMetadataExtractor.php index d6624eecd4..e4235a749c 100644 --- a/includes/media/SVGMetadataExtractor.php +++ b/includes/media/SVGMetadataExtractor.php @@ -67,7 +67,7 @@ class SVGReader { if ( $size > $wgSVGMetadataCutoff ) { $this->debug( "SVG is $size bytes, which is bigger than $wgSVGMetadataCutoff. Truncating." ); $contents = file_get_contents( $source, false, null, -1, $wgSVGMetadataCutoff ); - if ($contents === false) { + if ( $contents === false ) { throw new MWException( 'Error reading SVG file.' ); } $this->reader->XML( $contents, null, LIBXML_NOERROR | LIBXML_NOWARNING ); @@ -132,7 +132,7 @@ class SVGReader { $this->debug( " tag is correct." ); $this->handleSVGAttribs(); - $exitDepth = $this->reader->depth; + $exitDepth = $this->reader->depth; $keepReading = $this->reader->read(); while ( $keepReading ) { $tag = $this->reader->localName; @@ -227,7 +227,7 @@ class SVGReader { if ( $this->reader->isEmptyElement ) { return; } - $exitDepth = $this->reader->depth; + $exitDepth = $this->reader->depth; $keepReading = $this->reader->read(); while( $keepReading ) { if( $this->reader->localName == $name && $this->reader->depth <= $exitDepth @@ -285,9 +285,9 @@ class SVGReader { $width = null; $height = null; - if( $this->reader->getAttribute('viewBox') ) { + if( $this->reader->getAttribute( 'viewBox' ) ) { // min-x min-y width height - $viewBox = preg_split( '/\s+/', trim( $this->reader->getAttribute('viewBox') ) ); + $viewBox = preg_split( '/\s+/', trim( $this->reader->getAttribute( 'viewBox' ) ) ); if( count( $viewBox ) == 4 ) { $viewWidth = $this->scaleSVGUnit( $viewBox[2] ); $viewHeight = $this->scaleSVGUnit( $viewBox[3] ); @@ -297,12 +297,12 @@ class SVGReader { } } } - if( $this->reader->getAttribute('width') ) { - $width = $this->scaleSVGUnit( $this->reader->getAttribute('width'), $defaultWidth ); + if( $this->reader->getAttribute( 'width' ) ) { + $width = $this->scaleSVGUnit( $this->reader->getAttribute( 'width' ), $defaultWidth ); $this->metadata['originalWidth'] = $this->reader->getAttribute( 'width' ); } - if( $this->reader->getAttribute('height') ) { - $height = $this->scaleSVGUnit( $this->reader->getAttribute('height'), $defaultHeight ); + if( $this->reader->getAttribute( 'height' ) ) { + $height = $this->scaleSVGUnit( $this->reader->getAttribute( 'height' ), $defaultHeight ); $this->metadata['originalHeight'] = $this->reader->getAttribute( 'height' ); } @@ -329,7 +329,7 @@ class SVGReader { * @param $viewportSize: Float optional scale for percentage units... * @return float: length in pixels */ - static function scaleSVGUnit( $length, $viewportSize=512 ) { + static function scaleSVGUnit( $length, $viewportSize = 512 ) { static $unitLength = array( 'px' => 1.0, 'pt' => 1.25, diff --git a/includes/media/Tiff.php b/includes/media/Tiff.php index 55dff77b07..0042208bbb 100644 --- a/includes/media/Tiff.php +++ b/includes/media/Tiff.php @@ -82,7 +82,7 @@ class TiffHandler extends ExifBitmapHandler { $meta = BitmapMetadataHandler::Tiff( $filename ); if ( !is_array( $meta ) ) { // This should never happen, but doesn't hurt to be paranoid. - throw new MWException('Metadata array is not an array'); + throw new MWException( 'Metadata array is not an array' ); } $meta['MEDIAWIKI_EXIF_VERSION'] = Exif::version(); return serialize( $meta ); diff --git a/includes/media/XCF.php b/includes/media/XCF.php index 555fa1fb71..ba0d41983f 100644 --- a/includes/media/XCF.php +++ b/includes/media/XCF.php @@ -84,7 +84,7 @@ class XCFHandler extends BitmapHandler { # The image structure always starts at offset 0 in the XCF file. # So we just read it :-) $binaryHeader = fread( $f, 26 ); - fclose($f); + fclose( $f ); # Master image structure: # diff --git a/includes/media/XMP.php b/includes/media/XMP.php index c5743d7286..e4833fc5cd 100644 --- a/includes/media/XMP.php +++ b/includes/media/XMP.php @@ -114,7 +114,7 @@ class XMPReader { */ private function resetXMLParser() { - if ($this->xmlParser) { + if ( $this->xmlParser ) { //is this needed? xml_parser_free( $this->xmlParser ); } @@ -156,7 +156,7 @@ class XMPReader { $data = $this->results; - wfRunHooks('XMPGetResults', Array(&$data)); + wfRunHooks( 'XMPGetResults', Array( &$data ) ); if ( isset( $data['xmp-special']['AuthorsPosition'] ) && is_string( $data['xmp-special']['AuthorsPosition'] ) @@ -201,7 +201,7 @@ class XMPReader { // To avoid copying over the _type meta-fields. continue; } - foreach( $loc as $field => $val ) { + foreach( $loc as $field => $val ) { $data['xmp-general'][$field . 'Created'][] = $val; } } @@ -255,7 +255,7 @@ class XMPReader { if ( !$this->charset ) { $bom = array(); if ( preg_match( '/\xEF\xBB\xBF|\xFE\xFF|\x00\x00\xFE\xFF|\xFF\xFE\x00\x00|\xFF\xFE/', - $content, $bom ) + $content, $bom ) ) { switch ( $bom[0] ) { case "\xFE\xFF": @@ -275,7 +275,7 @@ class XMPReader { break; default: //this should be impossible to get to - throw new MWException("Invalid BOM"); + throw new MWException( "Invalid BOM" ); break; } @@ -324,13 +324,13 @@ class XMPReader { $guid = substr( $content, 0, 32 ); if ( !isset( $this->results['xmp-special']['HasExtendedXMP'] ) || $this->results['xmp-special']['HasExtendedXMP'] !== $guid ) { - wfDebugLog('XMP', __METHOD__ . " Ignoring XMPExtended block due to wrong guid (guid= '$guid' )"); + wfDebugLog( 'XMP', __METHOD__ . " Ignoring XMPExtended block due to wrong guid (guid= '$guid')" ); return false; } - $len = unpack( 'Nlength/Noffset', substr( $content, 32, 8 ) ); + $len = unpack( 'Nlength/Noffset', substr( $content, 32, 8 ) ); - if (!$len || $len['length'] < 4 || $len['offset'] < 0 || $len['offset'] > $len['length'] ) { - wfDebugLog('XMP', __METHOD__ . 'Error reading extended XMP block, invalid length or offset.'); + if ( !$len || $len['length'] < 4 || $len['offset'] < 0 || $len['offset'] > $len['length'] ) { + wfDebugLog( 'XMP', __METHOD__ . 'Error reading extended XMP block, invalid length or offset.' ); return false; } @@ -345,8 +345,8 @@ class XMPReader { // so the probability that it will have > 128k, and be in the wrong order is very low... if ( $len['offset'] !== $this->extendedXMPOffset ) { - wfDebugLog('XMP', __METHOD__ . 'Ignoring XMPExtended block due to wrong order. (Offset was ' - . $len['offset'] . ' but expected ' . $this->extendedXMPOffset . ')'); + wfDebugLog( 'XMP', __METHOD__ . 'Ignoring XMPExtended block due to wrong order. (Offset was ' + . $len['offset'] . ' but expected ' . $this->extendedXMPOffset . ')' ); return false; } @@ -366,7 +366,7 @@ class XMPReader { $atEnd = false; } - wfDebugLog('XMP', __METHOD__ . 'Parsing a XMPExtended block'); + wfDebugLog( 'XMP', __METHOD__ . 'Parsing a XMPExtended block' ); return $this->parse( $actualContent, $atEnd ); } @@ -488,7 +488,7 @@ class XMPReader { if ( $this->curItem[0] !== $elm && !( $elm === self::NS_RDF . ' Description' && $this->mode[0] === self::MODE_STRUCT ) - ) { + ) { throw new MWException( "nesting mismatch. got a but expected a curItem[0] . '>' ); } diff --git a/includes/media/XMPInfo.php b/includes/media/XMPInfo.php index aa411dfdf9..a4ba741dd3 100644 --- a/includes/media/XMPInfo.php +++ b/includes/media/XMPInfo.php @@ -35,7 +35,7 @@ class XMPInfo { if( !self::$ranHooks ) { // This is for if someone makes a custom metadata extension. // For example, a medical wiki might want to decode DICOM xmp properties. - wfRunHooks('XMPGetInfo', Array(&self::$items)); + wfRunHooks( 'XMPGetInfo', Array( &self::$items ) ); self::$ranHooks = true; // Only want to do this once. } return self::$items; @@ -260,7 +260,7 @@ class XMPInfo { 'mode' => XMPReader::MODE_SIMPLE, 'validate' => 'validateDate', ), - 'DateTimeDigitized' => array( /* xmp:CreateDate */ + 'DateTimeDigitized' => array( /* xmp:CreateDate */ 'map_group' => 'exif', 'mode' => XMPReader::MODE_SIMPLE, 'validate' => 'validateDate', @@ -552,12 +552,12 @@ class XMPInfo { 'map_group' => 'exif', 'mode' => XMPReader::MODE_LANG, ), - 'DateTime' => array( /* proper prop is xmp:ModifyDate */ + 'DateTime' => array( /* proper prop is xmp:ModifyDate */ 'map_group' => 'exif', 'mode' => XMPReader::MODE_SIMPLE, 'validate' => 'validateDate', ), - 'ImageDescription' => array( /* proper one is dc:description */ + 'ImageDescription' => array( /* proper one is dc:description */ 'map_group' => 'exif', 'mode' => XMPReader::MODE_LANG, ), @@ -622,7 +622,7 @@ class XMPInfo { 'mode' => XMPReader::MODE_SIMPLE, 'validate' => 'validateInteger', ), - 'Software' => array( /* see xmp:CreatorTool */ + 'Software' => array( /* see xmp:CreatorTool */ 'map_group' => 'exif', 'mode' => XMPReader::MODE_SIMPLE, ), diff --git a/includes/media/XMPValidate.php b/includes/media/XMPValidate.php index e3fd59fdad..59547e5fd1 100644 --- a/includes/media/XMPValidate.php +++ b/includes/media/XMPValidate.php @@ -95,8 +95,8 @@ class XMPValidate { return; } if ( !preg_match( '/^[-+]?\d*(?:\.?\d*)$/D', $val ) - || !is_numeric($val) - ) { + || !is_numeric( $val ) + ) { wfDebugLog( 'XMP', __METHOD__ . " Expected rating but got $val" ); $val = null; return; @@ -247,8 +247,8 @@ class XMPValidate { $res = array(); if ( !preg_match( /* ahh! scary regex... */ - '/^([0-3]\d{3})(?:-([01]\d)(?:-([0-3]\d)(?:T([0-2]\d):([0-6]\d)(?::([0-6]\d)(?:\.\d+)?)?([-+]\d{2}:\d{2}|Z)?)?)?)?$/D' - , $val, $res) + '/^([0-3]\d{3})(?:-([01]\d)(?:-([0-3]\d)(?:T([0-2]\d):([0-6]\d)(?::([0-6]\d)(?:\.\d+)?)?([-+]\d{2}:\d{2}|Z)?)?)?)?$/D', + $val, $res ) ) { wfDebugLog( 'XMP', __METHOD__ . " Expected date but got $val" ); $val = null; diff --git a/includes/parser/CoreLinkFunctions.php b/includes/parser/CoreLinkFunctions.php index 4bfa9d35da..1cabf766aa 100644 --- a/includes/parser/CoreLinkFunctions.php +++ b/includes/parser/CoreLinkFunctions.php @@ -47,15 +47,15 @@ class CoreLinkFunctions { */ static function defaultLinkHook( $parser, $holders, $markers, Title $title, $titleText, &$displayText = null, &$leadingColon = false ) { - if( isset($displayText) && $markers->findMarker( $displayText ) ) { + if( isset( $displayText ) && $markers->findMarker( $displayText ) ) { # There are links inside of the displayText # For backwards compatibility the deepest links are dominant so this # link should not be handled - $displayText = $markers->expand($displayText); + $displayText = $markers->expand( $displayText ); # Return false so that this link is reverted back to WikiText return false; } - return $holders->makeHolder( $title, isset($displayText) ? $displayText : $titleText, array(), '', '' ); + return $holders->makeHolder( $title, isset( $displayText ) ? $displayText : $titleText, array(), '', '' ); } /** @@ -73,15 +73,15 @@ class CoreLinkFunctions { global $wgContLang; # When a category link starts with a : treat it as a normal link if( $leadingColon ) return true; - if( isset($sortText) && $markers->findMarker( $sortText ) ) { + if( isset( $sortText ) && $markers->findMarker( $sortText ) ) { # There are links inside of the sortText # For backwards compatibility the deepest links are dominant so this # link should not be handled - $sortText = $markers->expand($sortText); + $sortText = $markers->expand( $sortText ); # Return false so that this link is reverted back to WikiText return false; } - if( !isset($sortText) ) $sortText = $parser->getDefaultSort(); + if( !isset( $sortText ) ) $sortText = $parser->getDefaultSort(); $sortText = Sanitizer::decodeCharReferences( $sortText ); $sortText = str_replace( "\n", '', $sortText ); $sortText = $wgContLang->convertCategoryKey( $sortText ); diff --git a/includes/parser/CoreParserFunctions.php b/includes/parser/CoreParserFunctions.php index b77309b987..b2a72a4155 100644 --- a/includes/parser/CoreParserFunctions.php +++ b/includes/parser/CoreParserFunctions.php @@ -422,7 +422,7 @@ class CoreParserFunctions { return self::formatRaw( SiteStats::images(), $raw ); } static function numberofadmins( $parser, $raw = null ) { - return self::formatRaw( SiteStats::numberingroup('sysop'), $raw ); + return self::formatRaw( SiteStats::numberingroup( 'sysop' ), $raw ); } static function numberofedits( $parser, $raw = null ) { return self::formatRaw( SiteStats::edits(), $raw ); @@ -800,7 +800,7 @@ class CoreParserFunctions { // Usage {{filepath|300}}, {{filepath|nowiki}}, {{filepath|nowiki|300}} or {{filepath|300|nowiki}} // or {{filepath|300px}}, {{filepath|200x300px}}, {{filepath|nowiki|200x300px}}, {{filepath|200x300px|nowiki}} - public static function filepath( $parser, $name='', $argA='', $argB='' ) { + public static function filepath( $parser, $name = '', $argA = '', $argB = '' ) { $file = wfFindFile( $name ); if( $argA == 'nowiki' ) { diff --git a/includes/parser/DateFormatter.php b/includes/parser/DateFormatter.php index 0f22675e28..88d68a7531 100644 --- a/includes/parser/DateFormatter.php +++ b/includes/parser/DateFormatter.php @@ -102,11 +102,11 @@ class DateFormatter { # Rules # pref source target - $this->rules[self::DMY][self::MD] = self::DM; - $this->rules[self::ALL][self::MD] = self::MD; - $this->rules[self::MDY][self::DM] = self::MD; - $this->rules[self::ALL][self::DM] = self::DM; - $this->rules[self::NONE][self::ISO2] = self::ISO1; + $this->rules[self::DMY][self::MD] = self::DM; + $this->rules[self::ALL][self::MD] = self::MD; + $this->rules[self::MDY][self::DM] = self::MD; + $this->rules[self::ALL][self::DM] = self::DM; + $this->rules[self::NONE][self::ISO2] = self::ISO1; $this->preferences = array( 'default' => self::NONE, @@ -145,7 +145,7 @@ class DateFormatter { * @param $options Array: can contain 'linked' and/or 'match-whole' * @return mixed|String */ - function reformat( $preference, $text, $options = array('linked') ) { + function reformat( $preference, $text, $options = array( 'linked' ) ) { $linked = in_array( 'linked', $options ); $match_whole = in_array( 'match-whole', $options ); @@ -172,21 +172,21 @@ class DateFormatter { $regex = $this->regexes[$i]; // Horrible hack - if (!$linked) { + if ( !$linked ) { $regex = str_replace( array( '\[\[', '\]\]' ), '', $regex ); } - if ($match_whole) { + if ( $match_whole ) { // Let's hope this works $regex = preg_replace( '!^/!', '/^', $regex ); $regex = str_replace( $this->regexTrail, - '$'.$this->regexTrail, $regex ); + '$' . $this->regexTrail, $regex ); } // Another horrible hack $this->mLinked = $linked; $text = preg_replace_callback( $regex, array( &$this, 'replace' ), $text ); - unset($this->mLinked); + unset( $this->mLinked ); } return $text; } @@ -203,7 +203,7 @@ class DateFormatter { $bits = array(); $key = $this->keys[$this->mSource]; - for ( $p=0; $p < strlen($key); $p++ ) { + for ( $p=0; $p < strlen( $key ); $p++ ) { if ( $key[$p] != ' ' ) { $bits[$key[$p]] = $matches[$p+1]; } @@ -220,7 +220,7 @@ class DateFormatter { function formatDate( $bits, $link = true ) { $format = $this->targets[$this->mTarget]; - if (!$link) { + if ( !$link ) { // strip piped links $format = preg_replace( '/\[\[[^|]+\|([^\]]+)\]\]/', '$1', $format ); // strip remaining links @@ -246,7 +246,7 @@ class DateFormatter { } } - if ( !isset($bits['d']) ) { + if ( !isset( $bits['d'] ) ) { $bits['d'] = sprintf( '%02d', $bits['j'] ); } @@ -263,7 +263,7 @@ class DateFormatter { $text .= $bits['y']; break; case 'j': # ordinary day of month - if ( !isset($bits['j']) ) { + if ( !isset( $bits['j'] ) ) { $text .= intval( $bits['d'] ); } else { $text .= $bits['j']; @@ -271,7 +271,7 @@ class DateFormatter { break; case 'F': # long month if ( !isset( $bits['F'] ) ) { - $m = intval($bits['m']); + $m = intval( $bits['m'] ); if ( $m > 12 || $m < 1 ) { $fail = true; } else { @@ -293,7 +293,7 @@ class DateFormatter { } $isoBits = array(); - if ( isset($bits['y']) ) + if ( isset( $bits['y'] ) ) $isoBits[] = $bits['y']; $isoBits[] = $bits['m']; $isoBits[] = $bits['d']; diff --git a/includes/parser/LinkHolderArray.php b/includes/parser/LinkHolderArray.php index 0c05a51d09..5e93466571 100644 --- a/includes/parser/LinkHolderArray.php +++ b/includes/parser/LinkHolderArray.php @@ -217,7 +217,7 @@ class LinkHolderArray { */ function makeHolder( $nt, $text = '', $query = array(), $trail = '', $prefix = '' ) { wfProfileIn( __METHOD__ ); - if ( ! is_object($nt) ) { + if ( !is_object( $nt ) ) { # Fail gracefully $retVal = "{$prefix}{$text}{$trail}"; } else { @@ -226,7 +226,7 @@ class LinkHolderArray { $entry = array( 'title' => $nt, - 'text' => $prefix.$text.$inside, + 'text' => $prefix . $text . $inside, 'pdbk' => $nt->getPrefixedDBkey(), ); if ( $query !== array() ) { @@ -281,7 +281,7 @@ class LinkHolderArray { $linkCache = LinkCache::singleton(); $output = $this->parent->getOutput(); - wfProfileIn( __METHOD__.'-check' ); + wfProfileIn( __METHOD__ . '-check' ); $dbr = wfGetDB( DB_SLAVE ); $threshold = $this->parent->getOptions()->getStubThreshold(); @@ -355,19 +355,19 @@ class LinkHolderArray { } unset( $res ); } - if ( count($linkcolour_ids) ) { + if ( count( $linkcolour_ids ) ) { //pass an array of page_ids to an extension wfRunHooks( 'GetLinkColours', array( $linkcolour_ids, &$colours ) ); } - wfProfileOut( __METHOD__.'-check' ); + wfProfileOut( __METHOD__ . '-check' ); # Do a second query for different language variants of links and categories - if($wgContLang->hasVariants()) { + if( $wgContLang->hasVariants() ) { $this->doVariants( $colours ); } # Construct search and replace arrays - wfProfileIn( __METHOD__.'-construct' ); + wfProfileIn( __METHOD__ . '-construct' ); $replacePairs = array(); foreach ( $this->internals as $ns => $entries ) { foreach ( $entries as $index => $entry ) { @@ -399,16 +399,16 @@ class LinkHolderArray { } } $replacer = new HashtableReplacer( $replacePairs, 1 ); - wfProfileOut( __METHOD__.'-construct' ); + wfProfileOut( __METHOD__ . '-construct' ); # Do the thing - wfProfileIn( __METHOD__.'-replace' ); + wfProfileIn( __METHOD__ . '-replace' ); $text = preg_replace_callback( '/()/', $replacer->cb(), $text); - wfProfileOut( __METHOD__.'-replace' ); + wfProfileOut( __METHOD__ . '-replace' ); wfProfileOut( __METHOD__ ); } diff --git a/includes/parser/Parser.php b/includes/parser/Parser.php index 5923a38341..876e3b7a47 100644 --- a/includes/parser/Parser.php +++ b/includes/parser/Parser.php @@ -1859,7 +1859,7 @@ class Parser { # fix up urlencoded title texts if ( strpos( $m[1], '%' ) !== false ) { # Should anchors '#' also be rejected? - $m[1] = str_replace( array('<', '>'), array('<', '>'), rawurldecode( $m[1] ) ); + $m[1] = str_replace( array( '<', '>' ), array( '<', '>' ), rawurldecode( $m[1] ) ); } $trail = $m[3]; } elseif ( preg_match( $e1_img, $line, $m ) ) { # Invalid, but might be an image with a link in its caption @@ -3715,7 +3715,7 @@ class Parser { global $wgEnableScaryTranscluding; if ( !$wgEnableScaryTranscluding ) { - return wfMessage('scarytranscludedisabled')->inContentLanguage()->text(); + return wfMessage( 'scarytranscludedisabled' )->inContentLanguage()->text(); } $url = $title->getFullUrl( "action=$action" ); @@ -3734,7 +3734,7 @@ class Parser { global $wgTranscludeCacheExpiry; $dbr = wfGetDB( DB_SLAVE ); $tsCond = $dbr->timestamp( time() - $wgTranscludeCacheExpiry ); - $obj = $dbr->selectRow( 'transcache', array('tc_time', 'tc_contents' ), + $obj = $dbr->selectRow( 'transcache', array( 'tc_time', 'tc_contents' ), array( 'tc_url' => $url, "tc_time >= " . $dbr->addQuotes( $tsCond ) ) ); if ( $obj ) { return $obj->tc_contents; @@ -3751,7 +3751,7 @@ class Parser { } $dbw = wfGetDB( DB_MASTER ); - $dbw->replace( 'transcache', array('tc_url'), array( + $dbw->replace( 'transcache', array( 'tc_url' ), array( 'tc_url' => $url, 'tc_time' => $dbw->timestamp( time() ), 'tc_contents' => $text) @@ -3777,7 +3777,7 @@ class Parser { $argName = trim( $nameWithSpaces ); $object = false; $text = $frame->getArgument( $argName ); - if ( $text === false && $parts->getLength() > 0 + if ( $text === false && $parts->getLength() > 0 && ( $this->ot['html'] || $this->ot['pre'] @@ -3830,7 +3830,7 @@ class Parser { $content = !isset( $params['inner'] ) ? null : $frame->expand( $params['inner'] ); $marker = "{$this->mUniqPrefix}-$name-" . sprintf( '%08X', $this->mMarkerIndex++ ) . self::MARKER_SUFFIX; - $isFunctionTag = isset( $this->mFunctionTagHooks[strtolower($name)] ) && + $isFunctionTag = isset( $this->mFunctionTagHooks[strtolower( $name )] ) && ( $this->ot['html'] || $this->ot['pre'] ); if ( $isFunctionTag ) { $markerType = 'none'; @@ -4201,7 +4201,7 @@ class Parser { # to allow setting directionality in toc items. $tocline = preg_replace( array( '#<(?!/?(span|sup|sub|i|b)(?: [^>]*)?>).*?'.'>#', '#<(/?(?:span(?: dir="(?:rtl|ltr)")?|sup|sub|i|b))(?: .*?)?'.'>#' ), - array( '', '<$1>' ), + array( '', '<$1>' ), $safeHeadline ); $tocline = trim( $tocline ); @@ -4322,9 +4322,9 @@ class Parser { // We use a page and section attribute to stop the language converter from converting these important bits // of data, but put the headline hint inside a content block because the language converter is supposed to // be able to convert that piece of data. - $editlink = ''; } else { $editlink .= '/>'; @@ -4976,7 +4976,7 @@ class Parser { // is defined for images in galleries $matches[3] = $this->recursiveTagParse( trim( $matches[3] ) ); - $parameterMatches = StringUtils::explode('|', $matches[3]); + $parameterMatches = StringUtils::explode( '|', $matches[3] ); $magicWordAlt = MagicWord::get( 'img_alt' ); $magicWordLink = MagicWord::get( 'img_link' ); @@ -5022,7 +5022,7 @@ class Parser { } else { $handlerClass = ''; } - if ( !isset( $this->mImageParams[$handlerClass] ) ) { + if ( !isset( $this->mImageParams[$handlerClass] ) ) { # Initialise static lists static $internalParamNames = array( 'horizAlign' => array( 'left', 'right', 'center', 'none' ), @@ -5386,7 +5386,7 @@ class Parser { * @return String: for "get", the extracted section text. * for "replace", the whole page with the section replaced. */ - private function extractSections( $text, $section, $mode, $newText='' ) { + private function extractSections( $text, $section, $mode, $newText = '' ) { global $wgTitle; # not generally used but removes an ugly failure mode $this->startParse( $wgTitle, new ParserOptions, self::OT_PLAIN, true ); $outText = ''; @@ -5507,7 +5507,7 @@ class Parser { * @param $deftext String: default to return if section is not found * @return string text of the requested section */ - public function getSection( $text, $section, $deftext='' ) { + public function getSection( $text, $section, $deftext = '' ) { return $this->extractSections( $text, $section, "get", $deftext ); } diff --git a/includes/parser/ParserCache.php b/includes/parser/ParserCache.php index d41962127a..0faa40a839 100644 --- a/includes/parser/ParserCache.php +++ b/includes/parser/ParserCache.php @@ -67,7 +67,7 @@ class ParserCache { // idhash seem to mean 'page id' + 'rendering hash' (r3710) $pageid = $article->getID(); - $renderkey = (int)($wgRequest->getVal('action') == 'render'); + $renderkey = (int)($wgRequest->getVal( 'action' ) == 'render'); $key = wfMemcKey( 'pcache', 'idhash', "{$pageid}-{$renderkey}!{$hash}" ); return $key; diff --git a/includes/parser/ParserOutput.php b/includes/parser/ParserOutput.php index 53b62938fb..27b75ac4da 100644 --- a/includes/parser/ParserOutput.php +++ b/includes/parser/ParserOutput.php @@ -83,13 +83,13 @@ class ParserOutput extends CacheTime { function replaceEditSectionLinksCallback( $m ) { global $wgOut, $wgLang; $args = array( - htmlspecialchars_decode($m[1]), - htmlspecialchars_decode($m[2]), - isset($m[4]) ? $m[3] : null, + htmlspecialchars_decode( $m[1] ), + htmlspecialchars_decode( $m[2] ), + isset( $m[4] ) ? $m[3] : null, ); $args[0] = Title::newFromText( $args[0] ); - if ( !is_object($args[0]) ) { - throw new MWException("Bad parser output text."); + if ( !is_object( $args[0] ) ) { + throw new MWException( "Bad parser output text." ); } $args[] = $wgLang->getCode(); $skin = $wgOut->getSkin(); @@ -261,7 +261,7 @@ class ParserOutput extends CacheTime { if( $prefix == '' ) { throw new MWException( 'Non-interwiki link passed, internal parser error.' ); } - if (!isset($this->mInterwikiLinks[$prefix])) { + if ( !isset( $this->mInterwikiLinks[$prefix] ) ) { $this->mInterwikiLinks[$prefix] = array(); } $this->mInterwikiLinks[$prefix][$title->getDBkey()] = 1; diff --git a/includes/parser/Parser_LinkHooks.php b/includes/parser/Parser_LinkHooks.php index d1ca8aac72..f6da6c743f 100644 --- a/includes/parser/Parser_LinkHooks.php +++ b/includes/parser/Parser_LinkHooks.php @@ -105,9 +105,9 @@ class Parser_LinkHooks extends Parser { */ public function setLinkHook( $ns, $callback, $flags = 0 ) { if( $flags & SLH_PATTERN && !is_string($ns) ) - throw new MWException( __METHOD__.'() expecting a regex string pattern.' ); - elseif( $flags | ~SLH_PATTERN && !is_int($ns) ) - throw new MWException( __METHOD__.'() expecting a namespace index.' ); + throw new MWException( __METHOD__ . '() expecting a regex string pattern.' ); + elseif( $flags | ~SLH_PATTERN && !is_int( $ns ) ) + throw new MWException( __METHOD__ . '() expecting a namespace index.' ); $oldVal = isset( $this->mLinkHooks[$ns] ) ? $this->mLinkHooks[$ns][0] : null; $this->mLinkHooks[$ns] = array( $callback, $flags ); return $oldVal; @@ -133,8 +133,8 @@ class Parser_LinkHooks extends Parser { function replaceInternalLinks2( &$s ) { wfProfileIn( __METHOD__ ); - wfProfileIn( __METHOD__.'-setup' ); - static $tc = FALSE, $titleRegex;//$e1, $e1_img; + wfProfileIn( __METHOD__ . '-setup' ); + static $tc = FALSE, $titleRegex; //$e1, $e1_img; if( !$tc ) { # the % is needed to support urlencoded titles as well $tc = Title::legalChars() . '#%'; @@ -149,12 +149,12 @@ class Parser_LinkHooks extends Parser { $holders = new LinkHolderArray( $this ); if( is_null( $this->mTitle ) ) { - wfProfileOut( __METHOD__.'-setup' ); + wfProfileOut( __METHOD__ . '-setup' ); wfProfileOut( __METHOD__ ); - throw new MWException( __METHOD__.": \$this->mTitle is null\n" ); + throw new MWException( __METHOD__ . ": \$this->mTitle is null\n" ); } - wfProfileOut( __METHOD__.'-setup' ); + wfProfileOut( __METHOD__ . '-setup' ); $offset = 0; $offsetStack = array(); @@ -167,7 +167,7 @@ class Parser_LinkHooks extends Parser { # Determine if the bracket is a starting or ending bracket # When we find both, use the first one elseif( $startBracketOffset !== false && $endBracketOffset !== false ) - $isStart = $startBracketOffset <= $endBracketOffset; + $isStart = $startBracketOffset <= $endBracketOffset; # When we only found one, check which it is else $isStart = $startBracketOffset !== false; $bracketOffset = $isStart ? $startBracketOffset : $endBracketOffset; @@ -178,26 +178,26 @@ class Parser_LinkHooks extends Parser { } else { /** Closing bracket **/ # Pop the start pos for our current link zone off the stack - $startBracketOffset = array_pop($offsetStack); + $startBracketOffset = array_pop( $offsetStack ); # Just to clean up the code, lets place offsets on the outer ends $endBracketOffset += 2; # Only do logic if we actually have a opening bracket for this - if( isset($startBracketOffset) ) { + if( isset( $startBracketOffset ) ) { # Extract text inside the link - @list( $titleText, $paramText ) = explode('|', - substr($s, $startBracketOffset+2, $endBracketOffset-$startBracketOffset-4), 2); + @list( $titleText, $paramText ) = explode( '|', + substr( $s, $startBracketOffset + 2, $endBracketOffset - $startBracketOffset - 4 ), 2 ); # Create markers only for valid links if( preg_match( $titleRegex, $titleText ) ) { # Store the text for the marker - $marker = $markers->addMarker($titleText, $paramText); + $marker = $markers->addMarker( $titleText, $paramText ); # Replace the current link with the marker - $s = substr($s,0,$startBracketOffset). - $marker. - substr($s, $endBracketOffset); + $s = substr( $s, 0, $startBracketOffset ) . + $marker . + substr( $s, $endBracketOffset ); # We have modified $s, because of this we need to set the # offset manually since the end position is different now - $offset = $startBracketOffset+strlen($marker); + $offset = $startBracketOffset+strlen( $marker ); continue; } # ToDo: Some LinkHooks may allow recursive links inside of @@ -212,9 +212,9 @@ class Parser_LinkHooks extends Parser { } # Now expand our tree - wfProfileIn( __METHOD__.'-expand' ); + wfProfileIn( __METHOD__ . '-expand' ); $s = $markers->expand( $s ); - wfProfileOut( __METHOD__.'-expand' ); + wfProfileOut( __METHOD__ . '-expand' ); wfProfileOut( __METHOD__ ); return $holders; @@ -222,14 +222,14 @@ class Parser_LinkHooks extends Parser { function replaceInternalLinksCallback( $parser, $holders, $markers, $titleText, $paramText ) { wfProfileIn( __METHOD__ ); - $wt = isset($paramText) ? "[[$titleText|$paramText]]" : "[[$titleText]]"; - wfProfileIn( __METHOD__."-misc" ); + $wt = isset( $paramText ) ? "[[$titleText|$paramText]]" : "[[$titleText]]"; + wfProfileIn( __METHOD__ . "-misc" ); # Don't allow internal links to pages containing # PROTO: where PROTO is a valid URL protocol; these # should be external links. - if( preg_match('/^\b(?i:' . wfUrlProtocols() . ')/', $titleText) ) { - wfProfileOut( __METHOD__."-misc" ); + if( preg_match( '/^\b(?i:' . wfUrlProtocols() . ')/', $titleText ) ) { + wfProfileOut( __METHOD__ . "-misc" ); wfProfileOut( __METHOD__ ); return $wt; } @@ -243,17 +243,17 @@ class Parser_LinkHooks extends Parser { $leadingColon = $titleText[0] == ':'; if( $leadingColon ) $titleText = substr( $titleText, 1 ); - wfProfileOut( __METHOD__."-misc" ); + wfProfileOut( __METHOD__ . "-misc" ); # Make title object - wfProfileIn( __METHOD__."-title" ); + wfProfileIn( __METHOD__ . "-title" ); $title = Title::newFromText( $this->mStripState->unstripNoWiki( $titleText ) ); if( !$title ) { - wfProfileOut( __METHOD__."-title" ); + wfProfileOut( __METHOD__ . "-title" ); wfProfileOut( __METHOD__ ); return $wt; } $ns = $title->getNamespace(); - wfProfileOut( __METHOD__."-title" ); + wfProfileOut( __METHOD__ . "-title" ); # Default for Namespaces is a default link # ToDo: Default for patterns is plain wikitext @@ -279,7 +279,7 @@ class Parser_LinkHooks extends Parser { if( $return === false ) { # False (no link) was returned, output plain wikitext # Build it again as the hook is allowed to modify $paramText - $return = isset($paramText) ? "[[$titleText|$paramText]]" : "[[$titleText]]"; + $return = isset( $paramText ) ? "[[$titleText|$paramText]]" : "[[$titleText]]"; } # Content was returned, return it wfProfileOut( __METHOD__ ); @@ -300,14 +300,14 @@ class LinkMarkerReplacer { $this->callback = $callback; } - function addMarker($titleText, $paramText) { + function addMarker( $titleText, $paramText ) { $id = $this->nextId++; $this->markers[$id] = array( $titleText, $paramText ); return ""; } function findMarker( $string ) { - return (bool) preg_match('//', $string ); + return (bool) preg_match( '//', $string ); } function expand( $string ) { @@ -315,8 +315,8 @@ class LinkMarkerReplacer { } function callback( $m ) { - $id = intval($m[1]); - if( !array_key_exists($id, $this->markers) ) return $m[0]; + $id = intval( $m[1] ); + if( !array_key_exists( $id, $this->markers ) ) return $m[0]; $args = $this->markers[$id]; array_unshift( $args, $this ); array_unshift( $args, $this->holders ); diff --git a/includes/parser/Preprocessor_DOM.php b/includes/parser/Preprocessor_DOM.php index 53f3febc27..250552838a 100644 --- a/includes/parser/Preprocessor_DOM.php +++ b/includes/parser/Preprocessor_DOM.php @@ -137,9 +137,9 @@ class Preprocessor_DOM implements Preprocessor { $cacheable = ( $wgPreprocessorCacheThreshold !== false && strlen( $text ) > $wgPreprocessorCacheThreshold ); if ( $cacheable ) { - wfProfileIn( __METHOD__.'-cacheable' ); + wfProfileIn( __METHOD__ . '-cacheable' ); - $cacheKey = wfMemcKey( 'preprocess-xml', md5($text), $flags ); + $cacheKey = wfMemcKey( 'preprocess-xml', md5( $text ), $flags ); $cacheValue = $wgMemc->get( $cacheKey ); if ( $cacheValue ) { $version = substr( $cacheValue, 0, 8 ); @@ -152,11 +152,11 @@ class Preprocessor_DOM implements Preprocessor { } if ( $xml === false ) { if ( $cacheable ) { - wfProfileIn( __METHOD__.'-cache-miss' ); + wfProfileIn( __METHOD__ . '-cache-miss' ); $xml = $this->preprocessToXml( $text, $flags ); $cacheValue = sprintf( "%08d", self::CACHE_VERSION ) . $xml; $wgMemc->set( $cacheKey, $cacheValue, 86400 ); - wfProfileOut( __METHOD__.'-cache-miss' ); + wfProfileOut( __METHOD__ . '-cache-miss' ); wfDebugLog( "Preprocessor", "Saved preprocessor XML to memcached (key $cacheKey)" ); } else { $xml = $this->preprocessToXml( $text, $flags ); @@ -169,10 +169,10 @@ class Preprocessor_DOM implements Preprocessor { $this->parser->mGeneratedPPNodeCount += substr_count( $xml, '<' ); $max = $this->parser->mOptions->getMaxGeneratedPPNodeCount(); if ( $this->parser->mGeneratedPPNodeCount > $max ) { - throw new MWException( __METHOD__.': generated node count limit exceeded' ); + throw new MWException( __METHOD__ . ': generated node count limit exceeded' ); } - wfProfileIn( __METHOD__.'-loadXML' ); + wfProfileIn( __METHOD__ . '-loadXML' ); $dom = new DOMDocument; wfSuppressWarnings(); $result = $dom->loadXML( $xml ); @@ -183,13 +183,13 @@ class Preprocessor_DOM implements Preprocessor { // 1 << 19 == XML_PARSE_HUGE, needed so newer versions of libxml2 don't barf when the XML is >256 levels deep $result = $dom->loadXML( $xml, 1 << 19 ); if ( !$result ) { - throw new MWException( __METHOD__.' generated invalid XML' ); + throw new MWException( __METHOD__ . ' generated invalid XML' ); } } $obj = new PPNode_DOM( $dom->documentElement ); - wfProfileOut( __METHOD__.'-loadXML' ); + wfProfileOut( __METHOD__ . '-loadXML' ); if ( $cacheable ) { - wfProfileOut( __METHOD__.'-cacheable' ); + wfProfileOut( __METHOD__ . '-cacheable' ); } wfProfileOut( __METHOD__ ); return $obj; @@ -397,7 +397,7 @@ class Preprocessor_DOM implements Preprocessor { if ( $stack->top ) { $part = $stack->top->getCurrentPart(); - if ( ! (isset( $part->commentEnd ) && $part->commentEnd == $wsStart - 1 )) { + if ( !(isset( $part->commentEnd ) && $part->commentEnd == $wsStart - 1 )) { $part->visualEnd = $wsStart; } // Else comments abutting, no change in visual end @@ -758,7 +758,7 @@ class PPDStack { function pop() { if ( !count( $this->stack ) ) { - throw new MWException( __METHOD__.': no elements remaining' ); + throw new MWException( __METHOD__ . ': no elements remaining' ); } $temp = array_pop( $this->stack ); @@ -815,7 +815,7 @@ class PPDStackElement { } function &getAccum() { - return $this->parts[count($this->parts) - 1]->out; + return $this->parts[count( $this->parts ) - 1]->out; } function addPart( $s = '' ) { @@ -824,7 +824,7 @@ class PPDStackElement { } function getCurrentPart() { - return $this->parts[count($this->parts) - 1]; + return $this->parts[count( $this->parts ) - 1]; } /** @@ -1118,7 +1118,7 @@ class PPFrame_DOM implements PPFrame { } # Add a strip marker in PST mode so that pstPass2() can run some old-fashioned regexes on the result # Not in RECOVER_COMMENTS mode (extractSections) though - elseif ( $this->parser->ot['wiki'] && ! ( $flags & PPFrame::RECOVER_COMMENTS ) ) { + elseif ( $this->parser->ot['wiki'] && !( $flags & PPFrame::RECOVER_COMMENTS ) ) { $out .= $this->parser->insertStripItem( $contextNode->textContent ); } # Recover the literal comment in RECOVER_COMMENTS and pre+no-remove @@ -1175,7 +1175,7 @@ class PPFrame_DOM implements PPFrame { } } else { wfProfileOut( __METHOD__ ); - throw new MWException( __METHOD__.': Invalid parameter type' ); + throw new MWException( __METHOD__ . ': Invalid parameter type' ); } if ( $newIterator !== false ) { @@ -1459,25 +1459,25 @@ class PPTemplateFrame_DOM extends PPFrame_DOM { function getArguments() { $arguments = array(); foreach ( array_merge( - array_keys($this->numberedArgs), - array_keys($this->namedArgs)) as $key ) { - $arguments[$key] = $this->getArgument($key); + array_keys( $this->numberedArgs ), + array_keys( $this->namedArgs ) ) as $key ) { + $arguments[$key] = $this->getArgument( $key ); } return $arguments; } function getNumberedArguments() { $arguments = array(); - foreach ( array_keys($this->numberedArgs) as $key ) { - $arguments[$key] = $this->getArgument($key); + foreach ( array_keys( $this->numberedArgs ) as $key ) { + $arguments[$key] = $this->getArgument( $key ); } return $arguments; } function getNamedArguments() { $arguments = array(); - foreach ( array_keys($this->namedArgs) as $key ) { - $arguments[$key] = $this->getArgument($key); + foreach ( array_keys( $this->namedArgs ) as $key ) { + $arguments[$key] = $this->getArgument( $key ); } return $arguments; } diff --git a/includes/parser/Preprocessor_Hash.php b/includes/parser/Preprocessor_Hash.php index a4e408e99d..a871205ff4 100644 --- a/includes/parser/Preprocessor_Hash.php +++ b/includes/parser/Preprocessor_Hash.php @@ -116,9 +116,9 @@ class Preprocessor_Hash implements Preprocessor { $cacheable = $wgPreprocessorCacheThreshold !== false && strlen( $text ) > $wgPreprocessorCacheThreshold; if ( $cacheable ) { - wfProfileIn( __METHOD__.'-cacheable' ); + wfProfileIn( __METHOD__ . '-cacheable' ); - $cacheKey = wfMemcKey( 'preprocess-hash', md5($text), $flags ); + $cacheKey = wfMemcKey( 'preprocess-hash', md5( $text ), $flags ); $cacheValue = $wgMemc->get( $cacheKey ); if ( $cacheValue ) { $version = substr( $cacheValue, 0, 8 ); @@ -127,12 +127,12 @@ class Preprocessor_Hash implements Preprocessor { // From the cache wfDebugLog( "Preprocessor", "Loaded preprocessor hash from memcached (key $cacheKey)" ); - wfProfileOut( __METHOD__.'-cacheable' ); + wfProfileOut( __METHOD__ . '-cacheable' ); wfProfileOut( __METHOD__ ); return $hash; } } - wfProfileIn( __METHOD__.'-cache-miss' ); + wfProfileIn( __METHOD__ . '-cache-miss' ); } $rules = array( @@ -332,7 +332,7 @@ class Preprocessor_Hash implements Preprocessor { if ( $stack->top ) { $part = $stack->top->getCurrentPart(); - if ( ! (isset( $part->commentEnd ) && $part->commentEnd == $wsStart - 1 )) { + if ( !(isset( $part->commentEnd ) && $part->commentEnd == $wsStart - 1 )) { $part->visualEnd = $wsStart; } // Else comments abutting, no change in visual end @@ -391,7 +391,7 @@ class Preprocessor_Hash implements Preprocessor { } // and just become tags if ( in_array( $lowerName, $ignoredElements ) ) { - $accum->addNodeWithText( 'ignore', substr( $text, $tagStartPos, $i - $tagStartPos ) ); + $accum->addNodeWithText( 'ignore', substr( $text, $tagStartPos, $i - $tagStartPos ) ); continue; } @@ -549,7 +549,7 @@ class Preprocessor_Hash implements Preprocessor { } } - if ($matchingCount <= 0) { + if ( $matchingCount <= 0 ) { # No matching element found in callback array # Output a literal closing brace and continue $accum->addLiteral( str_repeat( $curChar, $count ) ); @@ -591,10 +591,10 @@ class Preprocessor_Hash implements Preprocessor { $lastNode = $node; } if ( !$node ) { - throw new MWException( __METHOD__. ': eqpos not found' ); + throw new MWException( __METHOD__ . ': eqpos not found' ); } if ( $node->name !== 'equals' ) { - throw new MWException( __METHOD__ .': eqpos is not equals' ); + throw new MWException( __METHOD__ . ': eqpos is not equals' ); } $equalsNode = $node; @@ -639,7 +639,7 @@ class Preprocessor_Hash implements Preprocessor { $accum =& $stack->getAccum(); # Re-add the old stack element if it still has unmatched opening characters remaining - if ($matchingCount < $piece->count) { + if ( $matchingCount < $piece->count ) { $piece->parts = array( new PPDPart_Hash ); $piece->count -= $matchingCount; # do we still qualify for any callback with remaining count? @@ -696,11 +696,11 @@ class Preprocessor_Hash implements Preprocessor { $rootNode->lastChild = $stack->rootAccum->lastNode; // Cache - if ($cacheable) { + if ( $cacheable ) { $cacheValue = sprintf( "%08d", self::CACHE_VERSION ) . serialize( $rootNode ); $wgMemc->set( $cacheKey, $cacheValue, 86400 ); - wfProfileOut( __METHOD__.'-cache-miss' ); - wfProfileOut( __METHOD__.'-cacheable' ); + wfProfileOut( __METHOD__ . '-cache-miss' ); + wfProfileOut( __METHOD__ . '-cacheable' ); wfDebugLog( "Preprocessor", "Saved preprocessor Hash to memcached (key $cacheKey)" ); } @@ -1038,7 +1038,7 @@ class PPFrame_Hash implements PPFrame { } # Add a strip marker in PST mode so that pstPass2() can run some old-fashioned regexes on the result # Not in RECOVER_COMMENTS mode (extractSections) though - elseif ( $this->parser->ot['wiki'] && ! ( $flags & PPFrame::RECOVER_COMMENTS ) ) { + elseif ( $this->parser->ot['wiki'] && !( $flags & PPFrame::RECOVER_COMMENTS ) ) { $out .= $this->parser->insertStripItem( $contextNode->firstChild->value ); } # Recover the literal comment in RECOVER_COMMENTS and pre+no-remove @@ -1085,7 +1085,7 @@ class PPFrame_Hash implements PPFrame { $newIterator = $contextNode->getChildren(); } } else { - throw new MWException( __METHOD__.': Invalid parameter type' ); + throw new MWException( __METHOD__ . ': Invalid parameter type' ); } if ( $newIterator !== false ) { @@ -1374,9 +1374,9 @@ class PPTemplateFrame_Hash extends PPFrame_Hash { function getArguments() { $arguments = array(); foreach ( array_merge( - array_keys($this->numberedArgs), - array_keys($this->namedArgs)) as $key ) { - $arguments[$key] = $this->getArgument($key); + array_keys( $this->numberedArgs ), + array_keys( $this->namedArgs ) ) as $key ) { + $arguments[$key] = $this->getArgument( $key ); } return $arguments; } @@ -1386,8 +1386,8 @@ class PPTemplateFrame_Hash extends PPFrame_Hash { */ function getNumberedArguments() { $arguments = array(); - foreach ( array_keys($this->numberedArgs) as $key ) { - $arguments[$key] = $this->getArgument($key); + foreach ( array_keys( $this->numberedArgs ) as $key ) { + $arguments[$key] = $this->getArgument( $key ); } return $arguments; } @@ -1397,8 +1397,8 @@ class PPTemplateFrame_Hash extends PPFrame_Hash { */ function getNamedArguments() { $arguments = array(); - foreach ( array_keys($this->namedArgs) as $key ) { - $arguments[$key] = $this->getArgument($key); + foreach ( array_keys( $this->namedArgs ) as $key ) { + $arguments[$key] = $this->getArgument( $key ); } return $arguments; } diff --git a/includes/parser/Preprocessor_HipHop.hphp b/includes/parser/Preprocessor_HipHop.hphp index 8059e356fd..bd5e1a7862 100644 --- a/includes/parser/Preprocessor_HipHop.hphp +++ b/includes/parser/Preprocessor_HipHop.hphp @@ -121,7 +121,7 @@ class Preprocessor_HipHop implements Preprocessor { if ( $cacheable ) { wfProfileIn( __METHOD__.'-cacheable' ); - $cacheKey = strval( wfMemcKey( 'preprocess-hash', md5($text), $flags ) ); + $cacheKey = strval( wfMemcKey( 'preprocess-hash', md5( $text ), $flags ) ); $cacheValue = strval( $wgMemc->get( $cacheKey ) ); if ( $cacheValue !== '' ) { $version = substr( $cacheValue, 0, 8 ); @@ -347,7 +347,7 @@ class Preprocessor_HipHop implements Preprocessor { if ( $stack->top ) { $part = $stack->getTop()->getCurrentPart(); - if ( ! (isset( $part->commentEnd ) && $part->commentEnd == $wsStart - 1 )) { + if ( !(isset( $part->commentEnd ) && $part->commentEnd == $wsStart - 1 )) { $part->visualEnd = $wsStart; } // Else comments abutting, no change in visual end @@ -411,7 +411,7 @@ class Preprocessor_HipHop implements Preprocessor { } // and just become tags if ( in_array( $lowerName, $ignoredElements ) ) { - $accum->addNodeWithText( 'ignore', strval( substr( $text, $tagStartPos, $i - $tagStartPos ) ) ); + $accum->addNodeWithText( 'ignore', strval( substr( $text, $tagStartPos, $i - $tagStartPos ) ) ); continue; } @@ -578,7 +578,7 @@ class Preprocessor_HipHop implements Preprocessor { } } - if ($matchingCount <= 0) { + if ( $matchingCount <= 0 ) { # No matching element found in callback array # Output a literal closing brace and continue $accum->addLiteral( str_repeat( $curChar, $count ) ); @@ -671,7 +671,7 @@ class Preprocessor_HipHop implements Preprocessor { $accum = $stack->getAccum(); # Re-add the old stack element if it still has unmatched opening characters remaining - if ($matchingCount < $piece->count) { + if ( $matchingCount < $piece->count ) { $piece->parts = array( new PPDPart_HipHop ); $piece->count -= $matchingCount; # do we still qualify for any callback with remaining count? @@ -729,7 +729,7 @@ class Preprocessor_HipHop implements Preprocessor { $rootNode->lastChild = $stack->rootAccum->lastNode; // Cache - if ($cacheable) { + if ( $cacheable ) { $cacheValue = sprintf( "%08d", self::CACHE_VERSION ) . serialize( $rootNode ); $wgMemc->set( $cacheKey, $cacheValue, 86400 ); wfProfileOut( __METHOD__.'-cache-miss' ); @@ -865,7 +865,7 @@ class PPDStackElement_HipHop { * @return PPDAccum_HipHop */ function getAccum() { - return PPDAccum_HipHop::cast( $this->parts[count($this->parts) - 1]->out ); + return PPDAccum_HipHop::cast( $this->parts[count( $this->parts ) - 1]->out ); } /** @@ -879,7 +879,7 @@ class PPDStackElement_HipHop { * @return PPDPart_HipHop */ function getCurrentPart() { - return PPDPart_HipHop::cast( $this->parts[count($this->parts) - 1] ); + return PPDPart_HipHop::cast( $this->parts[count( $this->parts ) - 1] ); } /** @@ -1216,7 +1216,7 @@ class PPFrame_HipHop implements PPFrame { } # Add a strip marker in PST mode so that pstPass2() can run some old-fashioned regexes on the result # Not in RECOVER_COMMENTS mode (extractSections) though - elseif ( $this->parser->ot['wiki'] && ! ( $flags & PPFrame::RECOVER_COMMENTS ) ) { + elseif ( $this->parser->ot['wiki'] && !( $flags & PPFrame::RECOVER_COMMENTS ) ) { $out .= $this->parser->insertStripItem( $contextNode->firstChild->value ); } # Recover the literal comment in RECOVER_COMMENTS and pre+no-remove @@ -1569,8 +1569,8 @@ class PPTemplateFrame_HipHop extends PPFrame_HipHop { */ function getNumberedArguments() { $arguments = array(); - foreach ( array_keys($this->numberedArgs) as $key ) { - $arguments[$key] = $this->getArgument($key); + foreach ( array_keys( $this->numberedArgs ) as $key ) { + $arguments[$key] = $this->getArgument( $key ); } return $arguments; } @@ -1580,8 +1580,8 @@ class PPTemplateFrame_HipHop extends PPFrame_HipHop { */ function getNamedArguments() { $arguments = array(); - foreach ( array_keys($this->namedArgs) as $key ) { - $arguments[$key] = $this->getArgument($key); + foreach ( array_keys( $this->namedArgs ) as $key ) { + $arguments[$key] = $this->getArgument( $key ); } return $arguments; } diff --git a/includes/parser/Tidy.php b/includes/parser/Tidy.php index dd7e9650f5..4994d3e050 100644 --- a/includes/parser/Tidy.php +++ b/includes/parser/Tidy.php @@ -68,9 +68,9 @@ class MWTidyWrapper { $wrappedtext = preg_replace( '!<(link|meta)([^>]*?)(/{0,1}>)!', ''. - 'test'.$wrappedtext.''; + $wrappedtext = '' . + 'test' . $wrappedtext . ''; return $wrappedtext; } -- 2.20.1