jenkins-bot [Thu, 14 Feb 2019 13:24:55 +0000 (13:24 +0000)]
Merge "EnhancedChangesList: Load style module via addModuleStyles()"
jenkins-bot [Thu, 14 Feb 2019 13:17:55 +0000 (13:17 +0000)]
Merge "Add missing dependency on module 'mediawiki.notify'"
jenkins-bot [Thu, 14 Feb 2019 13:09:13 +0000 (13:09 +0000)]
Merge "mediawiki.special.changeslist.enhanced: Convert CSS to LESS"
Fomafix [Thu, 14 Feb 2019 08:59:23 +0000 (09:59 +0100)]
Add missing dependency on module 'mediawiki.notify'
watchlist.js uses mw.notify.
Change-Id: Iff59e01d96f3d8ffddd9ddaf9d3b4463c8cac8d1
jenkins-bot [Thu, 14 Feb 2019 06:38:04 +0000 (06:38 +0000)]
Merge "registration: Allow @-prefixed keys in manifest_version 2"
jenkins-bot [Thu, 14 Feb 2019 06:18:57 +0000 (06:18 +0000)]
Merge "Update AtEase calls to use Wikimedia namespace"
jenkins-bot [Thu, 14 Feb 2019 01:25:11 +0000 (01:25 +0000)]
Merge "objectcache: cleanup tombstone/mutex logic in doGetWithSetCallback()"
jenkins-bot [Thu, 14 Feb 2019 00:49:21 +0000 (00:49 +0000)]
Merge "resourceloader: Restore the comment about <script> vs XHR loading"
Bartosz Dziewoński [Wed, 13 Feb 2019 13:21:04 +0000 (14:21 +0100)]
resourceloader: Restore the comment about <script> vs XHR loading
Removed in
42956b99b558294e5aa8c6c0e2a8f18513478022.
I think it's useful to know this rationale (even more so because
the arguments about caching seem no longer correct these days).
Also, add the line about loading progress not being known when
using this method.
(Slightly related to T216034)
Change-Id: I81fa90483c0c85fecc5cb620196521ce8bdd33a7
Aaron Schulz [Wed, 13 Feb 2019 18:54:39 +0000 (10:54 -0800)]
objectcache: cleanup tombstone/mutex logic in doGetWithSetCallback()
This largely follows-up
6b2f13b055c84d.
* Make the comments and use of temporary variables easier to follow.
* Simplified some conditionals by remove redundant checks.
* Bypass the final set() call if $isTombstone is true. It will almost
always be rejected due to the tombstone still being there anyway, so
there is no point in the roundtrips. Also, the most likely case where
it would succeed is due to the callback taking a long time to run, in
which case data from the replication lag uncertainty period that the
tombstone represents would be getting saved to cache with the full
nominal TTL, which is wrong.
Change-Id: Ic28e15b24f39e128bd72ad4d905edb852bc907aa
Fomafix [Wed, 13 Feb 2019 13:07:26 +0000 (14:07 +0100)]
mediawiki.special.changeslist.enhanced: Convert CSS to LESS
Change-Id: Ic71a6bce99fd6417f90b5abdd52dcfa10e62029d
Translation updater bot [Wed, 13 Feb 2019 21:01:42 +0000 (22:01 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I377eb66bceaf7e946bbcdb51cf767d96be3e24c9
jenkins-bot [Wed, 13 Feb 2019 20:36:32 +0000 (20:36 +0000)]
Merge "Add missing documentation to ProtectedTitlesPager"
jenkins-bot [Wed, 13 Feb 2019 18:47:02 +0000 (18:47 +0000)]
Merge "rdbms: Use more narrow type hints in LBFactoryTest"
Thiemo Kreuz [Tue, 12 Feb 2019 12:01:26 +0000 (13:01 +0100)]
rdbms: Use more narrow type hints in LBFactoryTest
Originally I wanted to fix the broken type hint for the `Database`
class. But I ended limiting the scope as much as possible and only
type hint at the interfaces that contain the methods the code actually
needs.
Change-Id: I450a55e80612f6e676f7c803dc904b4b653426d8
Fomafix [Wed, 13 Feb 2019 11:27:20 +0000 (12:27 +0100)]
mediawiki.special.changeslist.legend: Convert CSS to LESS
Change-Id: I543cb50958689af6b32d3cd462a8f77f31724a03
jenkins-bot [Wed, 13 Feb 2019 17:52:30 +0000 (17:52 +0000)]
Merge "rdbms: avoid duplicate spammy logging in LoadBalancer::getRandomNonLagged"
Lucas Werkmeister [Wed, 13 Feb 2019 10:44:06 +0000 (11:44 +0100)]
Fix CommentStoreComment RawMessage construction
If a CommentStoreComment is constructed without a Message argument, then
the RawMessage it uses instead should specify the comment text as a
plain-text parameter, not as a regular parameter: we don’t want any
syntax in the text to be interpreted at the Message level.
Change-Id: If14debde2bceae695c8955604ee96bd5005d8b66
jenkins-bot [Wed, 13 Feb 2019 05:36:11 +0000 (05:36 +0000)]
Merge "resourceloader: Ignore warnings in JSMinPlus parser"
Stanislav Malyshev [Fri, 8 Feb 2019 20:13:49 +0000 (12:13 -0800)]
registration: Allow @-prefixed keys in manifest_version 2
As specified in
<https://www.mediawiki.org/wiki/Manual:Extension_registration#Retaining_documentation>.
Bug: T215650
Change-Id: I2ff523828389fbec39cdf7c55046e7da901a2ecb
Timo Tijhof [Wed, 13 Feb 2019 01:45:56 +0000 (01:45 +0000)]
resourceloader: Ignore warnings in JSMinPlus parser
It's old and unmaintained. The only thing we care about is if it
was able to parse the script and if not, what its error is. Its
return value or broken inner workings are insignificant at this
point and only cause noise.
Bug: T77169
Change-Id: Ie357ccfcc6141f894b452eb3996e168c1526990f
Reedy [Tue, 12 Feb 2019 23:48:31 +0000 (23:48 +0000)]
Update AtEase calls to use Wikimedia namespace
Helps ease migration (stops vendor patch failing)
Change-Id: I9a985b341e1c3664c4ced6f793b19149067a580a
Translation updater bot [Tue, 12 Feb 2019 20:54:12 +0000 (21:54 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Ia27cd1dfe1e1fecdff6431841c9e26a2daf3a865
Aaron Schulz [Tue, 12 Feb 2019 18:52:31 +0000 (10:52 -0800)]
rdbms: avoid duplicate spammy logging in LoadBalancer::getRandomNonLagged
This is already logged in LoadMonitor in getServerStates() in a less spammy way
(due to APC caching of server states).
Bug: T215611
Change-Id: Id70fdfa62eff9cb6446deea5e197f4c0af4928aa
jenkins-bot [Tue, 12 Feb 2019 16:27:04 +0000 (16:27 +0000)]
Merge "Prevent fatal PHP errors when PageRestriction::getTitle() returns null."
Thiemo Kreuz [Tue, 12 Feb 2019 12:03:38 +0000 (13:03 +0100)]
Update @deprecated comment for the DB_SLAVE constant
I keep searching for the proper replacement for this deprecated
constant. It's much easier to find when the @deprecated comment
just mentions it.
Change-Id: I199b876ecfb6e146848b395bc7bfad80742f000d
Thiemo Kreuz [Tue, 12 Feb 2019 11:57:05 +0000 (12:57 +0100)]
Add missing documentation to ProtectedTitlesPager
This was discussed in I2b5c95d. The reason no IDE was able to find this
usage of the deprecated SpecialPage::getTitle method was the missing
type hinting.
TODO:
* A lot of properties this class uses are not declared.
* A lot of stuff in here must be private, but is public at the moment.
But this is for later patches.
Change-Id: I12fd6e517e5bd3507032ee3aafcb1de96733985b
Reedy [Tue, 12 Feb 2019 01:24:17 +0000 (01:24 +0000)]
Update wikimedia/xmp-reader from 0.6.1 to 0.6.2
Change-Id: Ie396666aae2122dc552f6f1a7f6fe6ff96387fd1
Depends-On: Ia5dcf97548ed1c1f17cce9701df5cf13eea814dd
Reedy [Tue, 12 Feb 2019 00:40:12 +0000 (00:40 +0000)]
Update wikimedia/php-session-serializer from v1.0.6 to v1.0.7
Change-Id: Id30bb862bec42e508b3551d39f5980d900ade206
Depends-On: Ia19d237198fd2a0a15db467ec9dd97e98a857e33
jenkins-bot [Tue, 12 Feb 2019 01:16:50 +0000 (01:16 +0000)]
Merge "Revert "RCFilters: Export config vars in the RL modules where possible""
Catrope [Tue, 12 Feb 2019 00:54:39 +0000 (00:54 +0000)]
Revert "RCFilters: Export config vars in the RL modules where possible"
This reverts commit
bf4f9d0313495dd67a53b9925edf9a3cc6ef36fe.
Reason for revert: causes issues with OAuth extension
The OAuth extension uses a hook to override certain tag messages, and
that hook uses RequestContext::getMain()->msg(), which tries to load
the current user. That's not allowed in load.php requests, so we get a
"Sessions are disabled for this entry point" error.
Change-Id: If58b7edfca116cd7a11f38556f74bed82609d96a
Fomafix [Sun, 10 Feb 2019 15:04:57 +0000 (16:04 +0100)]
EnhancedChangesList: Load style module via addModuleStyles()
This change avoids a flash of missing collapsible toggle icons while
loading.
Change-Id: I090b1622868f2e5a01ca783dfce3be16b7d6b525
Reedy [Tue, 12 Feb 2019 00:28:49 +0000 (00:28 +0000)]
Update wikimedia/ip-set 2.0.0 to 2.0.1
Change-Id: I154a677bac28a451be4f203ff05ea4620260b54e
Depends-On: I1090817a5ff1e406cf51596a8b1558c7bd3ca7d7
jenkins-bot [Tue, 12 Feb 2019 00:26:42 +0000 (00:26 +0000)]
Merge "ChangesList: Remove spaces from <td> in EnhancedChangesListGroup.mustache"
jenkins-bot [Tue, 12 Feb 2019 00:14:25 +0000 (00:14 +0000)]
Merge "ProtectionForm: Move JS config var to RL packageFiles"
Fomafix [Sun, 10 Feb 2019 20:01:25 +0000 (21:01 +0100)]
ChangesList: Remove spaces from <td> in EnhancedChangesListGroup.mustache
The special page RecentChanges can included in wiki content via
{{Special:RecentChanges}}
In this case the generated content is parsed by a wikitext parser. The
wikitext parser converts
<td>
<span>Foo</span>
</td>
to the HTML
<td><p><span>Foo</span></p></td>
But the wikitext
<td><span>Foo</span></td>
is converted to the HTML
<td><span>Foo</span></td>
The module 'jquery.makeCollapsible' supports custom collapsible toggle
buttons but only when they are a direct child of the <td> element. When
the module does not find a custom collapsible toggle button it adds the
default button [Expand].
Because of the additional <p> element when including the recent changes
the module 'jquery.makeCollapsible' adds a default collapsible toggle
button.
This change removes the spaces between <td> and <span> to prevent the
<p> elements when including the recent changes.
Bug: T215737
Change-Id: Ida46956fc7f9ab923c542751ac13411380c02ab0
jenkins-bot [Mon, 11 Feb 2019 23:50:13 +0000 (23:50 +0000)]
Merge "Job::factory should throw an InvalidArgumentException, not MWException"
Derick Alangi [Wed, 30 Jan 2019 19:40:46 +0000 (20:40 +0100)]
Job::factory should throw an InvalidArgumentException, not MWException
Change-Id: I9a85562b205db604d2746ec5db0e72dacdb93c6d
jenkins-bot [Mon, 11 Feb 2019 22:21:45 +0000 (22:21 +0000)]
Merge "mw.widgets: Use CSS grid for the calendar in supporting browsers"
Bartosz Dziewoński [Wed, 30 Jan 2019 23:54:42 +0000 (15:54 -0800)]
mw.widgets: Use CSS grid for the calendar in supporting browsers
Bug: T214997
Change-Id: I05dca01585f3de86580e7ae94ceeae1716f56ba3
jenkins-bot [Mon, 11 Feb 2019 21:05:48 +0000 (21:05 +0000)]
Merge "parser: Add new pcache metrics, split by page content model"
jenkins-bot [Mon, 11 Feb 2019 21:05:42 +0000 (21:05 +0000)]
Merge "registration: Define packageFiles for v1 extension schema"
Translation updater bot [Mon, 11 Feb 2019 20:54:25 +0000 (21:54 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Id809e80a46547f7bf042eb6073efd7a519666ce7
addshore [Thu, 24 Jan 2019 16:58:04 +0000 (17:58 +0100)]
parser: Add new pcache metrics, split by page content model
Change-Id: I31c3c5b863309ffcc4424c43891b577b3fb7a753
Gilles Dubuc [Mon, 11 Feb 2019 20:39:41 +0000 (21:39 +0100)]
registration: Define packageFiles for v1 extension schema
Follows
56fa42d4332c.
Bug: T215756
Change-Id: Icbf433b6b147f53cf99533a7272fc83392a8999d
jenkins-bot [Mon, 11 Feb 2019 18:27:04 +0000 (18:27 +0000)]
Merge "Add ability to define packageFiles in extension.json"
jenkins-bot [Mon, 11 Feb 2019 18:10:02 +0000 (18:10 +0000)]
Merge "Change `.forEach()` to `for ()` loop with break"
jenkins-bot [Mon, 11 Feb 2019 17:42:37 +0000 (17:42 +0000)]
Merge "mw.widgets: Make TitleSearchWidget read-only-able"
Fomafix [Thu, 13 Sep 2018 18:38:09 +0000 (20:38 +0200)]
Change `.forEach()` to `for ()` loop with break
Follow-up to change
1edba8029, which replaced:
$.each( array, function ( index, value ) { ... } )
by:
array.forEach( function ( value, index ) { ... } )
`jQuery.each` makes a break of the loop on a `return false`.
`Array.prototype.forEach` ignores the return value and there
is no way to stop or break a `forEach()` loop other than by
throwing an exception. [1]
A `$.each` with a `return false` could be replaced by
`Array.prototype.find`, but `find()` is not part of ES5. [2]
return this.getItems().find( function ( filterItem ) {
return filterItem.isSelected() && filterItem.isConflicted();
} );
So a simple `for ()` loop with a `break` or a `return` is
used in these cases.
Also explicitly specify `undefined` as possible return value
in FiltersViewModel.prototype.getFirstConflictedItem.
[1] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/forEach
[2] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/find
Change-Id: I0af89d39ed789f49e06b25cac14ecd995ba58cbd
jenkins-bot [Mon, 11 Feb 2019 15:07:41 +0000 (15:07 +0000)]
Merge "Exception is never thrown in the getConnection() method"
Ed Sanders [Mon, 11 Feb 2019 13:52:39 +0000 (13:52 +0000)]
mw.widgets: Make TitleSearchWidget read-only-able
Change-Id: I3eed52438c1e416d4dcdedb564bb9df3745d0f77
Derick Alangi [Mon, 11 Feb 2019 12:01:11 +0000 (13:01 +0100)]
Remove unused @throws anotation from PHPDoc comment
Change-Id: If60ad5c12edbf4ea96c5c337f0c05cf0a8d5e43d
Fomafix [Mon, 17 Sep 2018 20:14:53 +0000 (22:14 +0200)]
ProtectionForm: Move JS config var to RL packageFiles
The check for type Array of the JavaScript config variable is obsolete.
Change-Id: I4a38cfc211360c831958ce8ca88584cdf56a727c
Gilles Dubuc [Mon, 11 Feb 2019 09:53:09 +0000 (10:53 +0100)]
Add ability to define packageFiles in extension.json
Bug: T215756
Change-Id: I97c3ccc13c54b424952ce15509b98a217b2670b1
jenkins-bot [Mon, 11 Feb 2019 03:54:58 +0000 (03:54 +0000)]
Merge "Add jakub-onderka/php-console-highlighter 0.3.2 explicitly"
Reedy [Mon, 11 Feb 2019 03:27:55 +0000 (03:27 +0000)]
Add jakub-onderka/php-console-highlighter 0.3.2 explicitly
We pin it in various libraries, might aswell in core for completenes
Change-Id: I659c880c9e16e4eab7050874f75c9eb5c9fa958c
Reedy [Mon, 11 Feb 2019 02:02:04 +0000 (02:02 +0000)]
Update cssjanus from 1.2.0 to 1.2.1
Change-Id: I99f11a24ff0a8b02b1c0103ad8cb8faeb165c84e
Depends-On: Iee4c24b6b5dd92493160caafa4764b6d6e427147
jenkins-bot [Mon, 11 Feb 2019 00:58:25 +0000 (00:58 +0000)]
Merge "Updated pear/net_smtp from 1.8.0 to 1.8.1"
jenkins-bot [Mon, 11 Feb 2019 00:53:07 +0000 (00:53 +0000)]
Merge "ParserTestPrinter: use Shell class"
jenkins-bot [Mon, 11 Feb 2019 00:51:56 +0000 (00:51 +0000)]
Merge "JpegPixelFormatTest: use Shell class"
jenkins-bot [Mon, 11 Feb 2019 00:43:31 +0000 (00:43 +0000)]
Merge "Linker: Remove some else statements, and unnecessary temporary variables"
jenkins-bot [Mon, 11 Feb 2019 00:37:59 +0000 (00:37 +0000)]
Merge "Make attachLatest.php wait for DB replica lag"
Reedy [Sun, 10 Feb 2019 23:00:06 +0000 (23:00 +0000)]
Updated pear/net_smtp from 1.8.0 to 1.8.1
Depends-On: I6543ac3e6482da197ce2d644823861d1db4624d8
Change-Id: I91b3c2864536a53fcc829a1e10a3bc0d4638db2b
Reedy [Sat, 9 Feb 2019 07:25:57 +0000 (07:25 +0000)]
Linker: Remove some else statements, and unnecessary temporary variables
Change-Id: I9b9383459edf06280135d9709da889fc5a688c98
Reedy [Sun, 10 Feb 2019 22:37:29 +0000 (22:37 +0000)]
Update dev dependancies
* Updated psy/psysh from 0.9.6 to 0.9.9 (dev-only).
* Updated nikic/php-parser from 3.1.3 to 3.1.5 (dev-only).
Change-Id: I05e45327e93d3bc733db73c0efe573b3223cc902
Depends-On: I896ac6c5afa8221ceca726eb7895e05d87d7e6f3
Translation updater bot [Sun, 10 Feb 2019 20:56:24 +0000 (21:56 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I26dda2663489848ffc75fc54b766fb827eeff4de
Reedy [Sat, 9 Feb 2019 23:27:14 +0000 (23:27 +0000)]
Make attachLatest.php wait for DB replica lag
Change-Id: I4f402ba772d0b0dda8360eaacf11e318f659efc0
Timo Tijhof [Wed, 23 Jan 2019 23:51:49 +0000 (15:51 -0800)]
build: Use headless Chrome and Firefox for QUnit testing
Also:
* Remove "watch" task from Gruntfile.
This wasn't exposed via npm-run and afaik rarely if ever used.
It seems mostly obsoleted by modern editors which perform
linting and style guidance as-you-type and on-save.
* Remove "chromium" target from karma config, the default
target supports both Chromium and Chrome.
* Remove unused "default" alias in Gruntfile. Was only
accessible if developers installed grunt-cli globally, which
we don't require and shouldn't encourage. The new minify task
is now exposed as "npm run build".
* Remove "test" alias in Gruntfile. Was only used by "npm run test",
which now uses "grunt lint" directly, which makes it more clear
that these are only linters, and not unit tests.
This references T211784 because ensuring no headed browsers are used
(which would need Xvfb to start), is a prerequisite for the new Node 10
images. We may still need to provide a slower Xvfb-wrapped variant for
some repos, but would be nice of mw-core wasn't one of them.
Bug: T211784
Change-Id: I270a16d2b4f799ac7c9f84e9e2ee23806bdbc57e
Max Semenik [Sun, 10 Feb 2019 06:25:57 +0000 (22:25 -0800)]
ParserTestPrinter: use Shell class
Change-Id: I9e2eb3b01a9907d72e3edaa6660a4057d513942e
Max Semenik [Sun, 10 Feb 2019 06:20:25 +0000 (22:20 -0800)]
JpegPixelFormatTest: use Shell class
Change-Id: I53099827dc2b2b26b7f3cbc9f0e12030868fdafd
jenkins-bot [Sun, 10 Feb 2019 06:19:28 +0000 (06:19 +0000)]
Merge "build: Update karma to 3.1.4"
jenkins-bot [Sun, 10 Feb 2019 06:03:08 +0000 (06:03 +0000)]
Merge "Hard deprecate Language::setCode"
Timo Tijhof [Sun, 10 Feb 2019 04:00:38 +0000 (04:00 +0000)]
build: Update karma to 3.1.4
This fixes the bug where HeadlessChrome was always shown as
version 0.0.0 in the console output, which makes it rather
difficult to debug which Chrome version is installed.
Upstream https://github.com/karma-runner/karma/issues/2762,
which updates the ua-parser library to a version that fixes
that bug.
Change-Id: I0b7fe7f8a90649592c4d31fb3055cdc9e8d34814
Roan Kattouw [Sat, 9 Feb 2019 22:59:10 +0000 (14:59 -0800)]
RCFilters: Export config vars in the RL modules where possible
Right now there are only a few settings that don't depend on the request
context, but we can at least export those. The tag data in
particular can get pretty big.
Downgrade the type hint for ChangeTags::tagDescription() and
tagLongDescriptionMessage() from IContextSource to MessageLocalizer, so
we can pass a ResourceLoaderContext to these functions. (Since
IContextSource extends MessageLocalizer, this won't break any callers.)
truncateTagDescription() can't be downgraded to MessageLocalizer because
it needs a Language object, so hack up a fake RequestContext when
calling it. It would be nice if this weren't necessary; perhaps we can
move getLanguage() from IContextSource up into MessageLocalizer?
Bug: T201574
Change-Id: I9b66e35de826a07aa9551ba285e64e4852293229
jenkins-bot [Sun, 10 Feb 2019 02:11:01 +0000 (02:11 +0000)]
Merge "resourceloader: Reduce 'implement' overhead for modules without scripts"
jenkins-bot [Sun, 10 Feb 2019 01:26:02 +0000 (01:26 +0000)]
Merge "Move migrateActors.php to includes"
jenkins-bot [Sun, 10 Feb 2019 01:19:26 +0000 (01:19 +0000)]
Merge "RCFilters: Convert RL modules to packageFiles"
Roan Kattouw [Fri, 14 Sep 2018 19:29:51 +0000 (12:29 -0700)]
RCFilters: Convert RL modules to packageFiles
* Use per-file require() to get classes' dependencies
* Export all DM classes to the global mw.rcfilters.dm object because the
unit tests need that
* Don't make any of the UI classes globally available except
MainWrapperWidget (and we can probably drop that one too)
* Rename mw.rcfilters.{dm,ui}.XYZ.js to XYZ.js
Change-Id: I8e541abf15c6987827a29eecc6a6f19f27378abb
Krinkle [Sun, 10 Feb 2019 00:17:45 +0000 (00:17 +0000)]
Merge "wdio-mediawiki: Rename internal "Front page" ref to "Main page""
jenkins-bot [Sat, 9 Feb 2019 23:40:34 +0000 (23:40 +0000)]
Merge "resources: Update jquery-client from v2.0.1 to v2.0.2"
jenkins-bot [Sat, 9 Feb 2019 23:40:29 +0000 (23:40 +0000)]
Merge "mediawiki.user: Remove deprecated stickyRandomId()"
James D. Forrester [Sat, 9 Feb 2019 22:42:09 +0000 (14:42 -0800)]
resources: Update jquery-client from v2.0.1 to v2.0.2
Bug: T101483
Change-Id: Ib1537cd92d733998818fe28b04ee81bec48a75d3
jenkins-bot [Sat, 9 Feb 2019 23:14:59 +0000 (23:14 +0000)]
Merge "wdio-mediawiki: Move non-public methods to local scope"
Timo Tijhof [Fri, 25 Jan 2019 19:08:01 +0000 (11:08 -0800)]
wdio-mediawiki: Rename internal "Front page" ref to "Main page"
Also remove redundant 'new Promise' indirection, in favour
of native chaining through "then()".
This avoids a situation where wdio could hang indefinitely (until
timeout) when MWBot.request fails because we did not attach any
"catch()" handler to the promise. By always keeping a chain, the
failures are (by default) forwarded and thus propagated and thus
caught eventually.
Change-Id: If2f09479600029db2fa967c57082031744a06d8f
jenkins-bot [Sat, 9 Feb 2019 23:05:59 +0000 (23:05 +0000)]
Merge "Follow-up I5bcae848: Remove from 1.33 RL, backported to 1.32"
Timo Tijhof [Fri, 25 Jan 2019 19:05:57 +0000 (11:05 -0800)]
wdio-mediawiki: Move non-public methods to local scope
Change-Id: I56258290d7c731b913f4df21c0bf4adc7fe4c69f
jenkins-bot [Sat, 9 Feb 2019 22:54:57 +0000 (22:54 +0000)]
Merge "mediawiki.language: Deprecate mw.language.specialCharacters"
jenkins-bot [Sat, 9 Feb 2019 22:50:25 +0000 (22:50 +0000)]
Merge "mediawiki.libs.jpegmeta: Remove deprecated mw.libs property"
James D. Forrester [Thu, 7 Feb 2019 22:34:09 +0000 (14:34 -0800)]
Follow-up I5bcae848: Remove from 1.33 RL, backported to 1.32
Change-Id: I84fa5e2fae785f80833a3128c18790d6ad3d1042
Bartosz Dziewoński [Tue, 29 Jan 2019 03:33:14 +0000 (04:33 +0100)]
resourceloader: Reduce 'implement' overhead for modules without scripts
Change-Id: I55728c526711545be3923d3e1e2f276cbfa52224
Roan Kattouw [Sat, 9 Feb 2019 00:53:48 +0000 (16:53 -0800)]
mediawiki.language: Deprecate mw.language.specialCharacters
Use require( 'mediawiki.language.specialCharacters' ) instead.
Remove mw.language.setSpecialCharacters(), because it was only used by
the specialCharacters module. There already was no getter.
Depends-On: I9cf525a1e1aadc12d72284d08b98882b0ab95f5e
Depends-On: I74e706a6603bd8fa899193de91e49f246608c4c1
Change-Id: I02e0e84b79309caa314954925cc9c0c2874b9bde
jenkins-bot [Sat, 9 Feb 2019 22:37:17 +0000 (22:37 +0000)]
Merge "Drop SessionManager::autoCreateUser(), deprecated in 1.27 and unused"
Timo Tijhof [Sat, 9 Feb 2019 01:21:46 +0000 (01:21 +0000)]
mediawiki.user: Remove deprecated stickyRandomId()
Introduced and renamed/deprecated in the same cycle (MW 1.32), was
meant to be removed before release but forgotten.
Change-Id: I4bb219a1e38e15651115b70277e1968886dca690
Timo Tijhof [Sat, 9 Feb 2019 01:16:05 +0000 (01:16 +0000)]
mediawiki.libs.jpegmeta: Remove deprecated mw.libs property
Deprecated since 1.31.
Also fix existing uses to not use the private mw.loader access
pattern, which is unsupported and not needed here.
Depends-On: If0a125320af15b92216d98f54348f8b375cc1988
Change-Id: I403379ebf710077b77a02854c22071014d1a6bc4
jenkins-bot [Sat, 9 Feb 2019 22:32:47 +0000 (22:32 +0000)]
Merge "Drop b/c reading of wgSessionsInObjectCache and wgSessionHandler, deprecated in 1.27"
jenkins-bot [Sat, 9 Feb 2019 22:16:53 +0000 (22:16 +0000)]
Merge "resourceloader: Misc optimisations in startup module"
James D. Forrester [Sat, 9 Feb 2019 01:41:28 +0000 (17:41 -0800)]
Drop SessionManager::autoCreateUser(), deprecated in 1.27 and unused
Depends-On: I261ea755c1d273ccc7fcc7c3b041623ccf4e331b
Change-Id: Ice2d755bee694b97e5ddbfc72caddf2b87ba0fc9
James D. Forrester [Sat, 9 Feb 2019 20:59:00 +0000 (12:59 -0800)]
Drop b/c reading of wgSessionsInObjectCache and wgSessionHandler, deprecated in 1.27
Depends-On: I0d861a24b6cfd5c881112f15c682d97cef715cf0
Change-Id: I6b69d9ad3863512879f287f960828c1fdf7b214c
James D. Forrester [Sat, 9 Feb 2019 01:43:08 +0000 (17:43 -0800)]
Drop User::getGroup{Name|Member}(), deprecated in 1.29 and unused
Except in the Configure extension.
Change-Id: Id6e2511cc2c5f86afcf0af2faa69d4a712efbe26
James D. Forrester [Sat, 9 Feb 2019 20:18:35 +0000 (12:18 -0800)]
Drop EmailNotification::updateWatchlistTimestamp(), deprecated in 1.27 and unused
Change-Id: Idad6f5aa579e41e941d1074465dd2f0e0f4577dc