jenkins-bot [Thu, 1 Aug 2019 20:59:05 +0000 (20:59 +0000)]
Merge "Fix bogus field use in RevisionRenderer::getSpeculativePageId"
Aaron Schulz [Thu, 1 Aug 2019 19:57:22 +0000 (15:57 -0400)]
Fix bogus field use in RevisionRenderer::getSpeculativePageId
This field was renamed, causing a functional merge conflict
Follow-up
5099ee9f7273
Bug: T229589
Change-Id: I7a6bb68ff1fe320313276dc5a67c70de6715ccb6
Aaron Schulz [Thu, 1 Aug 2019 18:25:27 +0000 (14:25 -0400)]
Clean up $wgFileBackends/$wgLockManagers comments
Change-Id: Ib9692176f0e100f3b0c39544109ef2d8a8c8cd92
jenkins-bot [Thu, 1 Aug 2019 17:40:05 +0000 (17:40 +0000)]
Merge "Add missing title info in RenderedRevision::outputVariesOnRevisionMetaData()"
jenkins-bot [Thu, 1 Aug 2019 17:39:12 +0000 (17:39 +0000)]
Merge "Cleanup UserGroupMembership::insert() and make it more atomic"
Aaron Schulz [Wed, 31 Jul 2019 02:02:55 +0000 (22:02 -0400)]
Cleanup UserGroupMembership::insert() and make it more atomic
Bug: T229456
Change-Id: Ibf7900dd9273d3befb5c7f0c4ed46b65bd3b0ae4
jenkins-bot [Thu, 1 Aug 2019 17:01:27 +0000 (17:01 +0000)]
Merge "API: Create a module bundle for 'apipretty' and 'apihelp'"
jenkins-bot [Thu, 1 Aug 2019 16:58:26 +0000 (16:58 +0000)]
Merge "filebackend: avoid use of IDatabase::clearFlags() in DBLockManager"
jenkins-bot [Thu, 1 Aug 2019 16:58:17 +0000 (16:58 +0000)]
Merge "resourceloader: Remove getters for private constants in mw.loader.store"
jenkins-bot [Thu, 1 Aug 2019 16:31:57 +0000 (16:31 +0000)]
Merge "Suppress notice from ParserOutput::__sleep()"
jenkins-bot [Thu, 1 Aug 2019 16:28:09 +0000 (16:28 +0000)]
Merge "resourceloader: Remove slow structure test for checking getVersionHash"
Timo Tijhof [Thu, 1 Aug 2019 00:19:45 +0000 (01:19 +0100)]
resourceloader: Remove slow structure test for checking getVersionHash
This isn't needed because the startup module validates this already.
The vast majority of modules are FileModule instances which can't be invalid,
because a separate test asserts that class already. This test existed for
validating the format of version hashes returned by a theoretical Module
sub class in an extension that (badly) overrides the getVersionHash method.
As of writing, no extension overrides that method. And more importantly,
the startup module already validates this at run-time, and logs a warning.
This commit turns that into an exception, which would get logged in a way
that Jenkins will fail the build if encountered.
This structure test, which computed the response for all registered modules,
previously took 3-5 seconds in CI.
Bug: T225730
Change-Id: Id2e37434b0ccd95dd2279f04e2230e9c06b09ccb
jenkins-bot [Thu, 1 Aug 2019 11:42:11 +0000 (11:42 +0000)]
Merge "resourceloader: Avoid escaping of UTF-8 characters in messages"
Aaron Schulz [Thu, 1 Aug 2019 08:11:49 +0000 (04:11 -0400)]
Add missing title info in RenderedRevision::outputVariesOnRevisionMetaData()
Follows
3a044ca51ce9b.
Bug: T226785
Change-Id: I03cf35ee2773cfeb887edec8bc447c834bab5a2a
Fomafix [Tue, 30 Jul 2019 04:52:59 +0000 (06:52 +0200)]
resourceloader: Avoid escaping of UTF-8 characters in messages
It's not needed to escape UTF-8 characters in messages.
The characters '&', '<' and '>' are still escaped. For the output in
load.php this escaping is not necessary but messages can also embedded
into <script> tags and here are the characters '<' and '>' problematic.
Bug: T229301
Change-Id: If424a21df4a813ba6cb79b939f0857d96f162a17
Bartosz Dziewoński [Thu, 1 Aug 2019 02:32:02 +0000 (04:32 +0200)]
mediawiki.Upload.BookletLayout: Add missing message
Bug: T203058
Change-Id: If1274da9b9dca5595201c298ffd35576ef7b7e52
Timo Tijhof [Thu, 1 Aug 2019 00:40:19 +0000 (01:40 +0100)]
resourceloader: Remove getters for private constants in mw.loader.store
Turn the private getter methods into private properties.
Shorter, simpler, faster.
Change-Id: I8c7a7c566983ba6ac78cd2feb5d0ec6debb3773c
Tim Starling [Thu, 1 Aug 2019 00:08:38 +0000 (10:08 +1000)]
Suppress notice from ParserOutput::__sleep()
Bug: T229366
Change-Id: I8f0a537f0b6b76aac0c52e691ec4653c51c49940
jenkins-bot [Thu, 1 Aug 2019 00:01:08 +0000 (00:01 +0000)]
Merge "Make CliInstaller control the processing logic of the error"
jenkins-bot [Wed, 31 Jul 2019 23:07:22 +0000 (23:07 +0000)]
Merge "context: Use getRawVal instead of getVal for 'uselang' and 'useskin'"
jenkins-bot [Wed, 31 Jul 2019 20:42:59 +0000 (20:42 +0000)]
Merge "Localisation updates from https://translatewiki.net."
jenkins-bot [Wed, 31 Jul 2019 20:11:03 +0000 (20:11 +0000)]
Merge "Fix documentation of languageinfo name prop"
Translation updater bot [Wed, 31 Jul 2019 20:07:56 +0000 (22:07 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ie2a14a24bf788729b75ce23b7fec1b0bf5d9c02e
jenkins-bot [Wed, 31 Jul 2019 17:34:55 +0000 (17:34 +0000)]
Merge "resourceloader: Remove deprecated ResourceLoaderContext::expandModuleNames"
jenkins-bot [Wed, 31 Jul 2019 16:58:32 +0000 (16:58 +0000)]
Merge "resourceloader: Only register 'jquery.qunit' in test context"
jenkins-bot [Wed, 31 Jul 2019 16:58:26 +0000 (16:58 +0000)]
Merge "resourceloader: Don't explicitly enqueue test libs on SpecialJavaScriptTest"
jenkins-bot [Wed, 31 Jul 2019 16:52:13 +0000 (16:52 +0000)]
Merge "resourceloader: Hard-deprecate ResourceLoaderContext::getConfig"
jenkins-bot [Wed, 31 Jul 2019 15:06:33 +0000 (15:06 +0000)]
Merge "preferences: Fix skinname msg check in generateSkinOptions"
jenkins-bot [Wed, 31 Jul 2019 14:15:14 +0000 (14:15 +0000)]
Merge "Add QueryPage::delete method"
Timo Tijhof [Tue, 30 Jul 2019 14:25:23 +0000 (15:25 +0100)]
resourceloader: Hard-deprecate ResourceLoaderContext::getConfig
Already in 1.34 release notes from when it was soft-deprecated, earlier
this release cycle.
Depends-On: I949b91daabb0cf16519ef02e718ad97c827c4eec
Depends-On: Icf1ead8829268505709c71f46dede5cdfc4471a8
Change-Id: I471088b322848a779d0dd58651dc1bd0d49067f1
jenkins-bot [Wed, 31 Jul 2019 13:28:54 +0000 (13:28 +0000)]
Merge "Allow SelectWithInput to be marked as required and handle that dynamically"
jenkins-bot [Wed, 31 Jul 2019 12:36:45 +0000 (12:36 +0000)]
Merge "Fix SpecialBlock validation for ipb_allow_usertalk"
Tim Starling [Wed, 31 Jul 2019 02:16:07 +0000 (12:16 +1000)]
Revert rename of mSpeculativeRevId to speculativeRevIdUsed
And add a test which is confirmed to fail on HHVM prior to this change
with the error message "serialize(): "" returned as member variable from
__sleep() but does not exist".
Bug: T229366
Change-Id: I236bb4d64bc2e9f7756885e8c418399804eac5e1
jdlrobson [Tue, 30 Jul 2019 21:18:05 +0000 (14:18 -0700)]
preferences: Fix skinname msg check in generateSkinOptions
Fixes a bug introduced in
b2b204eeafc.
$useSkin is not the appropriate variable to check here - we want
to check the skin set in preferences.
Bug: T223824
Change-Id: I666e30dd9ff396fd39c47b362d66670dfaa92ca9
jenkins-bot [Tue, 30 Jul 2019 21:44:56 +0000 (21:44 +0000)]
Merge "context: Make the getSkin() fallback logic more explicit"
jenkins-bot [Tue, 30 Jul 2019 21:44:49 +0000 (21:44 +0000)]
Merge "Fix recent changes and watchlist separator whitespace"
David Barratt [Mon, 22 Jul 2019 22:53:14 +0000 (18:53 -0400)]
Allow SelectWithInput to be marked as required and handle that dynamically
Alters the SelectWithInput to allow a required config to be passed from a
parent widget. Also handles the required state dynamically. If the widget is
an OR widget, then only the select dropdown is required. The text input will
be required when the other option is selected. If the widget is an AND widget
then both the select dropdown and the text input will be required.
Bug: T220533
Change-Id: I8479743126756f2b1bd7bcd53b100a0134f34d07
jenkins-bot [Tue, 30 Jul 2019 20:26:36 +0000 (20:26 +0000)]
Merge "Fix return type hints in media related classes"
Dayllan Maza [Tue, 30 Jul 2019 02:15:56 +0000 (22:15 -0400)]
Fix SpecialBlock validation for ipb_allow_usertalk
ipb_allow_usertalk should be saved as false only when:
A block is sitewide
A block is partial and there is a restriction on the User_talk namespace
Bug: T224468
Change-Id: Ic85368991b5905af1bab99b0cb5fcba0e993405e
edderso [Tue, 30 Jul 2019 17:46:47 +0000 (18:46 +0100)]
Fix recent changes and watchlist separator whitespace
Added spaces around 'mw-changeslist-separator' spans in EnhancedChangesListGroup.mustache
Bug: T222903
Change-Id: Ie7e09a39a8f51943fa6c2c244d80435150296a5c
Timo Tijhof [Tue, 30 Jul 2019 00:05:42 +0000 (01:05 +0100)]
resourceloader: Only register 'jquery.qunit' in test context
Change-Id: I0ea4bb73d5b886ea903a19a12bdd464778af0002
Timo Tijhof [Tue, 30 Jul 2019 15:06:35 +0000 (16:06 +0100)]
resourceloader: Don't explicitly enqueue test libs on SpecialJavaScriptTest
The test-only modules registered by QUnitTestResources.php are currently
were previously caught by the array_keys() catch-all in registerTestModules()
which meant that modules like 'test.sinonjs' would be requested on
SpecialJavaScriptTest despite not doing anything by itself, nor executing
at the "right" time per se through this means.
In order for it to execute at the right time, the testrunner has to depend
on it (which it does, already). But, that also means it doesn't need to
be requested separately. Doing so could be confusing.
This is neccecary in order to move 'jquery.qunit' from Resources.php
to QUnitTestResources.php as otherwise, listing in QUnitTestResources.php,
would implicitly mean SpecialJavaScriptTest.php thinks it's a test suite
and load it. That is a problem, because when we run the tests headless from
the command-line with Karma, the environment already has a QUnit interface
defined, and should not be loaded a second time by MW.
Change-Id: I08b31cd1dee516cf0d26bafdb8cc7c1223633bad
Aaron Schulz [Tue, 30 Jul 2019 15:37:34 +0000 (11:37 -0400)]
filebackend: avoid use of IDatabase::clearFlags() in DBLockManager
Change-Id: I143533790363d8bb9b9038cf320b251131602d4a
jenkins-bot [Tue, 30 Jul 2019 15:23:06 +0000 (15:23 +0000)]
Merge "Adapt Recent Changes advanced filters for mobile usage"
Timo Tijhof [Tue, 30 Jul 2019 14:28:21 +0000 (15:28 +0100)]
resourceloader: Remove deprecated ResourceLoaderContext::expandModuleNames
Change-Id: If9aa389cc64cb41e60c865d586d644d9f3bca9b5
jenkins-bot [Tue, 30 Jul 2019 14:15:57 +0000 (14:15 +0000)]
Merge "Fix punctuation in HTMLForm documentation"
Thalia [Tue, 30 Jul 2019 13:43:39 +0000 (14:43 +0100)]
Fix punctuation in HTMLForm documentation
Change-Id: I22c4ed248fddc93afd486b9bee5a80bdbba1c685
Derick Alangi [Sat, 27 Jul 2019 18:29:24 +0000 (19:29 +0100)]
pager: Add visibility methods declared in the Pager interface
In addition, also add visibility to the class(es) that implement
the method.
Change-Id: If650cfcafbe4fe8cd4d2e0629df3f170c599ea41
Jan Drewniak [Fri, 14 Jun 2019 10:04:01 +0000 (12:04 +0200)]
Adapt Recent Changes advanced filters for mobile usage
Changes the behaviour of the rcfilter search input by essentially
turning it into a button for mobile devices. Depending on the value
of `OO.ui.isMobile()` the input is set to readonly mode and given
a shorter message and different icon.
Setting the search input to readonly prevents onscreen keyboards from
being actived, but still opens the filter menu, so that mobile users
can still add/remove filters, just without the ability to search through
them.
Styles are also modified to make the search input appear as a button by
overriding the default readonly and placeholder styles.
Bug: T225499, T223230
Change-Id: Iaa67369542e658d3571d957a204daa7a53d1e520
Translation updater bot [Tue, 30 Jul 2019 06:20:29 +0000 (08:20 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I1b7b2936762e14eb43e9d777c3c3d198b66e4e6d
jenkins-bot [Tue, 30 Jul 2019 01:30:09 +0000 (01:30 +0000)]
Merge "Add SearchResultSetTrait"
jenkins-bot [Tue, 30 Jul 2019 01:29:33 +0000 (01:29 +0000)]
Merge "Add BaseSearchResultSet"
Timo Tijhof [Tue, 30 Jul 2019 00:17:35 +0000 (01:17 +0100)]
API: Create a module bundle for 'apipretty' and 'apihelp'
These are both fairly small modules used in related low-traffic
scenarios. The cost of registering both globally on all page views
as a top-level entry point does not seem worth the marginal gain
of loading only one of these two in the contexts where they are
needed.
Change-Id: I42458ebec3f8d6e14e52e44d62fb914fcbeda5db
Timo Tijhof [Mon, 29 Jul 2019 22:42:57 +0000 (23:42 +0100)]
context: Make the getSkin() fallback logic more explicit
Previously the first two post-hook checks where mutually exclusive
and the fallback was generic (not conditional) which means we
would also allow the first two conditions to succeed in a way that
leaves $this->skin as null.
Aside from that not being possible right now, it also duplicates a
null check in two places, which isn't ideal.
Codify that the first two blocks always result in $this->skin
being assigned non-null by using an 'else' branch instead of another
generic check.
Change-Id: I7986684bf1bb2daad3aaddfbcd2ca02e652f78c2
jenkins-bot [Mon, 29 Jul 2019 23:25:36 +0000 (23:25 +0000)]
Merge "Add explicit visibility to SearchResult methods"
jenkins-bot [Mon, 29 Jul 2019 23:25:29 +0000 (23:25 +0000)]
Merge "Add explicit visibility to ISearchResultSet methods"
Timo Tijhof [Mon, 29 Jul 2019 22:57:43 +0000 (23:57 +0100)]
context: Use getRawVal instead of getVal for 'uselang' and 'useskin'
Bug: T189966
Change-Id: I9db7b3f36f5457e80aa9b673bcb56deb83e47a18
jenkins-bot [Mon, 29 Jul 2019 21:59:09 +0000 (21:59 +0000)]
Merge "Update gradient mixins from OOUI, add horizontal-gradient"
jenkins-bot [Mon, 29 Jul 2019 21:41:27 +0000 (21:41 +0000)]
Merge "MessageCache: Restore 'loadedLanguages' tracking for load()"
jenkins-bot [Mon, 29 Jul 2019 21:21:39 +0000 (21:21 +0000)]
Merge "Deprecate several public properties on the block classes"
Thalia [Mon, 29 Jul 2019 20:10:27 +0000 (21:10 +0100)]
Deprecate several public properties on the block classes
Public methods for checking and setting these properties already
exist where needed. Also update the remaining direct uses of these
properties in core.
Change-Id: Icdef025c9700e625aeb2a07975e69f1b1cc2466c
Ed Sanders [Mon, 29 Jul 2019 20:07:31 +0000 (21:07 +0100)]
Update gradient mixins from OOUI, add horizontal-gradient
Change-Id: I31ab76ea938f29c3d39456f093268780a44c014e
jenkins-bot [Mon, 29 Jul 2019 19:50:55 +0000 (19:50 +0000)]
Merge "Fix SlotDiffRenderer documentation"
jenkins-bot [Mon, 29 Jul 2019 19:42:22 +0000 (19:42 +0000)]
Merge "rdbms: make DatabaseSqlite::open() also check DBO_DEFAULT"
jenkins-bot [Mon, 29 Jul 2019 19:34:55 +0000 (19:34 +0000)]
Merge "externalstore: use CONN_TRX_AUTOCOMMIT instead of IDatabase::clearFlag()"
jenkins-bot [Mon, 29 Jul 2019 19:11:55 +0000 (19:11 +0000)]
Merge "CopyTextLayout: Only select-all on focus"
Timo Tijhof [Mon, 29 Jul 2019 18:22:10 +0000 (19:22 +0100)]
MessageCache: Restore 'loadedLanguages' tracking for load()
This was removed in
97e86d934b3 in 2018 in favour of using
`$this->cache->has($code)`. This is a problem because there
are cases where only a narrow subset of that structure is
populated (by MessageCache->replace) without things like
$this->overridable (or anything else that MessageCache->load does)
having ocurred yet.
The assumption that keys are only added to $this->cache by
MessageCache->load (or after that method has been called) was
actually true at some point. But, this changed in 2017 when
commit
c962b480568e optimised MessageCache->replace to not call
MessageCache->load.
Bug: T208897
Change-Id: Ie8bb4a4793675e5f1454e65c427f3100035c8b4d
Lucas Werkmeister [Mon, 29 Jul 2019 17:12:17 +0000 (19:12 +0200)]
Fix documentation of languageinfo name prop
A separate lilang parameter existed in some patch sets of change
Ic66991cd85, but was ultimately abandoned again in favor of respecting
the general uselang parameter. Apparently I forgot to update the
documentation, though.
Change-Id: I2722f7a513c963bb9fec0308c413ae02e00851c6
Ed Sanders [Mon, 29 Jul 2019 14:51:33 +0000 (15:51 +0100)]
CopyTextLayout: Only select-all on focus
This allows users to partially select the text, which is useful
in some cases, but still makes it easy to copy either using a keyboard
shortcut or the ButtonWidget.
Bug: T110579
Change-Id: I5be1530bb2cca9f8251e2e1c87a85e1e79cfe47f
jenkins-bot [Mon, 29 Jul 2019 13:11:57 +0000 (13:11 +0000)]
Merge "Remove TODO for unblockself"
RazeSoldier [Sat, 27 Jul 2019 15:38:54 +0000 (23:38 +0800)]
Make CliInstaller control the processing logic of the error
Previously, if there was an error during CLI installation,
CliInstaller::showStatusMessage() exited the script directly. The exit
timing of the script should be given to the caller, not the callee.
So, I coding:
[1] Remove `exit()` from CliInstaller::showStatusMessage()
[2] Make the callee to return Status, the caller determine how to handle these Status
[3] Strictly check the key database type instead of just outputting message
Bug: T46511
Change-Id: I72ffd33fe5c592b9ea78f37bae5a9c081295c624
Brad Jorsch [Tue, 23 Jul 2019 16:02:11 +0000 (12:02 -0400)]
Better handle "no accounts to unlink" case in Special:UnlinkAccounts
When there are no accounts to unlink, say so rather than displaying a
button that results in an error when clicked.
Bug: T228717
Change-Id: I17f8aed213f114338c4b46e26ce369bc63e36a99
Aaron Schulz [Sun, 28 Jul 2019 16:38:29 +0000 (12:38 -0400)]
rdbms: make DatabaseSqlite::open() also check DBO_DEFAULT
Change-Id: Ib21078dc9d4aa8cba6c5cb6c25868af328c1cab6
jenkins-bot [Sat, 27 Jul 2019 14:51:08 +0000 (14:51 +0000)]
Merge "objectcache: make "busyValue" stricter to avoid callback ambigiuity"
jenkins-bot [Sat, 27 Jul 2019 14:23:46 +0000 (14:23 +0000)]
Merge "import: Fix wrong/unspecific type hints in UploadSourceAdapter"
Aaron Schulz [Sat, 27 Jul 2019 09:08:06 +0000 (05:08 -0400)]
externalstore: use CONN_TRX_AUTOCOMMIT instead of IDatabase::clearFlag()
Change-Id: I8984623d3ff67d305597f05c596c2777c2c117e0
Aaron Schulz [Fri, 19 Jul 2019 10:31:46 +0000 (03:31 -0700)]
objectcache: make "busyValue" stricter to avoid callback ambigiuity
Change-Id: I01a1503ff5b37d65ef148fef79270505d8eb3146
Translation updater bot [Sat, 27 Jul 2019 06:18:05 +0000 (08:18 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I3289a8380de64e080ec1f19e3a443e27795f9d51
David Barratt [Fri, 19 Jul 2019 18:12:06 +0000 (14:12 -0400)]
Remove TODO for unblockself
It is impossible to reach the unblockself code if someone is anonymous, so
there is no need to check that the block applies to that permission.
Bug: T228538
Change-Id: Ie7b1e0f37363cc9e75ee2c871c06cefdfb2eb1d1
jenkins-bot [Fri, 26 Jul 2019 23:03:53 +0000 (23:03 +0000)]
Merge "Follow-up
f7cddcf7c1: Move RELEASE-NOTES-1.34 entry to right place"
jenkins-bot [Fri, 26 Jul 2019 22:52:24 +0000 (22:52 +0000)]
Merge "QueryPage: allow arbitrary sorting"
James D. Forrester [Fri, 26 Jul 2019 21:39:48 +0000 (14:39 -0700)]
Follow-up
f7cddcf7c1: Move RELEASE-NOTES-1.34 entry to right place
This isn't a deprecation, it's a breaking config change, which we
put in either the "changed configuration" or the "breaking changes"
sections. In this case I'm dumping it into the former as that's
more frequently read by sysadmins.
Change-Id: I9d63be2ec6392b66c50fb96ada510584da9ec16a
Gergő Tisza [Fri, 26 Jul 2019 14:47:09 +0000 (16:47 +0200)]
Add QueryPage::delete method
Add a method for delete the cached result for a page. This is
useful for backlog-type query pages which provide some interface
for fixing the problem in-place.
Change-Id: I36b750d71b6551bb5c662e82c24f029db01acd3b
jenkins-bot [Fri, 26 Jul 2019 20:27:45 +0000 (20:27 +0000)]
Merge "resourceloader: Move 'mw.config' assignment from startup.js to mediawiki.js"
jenkins-bot [Fri, 26 Jul 2019 20:24:18 +0000 (20:24 +0000)]
Merge "resourceloader: Remove internal 'wgResourceLoaderStorageEnabled' from mw.config"
Umherirrender [Sat, 30 Mar 2019 20:14:52 +0000 (21:14 +0100)]
Deprecate wrapper SVGMetadataExtractor::getMetadata
Use SVGReader->getMetadata() directly. Also rename the test,
because it covers the implementation and not the wrapper.
Change-Id: I61565c6aadc6d1c1e942b9bc4555ef4aeb09e5d8
Gergő Tisza [Fri, 26 Jul 2019 17:51:26 +0000 (19:51 +0200)]
QueryPage: allow arbitrary sorting
When the value field is not provided in QueryPage::getQueryInfo,
it is set to zero, essentially randomizing the result. Use a
sequential index instead.
Change-Id: I8b67268e3c59a51ed00bd832f80df184dd771c3b
Aaron Schulz [Sat, 20 Jul 2019 21:09:31 +0000 (14:09 -0700)]
Inject getLocalServerObjectCache() into the CachingSiteStore instance
This means SiteStore now uses APCu on PHP7 as well. Previously it only
used APC on HHVM, and used the main cache (e.g. Memcached) on PHP7.
Change-Id: I83ff1d2dd61c611c9976c6f9ca8026a0b6dd6662
jenkins-bot [Fri, 26 Jul 2019 16:09:39 +0000 (16:09 +0000)]
Merge "ApiSandbox: Fix upload widget"
jenkins-bot [Fri, 26 Jul 2019 15:27:09 +0000 (15:27 +0000)]
Merge "Don't try to store File objects to the upload session"
jenkins-bot [Fri, 26 Jul 2019 15:16:38 +0000 (15:16 +0000)]
Merge "rdbms: remove various deprecated methods"
jenkins-bot [Fri, 26 Jul 2019 15:11:15 +0000 (15:11 +0000)]
Merge "Fix exception when viewing special pages with relative related titles"
Brad Jorsch [Fri, 26 Jul 2019 15:03:24 +0000 (11:03 -0400)]
ApiSandbox: Fix upload widget
Attempting to send the request with an active upload widget was
producing a JavaScript error "TypeError: this.setIcon is not a
function". This was probably broken by Iaaa226ea.
Further, validation was not working correctly since getValue() was
returning undefined rather than null as documented. This was probably
broken by I8d736fbb.
Bug: T229123
Change-Id: I78a6f9f0cffcd229ec0ab80c2309a0ee2089c927
Aaron Schulz [Thu, 27 Jun 2019 08:13:13 +0000 (01:13 -0700)]
rdbms: remove various deprecated methods
Change-Id: I5ae923065a08078225b7df080cb92edca799ebaf
jenkins-bot [Fri, 26 Jul 2019 14:55:33 +0000 (14:55 +0000)]
Merge "Code cleanup related to initSpeculativePageId()"
jenkins-bot [Fri, 26 Jul 2019 14:53:30 +0000 (14:53 +0000)]
Merge "rdbms: make LoadBalancer::waitForAll() include servers with load in any group"
Aaron Schulz [Thu, 11 Jul 2019 02:35:46 +0000 (19:35 -0700)]
rdbms: normalize Database open() code and error handling
Mainly:
* Use oci_new_connect() for Oracle to avoid broken connection reuse
similar to the PGSQL_CONNECT_FORCE_NEW flag in DatabasePostgres
* Set 'client_min_messages' unconditionally for PostgreSQL
* Factor out Database::getConnectExceptionAndLog() helper method
* Use the same style of query() calls in DatabaseOracle::open() as
the other subclasses
* Make sure the Database driver handle field is null on failure
instead of false for sanity
Also:
* Disallow changing of Database handle DBO_* flags after construction
where it does not make sense to change them
* Do not mention DBO_* flags meant for non-config use in $wgDBservers
* Ignore DBO_PERSISTENT for SQLite if DBO_TRX is also set for sanity
* Remove $wgDBOracleDRCP variable to discourage careless automatic
setting of DBO_PERSISTENT that breaks LoadBalancer assumptions
Change-Id: Iea948f7f872294ea8fc5d897fc10c9d29b7141d5
jenkins-bot [Fri, 26 Jul 2019 14:02:29 +0000 (14:02 +0000)]
Merge "Convert LoadBalancer::getConnection() callers to LoadBalancer::getConnectionRef()"
Tim Starling [Fri, 26 Jul 2019 06:39:16 +0000 (16:39 +1000)]
Code cleanup related to initSpeculativePageId()
Change-Id: I5b97c6292a28df6633c573a05c89210b096db5a8
Aaron Schulz [Thu, 27 Jun 2019 04:30:35 +0000 (21:30 -0700)]
parser: add speculative page IDs to use with {{PAGEID}}
This works similarly to speculative rev IDs with {{REVISIONID}}.
Re-parses can be avoided if the page ID is correctly guessed.
Also make the {{PAGEID:X}} parser function set vary-page-id.
Bug: T226785
Change-Id: I0b19be45e6ddd6cde330bfcd09d243e4e5beda01