jenkins-bot [Tue, 20 Sep 2016 17:54:42 +0000 (17:54 +0000)]
Merge "Improve tableExists() for MySQL"
Aaron Schulz [Tue, 20 Sep 2016 17:30:00 +0000 (10:30 -0700)]
Improve tableExists() for MySQL
Use SHOW TABLES to avoid log spam when the table does not exist.
This should make the CLI jenkins log a bit more readable.
Change-Id: I027a9d0af0e42959e9f03cebb295218068a263d3
jenkins-bot [Tue, 20 Sep 2016 16:38:11 +0000 (16:38 +0000)]
Merge "Extract replacePrefixes into a static method"
jenkins-bot [Tue, 20 Sep 2016 13:56:21 +0000 (13:56 +0000)]
Merge "WikiPage::getDeletionUpdates returns DeferrableUpdates"
jenkins-bot [Tue, 20 Sep 2016 13:54:09 +0000 (13:54 +0000)]
Merge "phpdoc Title::inNamespaces also allows array"
addshore [Tue, 20 Sep 2016 12:34:14 +0000 (13:34 +0100)]
phpdoc Title::inNamespaces also allows array
Change-Id: I201dbaf9c0dee5b47c4edde73ff68b88560e8a0f
addshore [Tue, 20 Sep 2016 12:09:09 +0000 (13:09 +0100)]
WikiPage::getDeletionUpdates returns DeferrableUpdates
This means the hook also only needs to add
DeferrableUpdate object rather than DataUpdate objects
Change-Id: Ic19c93860aa364d4e1b69a20ed6bbcd61f6f4979
jenkins-bot [Tue, 20 Sep 2016 08:26:06 +0000 (08:26 +0000)]
Merge "Replace $wiki with $domain in ILoadBalancer"
jenkins-bot [Tue, 20 Sep 2016 08:10:56 +0000 (08:10 +0000)]
Merge "Make rebuildFileCache cover ?action=history"
Aaron Schulz [Wed, 14 Sep 2016 20:36:34 +0000 (13:36 -0700)]
Make rebuildFileCache cover ?action=history
Also simplified the logic slightly
Change-Id: I6145d52b6b701735fa4bd8e41e07fb2bf6fdcee3
Aaron Schulz [Tue, 20 Sep 2016 07:32:06 +0000 (00:32 -0700)]
Replace $wiki with $domain in ILoadBalancer
Change-Id: I1752d3358a8fc4314dfd497f3e08d3d5a6bfdd39
jenkins-bot [Tue, 20 Sep 2016 06:43:04 +0000 (06:43 +0000)]
Merge "Include setTableAliases/setDomainPrefix in ILoadBalancer"
jenkins-bot [Tue, 20 Sep 2016 06:41:32 +0000 (06:41 +0000)]
Merge "Database class parameter and documentation cleanups"
Aaron Schulz [Tue, 20 Sep 2016 06:33:30 +0000 (23:33 -0700)]
Include setTableAliases/setDomainPrefix in ILoadBalancer
Also remove redundant LoadBalancer documentation.
Change-Id: Ib9a678349cf850f1cec498a8534e546bf9f41386
Aaron Schulz [Mon, 19 Sep 2016 23:34:32 +0000 (16:34 -0700)]
Database class parameter and documentation cleanups
* Document various parameter arrays.
* Fix $user = false loophole in Database::__construct().
* Set the Postgres port *before* calling super, as it is
needed by open().
* Remove 'chronProt' parameter as it is lazy-loaded.
Change-Id: Icc1037efa1eee7ae6fdd2919f60001e6e29ae55c
jenkins-bot [Tue, 20 Sep 2016 00:51:35 +0000 (00:51 +0000)]
Merge "mediawiki.UI: Make colors' contrast compliant to WCAG 2.0 level AA"
jenkins-bot [Mon, 19 Sep 2016 23:49:02 +0000 (23:49 +0000)]
Merge "Fix undefined getDelimiter() call in sql.php"
Aaron Schulz [Mon, 19 Sep 2016 20:00:19 +0000 (13:00 -0700)]
Change DatabaseBase::factory call to Database::factory in LoadBalancer
Change-Id: Id4bbc08b5aa913e2e3e47a7873db600fe957c985
jenkins-bot [Mon, 19 Sep 2016 22:40:18 +0000 (22:40 +0000)]
Merge "Remove unused DatabaseBase::debug() method"
jenkins-bot [Mon, 19 Sep 2016 22:32:26 +0000 (22:32 +0000)]
Merge "Fix broken $wgExternalServers example setting"
Aaron Schulz [Mon, 19 Sep 2016 21:17:19 +0000 (14:17 -0700)]
Fix undefined getDelimiter() call in sql.php
* Fixes regression from
4ef4438739.
* Also fixed numerous IDEA warnings.
Change-Id: Id41faff835ca25399ce1ceb10a19d19ffc914689
jenkins-bot [Mon, 19 Sep 2016 22:23:51 +0000 (22:23 +0000)]
Merge "Fix "externalCluster" LBFactorySimple setting in LBFactoryMW"
Aaron Schulz [Mon, 19 Sep 2016 22:16:29 +0000 (15:16 -0700)]
Fix broken $wgExternalServers example setting
Just reference $wgDBservers instead, which uses the same format.
Change-Id: Iaa32cb067f9487b459925310ac4c52efe3f4a3f1
Aaron Schulz [Mon, 19 Sep 2016 22:13:43 +0000 (15:13 -0700)]
Fix "externalCluster" LBFactorySimple setting in LBFactoryMW
Fixes regression from
d175b391ae2a
Change-Id: I4bbc875e2fcd021e342959a37475ec356cb58cce
Volker E [Fri, 15 Jan 2016 03:07:10 +0000 (19:07 -0800)]
mediawiki.UI: Make colors' contrast compliant to WCAG 2.0 level AA
Establishing Web Accessibility Guidelines level AA color contrast
compliance by aligning to improved color palette, similar to
I6fdb90af8b9dc5e5e026eb0c1bd13138c73da4cd
Bug: T109915
Change-Id: I191f8ec731eeef0827124741200c51cb42ba99f8
Aaron Schulz [Mon, 19 Sep 2016 17:37:57 +0000 (10:37 -0700)]
Move DatabasePostgres to /libs/rdbms
Fixed all IDEA warnings in the postgres classes too.
Change-Id: I06b4c5b2c581fb65552d980cc106aa10fed40285
Aaron Schulz [Mon, 19 Sep 2016 21:25:35 +0000 (14:25 -0700)]
Remove unused DatabaseBase::debug() method
This just trivially wrapped getFlags()/setFlags() anyway
Change-Id: Iab5b508f6746098b66da00c8bf038215cb2359ef
jenkins-bot [Mon, 19 Sep 2016 20:21:16 +0000 (20:21 +0000)]
Merge "Remove strictIPs(), cascadingDeletes(), and cleanupTriggers()"
L10n-bot [Mon, 19 Sep 2016 20:17:20 +0000 (20:17 +0000)]
Merge "Localisation updates from https://translatewiki.net."
Aaron Schulz [Fri, 16 Sep 2016 05:37:29 +0000 (22:37 -0700)]
Remove strictIPs(), cascadingDeletes(), and cleanupTriggers()
These DatabaseBase methods have no callers are were a mistake to
begin with. They only encouraged code forking and incompatibilities
among different backing DB types.
Also removed stray realTimestamps() method that was left over
from prior removals.
Change-Id: I37bef8585151e2782d2c88b5ae1e6752109c6ac7
Translation updater bot [Mon, 19 Sep 2016 20:06:14 +0000 (22:06 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ia226031f53b3b32abf5cec62bda2c90548ee940b
jenkins-bot [Mon, 19 Sep 2016 20:04:28 +0000 (20:04 +0000)]
Merge "Fix SQLite $wgObjectCaches definition + b/c handling"
Marius Hoch [Mon, 19 Sep 2016 19:01:56 +0000 (21:01 +0200)]
Fix SQLite $wgObjectCaches definition + b/c handling
Follow-up to
47e816c69c197fec86c344256d81d7c8f781b880
Change-Id: Id94857a7c8726871cf826a34b5cf10cb465b7125
jenkins-bot [Mon, 19 Sep 2016 19:40:17 +0000 (19:40 +0000)]
Merge "Clarify comment in traditional gallery"
jenkins-bot [Mon, 19 Sep 2016 19:31:44 +0000 (19:31 +0000)]
Merge "Avoid using cascadingDeletes()/cleanupTriggers()"
Arlo Breault [Mon, 19 Sep 2016 19:23:50 +0000 (12:23 -0700)]
Clarify comment in traditional gallery
Change-Id: I13aa2132d64a1dca8a5ab867fdffc48aca2cf9d1
jenkins-bot [Mon, 19 Sep 2016 19:02:04 +0000 (19:02 +0000)]
Merge "Avoid calling awful DatabaseBase::strictIPs() method"
jenkins-bot [Mon, 19 Sep 2016 18:32:09 +0000 (18:32 +0000)]
Merge "Fix SqliteInstaller DatabaseSqlite creation"
Marius Hoch [Mon, 19 Sep 2016 18:11:33 +0000 (20:11 +0200)]
Fix SqliteInstaller DatabaseSqlite creation
Follow-up to
47e816c69c197fec86c344256d81d7c8f781b880
Change-Id: I1612b0a187ea1df272bdd304ffb2bafbc006b2e4
Aaron Schulz [Mon, 19 Sep 2016 17:55:07 +0000 (10:55 -0700)]
Fix "MWExceptionRenderer::getText() should not be called statically" errors
Change-Id: Icfb65795b1455217ca9bc2c1f7cd453144ad5106
jenkins-bot [Mon, 19 Sep 2016 17:41:35 +0000 (17:41 +0000)]
Merge "Html: Update list of $voidElements"
jenkins-bot [Mon, 19 Sep 2016 17:29:53 +0000 (17:29 +0000)]
Merge "Cleanup ServiceWiring/LBFactoryMW interaction"
Brad Jorsch [Mon, 19 Sep 2016 16:39:44 +0000 (12:39 -0400)]
Make MWExceptionRenderer work with PHP7's exception changes
See https://wiki.php.net/rfc/throwable-interface
Change-Id: Ib65f912580f5d84997c5926e7f602d5f5ef3faba
Bartosz Dziewoński [Mon, 19 Sep 2016 16:02:06 +0000 (18:02 +0200)]
Html: Update list of $voidElements
`<command>` is nowhere to be found in current HTML5 specification.
Scarce documentation on the internet hints that it has been removed.
Change-Id: I2a704194c7e8f8ca307f9d97c7f47a47cfaf00a6
Aaron Schulz [Sun, 18 Sep 2016 01:50:56 +0000 (18:50 -0700)]
Cleanup ServiceWiring/LBFactoryMW interaction
* Move almost all the code to LBFactoryMW and inject the main config.
* Make LBFactoryMW no longer extend anything, which is now pointless.
* Let site admins explicitly set "servers" and "externalServers" arrays.
* Pass in the $wgDBschema field regardless of $wgDBtype. It defaults to
null, so no one would bother setting it if they did not want to use it.
Change-Id: I51f15c0f5d98a73907c51958bdb82dea76b3e38c
jenkins-bot [Mon, 19 Sep 2016 16:18:50 +0000 (16:18 +0000)]
Merge "Various small cleanups to ResultWrapper"
jenkins-bot [Mon, 19 Sep 2016 16:15:15 +0000 (16:15 +0000)]
Merge "Move LBFactorySingle to /libs/rdbms"
James D. Forrester [Mon, 19 Sep 2016 15:41:44 +0000 (08:41 -0700)]
OOjs UI: FieldsetLayout: Styling fixes for `<legend>` labels
[Backport from OOjs UI master as this fixes a significant regression.]
* Make the `<legend>` 'display: inline-table' rather than 'table'.
A block-level table would push down elements that follow it,
including the "help" icon, which in turn messed up the fields.
Fixes T145682, T145678 and first half of T145680.
* Only style .oo-ui-labelElement-label with margin and padding
if we have the .oo-ui-labelElement class (label is not empty).
Fixes second half of T145680.
Follow-up to
9cf8b941a9c618f1d7ba2512508f576f70116e1e.
Bug: T145682
Bug: T145678
Bug: T145680
Change-Id: Id95f4167afa6c000d6d2fa2ad7a62b65b6d4d53b
jenkins-bot [Mon, 19 Sep 2016 15:23:50 +0000 (15:23 +0000)]
Merge "Add Localisation to the links, add the link to Localisation in Languages/Language.php"
Aaron Schulz [Fri, 16 Sep 2016 02:36:40 +0000 (19:36 -0700)]
Stub out DatabaseBase::getSearchEngine() as a dummy method
SearchEngineFactory::getSearchEngineClass() should be used instead
Change-Id: I984b80815633a8dc38a76d7de8a46ec249ae729f
dcausse [Mon, 19 Sep 2016 13:50:05 +0000 (15:50 +0200)]
Extract replacePrefixes into a static method
Useful for some search engines that have a keyword that wants
to reuse this logic without building a new SearchEngine object.
Change-Id: Iee5bfd1da70b8339a98555ba062bd33b21f0b761
jenkins-bot [Mon, 19 Sep 2016 08:34:56 +0000 (08:34 +0000)]
Merge "Make ApiMain use isBot() to catch global bots in checkReadOnly()"
Aaron Schulz [Sun, 18 Sep 2016 03:21:50 +0000 (20:21 -0700)]
Various small cleanups to ResultWrapper
* Make FakeResultWrapper call super to avoid IDEA warnings
* Lots of documentation cleanups
Change-Id: Ifcd7163890fa8c7718e88c4244cc38371ed624fc
jenkins-bot [Mon, 19 Sep 2016 08:08:42 +0000 (08:08 +0000)]
Merge "Move LIST_ constaints to IDatabase class constants"
jenkins-bot [Mon, 19 Sep 2016 08:04:53 +0000 (08:04 +0000)]
Merge "Move DatabaseSqlite to /libs/rdbms"
jenkins-bot [Mon, 19 Sep 2016 08:04:50 +0000 (08:04 +0000)]
Merge "Fixed method name casing and IDEA warnings in FileRepo"
Aaron Schulz [Mon, 19 Sep 2016 07:28:17 +0000 (00:28 -0700)]
Move LIST_ constaints to IDatabase class constants
Leave aliases in Defines.php for backwards compatibility.
Change-Id: I88b45e0943cbfe97d863c2e0a4911fc0f81e5bb5
Aaron Schulz [Mon, 19 Sep 2016 02:12:05 +0000 (19:12 -0700)]
Fixed method name casing and IDEA warnings in FileRepo
Change-Id: I463885a9f425491cd040cb1cdbc4c16925522848
Aaron Schulz [Sun, 18 Sep 2016 23:48:22 +0000 (16:48 -0700)]
Move DatabaseSqlite to /libs/rdbms
Change-Id: Ibda20041803deb922b7e3803cba6fc8d15214169
jenkins-bot [Mon, 19 Sep 2016 07:52:03 +0000 (07:52 +0000)]
Merge "Remove wf* function and global variable usage from DatabaseSqlite"
Aaron Schulz [Sun, 18 Sep 2016 03:39:28 +0000 (20:39 -0700)]
Remove wf* function and global variable usage from DatabaseSqlite
Change-Id: I81753621ecd1e7e3b099243b4c4d0f3428bf9ae2
Aaron Schulz [Sun, 18 Sep 2016 05:29:06 +0000 (22:29 -0700)]
Cleanups and IDEA warning fixes to FileRepo classes
Change-Id: I98247b299c31b93df183981adc517187cb4aefe5
Aaron Schulz [Sun, 18 Sep 2016 04:42:56 +0000 (21:42 -0700)]
Make LockManager use StatusValue and move classes to /libs
Change-Id: Ifa41fc2939f3515d4a056746b0fcbff79786d25b
jenkins-bot [Mon, 19 Sep 2016 03:39:50 +0000 (03:39 +0000)]
Merge "Remove wf* function dependencies from FSLockManager"
Aaron Schulz [Sun, 18 Sep 2016 21:01:42 +0000 (14:01 -0700)]
Make ApiMain use isBot() to catch global bots in checkReadOnly()
Change-Id: I2090b1aad8a5858965e4ec261f8e88c37414e804
Aaron Schulz [Sun, 18 Sep 2016 03:48:23 +0000 (20:48 -0700)]
Remove wf* function dependencies from FSLockManager
Change-Id: I52f08c6e7372ddbbcc1b5f82d505e435b01ff138
Translation updater bot [Sun, 18 Sep 2016 20:02:54 +0000 (22:02 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Id7a10255e2d68819e0de0c005a4442a43f426502
Aaron Schulz [Fri, 16 Sep 2016 05:44:49 +0000 (22:44 -0700)]
Avoid calling awful DatabaseBase::strictIPs() method
That method should be removed since it encourages incompatibility
Change-Id: Id8a0174266bcd988c85943507f1edb3518fe087e
Aaron Schulz [Sun, 18 Sep 2016 02:13:21 +0000 (19:13 -0700)]
Move LBFactorySingle to /libs/rdbms
Also add newFromConnection() methods for cleaner looking construction
since the IDatabase is fundamental and required.
Change-Id: Ife478d045cee92a30c91e9004833a557488bd512
jenkins-bot [Sun, 18 Sep 2016 02:12:51 +0000 (02:12 +0000)]
Merge "Remove long-since unused cruft methods from DatabaseBase"
jenkins-bot [Sun, 18 Sep 2016 02:09:11 +0000 (02:09 +0000)]
Merge "Fix file/class name mismatch from
e2adcc89bbe"
Aaron Schulz [Fri, 16 Sep 2016 05:33:10 +0000 (22:33 -0700)]
Avoid using cascadingDeletes()/cleanupTriggers()
Simplify DB callers by just having one code path.
All but some very old code paths bothered with these.
Change-Id: Iaf7a2f83146a0ed15995f9cfc74edcf16ae5a448
jenkins-bot [Sun, 18 Sep 2016 02:03:40 +0000 (02:03 +0000)]
Merge "Avoid MWDebug usage in DatabaseBase"
Aaron Schulz [Sun, 18 Sep 2016 02:00:01 +0000 (19:00 -0700)]
Fix file/class name mismatch from
e2adcc89bbe
Change-Id: Ieac65f29a13612cecd421b62e1cb3a3f47552bb6
Aaron Schulz [Fri, 16 Sep 2016 20:57:56 +0000 (13:57 -0700)]
Avoid MWDebug usage in DatabaseBase
This class is in /libs and cannot depend on all of MediaWiki.
Replace the call with a simple debug() call instead.
Also, make the legacy logger route/format errors from the two
new DB log types (DBConnection, DBQuery) to the old wfLogDBError
locations, including MWDebug::debugMsg().
Change-Id: I64895d3f5b9a000d8186ab6a6ffb4b76a7e9ff40
jenkins-bot [Sun, 18 Sep 2016 01:27:50 +0000 (01:27 +0000)]
Merge "Move LoadBalancerSingle to /libs/rdbms"
Aaron Schulz [Sun, 18 Sep 2016 01:04:42 +0000 (18:04 -0700)]
Move LoadBalancerSingle to /libs/rdbms
Change-Id: I2e8177ca8fa6b9fcdec87e44f0cfeb11bb71f2bc
jenkins-bot [Sun, 18 Sep 2016 00:57:01 +0000 (00:57 +0000)]
Merge "Move LBFactoryMulti to /libs/rdbms"
Aaron Schulz [Fri, 16 Sep 2016 05:12:50 +0000 (22:12 -0700)]
Remove long-since unused cruft methods from DatabaseBase
Change-Id: I4b28c15a8589504bdbbe79ba0d3aed1e52dbe65b
Aaron Schulz [Fri, 16 Sep 2016 02:17:22 +0000 (19:17 -0700)]
Move LBFactoryMulti to /libs/rdbms
Also rename $wiki => $domain and lastWiki => lastDomain.
Change-Id: I2a30f42721715c56f5cddf9f07c10e8de70addd1
jenkins-bot [Sun, 18 Sep 2016 00:10:43 +0000 (00:10 +0000)]
Merge "Move mysql database classes to /libs/rdbms"
jenkins-bot [Sat, 17 Sep 2016 23:57:23 +0000 (23:57 +0000)]
Merge "Clean up $wgDBmwschema handling and only apply it to mssql"
Aaron Schulz [Thu, 15 Sep 2016 20:51:31 +0000 (13:51 -0700)]
Clean up $wgDBmwschema handling and only apply it to mssql
Follow-up to
61762bf3f8f904bcc5a0f90985e7f787756032a7
Change-Id: Ib8dc247ba17d7cbf4cf0f46dbe82983a715f2c8d
Aaron Schulz [Fri, 16 Sep 2016 03:56:24 +0000 (20:56 -0700)]
Move mysql database classes to /libs/rdbms
Change-Id: I1ba1799deec10e5a8ab8829b69e0708626e723e2
jenkins-bot [Sat, 17 Sep 2016 23:34:33 +0000 (23:34 +0000)]
Merge "Make Status extend StatusValue and start FileBackend update"
Aaron Schulz [Thu, 15 Sep 2016 18:52:55 +0000 (11:52 -0700)]
Move LBFactorySimple to /libs/rdbms
* Refactored LBFactory a bit to make this possible.
* Move newChronologyProtector() up to LBFactory and
make a lazy-loading method instead.
* Move appendPreShutdownTimeAsQuery() up to LBFactory.
* Inject the web request values for LBFactory from Setup.php.
* Remove unused laggedSlaveUsed() method.
Change-Id: Ie8a38a6f4d6359680eb6a5be24a34e30b9816479
jenkins-bot [Sat, 17 Sep 2016 22:57:15 +0000 (22:57 +0000)]
Merge "Inject Profiler into Database objects"
Aaron Schulz [Fri, 16 Sep 2016 22:55:40 +0000 (15:55 -0700)]
Make Status extend StatusValue and start FileBackend update
* This avoids code duplication.
* Callers can safely start type-hinting StatusValue as well.
* Also moved the wrap() logic out of Status::__construct(), which
only wrap() was (and should have been) using. Use "static" as
well, so subclass behave properly.
* The docs and type-hints in /filebackend are updated as an example.
* A migration pattern is to inject a StatusValue wrapper
into the backend and use it on all returned statuses, so MediaWiki
will still get Status for message methods.
Change-Id: Iff9255f34870ea6b0c4b91f6ddc69eea95186aba
jenkins-bot [Sat, 17 Sep 2016 22:45:18 +0000 (22:45 +0000)]
Merge "registration: Support 'ServiceWiringFiles' in extension.json"
jenkins-bot [Sat, 17 Sep 2016 22:41:01 +0000 (22:41 +0000)]
Merge "Make database classes handle hyphens in $wgDBname"
Aaron Schulz [Sat, 17 Sep 2016 22:30:17 +0000 (15:30 -0700)]
Inject Profiler into Database objects
* This removes the Profiler::instance() dependency from
a class in /libs.
* Also removed unused setTransactionProfiler() method
Change-Id: Iec735a130914090dc51aed30a283565a66aabee6
Aaron Schulz [Sat, 17 Sep 2016 04:39:57 +0000 (21:39 -0700)]
Make database classes handle hyphens in $wgDBname
* Add DatabaseDomain class to handle passing domains around.
It also can be cast to and from strings, which are of the same
format as wfWikiId() except with hyphens escaped.
* Make IDatabase::getDomainID() use these IDs so they can be
passed into LoadBalancer::getConnection() and friends without
breaking on sites with a hyphen in the DB name.
* Add more LBFactory unit tests for domains.
Bug: T145840
Change-Id: Icfed62b251af8cef706a899197c3ccdb730ef4d1
jenkins-bot [Sat, 17 Sep 2016 21:48:50 +0000 (21:48 +0000)]
Merge "LoginSignupSpecialPage: Reduce hackiness of "You are already logged in" warning"
Translation updater bot [Sat, 17 Sep 2016 20:41:20 +0000 (22:41 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I3280926eadcbb43d64499eed62a6b3de8ecb285d
jenkins-bot [Sat, 17 Sep 2016 18:05:13 +0000 (18:05 +0000)]
Merge "Show warnings in HTMLForm and warnings as warnings on Login/Signup form"
jenkins-bot [Sat, 17 Sep 2016 15:05:11 +0000 (15:05 +0000)]
Merge "mw.widgets.CategorySelector: Add client-side caching"
Bartosz Dziewoński [Sat, 17 Sep 2016 14:24:34 +0000 (16:24 +0200)]
LoginSignupSpecialPage: Reduce hackiness of "You are already logged in" warning
Use HTMLForm's built-in error/warning handling, rather than generate
the HTML ourselves. Depends on I9a27911613e62b5c4cb86bea40696cb37c4f49c2.
Change-Id: I80dd9dfcd546a50479ebe07b267105cfd4677fc7
Florian [Fri, 1 Jul 2016 16:26:20 +0000 (18:26 +0200)]
Show warnings in HTMLForm and warnings as warnings on Login/Signup form
This commit changes the way how HTMLForm handles a Status object
when executed from a request. It now handles, beside the errors,
also the warnings of a Status object and prints them out, wrapped
in a warning box.
The LoginSignupPage uses this feature to show informative warnings
actually as warnings and not as more disturbing error messages.
Error messages should be reserved for errors and only for erros. An
AuthenticationProvider, which returns an UI AuthenticationResponse
can choose, if the given message is an error or a warning message.
This commit also addds a new function to Status, which allows a
developer to split the object into two new Status objects, where one only
contains the errors and the other only the warnings of the origin
Status object (splitByErrorType). StatusValue also has a new function,
splitByErrorType(), to support this.
Bug: T139179
Change-Id: I9a27911613e62b5c4cb86bea40696cb37c4f49c2
Amir Sarabadani [Sat, 27 Aug 2016 17:26:40 +0000 (21:56 +0430)]
Rework UserContribs options section
It will make it more mobile friendly and fixes several issues.
Bug: T143518
Bug: T50544
Change-Id: Ie353af860aaec7d6921ae83fa59980ab0a5c8d9b
Aaron Schulz [Fri, 16 Sep 2016 03:33:25 +0000 (20:33 -0700)]
Cleanups to DatabaseMysqlBase
* Avoid global methods
* Inject global variables
* Remove $wgAllDBsAreLocalhost hack
Change-Id: I54b23654def1f83518764ad697434aebfc6cef73