Brian Wolff [Mon, 15 Feb 2016 02:13:48 +0000 (21:13 -0500)]
Use global cache keys login/create account rate limitting
If you are running multiple wikis, you probably want the rate limit
on one wiki to apply to all wikis
Bug: T126685
Change-Id: Id662742c7af1b26811f5b0aa199176cb9a7658d9
Translation updater bot [Sat, 13 Feb 2016 21:47:11 +0000 (22:47 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: If8a45c13a53d80dd04d39926980411a2c9af5bbe
Ricordisamoa [Fri, 12 Feb 2016 17:31:49 +0000 (18:31 +0100)]
Make maintenance/findHooks.php pass again
* check 4 new paths
* strip 'NormalizeMessageKey' hook from docs/hooks.txt,
last call was removed in
1ea4f23b05a1776be395e2390aab8326bd97caa7
Change-Id: Id36ab478b94f74be451cae848d5ef2a318d23040
jenkins-bot [Sat, 13 Feb 2016 10:17:12 +0000 (10:17 +0000)]
Merge "FormatJson: Remove PHP 5.3 compatibility code"
jenkins-bot [Sat, 13 Feb 2016 03:03:26 +0000 (03:03 +0000)]
Merge "Remove references to safe_mode INI setting"
Kevin Israel [Sat, 13 Feb 2016 00:30:01 +0000 (19:30 -0500)]
RELEASE-NOTES: Remove register_globals "Security reminder"
The feature no longer exists starting in PHP 5.4.0, and MediaWiki
now only supports PHP 5.5.9 or newer.
I did not remove the mention in UPGRADE because that refers to an
very old version of MediaWiki that needs a very old PHP version.
Change-Id: I0788d83943f4d08100177c430269eeb16e6f842e
Kevin Israel [Sat, 13 Feb 2016 00:18:26 +0000 (19:18 -0500)]
Remove references to safe_mode INI setting
The feature no longer exists starting in PHP 5.4.0, and MediaWiki
now only supports PHP 5.5.9 or newer.
Change-Id: I3f2d1b564c50f0a28ec1ec0abd7d1b242e26953b
Kevin Israel [Fri, 12 Feb 2016 23:49:01 +0000 (18:49 -0500)]
FormatJson: Remove PHP 5.3 compatibility code
MediaWiki now only works with PHP versions that are new enough
to have the encoding options required by encode54(). So fold
that into encode() and remove encode53() and prettyPrint().
Change-Id: I6b22daf8fa01ef608efbde9c6aecdbb5ce03e2b9
jenkins-bot [Fri, 12 Feb 2016 22:39:02 +0000 (22:39 +0000)]
Merge "Add IContextSource as parameter to ChangeTags::formatSummaryRow"
Aaron Schulz [Thu, 24 Dec 2015 01:11:24 +0000 (17:11 -0800)]
Upgrade mismatched commit() warnings to exceptions
I saw no WMF logs for these in the last 7 days.
Change-Id: I725535925ba3fc68cee485767f18937fb8f239bf
Translation updater bot [Fri, 12 Feb 2016 20:47:56 +0000 (21:47 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I2c3440378f1a706985d7e5a2093a395a226c6297
Bryan Davis [Thu, 11 Feb 2016 20:58:33 +0000 (13:58 -0700)]
Update AutoLoaderTest and ran maintenance/generateLocalAutoload.php
AutoLoaderTest didn't know about traits.
generateLocalAutoload found a missing Trait from the autoloader and
a class map ordering issue.
Change-Id: I34bf2698ad838b6a977c9bf39f6e416330ff0e5d
jenkins-bot [Fri, 12 Feb 2016 02:46:31 +0000 (02:46 +0000)]
Merge "Make change tagging of edits in RecentChange::notifyNew/Edit"
jenkins-bot [Fri, 12 Feb 2016 00:35:12 +0000 (00:35 +0000)]
Merge "Log multiple IPs using the same session or the same user account"
jenkins-bot [Fri, 12 Feb 2016 00:14:07 +0000 (00:14 +0000)]
Merge "Add MediaWikiTestCase convenience method for mocking a logger"
Max Semenik [Thu, 11 Feb 2016 19:20:43 +0000 (11:20 -0800)]
Remove REQUEST_TIME_FLOAT hack for old PHP
Change-Id: Id11f4f479d5225d92e38b2ae83b25315591b73d6
jenkins-bot [Thu, 11 Feb 2016 22:42:55 +0000 (22:42 +0000)]
Merge "Remove register_globals and magic_quotes_* checks"
jenkins-bot [Thu, 11 Feb 2016 21:30:55 +0000 (21:30 +0000)]
Merge "SessionProvider::mergeMetadata: Log additional data"
Bryan Davis [Thu, 11 Feb 2016 16:55:37 +0000 (09:55 -0700)]
SessionProvider::mergeMetadata: Log additional data
Add the data values and types to the exception raised when mismatched
session data is processed. This is done by passing the old and new
values on via a new MetadataMergeException class. The attached data is
added to the debug logging context info when caught.
Change-Id: If8a7174399289bc284ca1b36052ba515c8857c50
jenkins-bot [Thu, 11 Feb 2016 21:17:32 +0000 (21:17 +0000)]
Merge "Remove PHP < 5.3.6 compatibility in LegacyLogger"
jenkins-bot [Thu, 11 Feb 2016 21:10:42 +0000 (21:10 +0000)]
Merge "Stop doing $that = $this in includes/parser"
Reedy [Thu, 11 Feb 2016 20:54:09 +0000 (20:54 +0000)]
We support 5.5.9...
Change-Id: I6ef6a21e6f5cd9cdd82227f100eb89a9f6122d98
Translation updater bot [Thu, 11 Feb 2016 20:04:05 +0000 (21:04 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I002ea4f85ae2d98926b1aced118a5ebaee85c04d
jenkins-bot [Thu, 11 Feb 2016 19:48:06 +0000 (19:48 +0000)]
Merge "Fix a bunch of call-time pass-by-reference errors"
Max Semenik [Thu, 11 Feb 2016 00:41:44 +0000 (16:41 -0800)]
Remove register_globals and magic_quotes_* checks
Yay, this crap is finally gone as of PHP 5.4!
Change-Id: I2cb01b5bf0fdde4c8cf5286ef6aff93ac45e99fd
jenkins-bot [Thu, 11 Feb 2016 19:11:49 +0000 (19:11 +0000)]
Merge "Remove gzdecode() polyfill from includes/GlobalFunctions.php"
jenkins-bot [Thu, 11 Feb 2016 19:02:17 +0000 (19:02 +0000)]
Merge "Fix invalid key warning in CookieSessionProvider error handling code"
Ricordisamoa [Thu, 11 Feb 2016 14:45:42 +0000 (15:45 +0100)]
Remove gzdecode() polyfill from includes/GlobalFunctions.php
Unnecessary since PHP 5.4.0
Change-Id: I8423b792488e3b3326ef9b702f1b84c9a2137952
umherirrender [Thu, 11 Feb 2016 18:50:43 +0000 (19:50 +0100)]
Remove PHP < 5.3.6 compatibility in LegacyLogger
Change-Id: Iaa820accce207ce48022bf7e72264c3c247331ba
Gergő Tisza [Wed, 10 Feb 2016 21:55:35 +0000 (13:55 -0800)]
Fix invalid key warning in CookieSessionProvider error handling code
Change-Id: I68172ff5fcd6acaab7ecf298ed4a47f23cb8c9f7
jenkins-bot [Thu, 11 Feb 2016 16:15:38 +0000 (16:15 +0000)]
Merge "mw.ForeignStructuredUpload.BookletLayout: Remove A/B test code"
Gergő Tisza [Sun, 7 Feb 2016 19:24:05 +0000 (11:24 -0800)]
Log multiple IPs using the same session or the same user account
As an attempt to detect SessionManager errors that log people into
the wrong account, log multiple IPs using the same session, or the same
user account.
Bug: T125455
Change-Id: I27468a3f6d582d9b46984227b9307dc71190fd6a
Ricordisamoa [Thu, 11 Feb 2016 14:57:48 +0000 (15:57 +0100)]
InfoAction: Remove array dereferencing workaround
Change-Id: I99d3773a52d4b99367eb3008009da0ffd8a4690a
Ricordisamoa [Thu, 11 Feb 2016 08:40:54 +0000 (09:40 +0100)]
Stop doing $that = $this in includes/parser
Closures support $this as of PHP 5.4
Change-Id: Iace7ef43b17e8100f6bd71b4e23bad39cba87c0d
Bartosz Dziewoński [Fri, 5 Feb 2016 01:18:58 +0000 (01:18 +0000)]
mw.ForeignStructuredUpload.BookletLayout: Remove A/B test code
We don't want it to accidentally end up in MediaWiki 1.27 release.
It can be restored again when needed.
This reverts commit
d0e47d475cd7efd7541d51e02ab216a966da8b1f.
Bug: T120867
Change-Id: Ie1a90ad2d2ccdecf189313e18c3c5b24576363f4
jenkins-bot [Thu, 11 Feb 2016 04:35:20 +0000 (04:35 +0000)]
Merge "Improve docs for $wgPHPSessionHandling"
jenkins-bot [Thu, 11 Feb 2016 04:15:14 +0000 (04:15 +0000)]
Merge "Set context on RedirectSpecialPage in MediaWiki.php"
jenkins-bot [Thu, 11 Feb 2016 04:08:12 +0000 (04:08 +0000)]
Merge "mediawiki.widgets: Use formatversion=2 for API requests"
jenkins-bot [Thu, 11 Feb 2016 04:06:13 +0000 (04:06 +0000)]
Merge "OutputPage.php: Remove misleading comment"
jenkins-bot [Thu, 11 Feb 2016 04:06:09 +0000 (04:06 +0000)]
Merge "Get file from WikiFilePage, instead of ImagePage"
jenkins-bot [Thu, 11 Feb 2016 04:06:04 +0000 (04:06 +0000)]
Merge "mediawiki.action.edit.preview.js: Use formatversion=2 for API requests"
jenkins-bot [Thu, 11 Feb 2016 04:06:00 +0000 (04:06 +0000)]
Merge "Add tests for LanguageConverter classes that didn't have them"
jenkins-bot [Thu, 11 Feb 2016 04:05:56 +0000 (04:05 +0000)]
Merge "Don't modify $wgHooks on language object construction"
jenkins-bot [Thu, 11 Feb 2016 04:05:51 +0000 (04:05 +0000)]
Merge "Remove extra line breaks in memcached debug output"
jenkins-bot [Thu, 11 Feb 2016 03:55:35 +0000 (03:55 +0000)]
Merge "Avoid setRequestExpectations() call in internal API mode"
jenkins-bot [Thu, 11 Feb 2016 03:53:11 +0000 (03:53 +0000)]
Merge "Set doesWrites() for SpecialWatchlist"
jenkins-bot [Thu, 11 Feb 2016 03:51:21 +0000 (03:51 +0000)]
Merge "getFooterIcons returns an array"
jenkins-bot [Thu, 11 Feb 2016 03:51:16 +0000 (03:51 +0000)]
Merge "Work around T87871 to avoid double-loading OOjs UI PHP styles"
jenkins-bot [Thu, 11 Feb 2016 03:49:50 +0000 (03:49 +0000)]
Merge "Use LinkTarget in LinkBatch::addObj"
jenkins-bot [Thu, 11 Feb 2016 03:45:43 +0000 (03:45 +0000)]
Merge "Disable testIPTCParseForcedUTFButInvalid on PHP > 5.6.0 but < 5.6.10"
jenkins-bot [Thu, 11 Feb 2016 03:00:12 +0000 (03:00 +0000)]
Merge "Reduce conditional for calling openssl_random_pseudo_bytes"
jenkins-bot [Thu, 11 Feb 2016 02:33:12 +0000 (02:33 +0000)]
Merge "Stop doing $that = $this in includes/user"
jenkins-bot [Thu, 11 Feb 2016 02:26:06 +0000 (02:26 +0000)]
Merge "Stop doing $that = $this in includes/changes"
jenkins-bot [Thu, 11 Feb 2016 01:43:27 +0000 (01:43 +0000)]
Merge "Allow changing cookie options in WebResponseSetCookie hook"
jenkins-bot [Thu, 11 Feb 2016 00:38:34 +0000 (00:38 +0000)]
Merge "Suppress SessionManager sessions in the installer"
jenkins-bot [Thu, 11 Feb 2016 00:31:57 +0000 (00:31 +0000)]
Merge "DiffFormatter: Don't mess with PHP output buffering"
jenkins-bot [Thu, 11 Feb 2016 00:31:49 +0000 (00:31 +0000)]
Merge "Stop doing $that = $this in includes/specialpage"
jenkins-bot [Thu, 11 Feb 2016 00:18:57 +0000 (00:18 +0000)]
Merge "Remove < PHP 5.4 register_shutdown_function() from phpunit.php"
Tim Starling [Wed, 10 Feb 2016 10:04:28 +0000 (21:04 +1100)]
Suppress SessionManager sessions in the installer
SessionManager cannot work in the installer since it depends on
ObjectCache which is just an EmptyBagOStuff and so doesn't store
anything. So, introduce a custom SessionProvider which pretends to
persist sessions but actually doesn't.
Bug: T126177
Change-Id: I13d8aa1453c519df7c19ca2f1fb052c99ade043c
Ricordisamoa [Wed, 10 Feb 2016 23:29:22 +0000 (00:29 +0100)]
Stop doing $that = $this in includes/specialpage
Closures support $this as of PHP 5.4
Change-Id: Ib586150a50751873e9c3d12239f6ff8adedf70af
Ricordisamoa [Wed, 10 Feb 2016 23:25:29 +0000 (00:25 +0100)]
Stop doing $that = $this in includes/changes
Closures support $this as of PHP 5.4
Change-Id: I6bf728bf5c2222fd43945ec7a60a5f29efd42f0c
Ricordisamoa [Wed, 10 Feb 2016 23:09:05 +0000 (00:09 +0100)]
Follow-up to
02818c441cb10ce6bec2bc673fefdf1513791dc3
* Remove obsolete @protected tag from docstring
of DatabaseBase::indexName(), now really protected
* Make DatabaseSqlite::indexName() protected too
Change-Id: I90f894878379d0850dba61cd483af16864c209ea
Ricordisamoa [Wed, 10 Feb 2016 22:52:46 +0000 (23:52 +0100)]
Stop doing $that = $this in includes/user
Closures support $this as of PHP 5.4
Change-Id: If79be54276fe2a35bdd004908cfc160e6636f7c5
Bryan Davis [Wed, 10 Feb 2016 22:49:08 +0000 (15:49 -0700)]
Allow changing cookie options in WebResponseSetCookie hook
Pass the cookie options by value to WebResponseSetCookie handlers so
that they may alter them.
Bug: T49647
Change-Id: I69ae55baa7806f14726b0b08215c0df471794b39
Max Semenik [Wed, 10 Feb 2016 22:11:30 +0000 (14:11 -0800)]
Fix a bunch of call-time pass-by-reference errors
Change-Id: I3bd8e7c4d2dca465957a353cb7dc2a906699ff6a
Reedy [Wed, 10 Feb 2016 21:23:35 +0000 (21:23 +0000)]
Remove < PHP 5.4 register_shutdown_function() from phpunit.php
Change-Id: Ic4efeca82762b3c50cd2e1b45e43a6f1ef0f5710
Gergő Tisza [Sun, 7 Feb 2016 08:12:10 +0000 (08:12 +0000)]
Add MediaWikiTestCase convenience method for mocking a logger
Change-Id: I2f96eddf9f010333ab515c980f4158dce410a13a
Reedy [Wed, 10 Feb 2016 21:27:24 +0000 (21:27 +0000)]
Reduce conditional for calling openssl_random_pseudo_bytes
We require a much higher PHP version now, so this isn't a problem
for windows or otherwise
Change-Id: I65511f00b50d12992d8883d5482867f5e0a850bc
Reedy [Wed, 10 Feb 2016 21:21:54 +0000 (21:21 +0000)]
Disable testIPTCParseForcedUTFButInvalid on PHP > 5.6.0 but < 5.6.10
Bug: T124574
Change-Id: I6893f7f549bb4145296c97ba2fc12583cd22e18e
jenkins-bot [Wed, 10 Feb 2016 20:37:27 +0000 (20:37 +0000)]
Merge "PHPSessionHandler: Implement SessionHandlerInterface"
Translation updater bot [Wed, 10 Feb 2016 19:53:36 +0000 (20:53 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I692311d0a73d071b6c824e0fb59d96002bc07e4a
jenkins-bot [Wed, 10 Feb 2016 19:43:15 +0000 (19:43 +0000)]
Merge "Use LinkTarget in EmailNotification::updateWatchlistTimestamp"
jenkins-bot [Wed, 10 Feb 2016 19:42:32 +0000 (19:42 +0000)]
Merge "Use LinkTarget in some namespaceDupes methods"
jenkins-bot [Wed, 10 Feb 2016 19:42:28 +0000 (19:42 +0000)]
Merge "Use LinkTarget in Revision::newFromTitle"
jenkins-bot [Wed, 10 Feb 2016 19:42:24 +0000 (19:42 +0000)]
Merge "resourceloader: Remove obsolete '$that = $this' closure pattern"
jenkins-bot [Wed, 10 Feb 2016 19:42:19 +0000 (19:42 +0000)]
Merge "phpdoc @return MediaWikiTitleCodec in Title::getTitleParser"
jenkins-bot [Wed, 10 Feb 2016 19:23:09 +0000 (19:23 +0000)]
Merge "ApiMessage: Use a trait to avoid code duplication"
jenkins-bot [Wed, 10 Feb 2016 19:21:27 +0000 (19:21 +0000)]
Merge "Remove unused imports from Session classes"
CSteipp [Wed, 10 Feb 2016 19:17:51 +0000 (19:17 +0000)]
Merge "Revert "Limit ip-all/subnet-all ping limts per wiki""
jenkins-bot [Wed, 10 Feb 2016 19:15:23 +0000 (19:15 +0000)]
Merge "Remove "$that" from SessionManager"
jenkins-bot [Wed, 10 Feb 2016 19:05:56 +0000 (19:05 +0000)]
Merge "Stop doing $that = $this in includes/filebackend"
Brad Jorsch [Wed, 10 Feb 2016 19:03:50 +0000 (14:03 -0500)]
Improve docs for $wgPHPSessionHandling
Change-Id: I5eacd8205c1346f6d1dde6d4a5fac51bbf6f2615
MaxSem [Wed, 10 Feb 2016 19:01:54 +0000 (19:01 +0000)]
Merge "Add support for traits in ClassCollector"
jenkins-bot [Wed, 10 Feb 2016 18:40:31 +0000 (18:40 +0000)]
Merge "Stop doing $that = $this in includes/db"
jenkins-bot [Wed, 10 Feb 2016 18:28:31 +0000 (18:28 +0000)]
Merge "Stop doing $that = $this in includes/libs"
Ricordisamoa [Wed, 10 Feb 2016 17:13:38 +0000 (18:13 +0100)]
resourceloader: Remove obsolete '$that = $this' closure pattern
Closures support $this as of PHP 5.4.
Change-Id: Ib00be459490569036604afff53bd99fe247737df
jenkins-bot [Wed, 10 Feb 2016 18:16:41 +0000 (18:16 +0000)]
Merge "Stop doing $that = $this in includes/deferred"
victorbarbu [Sat, 6 Feb 2016 14:16:40 +0000 (16:16 +0200)]
Add support for traits in ClassCollector
Bug: T126116
Change-Id: Ifb81c6844565736111717736fe7649492e31f0f7
Ricordisamoa [Wed, 10 Feb 2016 17:22:59 +0000 (18:22 +0100)]
Stop doing $that = $this in includes/deferred
Closures support $this as of PHP 5.4
Change-Id: I2632d0c2bdc9e2fec72f1c64c3868dcb442ba871
Ricordisamoa [Wed, 10 Feb 2016 17:43:49 +0000 (18:43 +0100)]
Stop doing $that = $this in includes/jobqueue
Closures support $this as of PHP 5.4
Change-Id: Icf4eb9ffeab410c01c68a031ec6704cd83c2681e
jenkins-bot [Wed, 10 Feb 2016 17:39:31 +0000 (17:39 +0000)]
Merge "Add debug logging for the case that the API goes read only"
Ricordisamoa [Wed, 10 Feb 2016 17:33:52 +0000 (18:33 +0100)]
Stop doing $that = $this in includes/filebackend
Closures support $this as of PHP 5.4
Change-Id: Ib11139ec81336710c22146f9ff714e8afd3aa2cf
Ricordisamoa [Wed, 10 Feb 2016 17:26:25 +0000 (18:26 +0100)]
Stop doing $that = $this in includes/libs
Closures support $this as of PHP 5.4
Change-Id: I1b5a5d7e619029684cb8d2a8d150fcc13051c2e0
Brad Jorsch [Wed, 10 Feb 2016 17:10:38 +0000 (12:10 -0500)]
Remove "$that" from SessionManager
Also "function () use ( &$ref )" that was being done for similar
reasons.
Change-Id: If4ec263a9a9c02c1c6a414b26a0e77ba144437f1
Thiemo Mättig [Wed, 10 Feb 2016 17:06:48 +0000 (18:06 +0100)]
Remove unused imports from Session classes
Change-Id: Ia3cdd923728870f5eff0bd90fd2f6605047291c0
Ricordisamoa [Wed, 10 Feb 2016 17:07:30 +0000 (18:07 +0100)]
Stop doing $that = $this in includes/db
Closures support $this as of PHP 5.4
Also made DatabaseBase::indexName() protected
Change-Id: Iff31e7d9186832a855a953b923ac182f1c66ffa0
Brad Jorsch [Wed, 10 Feb 2016 16:49:19 +0000 (11:49 -0500)]
PHPSessionHandler: Implement SessionHandlerInterface
Now that support for PHP 5.3 has been dropped, we can do this.
Change-Id: If7fa9801194683eea6764e5748157d8a66a616df
jenkins-bot [Wed, 10 Feb 2016 16:29:35 +0000 (16:29 +0000)]
Merge "Fix case of Html class in HtmlTest comments"
jenkins-bot [Wed, 10 Feb 2016 15:59:18 +0000 (15:59 +0000)]
Merge "resourceloader: Disable localStorage cache on FF, Opera"
Brad Jorsch [Wed, 10 Feb 2016 15:40:15 +0000 (10:40 -0500)]
ApiMessage: Use a trait to avoid code duplication
Change-Id: I19eb63bdc4c4cbd137f4d2101d37c81ce91aa6b3