From: Kosta Harlan <kharlan@wikimedia.org>
Date: Wed, 17 Jul 2019 17:00:54 +0000 (-0400)
Subject: Tests: Remove old TODO file and update README with integration notes
X-Git-Tag: 1.34.0-rc.0~963^2
X-Git-Url: http://git.cyclocoop.org/%7B%24www_url%7Dadmin/compta/pie.php?a=commitdiff_plain;h=f2fbeacaef955bbda099a91679a699a8e3608fcc;p=lhc%2Fweb%2Fwiklou.git

Tests: Remove old TODO file and update README with integration notes

Change-Id: I006a238f5241a70841f0d25ef7196f13654fb7ac
---

diff --git a/tests/phpunit/README b/tests/phpunit/README
index f555812de2..4a0857f8b9 100644
--- a/tests/phpunit/README
+++ b/tests/phpunit/README
@@ -1,12 +1,12 @@
 == MediaWiki PHPUnit Tests ==
 
-The unit tests for MediaWiki are implemented using the PHPUnit testing
+The unit and integration tests for MediaWiki are implemented using the PHPUnit testing
 framework and require PHPUnit to run.
 
 
 === WARNING ===
 
-Some of the unit tests are DESTRUCTIVE and WILL ALTER YOUR WIKI'S CONTENTS.
+Some of the integration tests are DESTRUCTIVE and WILL ALTER YOUR WIKI'S CONTENTS.
 
 DO NOT RUN THESE TESTS ON A PRODUCTION SYSTEM OR ON ANY SYSTEM WHERE YOU NEED
 TO RETAIN YOUR DATA.
diff --git a/tests/phpunit/TODO b/tests/phpunit/TODO
deleted file mode 100644
index cd9b9e2d01..0000000000
--- a/tests/phpunit/TODO
+++ /dev/null
@@ -1,20 +0,0 @@
-== Things To Do ==
-
-* Most of the tests are named poorly;
-  naming should describe a use case in story-like language,
-  not simply identify the unit under test.
-  An example would be the difference between "testCalculate"
-  and "testAddingIntegersTogetherWorks".
-
-* Many of the tests make multiple assertions, and are thus not unitary tests.
-  By using data-providers and more use-case oriented test selection
-  nearly all of these cases can be easily resolved.
-
-* Some of the test files are either incorrectly named or in the wrong folder.
-  Tests should be organized in a mirrored structure to the source they are testing,
-  and named the same, with the exception of the word "Test" at the end.
-
-* Shared set-up code or base classes are present,
-  but usually named improperly or appear to be poorly factored.
-  Support code should share as much of the same naming  as the code it's supporting,
-  and test and test-case depenencies should be considered to resolve other shared needs.