From: Brad Jorsch <bjorsch@wikimedia.org>
Date: Tue, 29 Oct 2013 15:56:35 +0000 (-0400)
Subject: UploadStash::removeFileNoAuth shouldn't need auth
X-Git-Tag: 1.31.0-rc.0~18357
X-Git-Url: http://git.cyclocoop.org/%7B%24www_url%7Dadmin/compta/pie.php?a=commitdiff_plain;h=d4b250ad380b024620b724c9f9485e79ea712798;p=lhc%2Fweb%2Fwiklou.git

UploadStash::removeFileNoAuth shouldn't need auth

UploadStash::getFile has a "noAuth" parameter, which should be set true
when this is called from UploadStash::removeFileNoAuth.

Callers should already be doing their own auth checking, or calling
UploadStash::removeFile.

Bug: 56298
Change-Id: Ic70c4e2bc6df5cb9b139a3631766f8ff0ec4ef02
---

diff --git a/includes/upload/UploadStash.php b/includes/upload/UploadStash.php
index ebeb9c188d..7db6c64b36 100644
--- a/includes/upload/UploadStash.php
+++ b/includes/upload/UploadStash.php
@@ -358,7 +358,7 @@ class UploadStash {
 		wfDebug( __METHOD__ . " clearing row $key\n" );
 
 		// Ensure we have the UploadStashFile loaded for this key
-		$this->getFile( $key );
+		$this->getFile( $key, true );
 
 		$dbw = $this->repo->getMasterDb();