From: Thomas Gries <wikinaut@users.mediawiki.org>
Date: Tue, 7 Jun 2011 22:30:06 +0000 (+0000)
Subject: quick fix for bug28983 . Do not use $path in the loop. Even the remaining $e is dange... 
X-Git-Tag: 1.31.0-rc.0~29621
X-Git-Url: http://git.cyclocoop.org/%7B%24www_url%7Dadmin/compta/pie.php?a=commitdiff_plain;h=a65b660af918ba89c7ad7a3be52db14a070df451;p=lhc%2Fweb%2Fwiklou.git

quick fix for bug28983 . Do not use $path in the loop. Even the remaining $e is dangerous subject to change from the require-once-loaded extensions. This is NOT A FINAL fix, just a small improvement
---

diff --git a/includes/installer/Installer.php b/includes/installer/Installer.php
index 6c6a99f206..5c75f327af 100644
--- a/includes/installer/Installer.php
+++ b/includes/installer/Installer.php
@@ -1224,7 +1224,6 @@ abstract class Installer {
 		global $IP;
 		$exts = $this->getVar( '_Extensions' );
 		$IP = $this->getVar( 'IP' );
-		$path = $IP . '/extensions';
 
 		/**
 		 * We need to include DefaultSettings before including extensions to avoid
@@ -1240,7 +1239,7 @@ abstract class Installer {
 		require( "$IP/includes/DefaultSettings.php" );
 
 		foreach( $exts as $e ) {
-			require_once( "$path/$e/$e.php" );
+   			require_once( $IP . '/extensions' . "/$e/$e.php" );
 		}
 
 		$hooksWeWant = isset( $wgHooks['LoadExtensionSchemaUpdates'] ) ?