Merge "resourceloader: Remove back compat for old packageFiles format"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Fri, 22 Feb 2019 23:32:54 +0000 (23:32 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Fri, 22 Feb 2019 23:32:54 +0000 (23:32 +0000)
includes/resourceloader/ResourceLoaderFileModule.php

index 6680777..2848871 100644 (file)
@@ -1093,15 +1093,10 @@ class ResourceLoaderFileModule extends ResourceLoaderModule {
                        if ( is_string( $fileInfo ) ) {
                                $fileInfo = [ 'name' => $fileInfo, 'file' => $fileInfo ];
                        } elseif ( !isset( $fileInfo['name'] ) ) {
-                               // Backwards compatibility
-                               if ( !is_numeric( $alias ) ) {
-                                       $fileInfo['name'] = $alias;
-                               } else {
-                                       $msg = __METHOD__ . ": invalid package file definition for module " .
-                                               "\"{$this->getName()}\": 'name' key is required when value is not a string";
-                                       wfDebugLog( 'resourceloader', $msg );
-                                       throw new MWException( $msg );
-                               }
+                               $msg = __METHOD__ . ": invalid package file definition for module " .
+                                       "\"{$this->getName()}\": 'name' key is required when value is not a string";
+                               wfDebugLog( 'resourceloader', $msg );
+                               throw new MWException( $msg );
                        }
 
                        // Infer type from alias if needed