Merge "rdbms: fix IDEA warnings in DatabaseMssql.php"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Wed, 22 Aug 2018 05:01:43 +0000 (05:01 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Wed, 22 Aug 2018 05:01:43 +0000 (05:01 +0000)
1  2 
includes/libs/rdbms/database/DatabaseMssql.php

@@@ -77,7 -77,16 +77,7 @@@ class DatabaseMssql extends Database 
                parent::__construct( $params );
        }
  
 -      /**
 -       * Usually aborts on failure
 -       * @param string $server
 -       * @param string $user
 -       * @param string $password
 -       * @param string $dbName
 -       * @throws DBConnectionError
 -       * @return bool|resource|null
 -       */
 -      public function open( $server, $user, $password, $dbName ) {
 +      protected function open( $server, $user, $password, $dbName ) {
                # Test for driver support, to avoid suppressed fatal error
                if ( !function_exists( 'sqlsrv_connect' ) ) {
                        throw new DBConnectionError(
  
                $this->opened = true;
  
 -              return $this->conn;
 +              return (bool)$this->conn;
        }
  
        /**
        }
  
        /**
-        * @param MssqlResultWrapper $res
+        * @param IResultWrapper $res
         * @return stdClass
         */
        public function fetchObject( $res ) {
        }
  
        /**
-        * @param MssqlResultWrapper $res
+        * @param IResultWrapper $res
         * @return array
         */
        public function fetchRow( $res ) {