Merge "autocomplete: fix duplicate/missing tracking events"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Wed, 29 Jun 2016 08:47:20 +0000 (08:47 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Wed, 29 Jun 2016 08:47:20 +0000 (08:47 +0000)
1  2 
includes/specials/SpecialSearch.php

@@@ -720,7 -720,7 +720,7 @@@ class SpecialSearch extends SpecialPag
  
                $out .= "<ul class='mw-search-results'>\n";
                while ( $result ) {
-                       $out .= $this->showHit( $result, $terms, ++$pos );
+                       $out .= $this->showHit( $result, $terms, $pos++ );
                        $result = $matches->next();
                }
                $out .= "</ul>\n";
         * @return string
         */
        protected function searchProfileTabs( $term ) {
 -              $out = Xml::openElement( 'div', [ 'class' => 'mw-search-profile-tabs' ] );
 +              $out = Html::element( 'div', [ 'class' => 'visualClear' ] ) .
 +                      Xml::openElement( 'div', [ 'class' => 'mw-search-profile-tabs' ] );
  
                $bareterm = $term;
                if ( $this->startsWithImage( $term ) ) {
                                ->numParams( $this->offset + 1, $this->offset + $resultsShown, $totalNum )
                                ->numParams( $resultsShown )
                                ->parse();
 -                      $out .= Xml::tags( 'div', [ 'class' => 'results-info' ], $top ) .
 -                              Xml::element( 'div', [ 'style' => 'clear:both' ], '', false );
 +                      $out .= Xml::tags( 'div', [ 'class' => 'results-info' ], $top );
                }
  
                return $out;