Include error code in error message when convert fails
authorBrian Wolff <bawolff+wn@gmail.com>
Sat, 28 Sep 2013 21:35:41 +0000 (18:35 -0300)
committerBryan Davis <bd808@wikimedia.org>
Sun, 8 Dec 2013 04:40:26 +0000 (21:40 -0700)
This info is logged, but it makes it much easier to debug
things if the info is right there.

Change-Id: I3a331a19a13a932c6b7aefdd9885ad351f3f48e3

includes/media/Bitmap.php

index 13849f4..d93168f 100644 (file)
@@ -382,7 +382,7 @@ class BitmapHandler extends ImageHandler {
                if ( $retval !== 0 ) {
                        $this->logErrorForExternalProcess( $retval, $err, $cmd );
 
-                       return $this->getMediaTransformError( $params, $err );
+                       return $this->getMediaTransformError( $params, "$err\nError code: $retval" );
                }
 
                return false; # No error