Merge "Remove TODO for use of TRUNCATE and replace with comment"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Fri, 24 Jan 2014 02:00:29 +0000 (02:00 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Fri, 24 Jan 2014 02:00:29 +0000 (02:00 +0000)
includes/MessageBlobStore.php

index 8a8142b..7e1c745 100644 (file)
@@ -242,8 +242,9 @@ class MessageBlobStore {
 
        public static function clear() {
                // TODO: Give this some more thought
-               // TODO: Is TRUNCATE better?
                try {
+                       // Not using TRUNCATE, because that needs extra permissions,
+                       // which maybe not granted to the database user.
                        $dbw = wfGetDB( DB_MASTER );
                        $dbw->delete( 'msg_resource', '*', __METHOD__ );
                        $dbw->delete( 'msg_resource_links', '*', __METHOD__ );