From d14d3226128ab0f57e6ea28eb425a85c6388ce6f Mon Sep 17 00:00:00 2001
From: Aaron Schulz <aschulz@wikimedia.org>
Date: Thu, 19 May 2016 20:59:55 -0700
Subject: [PATCH] Lowered incrTableUpdate() batch size to $wgUpdateRowsPerQuery

Change-Id: I05787b6e9ace26e7a20c228fbc3502983dfed777
---
 includes/deferred/LinksUpdate.php | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/includes/deferred/LinksUpdate.php b/includes/deferred/LinksUpdate.php
index 1f7f3b0cbb..bd4238ce82 100644
--- a/includes/deferred/LinksUpdate.php
+++ b/includes/deferred/LinksUpdate.php
@@ -84,8 +84,6 @@ class LinksUpdate extends SqlDataUpdate implements EnqueueableDataUpdate {
 	 */
 	private $user;
 
-	const BATCH_SIZE = 500; // try to keep typical updates in a single transaction
-
 	/**
 	 * Constructor
 	 *
@@ -338,6 +336,8 @@ class LinksUpdate extends SqlDataUpdate implements EnqueueableDataUpdate {
 	 * @param array $insertions Rows to insert
 	 */
 	private function incrTableUpdate( $table, $prefix, $deletions, $insertions ) {
+		$bSize = RequestContext::getMain()->getConfig()->get( 'UpdateRowsPerQuery' );
+
 		if ( $table === 'page_props' ) {
 			$fromField = 'pp_page';
 		} else {
@@ -354,7 +354,7 @@ class LinksUpdate extends SqlDataUpdate implements EnqueueableDataUpdate {
 			foreach ( $deletions as $ns => $dbKeys ) {
 				foreach ( $dbKeys as $dbKey => $unused ) {
 					$curDeletionBatch[$ns][$dbKey] = 1;
-					if ( ++$curBatchSize >= self::BATCH_SIZE ) {
+					if ( ++$curBatchSize >= $bSize ) {
 						$deletionBatches[] = $curDeletionBatch;
 						$curDeletionBatch = [];
 						$curBatchSize = 0;
@@ -380,7 +380,7 @@ class LinksUpdate extends SqlDataUpdate implements EnqueueableDataUpdate {
 				$toField = $prefix . '_to';
 			}
 
-			$deletionBatches = array_chunk( array_keys( $deletions ), self::BATCH_SIZE );
+			$deletionBatches = array_chunk( array_keys( $deletions ), $bSize );
 			foreach ( $deletionBatches as $deletionBatch ) {
 				$deleteWheres[] = [ $fromField => $this->mId, $toField => $deletionBatch ];
 			}
@@ -392,7 +392,7 @@ class LinksUpdate extends SqlDataUpdate implements EnqueueableDataUpdate {
 			wfGetLBFactory()->waitForReplication( [ 'wiki' => $this->mDb->getWikiID() ] );
 		}
 
-		$insertBatches = array_chunk( $insertions, self::BATCH_SIZE );
+		$insertBatches = array_chunk( $insertions, $bSize );
 		foreach ( $insertBatches as $insertBatch ) {
 			$this->mDb->insert( $table, $insertBatch, __METHOD__, 'IGNORE' );
 			$this->mDb->commit( __METHOD__, 'flush' );
-- 
2.20.1