From a79158833f9b043f88304c6d1edf4f076d1cf592 Mon Sep 17 00:00:00 2001 From: Aryeh Gregor Date: Wed, 13 Feb 2008 17:58:54 +0000 Subject: [PATCH] Revert 30902: it was (as the style rule clearly said) putting a page break before *every single heading*. This was probably going to be a waste of paper, insofar as my five-line test page got spread out over three or four pages when I checked print preview. We could add page-break-after: avoid;, but I don't think this is necessary or useful unless someone can demonstrate that it actually changes some browser's behavior. Most browsers don't support the avoid value of page-break-*, and I strongly suspect that those that do already have this rule for h* in their default stylesheets, per the CSS 2.1 suggested default HTML 4 stylesheet: --- RELEASE-NOTES | 1 - includes/DefaultSettings.php | 2 +- skins/common/commonPrint.css | 4 +--- 3 files changed, 2 insertions(+), 5 deletions(-) diff --git a/RELEASE-NOTES b/RELEASE-NOTES index bf015984ea..f5ac33bd04 100644 --- a/RELEASE-NOTES +++ b/RELEASE-NOTES @@ -392,7 +392,6 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN * (bug 11567) Fix error checking for PEAR::Mail. UserMailer::send() now returns true-or-WikiError, which seems to be the calling convention expected by half its callers already -* (bug 12972) Add page break rules to the "print" style-sheet * (bug 12846) IE rtl.css issue in RTL wikis special:Preferences when selecting an LTR user language diff --git a/includes/DefaultSettings.php b/includes/DefaultSettings.php index 6edcc3aa7e..e8e58be4e8 100644 --- a/includes/DefaultSettings.php +++ b/includes/DefaultSettings.php @@ -1325,7 +1325,7 @@ $wgCacheEpoch = '20030516000000'; * to ensure that client-side caches don't keep obsolete copies of global * styles. */ -$wgStyleVersion = '115'; +$wgStyleVersion = '116'; # Server-side caching: diff --git a/skins/common/commonPrint.css b/skins/common/commonPrint.css index 734e50490c..b0aad3d1fe 100644 --- a/skins/common/commonPrint.css +++ b/skins/common/commonPrint.css @@ -129,10 +129,8 @@ ul { border-top: 1px solid black; } -h1, h2, h3, h4, h5, h6 -{ +h1, h2, h3, h4, h5, h6 { font-weight: bold; - page-break-before: always; } p, .documentDescription { -- 2.20.1