From 8555891d6827b1ba3b69501a2572c09e2b20beb3 Mon Sep 17 00:00:00 2001 From: Aaron Schulz Date: Sat, 9 Sep 2017 13:57:35 -0700 Subject: [PATCH] Remove use of implicitGroupby() in WikiPage Change-Id: I17cc3ae5a6e90ba49978606e9ca6a1cdcdb57c03 --- includes/page/WikiPage.php | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/includes/page/WikiPage.php b/includes/page/WikiPage.php index bf8a59710d..29ee533cee 100644 --- a/includes/page/WikiPage.php +++ b/includes/page/WikiPage.php @@ -982,18 +982,12 @@ class WikiPage implements Page, IDBAccessObject { $dbr = wfGetDB( DB_REPLICA ); - if ( $dbr->implicitGroupby() ) { - $realNameField = 'user_real_name'; - } else { - $realNameField = 'MIN(user_real_name) AS user_real_name'; - } - $tables = [ 'revision', 'user' ]; $fields = [ 'user_id' => 'rev_user', 'user_name' => 'rev_user_text', - $realNameField, + 'user_real_name' => 'MIN(user_real_name)', 'timestamp' => 'MAX(rev_timestamp)', ]; -- 2.20.1