From 5a121eb723d2a5647937032cec44990a02de4405 Mon Sep 17 00:00:00 2001 From: Roan Kattouw Date: Mon, 25 Apr 2011 10:17:30 +0000 Subject: [PATCH] Followup r86625: per CR, use loose comparison against null instead of typeof foo != 'undefined' because jQuery 1.4 (which MW uses) actually returns null for unset .data() keys, but 1.5 returns undefined. --- resources/jquery/jquery.collapsibleTabs.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/resources/jquery/jquery.collapsibleTabs.js b/resources/jquery/jquery.collapsibleTabs.js index 1c68250053..b239972760 100644 --- a/resources/jquery/jquery.collapsibleTabs.js +++ b/resources/jquery/jquery.collapsibleTabs.js @@ -49,7 +49,7 @@ }, addData: function( $collapsible ) { var $settings = $collapsible.parent().data( 'collapsibleTabsSettings' ); - if ( typeof $settings != 'undefined' ) { + if ( $settings != null ) { $collapsible.data( 'collapsibleTabsSettings', { 'expandedContainer': $settings.expandedContainer, 'collapsedContainer': $settings.collapsedContainer, @@ -114,4 +114,4 @@ $.collapsibleTabs.handleResize(); } }; -} )( jQuery ); \ No newline at end of file +} )( jQuery ); -- 2.20.1