From 4cff45e67c316f7ce63be60d05ae600210b72b97 Mon Sep 17 00:00:00 2001 From: "Ori.livneh" Date: Tue, 12 Apr 2016 18:48:25 +0000 Subject: [PATCH] Revert "Measure commitMasterChanges() run time" This reverts commit efb441883937. This is the biggest metric by statsd traffic volume on the Wikimedia cluster. Please re-introduce this only with sampling. Bug: T101141 Change-Id: I7bc3b3aaa98dcefe1a80a4f458a83232c29a27ea --- includes/db/loadbalancer/LBFactory.php | 4 ---- 1 file changed, 4 deletions(-) diff --git a/includes/db/loadbalancer/LBFactory.php b/includes/db/loadbalancer/LBFactory.php index a484bb44bd..f39596b75e 100644 --- a/includes/db/loadbalancer/LBFactory.php +++ b/includes/db/loadbalancer/LBFactory.php @@ -247,11 +247,7 @@ abstract class LBFactory { } ); } ); - $start = microtime( true ); $this->forEachLBCallMethod( 'commitMasterChanges', [ $fname ] ); - $timeMs = 1000 * ( microtime( true ) - $start ); - - RequestContext::getMain()->getStats()->timing( "db.commit-masters", $timeMs ); } /** -- 2.20.1