From 249c9d631ac45ca2ab3173894ffe188889341d19 Mon Sep 17 00:00:00 2001 From: Timo Tijhof Date: Wed, 6 Mar 2019 15:00:47 +0000 Subject: [PATCH] resourceloader: Remove wgAvailableSkins from mw.config MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Added in 2011 for use in QUnit tests (r80790, r80792). That was a terrible idea in hindsight, which I removed again in 2015 with 6b758fc982972e, and 0f9e4ca0fb7c. If a need for it were to arise in the future, we'd export it within the file module that needs it, or via addJsConfigVars() on only the pages that need it – not globally. Bug: T217772 Change-Id: I3885cacaa9b33e6947dbaf26f9b6839e19588603 --- RELEASE-NOTES-1.33 | 1 + includes/resourceloader/ResourceLoaderStartUpModule.php | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/RELEASE-NOTES-1.33 b/RELEASE-NOTES-1.33 index c2bb4cfb62..f29921602f 100644 --- a/RELEASE-NOTES-1.33 +++ b/RELEASE-NOTES-1.33 @@ -279,6 +279,7 @@ because of Phabricator reports. * The transitional wrapper classes AuthPluginPrimaryAuthenticationProvider, AuthManagerAuthPlugin, and AuthManagerAuthPluginUser. * The $wgAuth configuration setting and its use in Setup.php and unit tests +* (T217772) The 'wgAvailableSkins' mw.config key in JavaScript, was removed. === Deprecations in 1.33 === * The configuration option $wgUseESI has been deprecated, and is expected diff --git a/includes/resourceloader/ResourceLoaderStartUpModule.php b/includes/resourceloader/ResourceLoaderStartUpModule.php index e344736052..acc2503d90 100644 --- a/includes/resourceloader/ResourceLoaderStartUpModule.php +++ b/includes/resourceloader/ResourceLoaderStartUpModule.php @@ -107,7 +107,6 @@ class ResourceLoaderStartUpModule extends ResourceLoaderModule { 'wgSiteName' => $conf->get( 'Sitename' ), 'wgDBname' => $conf->get( 'DBname' ), 'wgExtraSignatureNamespaces' => $conf->get( 'ExtraSignatureNamespaces' ), - 'wgAvailableSkins' => Skin::getSkinNames(), 'wgExtensionAssetsPath' => $conf->get( 'ExtensionAssetsPath' ), // MediaWiki sets cookies to have this prefix by default 'wgCookiePrefix' => $conf->get( 'CookiePrefix' ), -- 2.20.1