Chad Horohoe [Tue, 16 Nov 2010 15:29:48 +0000 (15:29 +0000)]
Move preference for PEAR higher up the list, apt and yum repos tend to be out of date
Chad Horohoe [Tue, 16 Nov 2010 15:10:46 +0000 (15:10 +0000)]
More is_a() -> instanceof
Roan Kattouw [Tue, 16 Nov 2010 14:23:34 +0000 (14:23 +0000)]
Followup r76782: is_a() -> instanceof (we dropped PHP 4 support over 3 years ago), or -> ||
Sam Reed [Tue, 16 Nov 2010 14:06:21 +0000 (14:06 +0000)]
Variablise $navigationBar
Add a couple of braces
Chad Horohoe [Tue, 16 Nov 2010 13:44:51 +0000 (13:44 +0000)]
Fix for r69917: Should be using DB_ADMIN if we were using $wgUseRootUser
Aaron Schulz [Tue, 16 Nov 2010 10:51:24 +0000 (10:51 +0000)]
* Fixed ipv6 range test calls
* Made testisIPAddress test results more readable on failure
Neil Kandalgaonkar [Tue, 16 Nov 2010 07:11:39 +0000 (07:11 +0000)]
removed mac-specific temp dir path for debug log
Neil Kandalgaonkar [Tue, 16 Nov 2010 07:09:46 +0000 (07:09 +0000)]
fixed typo
Neil Kandalgaonkar [Tue, 16 Nov 2010 06:57:46 +0000 (06:57 +0000)]
Fixed bug#25784 (thumbnails of stashed files had wrong description URLs).
This fixes the more general problem that the imageinfo returned with stashed uploads was inaccurate, since it was relying on
code that only worked with non-stashed files.
So, I had to:
- move the ApiQueryStashImageInfo module into core. Which others had asked for anyway, and was anticipated sometime later.
- add lines to AutoLoader and ApiQuery to accomodate the new module
- add an ugly if/then to UploadBase -- based on the type of uploaded file, it will use a different API module to simulate a getImageInfo call.
I left a TODO that this situation wasn't ideal, but the way things are now, imageInfo is constructed by the API modules, when it should probably
really be the File modules. Then the API can wrap that info into various formats.
- add a few new lines to the tests to check imageinfo information in both regular and stashed upload files
Neil Kandalgaonkar [Tue, 16 Nov 2010 01:15:58 +0000 (01:15 +0000)]
removed URL hackery, now using SpecialPage::getTitleFor(). Followup to r75906
Neil Kandalgaonkar [Tue, 16 Nov 2010 00:24:37 +0000 (00:24 +0000)]
Followups mostly to r75906.
* Improved logic around error messages, and understandability of those messages.
* Removed FIXME on Content-Length header. When we serve the file
this way, it seems to be necessary to explicitly set the Content-Length. I tried
removing it and unsurprisingly it did not appear.
I am unsure what RoanKattouw is referring to when he says PHP can do this.
How can PHP know what the Content-Length is going to be, unless we set this explicitly?
Neil Kandalgaonkar [Mon, 15 Nov 2010 23:49:16 +0000 (23:49 +0000)]
updated comments, error messages. Removing exposure of actual paths in error message, while convenient for a developer it probably should not be exposed to the public.
Aaron Schulz [Mon, 15 Nov 2010 23:20:23 +0000 (23:20 +0000)]
Removed weird unused "IPv4toIPv6" function
Aaron Schulz [Mon, 15 Nov 2010 21:18:31 +0000 (21:18 +0000)]
* added more isValid()/isPrivate() tests
* added isValidBlock()/isIPv4() tests
Antoine Musso [Mon, 15 Nov 2010 21:14:29 +0000 (21:14 +0000)]
Use accessor when trying to get a private property.
I kept hitting my browser cache when verifying my change, this
mean I have committed r76700 without testing it :(
Raimond Spekking [Mon, 15 Nov 2010 21:10:22 +0000 (21:10 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-11-15 20:53:00 UTC)
Platonides [Mon, 15 Nov 2010 20:40:49 +0000 (20:40 +0000)]
If this was needed to use MockSearch, it will also be needed after it has run, so other tests can get the real db they expect.
Max Semenik [Mon, 15 Nov 2010 20:39:34 +0000 (20:39 +0000)]
Rm superfuluous tab
Aaron Schulz [Mon, 15 Nov 2010 20:37:11 +0000 (20:37 +0000)]
typo: RE_IPV4_BLOCK -> RE_IP_BLOCK
Antoine Musso [Mon, 15 Nov 2010 20:13:58 +0000 (20:13 +0000)]
Change HistoryPage properties scope to private as well as some obvious functions scopes.
Add a few comments.
Antoine Musso [Mon, 15 Nov 2010 19:51:47 +0000 (19:51 +0000)]
Stylize. Add a couple braces around if/else statements.
Antoine Musso [Mon, 15 Nov 2010 19:47:15 +0000 (19:47 +0000)]
Get ride of $counter in functions calls. Follow up r65417.
Sam Reed [Mon, 15 Nov 2010 15:49:52 +0000 (15:49 +0000)]
Add a few bits of parameter documentation
Chad Horohoe [Mon, 15 Nov 2010 12:20:00 +0000 (12:20 +0000)]
(bug 25935) Fix comment in cleanupRemovedModules.php
Raimond Spekking [Sun, 14 Nov 2010 21:10:48 +0000 (21:10 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-11-14 20:53:00 UTC)
Benjamin Lees [Sun, 14 Nov 2010 21:00:31 +0000 (21:00 +0000)]
Grammar fix
Raimond Spekking [Sun, 14 Nov 2010 19:45:55 +0000 (19:45 +0000)]
Follow-up r76434, r76570,r76668: Pass skin object per CR
Raimond Spekking [Sun, 14 Nov 2010 19:28:32 +0000 (19:28 +0000)]
Follow-up r76434, r76570: Add skinname per CR
Sam Reed [Sun, 14 Nov 2010 19:00:27 +0000 (19:00 +0000)]
Add Yuri Astrakhan to CREDITS per request at [en.wikipedia.org/w/index.php?title=User_talk:Reedy&action=historysubmit&diff=
396740314&oldid=
396417142] (he wrote most of the original API stuff)
Alexandre Emsenhuber [Sun, 14 Nov 2010 18:58:28 +0000 (18:58 +0000)]
Follow-up r76633: change function signature so that it's easier to track the problem
Aaron Schulz [Sat, 13 Nov 2010 23:31:13 +0000 (23:31 +0000)]
Minor cleanups
Roan Kattouw [Sat, 13 Nov 2010 22:12:39 +0000 (22:12 +0000)]
Remove duplicate occurrence of 'u' from $htmlpairsStatic in Sanitizer::removeHTMLtags(). Reported by Dan Bolser on IRC
Raimond Spekking [Sat, 13 Nov 2010 20:42:57 +0000 (20:42 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-11-13 20:25:00 UTC)
Alexandre Emsenhuber [Sat, 13 Nov 2010 17:35:27 +0000 (17:35 +0000)]
Seems I forgot to commit this file in r76634
Alexandre Emsenhuber [Sat, 13 Nov 2010 17:31:04 +0000 (17:31 +0000)]
* (bug 20591) There's now a different message on Special:MovePage when $wgFixDoubleRedirects is set to false.
Based on a patch by The Evil IP address: https://bugzilla.wikimedia.org/attachment.cgi?id=7807
Alexandre Emsenhuber [Sat, 13 Nov 2010 17:22:08 +0000 (17:22 +0000)]
* (bug 25908) OutputPage::getHeadLinks() now requires a Skin object as first parameter
Chad Horohoe [Sat, 13 Nov 2010 16:32:40 +0000 (16:32 +0000)]
Fix undefined $max when doing --dfn-only
Max Semenik [Sat, 13 Nov 2010 13:24:21 +0000 (13:24 +0000)]
Mention load.php, rm repetition
Antoine Musso [Sat, 13 Nov 2010 13:13:12 +0000 (13:13 +0000)]
revert r71054. Although unused, the variable might be used later.
Sam Reed [Sat, 13 Nov 2010 12:50:50 +0000 (12:50 +0000)]
Followup r76612, nfi what a stromg is
Antoine Musso [Sat, 13 Nov 2010 12:45:10 +0000 (12:45 +0000)]
With PHPUnit 3.5.0, use its autoloader (like r74831).
Fix 'make test' for me.
Antoine Musso [Sat, 13 Nov 2010 10:41:38 +0000 (10:41 +0000)]
Minor variable typo
Antoine Musso [Sat, 13 Nov 2010 10:33:30 +0000 (10:33 +0000)]
justify help memcached console help
Max Semenik [Sat, 13 Nov 2010 08:32:40 +0000 (08:32 +0000)]
Tests: removed assignments of null to globals that are usually not null in tearDown() methods. This practice leads to other tests having to play whack-a-mole by initializing random variables they don't need directly just to avoid crashing.
Rob Lanphier [Sat, 13 Nov 2010 06:25:12 +0000 (06:25 +0000)]
Followup to r76111. Making the result parameter on getThumbUrl optional
Sam Reed [Sat, 13 Nov 2010 00:47:51 +0000 (00:47 +0000)]
Fixup some more documentation
Sam Reed [Sat, 13 Nov 2010 00:32:54 +0000 (00:32 +0000)]
Fixed up some doxygen warnings
Krinkle [Fri, 12 Nov 2010 23:10:58 +0000 (23:10 +0000)]
clean-up trailing spaces and tabs in js/css resources
Aaron Schulz [Fri, 12 Nov 2010 20:08:27 +0000 (20:08 +0000)]
* parseCIDR() should use parseCIDR6() for IPv6 (plus the later is private since r76560...)
* Made parseRange() work for IPv6 "x - y" style ranges
* Added MWException to IPv4toIPv6()
Aaron Schulz [Fri, 12 Nov 2010 19:37:37 +0000 (19:37 +0000)]
* Removed redundant check in toUnsigned6().
* MW requires PHP 5.1+, so the -1/false ip2long annoyance is gone. Also, ip2long("255.255.255.255") is -1 so no special case code is needed anymore.
* Removed toSigned() (not used outside IP.php). Due to the above points, ip2long() is totally equilivant.
* Moved some functions and consts around.
* Comment tweaks.
Max Semenik [Fri, 12 Nov 2010 18:47:33 +0000 (18:47 +0000)]
Fix for r74950: use wfEscapeShellArg()
Alexandre Emsenhuber [Fri, 12 Nov 2010 17:41:40 +0000 (17:41 +0000)]
Doxygen fix: @defgroup require group name *and* a title
Alexandre Emsenhuber [Fri, 12 Nov 2010 16:42:46 +0000 (16:42 +0000)]
Fixed some doxygen warnings
Raimond Spekking [Fri, 12 Nov 2010 16:07:55 +0000 (16:07 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-11-12 15:48:00 UTC)
Sam Reed [Fri, 12 Nov 2010 14:20:10 +0000 (14:20 +0000)]
Followup r76566
HttpFunctions.old.php had the same definition twice
Raimond Spekking [Fri, 12 Nov 2010 12:16:48 +0000 (12:16 +0000)]
Follow-up r76434: Run hook for Modern skin too per suggestion of Jack Phoenix
Antoine Musso [Fri, 12 Nov 2010 12:08:45 +0000 (12:08 +0000)]
Fix ranges formatting issue when testing for (g,z) in IPv6 address
Add / change assertions comments
65535 -> 0xFFFF
Follow up r76560
Brian Wolff [Fri, 12 Nov 2010 07:32:09 +0000 (07:32 +0000)]
(Bug 25872) Rename HttpRequest class to MWHttpRequest to avoid conflict with php extension.
This also keeps the old HttpRequest class name around, so it should not break backwards compatability.
Aaron Schulz [Fri, 12 Nov 2010 01:33:46 +0000 (01:33 +0000)]
* Changes in IP.php:
** Fixed hexToOctet()/toOctet() padding (pad left not right)
** Made hexToQuad() left-pad input (e.g. C ->
0000000C)
** Added isPublic6() function (checked as needed by isPublic())
** Rewrote isValidBlock() to not do flaky and roundabout isArray() check. Works for v6 now.
** Removed toArray(), unused outside IP.php and broken for v6
** Removed toOctet() duplication
** Added new private IPv6ToRawHex() function. Used to make toHex() faster.
** Made some functions private
** Reverted r20435, pointless
** Updated credits
* Changes in IPTests:
** Added a bunch of tests (mostly v6)
** Removed weird array test (especially with toArray() gone) after r76514
** Padding *no* longer needed for hexToX functions - assertion flipped
* CheckUser: removed parseRange6() reference (now private)
Platonides [Thu, 11 Nov 2010 23:04:55 +0000 (23:04 +0000)]
Docummentation minor fixes.
Raimond Spekking [Thu, 11 Nov 2010 20:52:15 +0000 (20:52 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-11-11 20:17:00 UTC)
Bryan Tong Minh [Thu, 11 Nov 2010 20:06:22 +0000 (20:06 +0000)]
Fix fail from r57867: tooltip param was never used in HTMLForm
OverlordQ [Thu, 11 Nov 2010 20:03:46 +0000 (20:03 +0000)]
Partial 'reverts' of of r70608, r76539, that doesn't do what you want, you're specifying the same rc_id for every row which is wrong
OverlordQ [Thu, 11 Nov 2010 19:53:49 +0000 (19:53 +0000)]
sequence was renamed a while back but this was missed
Mark A. Hershberger [Thu, 11 Nov 2010 19:47:12 +0000 (19:47 +0000)]
followup r76526
As I said on IRC: : On my local wiki I saw that error once, but I thought what I committed fixed it because I'm not seeing it now.
Mark A. Hershberger [Thu, 11 Nov 2010 17:52:46 +0000 (17:52 +0000)]
* Revert r76503
* Catch exception thrown when user is not logged in SpecialUploadStash.php
* Address RK's fixme comment by making constructor's mimic UnlistedSpecialPage's
Derk-Jan Hartman [Thu, 11 Nov 2010 16:05:36 +0000 (16:05 +0000)]
Followup r76522. Typo in orphans.
Derk-Jan Hartman [Thu, 11 Nov 2010 16:03:21 +0000 (16:03 +0000)]
Use CSS pagination options when printing.
- Avoid pagebreaks after headers
- Avoid pagebreaks inside images and wikitables
- Avoid less than 3 lines at the end of beginning of paragraphs.
Works on Opera, and partly on Firefox.
Aaron Schulz [Thu, 11 Nov 2010 13:45:24 +0000 (13:45 +0000)]
* Return type cleanup (int -> bool)
* Improved doc comments
Alexandre Emsenhuber [Thu, 11 Nov 2010 12:37:22 +0000 (12:37 +0000)]
Fix for r54225: parameter delimiter is ",", not "."
Aaron Schulz [Thu, 11 Nov 2010 12:18:28 +0000 (12:18 +0000)]
* Followed-up r76267:
** Made RE_IPV6_ADD and sanitizeIP() hande '::'.
** RE_IPV6_ADD is no longer over-inclusive (# of octets and '::' must be valid)
* Removed weird debugging code
* Broke long line
Roan Kattouw [Thu, 11 Nov 2010 10:15:49 +0000 (10:15 +0000)]
(bug 25877) Don't focus search box when clicking SimpleSearch's magnifying class button
Mark A. Hershberger [Thu, 11 Nov 2010 04:50:24 +0000 (04:50 +0000)]
fixes Bug 25812
Chad Horohoe [Wed, 10 Nov 2010 22:11:18 +0000 (22:11 +0000)]
Combine config.css with vector.css so it gets flipped too, plus one less request :)
Raimond Spekking [Wed, 10 Nov 2010 21:42:18 +0000 (21:42 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-11-10 21:28:00 UTC)
Alexandre Emsenhuber [Wed, 10 Nov 2010 20:21:49 +0000 (20:21 +0000)]
Added dirs per recent modifications
Sam Reed [Wed, 10 Nov 2010 19:49:04 +0000 (19:49 +0000)]
Various unused variables, add some braces
Explicitally define some variables used in hook type calls
Sam Reed [Wed, 10 Nov 2010 19:19:46 +0000 (19:19 +0000)]
foreach loop is pointless if you're then just going to keep a counter manually
Hence switch foreach to for loop
Max Semenik [Wed, 10 Nov 2010 16:45:28 +0000 (16:45 +0000)]
Added a check for PCRE_UTF8 per report at Support desk
Chad Horohoe [Wed, 10 Nov 2010 16:06:42 +0000 (16:06 +0000)]
Drop setup_database() here too. Only caller is the old installer
Chad Horohoe [Wed, 10 Nov 2010 16:06:16 +0000 (16:06 +0000)]
Postgres updater stuff, needs review
* Move setup_database() from DatabasePostgres to PostgresInstaller
** Add install step after interwiki for the COMMIT
** Put the table creation test (should we abstract this?) in setupDatabase()
** The leftover stuff in initial_setup() also belongs in setupDatabase(), I think?
Chad Horohoe [Wed, 10 Nov 2010 15:37:55 +0000 (15:37 +0000)]
(bug 25856) fix exaggerated indentation of checkbox text
Chad Horohoe [Wed, 10 Nov 2010 15:29:51 +0000 (15:29 +0000)]
Remove bullets from radio lists
Alexandre Emsenhuber [Wed, 10 Nov 2010 14:48:40 +0000 (14:48 +0000)]
Fixed some doxygen warnings (and some whitespaces removal I forgot to commit in r76386)
Alexandre Emsenhuber [Wed, 10 Nov 2010 14:41:46 +0000 (14:41 +0000)]
Quick fix: @fixme doesn't exist on doxygen ;)
Chad Horohoe [Wed, 10 Nov 2010 13:03:06 +0000 (13:03 +0000)]
Followup r76439, next button is conditional on whether we allow $wgUpgradeKey
Chad Horohoe [Wed, 10 Nov 2010 12:58:22 +0000 (12:58 +0000)]
Disable forward/back when installer is disabled
Alexandre Emsenhuber [Wed, 10 Nov 2010 12:20:22 +0000 (12:20 +0000)]
Made file description header consistent with other ones
Alexandre Emsenhuber [Wed, 10 Nov 2010 09:16:28 +0000 (09:16 +0000)]
* (bug 19944) Link on image thumbnails no longer link to "Media:" namespace in some cases
* (bug 25670) wfFindFile() now checks the namespace of the given title, only "File" and "Media" are allowed now
The problem with bug 19944 was that the cache in RepoGroup was holding a file with a Title that has its namespace set to NS_MEDIA; the cache is now only used for title with namespace set to NS_FILE.
Also modified ImageGallery to not call wfFindFile() on non-NS_FILE title; was obviously breaking the above fix.
Alexandre Emsenhuber [Wed, 10 Nov 2010 08:28:26 +0000 (08:28 +0000)]
Fix for r70871: need explicit check against null since current check also catches "0", thus making an infinite redirect loop for that article
Alexandre Emsenhuber [Wed, 10 Nov 2010 08:22:00 +0000 (08:22 +0000)]
* (bug 17996) HTTP redirects are now combined when requesting a special page
Raimond Spekking [Wed, 10 Nov 2010 08:18:21 +0000 (08:18 +0000)]
* (bug 22463) Add hook 'SkinGetPoweredBy' to make 'powered by' icon customizable
Patch by Yaron
Andrew Garrett [Wed, 10 Nov 2010 00:54:19 +0000 (00:54 +0000)]
Resolve bug 25580: pass $pageInfo along to finishImportPage when overriding the import code
Rotem Liss [Tue, 9 Nov 2010 22:05:09 +0000 (22:05 +0000)]
Localization update for he.
Raimond Spekking [Tue, 9 Nov 2010 21:12:00 +0000 (21:12 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-11-09 21:07:00 UTC)
Alexandre Emsenhuber [Tue, 9 Nov 2010 19:52:06 +0000 (19:52 +0000)]
Fix syntax error from r76392
Alexandre Emsenhuber [Tue, 9 Nov 2010 17:41:00 +0000 (17:41 +0000)]
Moved testRunner[|.ora|.postgres].sql to [|oracle/|postgres/]archives/ so that they can be called through DatabaseBase::patchPath(), much simplier
Chad Horohoe [Tue, 9 Nov 2010 17:02:03 +0000 (17:02 +0000)]
Followup r76391, r76393, rm unused msg
Chad Horohoe [Tue, 9 Nov 2010 17:01:09 +0000 (17:01 +0000)]
Followup r76391 per CR: just do $wgUpgradeKey in generateSecretKey()
Alexandre Emsenhuber [Tue, 9 Nov 2010 17:00:35 +0000 (17:00 +0000)]
* (bug 17789) Added a note to the total views on Special:Statistics saying that is doesn't count non-existing pages and special pages