lhc/web/wiklou.git
13 years agoMake addPortletLink() work even if the ul is not there.
Platonides [Fri, 16 Jul 2010 21:55:39 +0000 (21:55 +0000)]
Make addPortletLink() work even if the ul is not there.
Insert the new ul into the last div if there's one (typically a <div class="menu">), directly in the portlet otherwise.

13 years agoLocalisation updates for core and extension messages from translatewiki.net (2010...
Raimond Spekking [Fri, 16 Jul 2010 19:09:07 +0000 (19:09 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-07-16 19:01:00 UTC)

13 years agoajaxwatch.js: coding style tweaks
Jack Phoenix [Fri, 16 Jul 2010 14:57:30 +0000 (14:57 +0000)]
ajaxwatch.js: coding style tweaks

13 years agoFollow up to r66383. When init of skin fails, make sure to init Vector instead of...
Derk-Jan Hartman [Fri, 16 Jul 2010 14:04:54 +0000 (14:04 +0000)]
Follow up to r66383. When init of skin fails, make sure to init Vector instead of Monobook now.

13 years agoWhen we have a bogus useskin value, fallback to $wgDefaultSkin if that value is sane...
Derk-Jan Hartman [Fri, 16 Jul 2010 13:57:03 +0000 (13:57 +0000)]
When we have a bogus useskin value, fallback to $wgDefaultSkin if that value is sane. Fallback to hardcoded "vector" default if $wgDefaultSkin is bogus. Users who still have amathyst selected as their skin preference, should now get vector instead of monobook. Follow up to r66383.

13 years agoFix method name in a comment
Niklas Laxström [Fri, 16 Jul 2010 11:38:10 +0000 (11:38 +0000)]
Fix method name in a comment

13 years agoRevert part of r69412 which causes fatal errors
Niklas Laxström [Fri, 16 Jul 2010 07:24:45 +0000 (07:24 +0000)]
Revert part of r69412 which causes fatal errors

13 years agoMove FakeResultWrapper to Database.php, allowing more special pages and extensions...
X! [Thu, 15 Jul 2010 22:39:48 +0000 (22:39 +0000)]
Move FakeResultWrapper to Database.php, allowing more special pages and extensions than just Special:Allmessages to use a ResultWrapper-specific class (TablePager comes to mind)

13 years agointval ( $id ) once in caller instead of in all the getTextXXX functions
Ariel Glenn [Thu, 15 Jul 2010 21:25:31 +0000 (21:25 +0000)]
intval ( $id ) once in caller instead of in all the getTextXXX functions

13 years agoLocalisation updates for core and extension messages from translatewiki.net (2010...
Raimond Spekking [Thu, 15 Jul 2010 19:32:38 +0000 (19:32 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-07-15 19:22:00 UTC)

13 years agoRecover EditUser extension and put it up to date with the new preferences.
Platonides [Thu, 15 Jul 2010 18:30:49 +0000 (18:30 +0000)]
Recover EditUser extension and put it up to date with the new preferences.

13 years agoAdd cleanupChanneled() method to clean the channel consistently.
Mark A. Hershberger [Thu, 15 Jul 2010 16:27:27 +0000 (16:27 +0000)]
Add cleanupChanneled() method to clean the channel consistently.

13 years agoApply r69357 to trunk; was a fix for trunk but got committed to REL1_16
Roan Kattouw [Thu, 15 Jul 2010 09:25:58 +0000 (09:25 +0000)]
Apply r69357 to trunk; was a fix for trunk but got committed to REL1_16

13 years agore r69339 use the actual function: s/hasCache/haveCache/
Mark A. Hershberger [Thu, 15 Jul 2010 01:15:55 +0000 (01:15 +0000)]
re r69339 use the actual function: s/hasCache/haveCache/

13 years agoFix flush(). Need ob_flush()
Chad Horohoe [Wed, 14 Jul 2010 23:07:05 +0000 (23:07 +0000)]
Fix flush(). Need ob_flush()

13 years agore r67320: output a newline if we switch from channeled to unchanneled output
Mark A. Hershberger [Wed, 14 Jul 2010 22:44:19 +0000 (22:44 +0000)]
re r67320: output a newline if we switch from channeled to unchanneled output

13 years agofollow up r69339:
Mark A. Hershberger [Wed, 14 Jul 2010 21:46:52 +0000 (21:46 +0000)]
follow up r69339:
* Add a missing setVaryCookie for consistency
* don't cache result when token is given in ApiFeedWatchlist

13 years agofollow up r69339: Add a missing setVaryCookie for consistency and to avoid user X...
Mark A. Hershberger [Wed, 14 Jul 2010 21:00:09 +0000 (21:00 +0000)]
follow up r69339: Add a missing setVaryCookie for consistency and to avoid user X with skin Y getting the response marked up for skin B.

13 years agoLocalisation updates for core and extension messages from translatewiki.net (2010...
Raimond Spekking [Wed, 14 Jul 2010 20:12:19 +0000 (20:12 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-07-14 19:53:00 UTC)

13 years agoRemove extra space.
Platonides [Wed, 14 Jul 2010 19:19:16 +0000 (19:19 +0000)]
Remove extra space.

13 years agoAPI: Make output containing private or user-specific data uncacheable for logged...
Roan Kattouw [Wed, 14 Jul 2010 19:00:54 +0000 (19:00 +0000)]
API: Make output containing private or user-specific data uncacheable for logged-in users by setting Vary: Cookie or Cache-Control: private, whichever is appropriate. Fixes instances in core and WMF-deployed extensions only. Without this change, the output of requests like ?action=query&list=recentchanges&rcprop=patrolled&smaxage=3600 would be cached in Squid and viewable for anyone using the same URL, even if they don't have patrol rights. Other, more serious exploits are also possible. Also avoid using $wgUser in one place, kill some unused global $wgUser; instances and tweak a comment.

13 years agoRemove 'minordefault' preference completely
Aryeh Gregor [Wed, 14 Jul 2010 18:50:32 +0000 (18:50 +0000)]
Remove 'minordefault' preference completely

See bug 24313.  The preference encourages people to mark changes minor
by mistake, but it's better to have minor changes not marked minor than
non-minor changes marked minor.  enwiki users at [[Help talk:Minor
edit]] seemed to think it was a good idea.  Plus, I'm always in favor of
removing user preferences where possible.

The only likely fallout of note is some bot operators who didn't notice
this suddenly find their bot not marking anything minor.  I doubt it
will cause major problems, though.

13 years agoBy flipping '"Courier New", monospace' to 'monospace, "Courier New"', we can get...
Trevor Parscal [Wed, 14 Jul 2010 18:31:29 +0000 (18:31 +0000)]
By flipping '"Courier New", monospace' to 'monospace, "Courier New"', we can get the beneifts of allowing the user's monospace font override to still be used. Improves on r69335 which is itself an improvement on r65391.

14 years agoImproves on the technique used in r65391 to fix the font-size issues in Firefox,...
Trevor Parscal [Wed, 14 Jul 2010 17:50:51 +0000 (17:50 +0000)]
Improves on the technique used in r65391 to fix the font-size issues in Firefox, Chrome and Safari caused by using "monospace" as a font-family. The old approach was to use "monospace, sans-serif", which worked but was reported to actually fall-back on the sans-serif variant. Some research has shown that using '"Courier New", monospace' resolves the issue on all browsers without risking falling back to proportionally spaced fonts.

14 years agoFix nitpick complaint on r61809
Chad Horohoe [Wed, 14 Jul 2010 17:42:52 +0000 (17:42 +0000)]
Fix nitpick complaint on r61809

14 years ago* revert r61258
Mark A. Hershberger [Wed, 14 Jul 2010 17:34:18 +0000 (17:34 +0000)]
* revert r61258
* check if iconv extension is loaded and, if so, use it in UtfNormal::cleanUp()

14 years agoRevert r64217 (WikiSysop is back, and now (s)he's localisable) per comments on review
Chad Horohoe [Wed, 14 Jul 2010 17:28:08 +0000 (17:28 +0000)]
Revert r64217 (WikiSysop is back, and now (s)he's localisable) per comments on review

14 years agostyle version bump for r69317
Adam Miller [Wed, 14 Jul 2010 15:06:52 +0000 (15:06 +0000)]
style version bump for r69317

14 years agoInstaller no longer writes LocalSettings.php to /config. Now offer it as a download...
Chad Horohoe [Wed, 14 Jul 2010 01:18:14 +0000 (01:18 +0000)]
Installer no longer writes LocalSettings.php to /config. Now offer it as a download to the user and instruct them to upload/move it to the wiki base directory. Also only set _InstallDone if we hit no fatals during installation

14 years agoEpic bug fix. Changing the markup structure of Vectors tabs and related watch/unwatch...
Adam Miller [Tue, 13 Jul 2010 22:31:46 +0000 (22:31 +0000)]
Epic bug fix. Changing the markup structure of Vectors tabs and related watch/unwatch code to address bug 23490

14 years agoLocalisation updates for core and extension messages from translatewiki.net (2010...
Raimond Spekking [Tue, 13 Jul 2010 19:10:15 +0000 (19:10 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-07-13 18:48:00 UTC)

14 years agoRevert r69291, other references-related problems reported
Max Semenik [Tue, 13 Jul 2010 18:29:33 +0000 (18:29 +0000)]
Revert r69291, other references-related problems reported

14 years ago7, it's 7! (follow up to r68824)
Platonides [Mon, 12 Jul 2010 20:11:41 +0000 (20:11 +0000)]
7, it's 7! (follow up to r68824)

14 years agocleanupSpam.php:
Robert Leverington [Mon, 12 Jul 2010 16:54:25 +0000 (16:54 +0000)]
cleanupSpam.php:
 - Replace calls to Article::updateArticle with equivilant calls to Article::doEdit.  Resolves bug 18892.

14 years agoFixed weird unit test failures I experienced after r68544
Max Semenik [Mon, 12 Jul 2010 11:14:00 +0000 (11:14 +0000)]
Fixed weird unit test failures I experienced after r68544

14 years ago* (bug 24045) MediaWiki:Ipb-needreblock is now wrapped in a div with class "mw-ipd...
Alexandre Emsenhuber [Sun, 11 Jul 2010 19:25:46 +0000 (19:25 +0000)]
* (bug 24045) MediaWiki:Ipb-needreblock is now wrapped in a div with class "mw-ipd-needreblock"

14 years agoFixed some doxygen warnings
Alexandre Emsenhuber [Sun, 11 Jul 2010 18:24:53 +0000 (18:24 +0000)]
Fixed some doxygen warnings

14 years agoremoved PHP4-ism
Alexandre Emsenhuber [Sun, 11 Jul 2010 18:13:23 +0000 (18:13 +0000)]
removed PHP4-ism

14 years agoereg is deprecated
Max Semenik [Sun, 11 Jul 2010 17:34:06 +0000 (17:34 +0000)]
ereg is deprecated

14 years agoLocalisation updates for core and extension messages from translatewiki.net (2010...
Raimond Spekking [Sun, 11 Jul 2010 15:10:37 +0000 (15:10 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-07-11 14:47:00 UTC)

14 years agoModified Special:Userlogout to subclass UnlistedSpecialPage
Alexandre Emsenhuber [Sun, 11 Jul 2010 14:17:17 +0000 (14:17 +0000)]
Modified Special:Userlogout to subclass UnlistedSpecialPage

14 years agoFollowup r69251, copy+paste fail
Chad Horohoe [Sun, 11 Jul 2010 12:34:54 +0000 (12:34 +0000)]
Followup r69251, copy+paste fail

14 years agoCleanup to r69187: forgot to safeguard against ul_value or updatelog itself not existing.
Chad Horohoe [Sun, 11 Jul 2010 12:31:44 +0000 (12:31 +0000)]
Cleanup to r69187: forgot to safeguard against ul_value or updatelog itself not existing.

14 years agoDoc fixes and message cleanups to r69238
Chad Horohoe [Sun, 11 Jul 2010 11:27:58 +0000 (11:27 +0000)]
Doc fixes and message cleanups to r69238

14 years agoFixed some doxygen warnings
Alexandre Emsenhuber [Sat, 10 Jul 2010 21:20:50 +0000 (21:20 +0000)]
Fixed some doxygen warnings

14 years ago* Modified Special:Specialpages to subclass UnlistedSpecialPage instead of using...
Alexandre Emsenhuber [Sat, 10 Jul 2010 20:13:06 +0000 (20:13 +0000)]
* Modified Special:Specialpages to subclass UnlistedSpecialPage instead of using wfSpecialSpecialpages()
* Use Html:: methods

14 years agoLocalisation updates for core and extension messages from translatewiki.net (2010...
Raimond Spekking [Sat, 10 Jul 2010 15:33:41 +0000 (15:33 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-07-10 15:00:00 UTC)

14 years agoAdd $wgUseInstantCommons support to installer, tweak help based on presumed access...
Chad Horohoe [Sat, 10 Jul 2010 12:29:15 +0000 (12:29 +0000)]
Add $wgUseInstantCommons support to installer, tweak help based on presumed access to it

14 years ago(bug 24296) Added converttitles parameter to convert titles to their canonical langua...
Bryan Tong Minh [Sat, 10 Jul 2010 11:53:22 +0000 (11:53 +0000)]
(bug 24296) Added converttitles parameter to convert titles to their canonical language variant.

14 years agoFollowup r69235
Sam Reed [Sat, 10 Jul 2010 11:46:47 +0000 (11:46 +0000)]
Followup r69235

Replace setPropert with setProperty

14 years ago(bug 14685) Double underscore magic word usage is now tracked in the page_props table...
Bryan Tong Minh [Sat, 10 Jul 2010 11:30:11 +0000 (11:30 +0000)]
(bug 14685) Double underscore magic word usage is now tracked in the page_props table, as well as the behavioral magic words {{DEFAULTSORT}} and {{DISPLAYTITLE}}.

14 years agoFollow-up r69231: servedby is a boolean so will always be non-null.
Bryan Tong Minh [Sat, 10 Jul 2010 10:47:52 +0000 (10:47 +0000)]
Follow-up r69231: servedby is a boolean so will always be non-null.

14 years ago(bug 24185) Titles in the Media and Special namespace are now supported for title...
Bryan Tong Minh [Sat, 10 Jul 2010 10:46:20 +0000 (10:46 +0000)]
(bug 24185) Titles in the Media and Special namespace are now supported for title normalization in action=query. Special pages have their name resolved to the local alias.

14 years agoPartial revert r69231, unrelated and unfinished installer changes
Chad Horohoe [Sat, 10 Jul 2010 10:39:30 +0000 (10:39 +0000)]
Partial revert r69231, unrelated and unfinished installer changes

14 years ago(bug 24303) Expose hostname in API results. Show via servedby parameter, added uncond...
Chad Horohoe [Sat, 10 Jul 2010 10:37:39 +0000 (10:37 +0000)]
(bug 24303) Expose hostname in API results. Show via servedby parameter, added unconditionally on errors

14 years agoUpdate tests for r69229
Max Semenik [Sat, 10 Jul 2010 10:26:59 +0000 (10:26 +0000)]
Update tests for r69229

14 years agoFixed mysqlisms in Database.php comments, abstracted getSearchEngine()
Max Semenik [Sat, 10 Jul 2010 10:15:59 +0000 (10:15 +0000)]
Fixed mysqlisms in Database.php comments, abstracted getSearchEngine()

14 years agoCleanup r69128, getStatArray() -> getStatusArray(). It's two characters, c'mon
Chad Horohoe [Sat, 10 Jul 2010 09:26:42 +0000 (09:26 +0000)]
Cleanup r69128, getStatArray() -> getStatusArray(). It's two characters, c'mon

14 years agoClean up query code
Niklas Laxström [Sat, 10 Jul 2010 08:14:39 +0000 (08:14 +0000)]
Clean up query code

14 years agoTweak comparison in r69171
Niklas Laxström [Sat, 10 Jul 2010 07:36:09 +0000 (07:36 +0000)]
Tweak comparison in r69171

14 years agoRemoved User::setLoaded(), deprecated since times forgotten
Max Semenik [Fri, 9 Jul 2010 21:27:36 +0000 (21:27 +0000)]
Removed User::setLoaded(), deprecated since times forgotten

14 years agoThis can be protected now since we redid installSteps hooks
Chad Horohoe [Fri, 9 Jul 2010 21:19:58 +0000 (21:19 +0000)]
This can be protected now since we redid installSteps hooks

14 years agoFollow-up to r67044: moved string function tests to a separate file protected by...
Max Semenik [Fri, 9 Jul 2010 21:11:54 +0000 (21:11 +0000)]
Follow-up to r67044: moved string function tests to a separate file protected by conditional, tweaked test runner to skip instead of exploding when required function hook is not found.

14 years agoReduce some duplication
Chad Horohoe [Fri, 9 Jul 2010 20:53:52 +0000 (20:53 +0000)]
Reduce some duplication

14 years agoPut sanity checks on some of the installer steps. Also make WebInstaller_Install...
Chad Horohoe [Fri, 9 Jul 2010 19:05:48 +0000 (19:05 +0000)]
Put sanity checks on some of the installer steps. Also make WebInstaller_Install bail if you try a 2nd time

14 years agoMove status box below output from pass/fail
Chad Horohoe [Fri, 9 Jul 2010 18:36:10 +0000 (18:36 +0000)]
Move status box below output from pass/fail

14 years agoLocalisation updates for core and extension messages from translatewiki.net (2010...
Raimond Spekking [Fri, 9 Jul 2010 15:54:33 +0000 (15:54 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-07-09 15:17:00 UTC)

14 years agoUse 'summary' instead of 'comment'
Siebrand Mazeland [Fri, 9 Jul 2010 14:51:31 +0000 (14:51 +0000)]
Use 'summary' instead of 'comment'

14 years agoKill deprecated function. Marked as such for ~30k revs and no callers
Chad Horohoe [Fri, 9 Jul 2010 14:15:48 +0000 (14:15 +0000)]
Kill deprecated function. Marked as such for ~30k revs and no callers

14 years agoRemoved commented-out deprecated function
Max Semenik [Fri, 9 Jul 2010 13:45:09 +0000 (13:45 +0000)]
Removed commented-out deprecated function

14 years agoCleanup to r69191: use addParserOutput() instead of addHtml(), specify current rev...
Chad Horohoe [Fri, 9 Jul 2010 12:43:27 +0000 (12:43 +0000)]
Cleanup to r69191: use addParserOutput() instead of addHtml(), specify current rev on Article, use doViewParse() so we can cache the ParserOutput

14 years ago(bug 22339) Added srwhat=nearmatch to list=search to get a "go" result
Bryan Tong Minh [Fri, 9 Jul 2010 11:08:18 +0000 (11:08 +0000)]
(bug 22339) Added srwhat=nearmatch to list=search to get a "go" result

Refactored SearchResult constructor to accept Titles. New static function newFromRow and newFromTitle can be used.
Added SearchNearMatchResultSet to wrap the output of SearchEngine::getNearMatch.

14 years agoRevert r64436, r64437, r64508 per CR r64436
Bryan Tong Minh [Fri, 9 Jul 2010 09:46:05 +0000 (09:46 +0000)]
Revert r64436, r64437, r64508 per CR r64436

14 years agoRevert r63213, r63214 per CR comment on r63214, doesn't match documented cmd.exe...
Tim Starling [Fri, 9 Jul 2010 06:54:14 +0000 (06:54 +0000)]
Revert r63213, r63214 per CR comment on r63214, doesn't match documented cmd.exe behaviour

14 years agorequestWriteMode() is deprecated and unused
Max Semenik [Thu, 8 Jul 2010 19:30:21 +0000 (19:30 +0000)]
requestWriteMode() is deprecated and unused

14 years agoTweaks to UPGRADE and INSTALL instructions. Include new info about new-installer...
Chad Horohoe [Thu, 8 Jul 2010 18:46:10 +0000 (18:46 +0000)]
Tweaks to UPGRADE and INSTALL instructions. Include new info about new-installer, remove some redundant sections

14 years agoFollowup r69186, need to specify column name here
Chad Horohoe [Thu, 8 Jul 2010 18:35:26 +0000 (18:35 +0000)]
Followup r69186, need to specify column name here

14 years ago(bug 24124) Diffs are taking 10 to 20 seconds to load. Use parser cache for page...
Chad Horohoe [Thu, 8 Jul 2010 17:01:28 +0000 (17:01 +0000)]
(bug 24124) Diffs are taking 10 to 20 seconds to load. Use parser cache for page preview when diffing to current version (which is the most often). Cuts execution time down on my sample page from 1141.44ms down to 13.78ms on a pcache hit

14 years agoAdd ul_value to Postgres schema.
Greg Sabino Mullane [Thu, 8 Jul 2010 15:11:57 +0000 (15:11 +0000)]
Add ul_value to Postgres schema.

14 years agoChange Updaters to Updater
Chad Horohoe [Thu, 8 Jul 2010 15:00:00 +0000 (15:00 +0000)]
Change Updaters to Updater

14 years agoRefactor a lot of updaters.inc into some classes in the installer code. Still need...
Chad Horohoe [Thu, 8 Jul 2010 14:57:19 +0000 (14:57 +0000)]
Refactor a lot of updaters.inc into some classes in the installer code. Still need all these blasted global functions. And OpenID still uses $wgUpdates, so support for it remains...for now!

14 years agoAdd optional ul_value blob to updatelog so it can store more useful things
Chad Horohoe [Thu, 8 Jul 2010 13:58:42 +0000 (13:58 +0000)]
Add optional ul_value blob to updatelog so it can store more useful things

14 years agoIntroduce $wgBetterDirectionality that lets us work on support for rtl ui in ltr...
Niklas Laxström [Thu, 8 Jul 2010 13:34:03 +0000 (13:34 +0000)]
Introduce $wgBetterDirectionality that lets us work on support for rtl ui in ltr wiki and vice versa.

14 years agoUnused template parameter
Niklas Laxström [Thu, 8 Jul 2010 12:49:19 +0000 (12:49 +0000)]
Unused template parameter

14 years agoFollowup to r51583: actually use the rd_interwiki and rd_fragment fields, in the...
Roan Kattouw [Thu, 8 Jul 2010 10:49:36 +0000 (10:49 +0000)]
Followup to r51583: actually use the rd_interwiki and rd_fragment fields, in the spirit of r33133: we now use the redirect table as a cache for redirect targets, no longer pulling the page text from ES for every logged-in redirect view. Old-style redirect table entries with NULL for fragment and interwiki are automatically updated when the redirect is visited or edited.

14 years agoFollowup r68831, r69170. Set none as the default cache always, never APC
Chad Horohoe [Thu, 8 Jul 2010 10:34:59 +0000 (10:34 +0000)]
Followup r68831, r69170. Set none as the default cache always, never APC

14 years agoWhitespace fix
Niklas Laxström [Thu, 8 Jul 2010 09:28:31 +0000 (09:28 +0000)]
Whitespace fix

14 years agoAdded $wgAllUnicodeFixes to replace live-hack at twn
Niklas Laxström [Thu, 8 Jul 2010 09:15:53 +0000 (09:15 +0000)]
Added $wgAllUnicodeFixes to replace live-hack at twn

14 years agoSimplify wfMsgGetKey
Niklas Laxström [Thu, 8 Jul 2010 09:08:03 +0000 (09:08 +0000)]
Simplify wfMsgGetKey

14 years agoUpdate syntax examples a bit
Niklas Laxström [Thu, 8 Jul 2010 09:03:47 +0000 (09:03 +0000)]
Update syntax examples a bit

14 years agoAvoid unstubbing in wfGetLangObj, code style
Niklas Laxström [Thu, 8 Jul 2010 08:23:35 +0000 (08:23 +0000)]
Avoid unstubbing in wfGetLangObj, code style

14 years agoDocument mDebugtext
Niklas Laxström [Thu, 8 Jul 2010 08:12:19 +0000 (08:12 +0000)]
Document mDebugtext

14 years agoLittle debugging help for LinkBatch
Niklas Laxström [Thu, 8 Jul 2010 08:11:14 +0000 (08:11 +0000)]
Little debugging help for LinkBatch

14 years agor68831 make sure $selected is set.
Mark A. Hershberger [Thu, 8 Jul 2010 08:08:14 +0000 (08:08 +0000)]
r68831 make sure $selected is set.

14 years agoUpdate comment: makeLikeArray() is deprecated
Max Semenik [Thu, 8 Jul 2010 06:53:42 +0000 (06:53 +0000)]
Update comment: makeLikeArray() is deprecated

14 years agonew-installer: Revert DB driver check breakage in r69128
Ævar Arnfjörð Bjarmason [Wed, 7 Jul 2010 15:05:05 +0000 (15:05 +0000)]
new-installer: Revert DB driver check breakage in r69128

We should use isCompiled() to check if we can actually use a DB
driver. Just constructing the object isn't enough. r69128 regressed so
that the installed displayed Oracle as an option for me, even though I
have no driver for it.

14 years agoContinue to clean up the LanguageConverter.php.
Philip Tzou [Wed, 7 Jul 2010 14:46:27 +0000 (14:46 +0000)]
Continue to clean up the LanguageConverter.php.

14 years ago doesn't need to be passed by ref
Chad Horohoe [Wed, 7 Jul 2010 13:56:44 +0000 (13:56 +0000)]
 doesn't need to be passed by ref

14 years agoGive the installerdbtype object to custom callbacks too :)
Chad Horohoe [Wed, 7 Jul 2010 13:53:27 +0000 (13:53 +0000)]
Give the installerdbtype object to custom callbacks too :)

14 years agoPartial revert r69128: go back to making isCompiled() an instance method rather than...
Chad Horohoe [Wed, 7 Jul 2010 13:52:05 +0000 (13:52 +0000)]
Partial revert r69128: go back to making isCompiled() an instance method rather than static. Moved $installSteps tweaking to new preInstall() method rather than piling more hacks into the constructor. Also pass InstallerDBType to install steps, reduce some code duplication