Matthias Mullie [Wed, 28 Jun 2017 15:24:19 +0000 (17:24 +0200)]
Add mw.api.chunkedUploadToStash
Change-Id: I5d181e8a13fc5310ebd0fbb854def42bfb33d6c4
jenkins-bot [Wed, 5 Jul 2017 20:07:47 +0000 (20:07 +0000)]
Merge "Add mediastatistics-header-3d"
Translation updater bot [Wed, 5 Jul 2017 19:54:35 +0000 (21:54 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I5445497e09dea043da64d53925b7df30ac22edee
jenkins-bot [Wed, 5 Jul 2017 19:42:01 +0000 (19:42 +0000)]
Merge "Added chunked upload support to upload.js"
jenkins-bot [Wed, 5 Jul 2017 18:35:16 +0000 (18:35 +0000)]
Merge "Fix phrase search"
jenkins-bot [Wed, 5 Jul 2017 17:54:07 +0000 (17:54 +0000)]
Merge "Add two new hooks to fix broken CentralAuth unit tests"
jenkins-bot [Wed, 5 Jul 2017 17:23:08 +0000 (17:23 +0000)]
Merge "Pass old user options in PreferencesFormPreSave hook"
Max Semenik [Thu, 29 Jun 2017 00:14:18 +0000 (17:14 -0700)]
Add two new hooks to fix broken CentralAuth unit tests
* UnitTestsAfterDatabaseSetup
* UnitTestsBeforeDatabaseTeardown
Bug T168802 necessitates that CentralAuth creates its tables
before any user tests are run, due to its extensive hooking
into everything. This change adds two hooks for that, called
after DB initialization is done and before teardown begins. The
corresponding CentralAuth change is
at I618840fafd22d9b6471eb470ef0414e354aa17f5
Bug: T168802
Change-Id: If7050513719833d4167a24283885d7c10a25856b
Piotr Miazga [Tue, 4 Jul 2017 18:30:45 +0000 (20:30 +0200)]
Pass old user options in PreferencesFormPreSave hook
Changes:
- added one argument to PreferencesFormPreSave hook,
a $oldUserOptions array which contains set of all user
options before save
- updated documentation
Bug: T169365
Change-Id: I28003c5898d64031e1efb212cb0bec58ff44b958
Matthias Mullie [Wed, 5 Jul 2017 09:09:52 +0000 (11:09 +0200)]
Add mediastatistics-header-3d
Bug: T169681
Change-Id: I8d6b07ebc83ac8f15f07b25bb3688567f2c1430f
jenkins-bot [Tue, 4 Jul 2017 21:07:03 +0000 (21:07 +0000)]
Merge "Fix Revi's mailmap email address"
Yongmin Hong [Mon, 3 Jul 2017 17:42:01 +0000 (02:42 +0900)]
Fix Revi's mailmap email address
I just realized it was using old email address. While it redirects
to the new address, it's better to have it fixed.
Change-Id: I2df2a32f6144acca985d04b4bf58372343d119f6
Translation updater bot [Tue, 4 Jul 2017 20:03:10 +0000 (22:03 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Id315d69a372c235c67b158549ddc14d57d807b08
jenkins-bot [Tue, 4 Jul 2017 19:42:56 +0000 (19:42 +0000)]
Merge "Allow install.php to run env-checks with no db"
jenkins-bot [Tue, 4 Jul 2017 19:42:52 +0000 (19:42 +0000)]
Merge "Don't ask for password for env-checks in install.php"
addshore [Tue, 4 Jul 2017 18:39:42 +0000 (19:39 +0100)]
Allow install.php to run env-checks with no db
Bug: T169668
Change-Id: Ibb05b26cbf2d26c02ee7f26497e16d2c98e97de2
addshore [Tue, 4 Jul 2017 18:22:23 +0000 (19:22 +0100)]
Don't ask for password for env-checks in install.php
Bug: T169669
Change-Id: I00dbaca0e4532ecc499317ec8f1cb7f9eb872db3
Matthias Mullie [Thu, 26 Jan 2017 13:43:19 +0000 (14:43 +0100)]
Display categories on File redirects
This NS_FILE-specific redirect logic was introduced in 2008,
in
3c9536652a3b27ec97cb2e3f046c5e98849c58a4.
mTitle, as referenced to in the comments, no longer exists.
Article also no longer creates redirects in there, that’s now
in WikitextContent::fillParserOutput.
The original commit message describes that this was introduced
to be able to display redirects to foreign file repos. A lot
has changed in how that works since 2008, too :)
Back to the present: for redirects to foreign repos,
`$this->mPage->getFile()->getRedirected()` seems to always return
`null` (a placeholder object is created when the thing doesn’t
exist), so this this foreign repo-specific bit of code is bypassed
anyway. For local redirects, Article::view seems to be working just
fine.
By using Article::view, Categories used on file redirect pages
will now actually be displayed too.
And we can get rid of the otherwise no longer used Article::viewRedirect.
Bug: T29857
Change-Id: Icb02f3af32d10870f58d945cb06a84b3ba1305d3
jenkins-bot [Tue, 4 Jul 2017 02:29:57 +0000 (02:29 +0000)]
Merge "Skin: Use WANObjectCache for sitenotice caching"
Brad Jorsch [Wed, 21 Jun 2017 16:21:45 +0000 (12:21 -0400)]
Remove ParserOptions::legacyOptions() and cleanup related code
ParserOptions::legacyOptions() has been sitting around since 1.17.
Originally it seems to have been intended as a way to avoid a mass cache
invalidation (similar to optionsHashPre30() from I7fb9ffca9). That code
was mostly removed in 1.23, but legacyOptions() was left behind because
it was also being used in a few places as "all cache-varying options"
(despite it not being documented for that purpose) where we'd rather
have any key than no key at all.
This patch creates an actual ParserOptions::allCacheVaryingOptions()
method for those use cases and deprecates the long-obsolete
legacyOptions().
It also makes more explicit the use of the "all cache-varying options"
fallback in ParserCache::getKey(), and doesn't bother trying to use that
fallback in ParserCache::get() where it no longer makes sense.
Change-Id: Ife1e54744155136a570210c03fe907f18f8e8ece
Catrope [Mon, 3 Jul 2017 23:29:15 +0000 (23:29 +0000)]
RCFilters: Fix parameter name for "namespace"
Bug: T169579
Change-Id: I3e4c22ab28ccc65275246a777172bdc2fe611a9e
Timo Tijhof [Sat, 1 Jul 2017 04:19:31 +0000 (21:19 -0700)]
Skin: Use WANObjectCache for sitenotice caching
* Move the md5() hash to the cache key, this makes it much safer
after a change happens by avoiding write competitions between different
servers and db slaves. It also allows an undo to re-use the existing
cache if it still exists.
In addition, it enables idiomatic use of getWithSetCallback given
that get and set are now logically separated.
* Avoid fragile re-use of variable names. Previously it read the
original $notice value at multiple points but also setting $notice
to $parsed after a certain point. Consistently use $parsed only.
(Ref T115890.)
Change-Id: I5488cc894ff1544e6c20b7d51a7a2adfc292c4ec
Translation updater bot [Mon, 3 Jul 2017 20:03:03 +0000 (22:03 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I1a872a41132ae96bcd018094649e5310fef41146
jenkins-bot [Mon, 3 Jul 2017 19:19:27 +0000 (19:19 +0000)]
Merge "Remove empty lines at begin of function, if, foreach, switch"
jenkins-bot [Mon, 3 Jul 2017 19:13:15 +0000 (19:13 +0000)]
Merge "Move wgBreakFrames client code to mediawiki.page.startup"
Moriel Schottlender [Mon, 3 Jul 2017 17:19:48 +0000 (10:19 -0700)]
RCFilters: Reverse the sorting on tags
We want the results to show most used tags on top and least
on bottom, so use a reverse sort.
Bug: T166914
Change-Id: I1473070ac9293626bde5e95dad79c7e0ca954f70
Fomafix [Mon, 3 Jul 2017 07:13:09 +0000 (09:13 +0200)]
Avoid double HTML encoding
Html:element() already makes an HTML encoding. The additional
htmlspecialchars is not necessary.
Change-Id: If0530c3d3cb0d3cc61e849a1c84ae0d68c242517
David Causse [Thu, 29 Jun 2017 08:29:13 +0000 (10:29 +0200)]
Fix phrase search
Partially revert I61dc536 that broke phrase search support.
Fix phrase search by making explicit that there are two
kind of legalSearchChars() usecases :
- the chars allowed to be part of the search query (including special
syntax chars such as " and *). Used by SearchDatabase::filter() to
cleanup the whole query string (the default).
- the chars allowed to be part of a search term (excluding special
syntax chars) Used by search engine implementaions when parsing with
a regex.
For future reference:
Originally this distinction was made "explicit" by calling directly
SearchEngine::legalSearchChars() during the parsing stage. This was
broken by Iaabc10c by enabling inheritance.
This patch adds a new optional param to legalSearchChars to make this
more explicit.
Also remove the function I introduced in I61dc536 (I wrongly assumed
that the disctinction made between legalSearchChars usecases was due
to a difference in behavior between indexing and searching).
Added more tests to prevent this from happening in the future.
Bug: T167798
Change-Id: Ibdc796bb2881a2ed8194099d8c9f491980010f0f
Translation updater bot [Sun, 2 Jul 2017 19:55:08 +0000 (21:55 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ic4006ba2d837d0e47d94591742d418ad517e4d26
Translation updater bot [Sat, 1 Jul 2017 19:55:08 +0000 (21:55 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ic282c8a9b73144ad7351da0bde0706bc0d1c66a8
Umherirrender [Sat, 1 Jul 2017 08:32:08 +0000 (10:32 +0200)]
Remove empty lines at begin of function, if, foreach, switch
Organize phpcs.xml a bit
Change-Id: Ifb767729b481b4b686e6d6444cf48b1f580cc478
jenkins-bot [Sat, 1 Jul 2017 00:46:16 +0000 (00:46 +0000)]
Merge "resourceloader: Minor documentation and coding style improvements"
Timo Tijhof [Sat, 1 Jul 2017 00:31:56 +0000 (17:31 -0700)]
resourceloader: Minor documentation and coding style improvements
Based on current non-voting codesniffer warnings.
Change-Id: I34cbc31eda3eaa519a71fe2c04122859f2f15914
Aaron Schulz [Wed, 24 May 2017 19:01:31 +0000 (12:01 -0700)]
Push lazy jobs when exceptions are handled by MWExceptionHandler
Remove the exit(1), which does not seem to be needed by any callers.
Doing so means that post-send updates can still happen, such as the
pushing of lazy jobs.
Better avoid showing exceptions in doPostOutputShutdown(), given
that an error may have already been shown. By the post-send part,
it's to late to show errors anyway.
Bug: T100085
Change-Id: Ib1c75323f222a0e02603d6415626a4b233e8e1c7
jenkins-bot [Fri, 30 Jun 2017 23:33:34 +0000 (23:33 +0000)]
Merge "Always log exceptions in rollbackMasterChangesAndLog()"
Aaron Schulz [Fri, 30 Jun 2017 22:01:33 +0000 (15:01 -0700)]
Always log exceptions in rollbackMasterChangesAndLog()
MWExceptionHandler::rollbackMasterChangesAndLog() only logged exceptions
if there were already master changes. This is extremely problematic when
debugging, especially in situations like DeferredUpdates where they were
silently being swallowed.
This makes it log exceptions in all paths, erring on the side of logging
the same exception twice (theoretically it's possible I suppose) instead
of not at all.
Also make the method able to handle DBError exceptions, which most of
the callers seemed to be assuming. ApiMain was handling this explicitly.
Bug: T168347
Change-Id: I8739051f824a455ba669344184c3b11ac95cb561
jenkins-bot [Fri, 30 Jun 2017 22:20:48 +0000 (22:20 +0000)]
Merge "RCFilters: Trim spaces in saved query names"
jenkins-bot [Fri, 30 Jun 2017 22:20:15 +0000 (22:20 +0000)]
Merge "RCFilters: Change tooltip messages for view buttons"
Moriel Schottlender [Thu, 29 Jun 2017 23:38:27 +0000 (16:38 -0700)]
RCFilters: Change tooltip messages for view buttons
Bug: T167384
Change-Id: I30ec6b8931539ccaad8d2d1a609d117f2a13767d
jenkins-bot [Fri, 30 Jun 2017 22:05:59 +0000 (22:05 +0000)]
Merge "Allow search suggestions in skins operating in mobile mode"
jenkins-bot [Fri, 30 Jun 2017 21:59:33 +0000 (21:59 +0000)]
Merge "resourceloader: Allow mobile target by default on SkinModule"
jdlrobson [Fri, 30 Jun 2017 21:22:56 +0000 (14:22 -0700)]
Allow search suggestions in skins operating in mobile mode
MobileFrontend silently removes this skin from the page. This is
now made explicit and the module can be safely loaded in a mobile
environment.
This is used by both Timeless which although does not work
perfectly on a mobile device it should be easy to fix with additional
work.
Change-Id: Iedea2872d14430db452cec7e758f20d854778414
Depends-On: Ic36e9792f9217f3fd37bbd1f5c66d894301363f0
jdlrobson [Fri, 30 Jun 2017 19:27:04 +0000 (12:27 -0700)]
resourceloader: Allow mobile target by default on SkinModule
If a skin is using this class, it's likely to be pretty new.
The targets system was mostly created for older code.
Let's make this the default so skins don't need to do anything
additional to work on mobile.
This simple change makes the Timeless skin work on mobile
when MobileFrontend is installed: ?useformat=mobile&useskin=timeless
It looks beautiful :)
Change-Id: I2ab8a1a634bdc0b5b2084d227c7388b5382e93e8
jenkins-bot [Fri, 30 Jun 2017 21:21:15 +0000 (21:21 +0000)]
Merge "Make file purging also purge old versions"
Timo Tijhof [Fri, 30 Jun 2017 20:36:54 +0000 (13:36 -0700)]
Move wgBreakFrames client code to mediawiki.page.startup
Follows-up
f7c324685195, which migrated this from legacy wikibits
to the 'mediawiki.page.ready', however it's better suited in
'mediawiki.page.startup' because that one loaded on all pages blindly
(used to be hardcoded in OutputPage, now part of 'core' group
in Skin::getDefaultModules).
mediawiki.page.ready on the other hand is primarily for enhancing
the page content, loaded in Skin::getDefaultModules in the 'content'
group, which extensions like MobileFrontend may override with an
alternate implementation. This means frame breaking is bypassed!
Change-Id: Ia7206fac5c4ec6ace87304cfaeef375916b94fcf
Translation updater bot [Fri, 30 Jun 2017 20:24:51 +0000 (22:24 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ic9c8bdac869b2a4f218933be4803887a623c51fa
jenkins-bot [Fri, 30 Jun 2017 18:37:12 +0000 (18:37 +0000)]
Merge "TidyDriverBase::validate throws an exception"
jenkins-bot [Fri, 30 Jun 2017 18:37:05 +0000 (18:37 +0000)]
Merge "Update phan issues & estimated counts"
jenkins-bot [Fri, 30 Jun 2017 18:19:23 +0000 (18:19 +0000)]
Merge "API: Split non-English description messages into summary + additional text"
jenkins-bot [Fri, 30 Jun 2017 17:22:58 +0000 (17:22 +0000)]
Merge "RCFilters: Fix popup head with long message and icon"
Moriel Schottlender [Fri, 30 Jun 2017 16:46:42 +0000 (09:46 -0700)]
RCFilters: Trim spaces in saved query names
Make sure to trim the spaces before saving, and also to verify that
names that contain spaces-only are considered empty.
Also make sure that the same behavior is working when saved queries
are edited - but since the save query button may be disabled, make
sure that any blur event on the input gets us out of the edit mode
either after save or without saving (if the string is invalid)
Bug: T169273
Change-Id: I16da9fcde0bf6be2b854243d7facc80d2860e458
Brad Jorsch [Wed, 14 Jun 2017 14:55:03 +0000 (10:55 -0400)]
API: Split non-English description messages into summary + additional text
Per request, automatically split non-English messages to avoid a lot of
work for translatewiki.
Change-Id: Ifb9928dfbc59028d0df65ff07e067aa17bcf0c2f
jenkins-bot [Fri, 30 Jun 2017 13:43:15 +0000 (13:43 +0000)]
Merge "Add missing class propertys in QuickTemplate"
addshore [Fri, 30 Jun 2017 13:10:54 +0000 (14:10 +0100)]
TidyDriverBase::validate throws an exception
Change-Id: I05e31c757ed92323ff905d993ac4d030b8aba1da
addshore [Fri, 30 Jun 2017 12:59:56 +0000 (13:59 +0100)]
Update phan issues & estimated counts
Since the last update there is a total of 550 less issues.
744 removed and 194 added in various places.
(roughly)
Change-Id: I0431773973c146e1492de72d869f6d33de4084e8
Matthias Mullie [Thu, 29 Jun 2017 13:06:51 +0000 (15:06 +0200)]
Improve error messages for (known unknown) network errors
Bug: T132611
Change-Id: I22f26e56e089edad7c423ac8f0007b5439de3e58
Matthias Mullie [Thu, 23 Feb 2017 09:47:34 +0000 (10:47 +0100)]
Added chunked upload support to upload.js
Meanwhile also made a uploadWithFormData abortable.
Bug: T103400
Change-Id: Idb4afbbf24c84100630e12869a0a30326a30736f
jenkins-bot [Fri, 30 Jun 2017 11:25:43 +0000 (11:25 +0000)]
Merge "Make mw.widgets.SearchInputWidget extend OO.ui.SearchInputWidget"
addshore [Fri, 30 Jun 2017 09:01:19 +0000 (10:01 +0100)]
Add missing class propertys in QuickTemplate
Change-Id: I327ac1207af8fcf9db792b3835b8a35378330eb6
jenkins-bot [Fri, 30 Jun 2017 08:53:18 +0000 (08:53 +0000)]
Merge "DidYouMeanWidget: Don't use deprecated Linker::linkKnown()"
Gilles Dubuc [Thu, 29 Jun 2017 13:21:38 +0000 (15:21 +0200)]
Make file purging also purge old versions
Also fixes purging for repos with sha1 thumb URLs.
Bug: T169198
Change-Id: Ibb98ecce83d690cc46769644038b54e37aea0b0d
jenkins-bot [Fri, 30 Jun 2017 08:47:25 +0000 (08:47 +0000)]
Merge "Keep the same DBLoadBalancerFactory in tests"
jenkins-bot [Fri, 30 Jun 2017 07:49:47 +0000 (07:49 +0000)]
Merge "filecache: Use current action instead of "view" only in outage mode"
jenkins-bot [Fri, 30 Jun 2017 07:48:16 +0000 (07:48 +0000)]
Merge "SearchInputWidget: Fix documented default for 'pushPending' option"
jenkins-bot [Fri, 30 Jun 2017 07:32:32 +0000 (07:32 +0000)]
Merge "Clean up release notes"
jenkins-bot [Fri, 30 Jun 2017 02:21:17 +0000 (02:21 +0000)]
Merge "UsersMultiSelectWidget: Port from CapsuleMultiselectWidget to MenuTagMultiselectWidget"
jenkins-bot [Fri, 30 Jun 2017 02:21:13 +0000 (02:21 +0000)]
Merge "Fix \n handling for HTMLUsersMultiselectField"
Roan Kattouw [Fri, 9 Jun 2017 02:13:45 +0000 (19:13 -0700)]
UsersMultiSelectWidget: Port from CapsuleMultiselectWidget to MenuTagMultiselectWidget
Bonus:
* Remove puzzling code that claimed to fix a bug that I couldn't reproduce
but instead made single-character searches never display suggestions
* Clear the input after choosing a menu item
Change-Id: I44e72205880d152639ee823238dc5ab84d34402b
Matthew Flaschen [Sun, 21 May 2017 13:28:59 +0000 (15:28 +0200)]
Fix \n handling for HTMLUsersMultiselectField
Bug: T166836
Change-Id: I51b772946f1e50a21fb86cab969defb4647b820b
jenkins-bot [Fri, 30 Jun 2017 01:53:26 +0000 (01:53 +0000)]
Merge "resourceloader: Restrict addModuleStyles() to type=styles modules"
jenkins-bot [Fri, 30 Jun 2017 01:43:09 +0000 (01:43 +0000)]
Merge "resourceloader: Improve ResourceLoaderClientHtmlTest tests"
jenkins-bot [Fri, 30 Jun 2017 00:23:01 +0000 (00:23 +0000)]
Merge "jsminplus: Fix JSNode memory leak from 'continue' statements"
jenkins-bot [Thu, 29 Jun 2017 22:33:46 +0000 (22:33 +0000)]
Merge "SpecialPageFactory::getPage can return null"
jenkins-bot [Thu, 29 Jun 2017 22:03:39 +0000 (22:03 +0000)]
Merge "API: Don't handle non-preflight OPTIONS as CORS"
Bartosz Dziewoński [Thu, 29 Jun 2017 20:04:34 +0000 (22:04 +0200)]
Make mw.widgets.SearchInputWidget extend OO.ui.SearchInputWidget
Mixin mw.widgets.TitleWidget instead of extending mw.widgets.TitleInputWidget.
* Remove code that reimplemented pieces of OO.ui.SearchInputWidget.
* Remove code that overrode pieces of mw.widgets.TitleInputWidget.
* Copy the code from mw.widgets.TitleInputWidget that we actually want.
This should result in no functional changes, other than losing the
TitleInputWidget API (some methods and config options) that no one
relied on, as far as I can tell.
Bug: T169194
Change-Id: Ic1482b4c7cfde7d4cf0b8900654bd3a454776010
Bartosz Dziewoński [Thu, 29 Jun 2017 19:57:05 +0000 (21:57 +0200)]
SearchInputWidget: Fix documented default for 'pushPending' option
Change-Id: Iadee48af255498c6608cfd00fca29eed9b14f1be
Translation updater bot [Thu, 29 Jun 2017 20:17:37 +0000 (22:17 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I420c049cd13179f6780c6a7f85857e2bf1389f99
Moriel Schottlender [Thu, 29 Jun 2017 18:53:05 +0000 (11:53 -0700)]
RCFilters: Followup I5cede87633147: Set actual value rather than object
Bug: T169042
Change-Id: Ib99981c212dbe1522defc1c1cc34fa01fff91dba
addshore [Thu, 29 Jun 2017 15:10:32 +0000 (16:10 +0100)]
Keep the same DBLoadBalancerFactory in tests
Bug: T168242
Change-Id: I9b57b8bcfdcb823adb89213518abfdfb834ef223
TTO [Thu, 29 Jun 2017 14:50:38 +0000 (14:50 +0000)]
Clean up release notes
Change-Id: Ief5b9a69a5ace43efe8a221e3118c09059361d36
James D. Forrester [Thu, 29 Jun 2017 07:34:54 +0000 (08:34 +0100)]
Update OOjs UI to v0.22.2
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.22.2
Depends-On: If6a7aa1d924b416fc95831e1a1b26313e6482cbf
Change-Id: I36a5329fe7d6e134ec1f7b5583017ddff64ca03a
Timo Tijhof [Thu, 29 Jun 2017 02:18:06 +0000 (19:18 -0700)]
resourceloader: Restrict addModuleStyles() to type=styles modules
If a type=general module is enqueued, don't try to load it as a
stylesheet.
* Per
a464d1d41d69f12fe, state tracking is already disabled for
these loads (as otherwise we wrongly claim state=ready, when in
fact only the styles and not the scripts were loaded).
* The warning was added in
a464d1d41d69f12fe.
* Default install (tested in Vagrant), Wikimedia Beta cluster, and
Wikimedia production have seen zero violations of this warning
in the past 7 days.
Raise severity to ERROR and add the 'continue' statement so that
these are now not loaded at all.
Bug: T92459
Change-Id: I211d56ac2df479ebf5b98667c613ecf81489539b
Timo Tijhof [Thu, 29 Jun 2017 02:11:11 +0000 (19:11 -0700)]
resourceloader: Improve ResourceLoaderClientHtmlTest tests
The example for a mixed user module is outdated. Current user modules
all separate styles and scripts.
To make the effective change by the next commit easier to review,
update these tests first seperately.
Change-Id: I76a8a96eed8a8c39863c535362b1d0144ef2f866
Timo Tijhof [Thu, 29 Jun 2017 01:19:20 +0000 (18:19 -0700)]
jsminplus: Fix JSNode memory leak from 'continue' statements
During parsing of scripts containing a 'continue' statement,
the JSNode for that statements, and all containing blocks (e.g. conditional
blocks, for-loop/white-loop statements , etc.) were being held
in memory indefinitely.
Bug: T31784
Change-Id: Id7006c264a470ba665434f6f275e49a1516b73ae
jenkins-bot [Thu, 29 Jun 2017 01:11:32 +0000 (01:11 +0000)]
Merge "Remove space after cast"
jenkins-bot [Thu, 29 Jun 2017 01:11:20 +0000 (01:11 +0000)]
Merge "clone keyword must not be used as a function"
jenkins-bot [Thu, 29 Jun 2017 00:25:07 +0000 (00:25 +0000)]
Merge "RCFilters: Fix typo in removing a saved query"
jenkins-bot [Thu, 29 Jun 2017 00:14:15 +0000 (00:14 +0000)]
Merge "RCFilters: Correct display of save filter popup"
Moriel Schottlender [Thu, 29 Jun 2017 00:06:12 +0000 (17:06 -0700)]
RCFilters: Fix typo in removing a saved query
Bug: T169107
Change-Id: I7c1535f6ae75159a069ebde7db781f6a875fcb3c
Moriel Schottlender [Wed, 28 Jun 2017 17:48:25 +0000 (10:48 -0700)]
RCFilters: Fix popup head with long message and icon
If the message is long, it should remain on the same line as the
icon, and the padding should come from the 'head' element rather
than the individual icon/label elements.
Bug: T169110
Change-Id: I726649f9fbd7e095aea62693aff269108c872661
Moriel Schottlender [Wed, 28 Jun 2017 23:44:54 +0000 (16:44 -0700)]
RCFilters: Followup I200720ffde8ad: Hide extended footer if gater is disabled
Bug: T169163
Change-Id: I62f63cbf06a7e42864faca1a196903eb34ea077b
jenkins-bot [Wed, 28 Jun 2017 23:30:19 +0000 (23:30 +0000)]
Merge "resourceloader: Use "\n" instead of ";" as separator for scripts"
jenkins-bot [Wed, 28 Jun 2017 20:37:13 +0000 (20:37 +0000)]
Merge "Add SearchIndexField::getEngineHints()"
Translation updater bot [Wed, 28 Jun 2017 20:01:23 +0000 (22:01 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I889cf1f5e93554486b452922edd474ef865bec7f
Aaron Schulz [Thu, 22 Jun 2017 21:08:05 +0000 (14:08 -0700)]
Paramaterize TransactionProfiler log entries
Change-Id: I4e468d818af48dba21cd2c567f4e6a58beb0924b
Umherirrender [Wed, 28 Jun 2017 18:22:20 +0000 (20:22 +0200)]
SpecialPageFactory::getPage can return null
Change-Id: I12b4969ec0c6b8d5a1d8feeda27152ba6075c4fd
Aaron Schulz [Thu, 22 Jun 2017 20:58:54 +0000 (13:58 -0700)]
Record PostSend master queries via TransactionProfiler
Bug: T166199
Change-Id: Ib2f858f09aae65af6aa8324edb72d8a16094f2b3
Moriel Schottlender [Wed, 28 Jun 2017 17:35:53 +0000 (10:35 -0700)]
RCFilters: Correct display of save filter popup
- Correct language in the 'apply' button
- Add a placeholder to the input
- Make the 'apply' button disabled if the input is empty
- Remove the use of the OOUI-built-in validation, since all
we do is "validate" that the input isn't empty, and there's
no need to show error mode (red border) for that, especially
since the 'apply' button is disabled in that case.
Bug: T169042
Change-Id: I5e3600b1ac8e63d8a25c0540468fe42febfc3a70
Umherirrender [Tue, 27 Jun 2017 19:44:12 +0000 (21:44 +0200)]
clone keyword must not be used as a function
Also changed a require_once
Change-Id: Ib8030ea5320a62ee4f114d8d506382c5665e3e02
jenkins-bot [Wed, 28 Jun 2017 14:06:37 +0000 (14:06 +0000)]
Merge "Use Devanagari digits for list items on mai.wikipedia"