Chad Horohoe [Sun, 5 Dec 2010 19:35:46 +0000 (19:35 +0000)]
This can be private too
Chad Horohoe [Sun, 5 Dec 2010 19:34:40 +0000 (19:34 +0000)]
Fix copy+paste error from r77778
Sam Reed [Sun, 5 Dec 2010 18:27:14 +0000 (18:27 +0000)]
-rakkaus/#mediawiki-i18n- [05-Dec-2010 18:22:39] PHP Fatal error: Call to private method CategoryViewer::getHTML() from context 'CategoryPage' in /www/w/includes/CategoryPage.php on line 74
Partial revert of r77809, remove making of methods private, but don't reinstate the comments. They're seemingly wrong, and useless.
Sam Reed [Sun, 5 Dec 2010 16:15:28 +0000 (16:15 +0000)]
Swap @private for setting function definition to private
Sam Reed [Sun, 5 Dec 2010 16:08:12 +0000 (16:08 +0000)]
Change some member calls to static, from r75709
Platonides [Sun, 5 Dec 2010 15:35:57 +0000 (15:35 +0000)]
Follow up r75705 typo.
Alexandre Emsenhuber [Sun, 5 Dec 2010 14:22:49 +0000 (14:22 +0000)]
Converted ImportStreamSource functions to return a Status object rather than ImportStreamSource-or-WikiError
This is a breaking change since the ImportStreamSource object is in the value member of the Status object; I will fix the extensions in my next commit
Alexandre Emsenhuber [Sun, 5 Dec 2010 13:57:07 +0000 (13:57 +0000)]
Converted WikiError to MWException so at least users can see the problem (nothing was checking the return value of WikiExporter::dumpFrom() and realted methods)
Roan Kattouw [Sun, 5 Dec 2010 13:38:25 +0000 (13:38 +0000)]
(bug 26228) On certain PHP 5.2 installs, finfo functions can be available while FILEINFO_MIME_TYPE is not. Check for the latter explicitly
Roan Kattouw [Sun, 5 Dec 2010 12:58:23 +0000 (12:58 +0000)]
Fix typo in r77714
Daniel Friesen [Sun, 5 Dec 2010 11:16:47 +0000 (11:16 +0000)]
Followup r77793, documentation for icon as a string was missing.
Daniel Friesen [Sun, 5 Dec 2010 11:01:34 +0000 (11:01 +0000)]
Make footerLink a public method, this method is useful for hooks now that r77732 allows a hook to add new footer links in this style.
Daniel Friesen [Sun, 5 Dec 2010 10:58:13 +0000 (10:58 +0000)]
Folowup r77763, add documentation for $wgFooterIcons.
Niklas Laxström [Sun, 5 Dec 2010 10:41:58 +0000 (10:41 +0000)]
Follow-up r77763, get rid of boolean param and whitespace fixes
Roan Kattouw [Sun, 5 Dec 2010 10:30:04 +0000 (10:30 +0000)]
Revert r77760, broken, and do what it intended correctly with strtok().
Daniel Friesen [Sun, 5 Dec 2010 06:59:39 +0000 (06:59 +0000)]
Follow up for r77732 and r77741, add the missing RELEASE-NOTES which I forgot.
Daniel Friesen [Sun, 5 Dec 2010 06:46:45 +0000 (06:46 +0000)]
Followup r77779, release note was put in the wrong section.
Daniel Friesen [Sun, 5 Dec 2010 06:43:15 +0000 (06:43 +0000)]
Add MW_CONFIG_FILE support to load a separate config file instead of LocalSettings.php, similar functionality to MW_CONFIG_CALLBACK but works in some cases that it doesn't.
Chad Horohoe [Sun, 5 Dec 2010 05:59:02 +0000 (05:59 +0000)]
One less $wgTitle, and use dbw->update() instead of raw sql
Chad Horohoe [Sun, 5 Dec 2010 05:19:31 +0000 (05:19 +0000)]
No need for globals, works fine without. Also add missing (and required) title arg
Chad Horohoe [Sun, 5 Dec 2010 05:14:41 +0000 (05:14 +0000)]
More useful debug output
Daniel Friesen [Sun, 5 Dec 2010 04:44:28 +0000 (04:44 +0000)]
Take the footer icon html building common to all 3 skins using r77741 $wgFooterIcons and turn it into a common makeFooterIcon method they can share.
Also fix the location of the noprint class meant to be on footer-icons in vector.
Daniel Friesen [Sun, 5 Dec 2010 04:22:29 +0000 (04:22 +0000)]
Add method documentation for getCommonStylePath and getSkinStylePath.
Chad Horohoe [Sun, 5 Dec 2010 04:14:39 +0000 (04:14 +0000)]
php4 access declarations are silly
Chad Horohoe [Sun, 5 Dec 2010 04:13:54 +0000 (04:13 +0000)]
Style cleanup to r64922
Sam Reed [Sun, 5 Dec 2010 00:37:44 +0000 (00:37 +0000)]
Followup r77748, throw NEW MWException
Sam Reed [Sat, 4 Dec 2010 23:42:25 +0000 (23:42 +0000)]
Explicitally do function documentation, rather than "see somewhere else"
Platonides [Sat, 4 Dec 2010 23:36:54 +0000 (23:36 +0000)]
Revert r70202. Replace with an exception.
Platonides [Sat, 4 Dec 2010 22:28:41 +0000 (22:28 +0000)]
Followup r77654, remove trailing ?> at end of file.
Daniel Friesen [Sat, 4 Dec 2010 20:55:23 +0000 (20:55 +0000)]
Implement $wgFooterIcons to replace copyrightico and poweredbyico with a flexible list of icons that can be customized by extensions, hosting, farms, wikimedia, etc...
Implementations for MonoBook, Vector, and Modern. Modern implementation uses text instead of icons as desired.
Alexandre Emsenhuber [Sat, 4 Dec 2010 19:30:26 +0000 (19:30 +0000)]
Follow-up r67324: removed check for empty text since the length is checked explicitly
Daniel Friesen [Sat, 4 Dec 2010 18:37:05 +0000 (18:37 +0000)]
Take the footerlinks from vector and monobook and make them skin generic.
Daniel Friesen [Sat, 4 Dec 2010 17:10:48 +0000 (17:10 +0000)]
Fixme fixme... typo typo... fix r77726's broken fix.
Daniel Friesen [Sat, 4 Dec 2010 17:00:34 +0000 (17:00 +0000)]
Follow up r77718, fix broken inconsistent use of $fname/$name in getCommonStylePath and getSkinStylePath.
Ilmari Karonen [Sat, 4 Dec 2010 16:10:51 +0000 (16:10 +0000)]
Partial workaround for bug 6220: at least make files on shared repositories show up as (struck-out) bluelinks instead of redlinks on Special:WantedFiles. Also change the query slightly to join on the image table instead of page, since that would seem to make more sense.
Daniel Friesen [Sat, 4 Dec 2010 15:35:36 +0000 (15:35 +0000)]
MySQL is the only database which quotes identifiers primarily using backticks. Move the backtick based addIdentifierQuotes implementation from the generic into DatabaseMysql and take the duplicated implementation used by oracle, sqlite, ibm_db2, postgresql, and mssql and remove it from all of them migrating it to the generic Database class as the default.
Daniel Friesen [Sat, 4 Dec 2010 15:14:08 +0000 (15:14 +0000)]
Followup to r77713, rename quote_ident to addIdentifierQuotes to follow naming conventions better. While I'm at it adding a missing addIdentifierQuotes implementation for Ibm_db2.
Daniel Friesen [Sat, 4 Dec 2010 14:45:14 +0000 (14:45 +0000)]
Implement getSkinStylePath and getCommonStylePath for image paths used directly in a skin, use it for vector's search icon.
Alexandre Emsenhuber [Sat, 4 Dec 2010 14:23:00 +0000 (14:23 +0000)]
XMLReader extension is distributed with PHP and enabled by default since PHP 5.1
Alexandre Emsenhuber [Sat, 4 Dec 2010 13:39:18 +0000 (13:39 +0000)]
Stylise UserMailer.php ; added some "public" to public functions
Alexandre Emsenhuber [Sat, 4 Dec 2010 13:27:05 +0000 (13:27 +0000)]
* Converted UserMailer stuff to return a Status object instead of true-or-WikiError
* Made WikiError::isError() compatible with Status objects
* Added Status::getMessage() for backward compatibility
Extensions using WikiError::isError() to detect a failure of UserMailer::send() and realted methods should still work like before
Daniel Friesen [Sat, 4 Dec 2010 09:27:02 +0000 (09:27 +0000)]
Fix a bug in the installer caused by r77487 creating installer sql statements like "GRANT ALL PRIVILEGES ON `'dbname'`.* TO ''tablename''@'%" while improving the database independence of replaceVars.
* Drop unused and likely broken /*$var*/` -> `$var syntax
* Replace {$var} with '{$var}' and `{$var}` handling that uses relevant database independent quoting ({$var} without surrouding quotes are never used)
* Give the generic/mysql class a proper quote_ident implementation
* Fix the unused Oracle and Sqlite quote_ident implementations which are potential sql injections if used
* Split common variable replacemnt code off to a replaceGlobalVars and make the generic and oracle code use it instead of duplicating the same code as each other
Antoine Musso [Sat, 4 Dec 2010 08:58:32 +0000 (08:58 +0000)]
Max command length using one line of code
Follow-up r76621 code review
Mark A. Hershberger [Sat, 4 Dec 2010 03:20:14 +0000 (03:20 +0000)]
Whitespace fixup under tha maint directory.
Trevor Parscal [Sat, 4 Dec 2010 02:16:37 +0000 (02:16 +0000)]
Added new localize plugin which allows simple placeholder based localization of a dom selection with special <msg /> elements or elements with title-msg or alt-msg attributes.
Trevor Parscal [Sat, 4 Dec 2010 00:48:37 +0000 (00:48 +0000)]
Fixes r77696 where a few mistakes were made. Also improves on r77693 by using actual group names rather than trying to divine the group from the module name...
Sam Reed [Sat, 4 Dec 2010 00:36:33 +0000 (00:36 +0000)]
Followup r77666, bug 26219
Only add the message about multi value, if the type is not an array, or if it is an array, if it has over 50 (LIMIT_SML1) items
Trevor Parscal [Sat, 4 Dec 2010 00:35:10 +0000 (00:35 +0000)]
Made use of Xml::encodeJsCall - improves on r77693.
Sam Reed [Sat, 4 Dec 2010 00:13:56 +0000 (00:13 +0000)]
Followup r77679, 1 more for bug 23332
Trevor Parscal [Fri, 3 Dec 2010 23:59:50 +0000 (23:59 +0000)]
Resolves bug #26131 by always placing user scripts and styles at the very end of the page
Sam Reed [Fri, 3 Dec 2010 23:50:00 +0000 (23:50 +0000)]
Followup r77666, remove changed in database comment (no idea where that came from)
Roan Kattouw [Fri, 3 Dec 2010 23:34:12 +0000 (23:34 +0000)]
Fix typo in comment
Roan Kattouw [Fri, 3 Dec 2010 23:29:09 +0000 (23:29 +0000)]
Fix grammar in r77563
Raimond Spekking [Fri, 3 Dec 2010 23:09:07 +0000 (23:09 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-12-03 23:39:00 UTC)
Raimond Spekking [Fri, 3 Dec 2010 22:34:58 +0000 (22:34 +0000)]
Follow-up r77670: Add new special page (alias) to messages/MessagesEn.php
Rotem Liss [Fri, 3 Dec 2010 22:13:35 +0000 (22:13 +0000)]
Localization update for he.
Sam Reed [Fri, 3 Dec 2010 20:30:21 +0000 (20:30 +0000)]
Fixup 1 more autoloader from r77677
Add Abstract classes explicitally to the autoloader
Move abstract classes from RevisionDelete.php to RevisionDeleteAbstracts.php (svn copy and remove of redundant classes)
Sam Reed [Fri, 3 Dec 2010 20:25:19 +0000 (20:25 +0000)]
Followup r77677, fix rest of autoloader entries
Sam Reed [Fri, 3 Dec 2010 19:56:59 +0000 (19:56 +0000)]
Move includes/RevisionDelete.php to includes/revisiondelete/RevisionDelete.php
Antoine Musso [Fri, 3 Dec 2010 19:56:08 +0000 (19:56 +0000)]
typo (fu r77320)
Roan Kattouw [Fri, 3 Dec 2010 19:47:22 +0000 (19:47 +0000)]
Fix indentation of => added in r77366 to be in step with the rest
Roan Kattouw [Fri, 3 Dec 2010 19:32:25 +0000 (19:32 +0000)]
and -> && in r77366
Bryan Tong Minh [Fri, 3 Dec 2010 19:23:12 +0000 (19:23 +0000)]
white space fix v2 (follow-up r77671)
Bryan Tong Minh [Fri, 3 Dec 2010 19:21:15 +0000 (19:21 +0000)]
White space fix
Bryan Tong Minh [Fri, 3 Dec 2010 19:18:39 +0000 (19:18 +0000)]
Added Special:Myuploads special page that redirects to Special:Listfiles
Bryan Tong Minh [Fri, 3 Dec 2010 18:48:11 +0000 (18:48 +0000)]
Added uploads link to page subtitle in Special:Contributions
Changed query parameter for the username in Special:Listfiles from username to user, which seems to be more consistent with the rest of MediaWiki. Searching by username was introduced in 1.17, so there should be no existing links that can be broken.
Sam Reed [Fri, 3 Dec 2010 16:24:05 +0000 (16:24 +0000)]
* (bug 26219) Show API limits for multi values in description
Also move bug 9675/r77612 RELEASE-NOTES to the correct section
Alexandre Emsenhuber [Fri, 3 Dec 2010 15:20:07 +0000 (15:20 +0000)]
Revert part of r77644: unwanted changes (oops!)
Roan Kattouw [Fri, 3 Dec 2010 14:44:07 +0000 (14:44 +0000)]
Followup r77072: declare llurl as a boolean parameter.
Roan Kattouw [Fri, 3 Dec 2010 14:38:16 +0000 (14:38 +0000)]
Fix license/licence inconsistencies in r77069
nadeesha [Fri, 3 Dec 2010 14:27:50 +0000 (14:27 +0000)]
delete dependency on MediaWikiCommonFunc.php
Sam Reed [Fri, 3 Dec 2010 14:16:57 +0000 (14:16 +0000)]
Followup r77654, SVN PROPS!!!
nadeesha [Fri, 3 Dec 2010 14:12:52 +0000 (14:12 +0000)]
Add following common functions for selenium scripts. getExistingPage(), getNewPage($pageName), loadWikiEditor(), clearWikiEditor(), clickShowPreviewBtn(), clickSavePageBtn(), clickEditLink(), deletePage($pageName)
nadeesha [Fri, 3 Dec 2010 14:11:00 +0000 (14:11 +0000)]
Add getUser() and getPass() functions.
nadeesha [Fri, 3 Dec 2010 14:10:09 +0000 (14:10 +0000)]
Added test scripts for wiki editor additional features and updated scripts on wiki basic editor. MediaWikiCommonFunction.php is deleted, since it is no longer used by the scripts.
Chad Horohoe [Fri, 3 Dec 2010 13:46:21 +0000 (13:46 +0000)]
Fix for r76480: !$css was never true, since it always contained \n. This way also lets us at least show one file if the other is inaccessible for less breakage.
Roan Kattouw [Fri, 3 Dec 2010 13:04:01 +0000 (13:04 +0000)]
Spaces to tabs in r77011
Alexandre Emsenhuber [Fri, 3 Dec 2010 12:47:04 +0000 (12:47 +0000)]
Follow-up r77618 and r77635: also remove the message from messageTypes.inc
Roan Kattouw [Fri, 3 Dec 2010 12:46:29 +0000 (12:46 +0000)]
Followup r76973: keep $target variable local
Alexandre Emsenhuber [Fri, 3 Dec 2010 11:29:55 +0000 (11:29 +0000)]
Allow the submit callback function to return a Status object (will use this later for other forms)
Alexandre Emsenhuber [Fri, 3 Dec 2010 10:08:47 +0000 (10:08 +0000)]
Use __METHOD__ instead of incorrect 'BackupDumper::dump'
Alexandre Emsenhuber [Fri, 3 Dec 2010 10:05:01 +0000 (10:05 +0000)]
Modifier dumpTextPass.php to use XMLReader and XMLWriter rather than xml_* functions
Sam Reed [Fri, 3 Dec 2010 09:57:53 +0000 (09:57 +0000)]
Documentation improvement to r77597
Sam Reed [Fri, 3 Dec 2010 09:40:11 +0000 (09:40 +0000)]
Per MaxSem CR on r77597, make $alias paramater optional, as per the documentation
Sam Reed [Fri, 3 Dec 2010 09:36:02 +0000 (09:36 +0000)]
Followup r77618 per Nikerabbit, remove now unused message 'cantcreateaccount-nonblock-text'
Sam Reed [Fri, 3 Dec 2010 01:43:23 +0000 (01:43 +0000)]
Return type documentation
Trevor Parscal [Fri, 3 Dec 2010 01:12:11 +0000 (01:12 +0000)]
Specified max width in em instead of px to support font scaling
Trevor Parscal [Fri, 3 Dec 2010 01:10:10 +0000 (01:10 +0000)]
Using 100ms fade by deafult
Trevor Parscal [Fri, 3 Dec 2010 01:06:35 +0000 (01:06 +0000)]
Using 100% opacity as default
Platonides [Fri, 3 Dec 2010 00:21:50 +0000 (00:21 +0000)]
Make $wgForceUIMsgAsContentMsg work a bit different for the messages we place in the upload form.
This is specially intended for commons, such that it no longer needs a bot changing the headers after each upload.
See http://commons.wikimedia.org/w/index.php?title=Commons%3AVillage_pump&action=historysubmit&diff=
46619490&oldid=
46619456#Uploading_a_new_file.2C_and_proceeding_updates
Sam Reed [Fri, 3 Dec 2010 00:06:05 +0000 (00:06 +0000)]
Kill off userNotPrivilegedMessage, not used after r77617
Andrew Garrett [Thu, 2 Dec 2010 23:59:12 +0000 (23:59 +0000)]
Fix r75759: replace call to userNotPrivilegedMessage() with a call to OutputPage::permissionRequired().
Ilmari Karonen [Thu, 2 Dec 2010 22:40:54 +0000 (22:40 +0000)]
followup to r77176: code style, release notes
Raimond Spekking [Thu, 2 Dec 2010 21:36:31 +0000 (21:36 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-12-02 21:19:00 UTC)
Aaron Schulz [Thu, 2 Dec 2010 19:49:54 +0000 (19:49 +0000)]
Broke and split up many long lines
Antoine Musso [Thu, 2 Dec 2010 19:44:30 +0000 (19:44 +0000)]
doxygen now ignore .git subdirectories
Antoine Musso [Thu, 2 Dec 2010 19:43:57 +0000 (19:43 +0000)]
make now honor the FLAG env variable to pass additional parameters.
Sam Reed [Thu, 2 Dec 2010 19:39:32 +0000 (19:39 +0000)]
Per Roans request, Merge in r65475 (Database.php only) from querypage-work2 branch
Antoine Musso [Thu, 2 Dec 2010 19:33:15 +0000 (19:33 +0000)]
pipe does not look nice in doxygen. fu r77499
Roan Kattouw [Thu, 2 Dec 2010 18:45:21 +0000 (18:45 +0000)]
Fix r75994 per CR: don't pass an array as a JS string if MessageBlobStore::get() doesn't return a blob for a module