Mark A. Hershberger [Thu, 3 Feb 2011 04:06:11 +0000 (04:06 +0000)]
Results of my work on new-installer and Pg.
* NOTE: this commit removes any semblence of tsearch compatibility with pre-8.3 PostgreSQL
* Make new-installer work against PostgreSQL
* Remove SearchPostgres.php's call to pg_fetch_result. I think this is the only one outside of the vestigtial old installer code.
Andrew Garrett [Thu, 3 Feb 2011 01:25:09 +0000 (01:25 +0000)]
Kill the XMLReader2 class in response to Tim's code review comments on r68587
Daniel Friesen [Thu, 3 Feb 2011 00:00:58 +0000 (00:00 +0000)]
Commit some fixes for comments on r77741
Trevor Parscal [Wed, 2 Feb 2011 22:59:06 +0000 (22:59 +0000)]
Fixed bug #26829 by increasing the specificity of the CSS hack used to get IE6 working so that it doesn't also affect IE7.
Sam Reed [Wed, 2 Feb 2011 22:43:07 +0000 (22:43 +0000)]
Followup r81427, actually use the $msg variable
Sam Reed [Wed, 2 Feb 2011 22:31:48 +0000 (22:31 +0000)]
Followup r67094, factor out code duplication in HistoryPage::getStartBody()
Sam Reed [Wed, 2 Feb 2011 22:23:11 +0000 (22:23 +0000)]
Followup r67094
Wrap some long lines
Tidy up SQL "IN()" wheel re-invention and such
Remove passing of $dbw around
Remove passing of by reference
Ilmari Karonen [Wed, 2 Feb 2011 21:30:02 +0000 (21:30 +0000)]
followup r81408: fix option desc and year in copyright statement
Antoine Musso [Wed, 2 Feb 2011 21:04:21 +0000 (21:04 +0000)]
Test suite for revisions and date related magic variables.
Tests should be carefully reviewed, please note there is are exceptions
for 'revisionday' and 'revisionmonth1' magics which are hardcoded in
the parser to return an integer.
Follow up r66200
TESTS:
$ php phpunit.php -c suite.xml --filter MagicVariable --testdox
PHPUnit 3.5.10 by Sebastian Bergmann.
MagicVariable
[x] Currentday is un padded
[x] Currentdaytwo is zero padded
[x] Localday is un padded
[x] Localdaytwo is zero padded
[x] Currentmonth is zero padded
[x] Currentmonthone is un padded
[x] Localmonth is zero padded
[x] Localmonthone is un padded
[x] Revisionday is un padded
[x] Revisiondaytwo is zero padded
[x] Revisionmonth is zero padded
[x] Revisionmonthone is un padded
$
Roan Kattouw [Wed, 2 Feb 2011 20:25:47 +0000 (20:25 +0000)]
Merge r80947 from 1.16wmf4 to trunk: throw exception when text couldn't be loaded from archive table
Ilmari Karonen [Wed, 2 Feb 2011 19:33:32 +0000 (19:33 +0000)]
followup r81408: fix class name in comment
Ilmari Karonen [Wed, 2 Feb 2011 19:25:53 +0000 (19:25 +0000)]
Add a maintenance script to fix double redirects (and corresponding edit summary messages). Still lacks some features like batch querying, but basically it works.
Roan Kattouw [Wed, 2 Feb 2011 19:16:05 +0000 (19:16 +0000)]
Fix regression in r81124, causing &pst to be ignored for the purposees of actually parsing wikitext
Bryan Tong Minh [Wed, 2 Feb 2011 16:07:28 +0000 (16:07 +0000)]
Cleanup SpecialUploadStash
Follow-up r78426:
* Fix clearing the stash; The data array passed has as keys the keys passed used in the descriptor, not the HTML input name
* Transform array( __CLASS__, $fname ) to __CLASS__ . "::$fname", because not all PHP version support the first
* Remove addHiddenField; not needed
* Fix indentation
* Kill loadRequest all together; all this stuff is handled by HTMLForm
Follow-up r80993: Use LocalRepo to create the UploadStash
Sam Reed [Wed, 2 Feb 2011 15:48:43 +0000 (15:48 +0000)]
Followup r81313, fix 210 typo
Bryan Tong Minh [Wed, 2 Feb 2011 15:44:42 +0000 (15:44 +0000)]
Follow-up r77640: Check whether there are errors before asking Status to transform them into wikitext.
Mark A. Hershberger [Wed, 2 Feb 2011 15:44:37 +0000 (15:44 +0000)]
* recover dropped check of $wgUsePathInfo from r81363
* document getPathInfo
Bryan Tong Minh [Wed, 2 Feb 2011 15:30:20 +0000 (15:30 +0000)]
Remove the $request parameter fro SpecialUploadStash::__construct(). This parameter was in SpecialUpload::__construct because it used to be the only way to talk to the upload backend in the pre-1.16 era. Not needed for SpecialUploadStash.
Alexandre Emsenhuber [Wed, 2 Feb 2011 14:48:26 +0000 (14:48 +0000)]
Force isCached() to false; otherwise the result is "This page is disabled for performance reason" when both $wgMiserMode and $wgDisableQueryPages are true
Sam Reed [Wed, 2 Feb 2011 14:26:12 +0000 (14:26 +0000)]
Fixup fixme on r81198, explicitally ORDER BY qc_value ASC if not doing DESC
Bryan Tong Minh [Wed, 2 Feb 2011 14:07:08 +0000 (14:07 +0000)]
Follow-up r79964: Fix double parsing of file info
Sam Reed [Wed, 2 Feb 2011 13:02:45 +0000 (13:02 +0000)]
Followup r81373, r81363
PHP Notice: Undefined variable: matches in /home/ci/cruisecontrol-bin-2.8.3/projects/mw/source/includes/WebRequest.php on line 109
Explicitally define $matches at top of function, allowing it to always be defined for all paths
Sam Reed [Wed, 2 Feb 2011 11:38:50 +0000 (11:38 +0000)]
Couple more return hints
Swap and for &&
Sam Reed [Wed, 2 Feb 2011 11:38:25 +0000 (11:38 +0000)]
Remove false related to failfunction...
Happy-melon [Wed, 2 Feb 2011 11:00:09 +0000 (11:00 +0000)]
Follow-up r79682: more documentation tidying
Sam Reed [Wed, 2 Feb 2011 10:42:17 +0000 (10:42 +0000)]
Fixup some trailing newlines
Fixup indentation of a few methods
Add a couple of return type hints
Tim Starling [Wed, 2 Feb 2011 05:35:57 +0000 (05:35 +0000)]
Blacklist ZIP subtypes added in r68873, to avoid GIFAR.
Mark A. Hershberger [Wed, 2 Feb 2011 03:14:37 +0000 (03:14 +0000)]
follow up r81363 and fix Bug#27099
Mark A. Hershberger [Wed, 2 Feb 2011 01:08:15 +0000 (01:08 +0000)]
* Remove last bit of code that uses PATH_INFO from img_auth.php so that people who want to use protected images on hosts with sadly mis-shapen PHPs (e.g. GoDaddy) can.
* Mangle PATH_INFO handler in WebRequest so that all the relevant bits are in a (couple of) static functions.
Mark A. Hershberger [Tue, 1 Feb 2011 23:08:10 +0000 (23:08 +0000)]
Whitespace cleanup
Tim Starling [Tue, 1 Feb 2011 22:54:50 +0000 (22:54 +0000)]
Relax Language::isValidCode() to avoid breaking uselang hacks
Tim Starling [Tue, 1 Feb 2011 22:43:58 +0000 (22:43 +0000)]
(bug 27094) fix path traversal vulnerability
Tim Starling [Tue, 1 Feb 2011 22:36:43 +0000 (22:36 +0000)]
(bug 27093, CVE-2011-0047): Fixed CSS injection vulnerability. The StringUtils.php patch is by Roan, the Sanitizer.php patch is by me.
Raimond Spekking [Tue, 1 Feb 2011 20:52:54 +0000 (20:52 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-02-01 20:37:00 UTC)
Sam Reed [Tue, 1 Feb 2011 18:58:32 +0000 (18:58 +0000)]
Followup r81311, add MysqlUpdater function to update ll_lang length if it's still 10
Sam Reed [Tue, 1 Feb 2011 18:35:38 +0000 (18:35 +0000)]
For bug 24129 and a followup to r23239, there was never a patch to transfer from VARCHAR/VARBINARY(10) to VARBINARY(20)
Need to work out how to fit it into the updaters...
Alexandre Emsenhuber [Tue, 1 Feb 2011 15:17:25 +0000 (15:17 +0000)]
* (bug 26851) Special:UserRights now allows to prefill the reason field
The parameter is named "user-reason" as for the form submission
Krinkle [Tue, 1 Feb 2011 02:28:10 +0000 (02:28 +0000)]
Applying conventions and some JSLint good practices in core modules.
Sam Reed [Mon, 31 Jan 2011 23:41:38 +0000 (23:41 +0000)]
Function out query building, to allow easier overriding
Sam Reed [Mon, 31 Jan 2011 23:13:22 +0000 (23:13 +0000)]
Followup r81279, forgot to press save!
Sam Reed [Mon, 31 Jan 2011 23:06:36 +0000 (23:06 +0000)]
Re-write raw SQL
Wrap lines, add missing braces
Krinkle [Mon, 31 Jan 2011 22:02:58 +0000 (22:02 +0000)]
Applying conventions and some JSLint good practices in core modules.
Mark A. Hershberger [Mon, 31 Jan 2011 21:04:40 +0000 (21:04 +0000)]
fix Bug#26274: Database layer should allow arrays for ORDER BY, GROUP BY
Mark A. Hershberger [Mon, 31 Jan 2011 20:58:06 +0000 (20:58 +0000)]
making my whitespace OCD happier.
Sam Reed [Mon, 31 Jan 2011 20:30:31 +0000 (20:30 +0000)]
More missing semi colons
Raimond Spekking [Mon, 31 Jan 2011 20:16:49 +0000 (20:16 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-01-31 20:09:00 UTC)
Chad Horohoe [Mon, 31 Jan 2011 20:09:29 +0000 (20:09 +0000)]
Fixups to r81266
Chad Horohoe [Mon, 31 Jan 2011 20:00:59 +0000 (20:00 +0000)]
(bug 26857) Fatal error during installation enabling 'Vector' extension (or any extension, really). The reason we're including extensions during setup is so they have a chance to register with LoadExtensionSchemaUpdates. Before including extensions, we now include DefaultSettings.php, so any operations on those variables won't result in the fatals described in the bug.
More importantly, this adds support for installing extension tables *at* install time. Previously, the best we could do was to add the require()s to LocalSettings. However, without a subsequent update, wikis will probably start having errors immediately after install (this is really bad!). So I've added an interface to the DatabaseUpdater passed to LoadExtensionSchemaUpdates. An extension can now call addNewExtension() which will allow the extension to be enabled on install and not just update. Example committed in CodeReview
Krinkle [Mon, 31 Jan 2011 19:33:16 +0000 (19:33 +0000)]
Wrapping core modules (FIXME from r79929)
(Touch: r74088, r73046)
Bryan Tong Minh [Mon, 31 Jan 2011 18:07:44 +0000 (18:07 +0000)]
Follow-up r81209: Use the same param detection method as WebStore, so that thumbnails with different mimetypes than the original file are thumbnailed as well.
Sam Reed [Mon, 31 Jan 2011 17:33:30 +0000 (17:33 +0000)]
Add a fairly pants TRUNCATE vs DELETE benchmark...
Sam Reed [Mon, 31 Jan 2011 16:41:19 +0000 (16:41 +0000)]
Swap "or" to ||
Chad Horohoe [Mon, 31 Jan 2011 16:23:38 +0000 (16:23 +0000)]
Stupid references, stupid PHP. I blame Nikerabbit (fixing r81254)
Chad Horohoe [Mon, 31 Jan 2011 15:47:47 +0000 (15:47 +0000)]
Remove a bunch of useless $wgOuts. Just pass them like we should. Also make them protected so people don't call them
Roan Kattouw [Mon, 31 Jan 2011 12:48:08 +0000 (12:48 +0000)]
(bug 27046) Do not strip newlines following C++-style // comments. Prior to this commit, such newlines were always stripped, causing invalid JS output in certain cases. They are now always preserved, even if they would normally qualifiy for vertical whitespace stripping/collapsing when wgResourceLoaderMinifyJSVerticalSpace is enabled.
Tim Starling [Mon, 31 Jan 2011 07:07:43 +0000 (07:07 +0000)]
Cleanup for r66268, r66267: merge WikiImporter back into Import.php, where it started. It doesn't really make sense to have a class called WikiImporter in a file called ImportXMLReader.php, and a few little helper classes for it in a file called Import.php.
Raimond Spekking [Sun, 30 Jan 2011 22:35:06 +0000 (22:35 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-01-30 22:23:00 UTC)
Sam Reed [Sun, 30 Jan 2011 22:12:13 +0000 (22:12 +0000)]
Remove usage of $dbw->escapeLike in RenameDbPrefix (per bug 270042)
Chad Horohoe [Sun, 30 Jan 2011 18:21:37 +0000 (18:21 +0000)]
Tweak install steps to be on the POST rather than GET. It makes more sense architecturally. It also gives us one last chance for them to say no (in case they clicked "I'm bored already" but changed their minds). Check final step of installer for fatals, and if everything's good, suppress the back button. It's just going to confuse people. And the opposite, suppress continue on fatals...no need pretending things went dandy if they didn't. It's basically now impossible to re-run 'page=Install' after it completes. This is probably a good thing as it throws errors. Coincidentally this also fixes bug 26947.
Brian Wolff [Sun, 30 Jan 2011 18:17:57 +0000 (18:17 +0000)]
(Bug 26961) hide anons from watchlist preference was broken due to typo in
r39314.
Fix by duplicatebug.
Given that this preference has been broken since it was introduced,
and the only person to notice in 3 years has been the testers, that may be
a good argument to remove the preference altogether.
Bryan Tong Minh [Sun, 30 Jan 2011 16:57:19 +0000 (16:57 +0000)]
As per my comments on bug 27038 and my comments on r75906, use a /thumb and /file prefix for files fetched via Special:UploadStash. Make filenames more consistent with regular thumbs by using the /thumb/$fileName/$thumbName scheme. Now uses MediaHandler::parseParamString so that params like page are properly handled.
Bryan Tong Minh [Sun, 30 Jan 2011 14:26:38 +0000 (14:26 +0000)]
Follow-up r80775: Check for meta.tiff as well.
Bump wgStyleVersion
Platonides [Sun, 30 Jan 2011 14:19:55 +0000 (14:19 +0000)]
ParseMaster is designed to use big regexes, with many starting characters.
It makes sense to pcre_study() them.
Sam Reed [Sun, 30 Jan 2011 08:16:13 +0000 (08:16 +0000)]
A few return type hints
Sam Reed [Sat, 29 Jan 2011 22:07:22 +0000 (22:07 +0000)]
Per fixme on r78786, obey sortDescending in Cached mode (ie if sortDescending, force order by qc_value DESC)
Bryan Tong Minh [Sat, 29 Jan 2011 21:42:03 +0000 (21:42 +0000)]
(bug 27021) Session key was changed somewhere from an int to a string, which broke stashed uploads totally. Changed $wgRequest->getInt to $wgRequest->getText. The API never explicitly defined it as int, so should not be affected.
Note that this also may break API clients in certain cases for strongly, statically typed languages (e.g. int sessionKey = request->sessionKey;). I see no way around this, so I will announce a breaking change on the API mailing list shortly.
Raimond Spekking [Sat, 29 Jan 2011 20:23:00 +0000 (20:23 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-01-29 19:51:00 UTC)
Alexandre Emsenhuber [Sat, 29 Jan 2011 09:32:02 +0000 (09:32 +0000)]
* (bug 22606) Follow-up r63059: don't send the "someone registred an account" message when setting email address (i.e. old one empty) in user preferences
Alexandre Emsenhuber [Sat, 29 Jan 2011 09:00:38 +0000 (09:00 +0000)]
* (bug 27016) Fix for r77638: dumpTextPass.php now consider the "output" parameter
Also added "output" parameter to the doc since nothing was mentioning it
Krinkle [Fri, 28 Jan 2011 23:31:01 +0000 (23:31 +0000)]
fixing php Parse error: syntax error from r81169
Krinkle [Fri, 28 Jan 2011 23:30:04 +0000 (23:30 +0000)]
Removing more, no longer needed, overrides for the white table background (which is no longer the case since bug 26449 was solved in r79087 and r79091)
* table#mw-search-top-table (r52669 / 55748)
* table.allpageslist, table.mw-allpages-table-form, table.mw-allpages-table-chunk (r49500)
* (r32269, r55393, r78865)
Thanks to Fomafix!
See also r80495 CR
Platonides [Fri, 28 Jan 2011 22:27:52 +0000 (22:27 +0000)]
Update comments to take into account r80443 and r80614 changes, per CR.
Platonides [Fri, 28 Jan 2011 22:17:01 +0000 (22:17 +0000)]
Follow up r81100. Don't hardcode hiddencat quotes, per r80936 CR.
Chad Horohoe [Fri, 28 Jan 2011 21:07:18 +0000 (21:07 +0000)]
(bug 26938) "wikipedia compatible" should not be part of the license name. We already explain this in the help box, there's no need to repeat it here
Raimond Spekking [Fri, 28 Jan 2011 21:06:09 +0000 (21:06 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-01-28 20:52:00 UTC)
Chad Horohoe [Fri, 28 Jan 2011 21:02:36 +0000 (21:02 +0000)]
(bug 26939) $wgMetaNamespace is not being generated
Krinkle [Fri, 28 Jan 2011 19:38:16 +0000 (19:38 +0000)]
* Adding cursor:pointer when hovering the headers (which hide/show stuff)
* Remove unneeded parens from r81151.
* Whitespaces
(Follow-up r81151, r81152, r81126)
Krinkle [Fri, 28 Jan 2011 19:32:46 +0000 (19:32 +0000)]
Made mediaWiki JS test suite table no longer sortable. This functionality broke with the introduction of hide/show clickers in r81126. But we don't need this so we might as well remove it.
Krinkle [Fri, 28 Jan 2011 19:25:40 +0000 (19:25 +0000)]
Some adjustments to new functionality from r81133
* Floating result to the right (looked a little messy)
* In Safari the 0.8em looked really pixelated and unreadably. Font-size back to normal size.
* Converted variable names to camelCase
* Fixed bug from r81133 (first array item is 0, first counter is 1). Added a +1 to fix it for now (since the headings were overwritten and the first one was removed). Perhaps should be done better at a later time.
Ariel Glenn [Fri, 28 Jan 2011 19:20:49 +0000 (19:20 +0000)]
open a series of files for xml input, if supplied (used for multiple xml prefetch files)
Ariel Glenn [Fri, 28 Jan 2011 19:16:16 +0000 (19:16 +0000)]
open a series of files for xml input, if supplied (used for multiple xml prefetch files)
Roan Kattouw [Fri, 28 Jan 2011 18:33:48 +0000 (18:33 +0000)]
Random fixes in mediawiki.js: add a var, fix indentation, and get our ABC right
Platonides [Fri, 28 Jan 2011 18:10:39 +0000 (18:10 +0000)]
Restore global wrongly removed in r80892
Platonides [Fri, 28 Jan 2011 17:51:46 +0000 (17:51 +0000)]
JSMin is gone, please talk with JavaScriptDistiller
(r80656 follow up)
Platonides [Fri, 28 Jan 2011 17:34:37 +0000 (17:34 +0000)]
Remove empty statement (r80993) and unused global (r80766).
Platonides [Fri, 28 Jan 2011 17:25:00 +0000 (17:25 +0000)]
Follow-up r81132 removal of pre-8.3 support.
Still needs removal of $wgDBts2schema inside initial_setup()
Ariel Glenn [Fri, 28 Jan 2011 17:18:35 +0000 (17:18 +0000)]
call parent constructor so that include path and other things work right
Chad Horohoe [Fri, 28 Jan 2011 15:42:55 +0000 (15:42 +0000)]
goodNames isn't used anymore
Chad Horohoe [Fri, 28 Jan 2011 15:25:15 +0000 (15:25 +0000)]
Followup r81132, missed some more ts2 removal
Chad Horohoe [Fri, 28 Jan 2011 15:00:18 +0000 (15:00 +0000)]
Minor cleanup, docs
Chad Horohoe [Fri, 28 Jan 2011 14:12:26 +0000 (14:12 +0000)]
Per comment on bug 26612, we should drop the pre-Postgres 8.3 support with the TSearch2 schema.
This removes a bunch of back-compat code in the installer and search code.
Minimum postgres version is now 8.3
Antoine Musso [Fri, 28 Jan 2011 12:13:42 +0000 (12:13 +0000)]
JS tests: fold headers, adapt style
Update the style by removing padding inherited from .wikitable and make
the font smaller (0.8em). Make easier to see the tests on a small screen.
I have folded out the tests by section (using headers as reference), added
some classes and id around to help selection.
TODO: we probably only want to hide tests which are OK
Roan Kattouw [Fri, 28 Jan 2011 01:47:08 +0000 (01:47 +0000)]
Implement prop=wikitext in action=parse, (optionally) returning the original wikitext. Requested by some Google folks wanting to get data about a revision in one request.
Roan Kattouw [Fri, 28 Jan 2011 01:09:47 +0000 (01:09 +0000)]
Add the resolved URL of each langlink to the API's action=parse output
Raimond Spekking [Thu, 27 Jan 2011 21:35:41 +0000 (21:35 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-01-27 21:09:00 UTC)
Bryan Tong Minh [Thu, 27 Jan 2011 21:15:50 +0000 (21:15 +0000)]
(bug 26285) Extensions will be automatically generated on upload if the user specified a filename without extension.
Note that this still will throw a warning.
Antoine Musso [Thu, 27 Jan 2011 21:14:36 +0000 (21:14 +0000)]
invalid 'var' in JS email validation
follow up r81101
Raimond Spekking [Thu, 27 Jan 2011 21:08:10 +0000 (21:08 +0000)]
Fix c&p error in r81103
Bryan Tong Minh [Thu, 27 Jan 2011 20:58:37 +0000 (20:58 +0000)]
(bug 26929) Introduced the edittools-upload message, which will be inserted under the upload form instead of edittools if available
Antoine Musso [Thu, 27 Jan 2011 20:52:12 +0000 (20:52 +0000)]
Bug 26948 - hyphens incorrectly interpreted as range
This is the kind of easy to fix, hard to review bug. Email validation
make uses of strings listing characters, those strings are then
enclosed between brackets "[]". Inside brackets, the hyphen is used
to describe a range of character [a-d] being a b c d.
The string containing an unescaped hyphen, made JS/PHP validation
to match the incorrect comma ",".
* Backslash hyphen
* JS,PHP: add tests for commas and hyphens in username or domain
* JS: add var to rfc_1034_ldh_str
* JS: minor code cleanup
TESTS:
php phpunit.php -c suite.xml --filter ValidEmail
OK (13 tests, 32 assertions)
Special:BlankPage?action=mwutiltest&debug=true
Ran 66 tests. 66 passed test(s). 0 error(s). 0 partially passed test(s).