From: Nick Jenkins <nickj@users.mediawiki.org>
Date: Mon, 20 Aug 2007 07:42:32 +0000 (+0000)
Subject: Prevent E_STRICT warning:
X-Git-Tag: 1.31.0-rc.0~51733
X-Git-Url: http://git.cyclocoop.org/%7B%24www_url%7Dadmin/compta/operations/recherche.php?a=commitdiff_plain;h=e88bfaf1aa6b41a078b7ace9e4c2e1f503b11523;p=lhc%2Fweb%2Fwiklou.git

Prevent E_STRICT warning:
"Trying to get property of non-object in includes/PageHistory.php on line 257"
Happens because $next === 'unknown', i.e. not an object, on one revision for me with the following fuzz command line test on a local test wiki:

curl --silent --include --globoff  -F 'offset'='&#x0003C;<u '  -F 'dir'='prev'  'http://localhost/wiki/index.php?title=Main_Page&action=history' | less
---

diff --git a/includes/PageHistory.php b/includes/PageHistory.php
index c92b3ddb3c..d84c35159f 100644
--- a/includes/PageHistory.php
+++ b/includes/PageHistory.php
@@ -248,7 +248,7 @@ class PageHistory {
 		
 		$tools = array();
 		
-		if ( !is_null( $next ) ) {
+		if ( !is_null( $next ) && is_object( $next ) ) {
 			if( $wgUser->isAllowed( 'rollback' ) && $latest ) {
 				$tools[] = '<span class="mw-rollback-link">'
 					. $this->mSkin->buildRollbackLink( $rev )