From: Chad Horohoe <demon@users.mediawiki.org>
Date: Fri, 22 Jan 2010 18:04:40 +0000 (+0000)
Subject: Cleanup needless code duplication
X-Git-Tag: 1.31.0-rc.0~38162
X-Git-Url: http://git.cyclocoop.org/%7B%24www_url%7Dadmin/compta/operations/recherche.php?a=commitdiff_plain;h=cb6a63f837fe01c7541dc151b0657b13cc89f0af;p=lhc%2Fweb%2Fwiklou.git

Cleanup needless code duplication
---

diff --git a/maintenance/mcc.php b/maintenance/mcc.php
index 909d7caa34..5a618a237a 100644
--- a/maintenance/mcc.php
+++ b/maintenance/mcc.php
@@ -15,57 +15,29 @@ $mcc->set_servers( $wgMemCachedServers );
 #$mcc->set_debug( true );
 
 function mccShowHelp($command) {
-
-	if(! $command ) { $command = 'fullhelp'; }
-	$onlyone = true;
-
-	switch ( $command ) {
-
-		case 'fullhelp':
-			// will show help for all commands
-			$onlyone = false;
-
-		case 'get':
-			print "get: grabs something\n";
-		if($onlyone) { break; }
-
-		case 'getsock':
-			print "getsock: lists sockets\n";
-		if($onlyone) { break; }
-
-		case 'set':
-			print "set: changes something\n";
-		if($onlyone) { break; }
-
-		case 'delete':
-			print "delete: deletes something\n";
-		if($onlyone) { break; }
-
-		case 'history':
-			print "history: show command line history\n";
-		if($onlyone) { break; }
-
-		case 'server':
-			print "server: show current memcached server\n";
-		if($onlyone) { break; }
-
-		case 'dumpmcc':
-			print "dumpmcc: shows the whole thing\n";
-		if($onlyone) { break; }
-
-		case 'exit':
-		case 'quit':
-			print "exit or quit: exit mcc\n";
-		if($onlyone) { break; }
-
-		case 'help':
-			print "help: help about a command\n";
-		if($onlyone) { break; }
-
-		default:
-			if($onlyone) {
-				print "$command: command does not exist or no help for it\n";
-			}
+	$commandList = array( 
+		'get' => 'grabs something',
+		'getsock' => 'lists sockets',
+		'set' => 'changes something',
+		'delete' => 'deletes something',
+		'history' => 'show command line history',
+		'server' => 'show current memcached server',
+		'dumpmcc' => 'shows the whole thing',
+		'exit' => 'exit mcc',
+		'quit' => 'exit mcc',
+		'help' => 'help about a command',
+	);
+	if( !$command ) { 
+		$command = 'fullhelp';
+	}
+	if( $command === 'fullhelp' ) {
+		foreach( $commandList as $cmd => $desc ) {
+			print "$cmd: $desc\n";
+		}
+	} elseif( isset( $commandList[$command] ) ) {
+		print "$cmd: $desc\n";
+	} else {
+		print "$command: command does not exist or no help for it\n";
 	}
 }
 
@@ -176,5 +148,3 @@ do {
 		}
 	}
 } while ( !$quit );
-
-