From: Erik Bernhardson <ebernhardson@wikimedia.org>
Date: Wed, 27 May 2015 14:13:33 +0000 (+0200)
Subject: Log what job types were never inserted
X-Git-Tag: 1.31.0-rc.0~11275^2
X-Git-Url: http://git.cyclocoop.org/%7B%24www_url%7Dadmin/compta/operations/recherche.php?a=commitdiff_plain;h=ca2dbb8aeb8b361a8d00e97ad025f615e94abd88;p=lhc%2Fweb%2Fwiklou.git

Log what job types were never inserted

I am seeing a constant stream of

	Notice: JobQueueGroup::__destruct: 1 buffered job(s) never inserted. in
	/srv/mediawiki/php-1.26wmf6/includes/jobqueue/JobQueueGroup.php on line 419

In the production logfiles.  Log what type of jobs these are so we can figure out
how to fix them.

Change-Id: I7beca910d8c4b20aa20bdec4883e399fd94fbcfd
---

diff --git a/includes/jobqueue/JobQueueGroup.php b/includes/jobqueue/JobQueueGroup.php
index 3d2393e528..5bd1cc94a8 100644
--- a/includes/jobqueue/JobQueueGroup.php
+++ b/includes/jobqueue/JobQueueGroup.php
@@ -416,7 +416,8 @@ class JobQueueGroup {
 	function __destruct() {
 		$n = count( $this->bufferedJobs );
 		if ( $n > 0 ) {
-			trigger_error( __METHOD__ . ": $n buffered job(s) never inserted." );
+			$type = implode( ', ', array_unique( array_map( 'get_class', $this->bufferedJobs ) ) );
+			trigger_error( __METHOD__ . ": $n buffered job(s) of type(s) $type never inserted." );
 		}
 	}
 }