From: Antoine Musso <hashar@users.mediawiki.org>
Date: Mon, 24 Oct 2011 17:45:45 +0000 (+0000)
Subject: Tests for r96188 features
X-Git-Tag: 1.31.0-rc.0~26929
X-Git-Url: http://git.cyclocoop.org/%7B%24www_url%7Dadmin/compta/operations/recherche.php?a=commitdiff_plain;h=9a2dc2d05a0b73853cf317f9ecba8731a6572274;p=lhc%2Fweb%2Fwiklou.git

Tests for r96188 features

That revision let us pass an array of values to 'class', 'rel'
and 'accesskey'. The revision requested some tests :)
---

diff --git a/tests/phpunit/includes/HtmlTest.php b/tests/phpunit/includes/HtmlTest.php
index 339e2da3d0..904958860a 100644
--- a/tests/phpunit/includes/HtmlTest.php
+++ b/tests/phpunit/includes/HtmlTest.php
@@ -143,4 +143,43 @@ class HtmlTest extends MediaWikiTestCase {
 			'Normalization should remove duplicates in string-lists in the array'
 		);
 	}
+
+	/**
+	 * Test feature added by r96188, let pass attributes values as
+	 * a PHP array. Restricted to class,rel, accesskey.
+	 */
+	function testExpandAttributesSpaceSeparatedAttributesWithBoolean() {
+		$this->assertEquals(
+			' class="booltrue one"',
+			Html::expandAttributes( array( 'class' => array(
+				'booltrue' => true,
+				'one' => 1,
+
+				# Method use isset() internally, make sure we do discard
+			    # attributes values which have been assigned well known values
+				'emptystring' => '',
+				'boolfalse' => false,
+				'zero' => 0,
+				'null' => null,
+			)))
+		);
+	}
+
+	/**
+	 * How do we handle duplicate keys in HTML attributes expansion?
+	 * We could pass a "class" the values: 'GREEN' and array( 'GREEN' => false )
+	 * The later will take precedence.
+	 *
+	 * Feature added by r96188
+	 */
+	function testValueIsAuthoritativeInSpaceSeparatedAttributesArrays() {
+		$this->assertEquals(
+			' class=""',
+			HTML::expandAttributes( array( 'class' => array(
+				'GREEN',
+				'GREEN' => false,
+				'GREEN',
+			)))
+		);
+	}
 }